[S] Change in osmo-ttcn3-hacks[master]: RSL_Emulation: allow RSL_DchanHdlr sandbox escape for both roles

2023-11-21 Thread osmith
Attention is currently required from: fixeria. osmith has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/35086?usp=email ) Change subject: RSL_Emulation: allow RSL_DchanHdlr sandbox escape for both roles

[M] Change in libosmocore[master]: add new osmo_sockaddr_from_str_and_uint() function

2023-11-21 Thread osmith
Attention is currently required from: laforge. osmith has posted comments on this change. ( https://gerrit.osmocom.org/c/libosmocore/+/35085?usp=email ) Change subject: add new osmo_sockaddr_from_str_and_uint() function ..

[S] Change in osmo-bsc[master]: use X6 timer for REL ACK, not T3111

2023-11-21 Thread osmith
Attention is currently required from: neels. osmith has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-bsc/+/35088?usp=email ) Change subject: use X6 timer for REL ACK, not T3111 .. Patch Set 1:

[S] Change in osmo-ggsn[master]: gtp: Add net GTP cause values and a function to check for success

2023-11-21 Thread osmith
Attention is currently required from: daniel, laforge. osmith has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-ggsn/+/35084?usp=email ) Change subject: gtp: Add net GTP cause values and a function to check for success

[M] Change in osmo-bsc[master]: recover BORKEN lchans for missing ACK scenarios

2023-11-21 Thread neels
Attention is currently required from: osmith. neels has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-bsc/+/30252?usp=email ) Change subject: recover BORKEN lchans for missing ACK scenarios .. Patch Set

[M] Change in osmo-bsc[master]: recover BORKEN lchans for missing ACK scenarios

2023-11-21 Thread neels
Attention is currently required from: neels, osmith. neels has uploaded a new patch set (#13) to the change originally created by osmith. ( https://gerrit.osmocom.org/c/osmo-bsc/+/30252?usp=email ) The following approvals got outdated and were removed: Verified-1 by Jenkins Builder Change

[M] Change in osmo-bsc[master]: recover BORKEN lchans for missing ACK scenarios

2023-11-21 Thread neels
Attention is currently required from: osmith. neels has uploaded a new patch set (#12) to the change originally created by osmith. ( https://gerrit.osmocom.org/c/osmo-bsc/+/30252?usp=email ) The following approvals got outdated and were removed: Verified-1 by Jenkins Builder Change subject:

[M] Change in osmo-bsc[master]: recover BORKEN lchans for missing ACK scenarios

2023-11-21 Thread neels
Attention is currently required from: osmith. neels has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-bsc/+/30252?usp=email ) Change subject: recover BORKEN lchans for missing ACK scenarios .. Patch Set

[S] Change in osmo-bsc[master]: use X6 timer for REL ACK, not T3111

2023-11-21 Thread fixeria
Attention is currently required from: neels. fixeria has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-bsc/+/35088?usp=email ) Change subject: use X6 timer for REL ACK, not T3111 .. Patch Set 1:

[L] Change in osmo-bsc[master]: tests/handover: move some functions to test/common

2023-11-21 Thread neels
neels has abandoned this change. ( https://gerrit.osmocom.org/c/osmo-bsc/+/30271?usp=email ) Change subject: tests/handover: move some functions to test/common .. Abandoned the C tests that this patch is preparing for are not

[S] Change in osmo-bsc[master]: use X6 timer for REL ACK, not T3111

2023-11-21 Thread neels
neels has uploaded this change for review. ( https://gerrit.osmocom.org/c/osmo-bsc/+/35088?usp=email ) Change subject: use X6 timer for REL ACK, not T3111 .. use X6 timer for REL ACK, not T3111 The lchan FSM timers were

[S] Change in libosmocore[master]: osmo_io: Assert that iofd mode is correct when calling *_write_msgb

2023-11-21 Thread laforge
laforge has submitted this change. ( https://gerrit.osmocom.org/c/libosmocore/+/35077?usp=email ) Change subject: osmo_io: Assert that iofd mode is correct when calling *_write_msgb .. osmo_io: Assert that iofd mode is correct

[S] Change in libosmocore[master]: osmo_io: Assert that iofd mode is correct when calling *_write_msgb

2023-11-21 Thread laforge
Attention is currently required from: daniel. laforge has posted comments on this change. ( https://gerrit.osmocom.org/c/libosmocore/+/35077?usp=email ) Change subject: osmo_io: Assert that iofd mode is correct when calling *_write_msgb

[M] Change in libosmo-sccp[master]: port from osmo_stream_*_get_ofd() to osmo_stream_srv_get_fd()

2023-11-21 Thread laforge
Attention is currently required from: arehbein, daniel. Hello Jenkins Builder, arehbein, daniel, I'd like you to reexamine a change. Please visit https://gerrit.osmocom.org/c/libosmo-sccp/+/35073?usp=email to look at the new patch set (#2). The following approvals got outdated and were

[M] Change in libosmocore[master]: add new osmo_sockaddr_from_str_and_uint() function

2023-11-21 Thread fixeria
Attention is currently required from: laforge. fixeria has posted comments on this change. ( https://gerrit.osmocom.org/c/libosmocore/+/35085?usp=email ) Change subject: add new osmo_sockaddr_from_str_and_uint() function ..

[S] Change in osmo-ttcn3-hacks[master]: RSL_Emulation: allow RSL_DchanHdlr sandbox escape for both roles

2023-11-21 Thread fixeria
fixeria has uploaded this change for review. ( https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/35086?usp=email ) Change subject: RSL_Emulation: allow RSL_DchanHdlr sandbox escape for both roles .. RSL_Emulation: allow

[S] Change in osmo-ttcn3-hacks[master]: BTS_Tests: extend TC_early_immediate_assignment: run on trx_nr=1

2023-11-21 Thread fixeria
fixeria has uploaded this change for review. ( https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/35087?usp=email ) Change subject: BTS_Tests: extend TC_early_immediate_assignment: run on trx_nr=1 .. BTS_Tests: extend

[M] Change in libosmo-netif[master]: Introduce generic osmo_stream_{cli,srv}_get_fd() API

2023-11-21 Thread fixeria
Attention is currently required from: daniel, laforge. fixeria has posted comments on this change. ( https://gerrit.osmocom.org/c/libosmo-netif/+/35072?usp=email ) Change subject: Introduce generic osmo_stream_{cli,srv}_get_fd() API

[M] Change in libosmo-netif[master]: Introduce generic osmo_stream_{cli,srv}_get_fd() API

2023-11-21 Thread laforge
Attention is currently required from: daniel, fixeria. laforge has posted comments on this change. ( https://gerrit.osmocom.org/c/libosmo-netif/+/35072?usp=email ) Change subject: Introduce generic osmo_stream_{cli,srv}_get_fd() API

[M] Change in libosmo-netif[master]: Introduce generic osmo_stream_{cli,srv}_get_fd() API

2023-11-21 Thread laforge
Attention is currently required from: daniel, laforge. Hello Jenkins Builder, daniel, I'd like you to reexamine a change. Please visit https://gerrit.osmocom.org/c/libosmo-netif/+/35072?usp=email to look at the new patch set (#3). The following approvals got outdated and were removed:

[M] Change in libosmo-netif[master]: Introduce generic osmo_stream_{cli,srv}_get_fd() API

2023-11-21 Thread laforge
Attention is currently required from: daniel, laforge. Hello Jenkins Builder, daniel, I'd like you to reexamine a change. Please visit https://gerrit.osmocom.org/c/libosmo-netif/+/35072?usp=email to look at the new patch set (#2). The following approvals got outdated and were removed:

[M] Change in libosmo-netif[master]: Introduce generic osmo_stream_{cli,srv}_get_fd() API

2023-11-21 Thread fixeria
Attention is currently required from: laforge. fixeria has posted comments on this change. ( https://gerrit.osmocom.org/c/libosmo-netif/+/35072?usp=email ) Change subject: Introduce generic osmo_stream_{cli,srv}_get_fd() API ..

[S] Change in libosmo-netif[master]: stream_{cli,srv}: Add support for SCTP in OSMO_IO mode

2023-11-21 Thread laforge
Attention is currently required from: arehbein, daniel, pespin. laforge has posted comments on this change. ( https://gerrit.osmocom.org/c/libosmo-netif/+/35069?usp=email ) Change subject: stream_{cli,srv}: Add support for SCTP in OSMO_IO mode

[S] Change in libosmo-netif[master]: stream_srv: osmo_stream_srv_get_ofd() works only in OSMO_FD mode

2023-11-21 Thread laforge
laforge has submitted this change. ( https://gerrit.osmocom.org/c/libosmo-netif/+/35071?usp=email ) Change subject: stream_srv: osmo_stream_srv_get_ofd() works only in OSMO_FD mode .. stream_srv: osmo_stream_srv_get_ofd() works

[M] Change in libosmo-netif[master]: Introduce generic osmo_stream_{cli,srv}_get_fd() API

2023-11-21 Thread laforge
Attention is currently required from: fixeria. laforge has posted comments on this change. ( https://gerrit.osmocom.org/c/libosmo-netif/+/35072?usp=email ) Change subject: Introduce generic osmo_stream_{cli,srv}_get_fd() API ..

[M] Change in libosmo-sccp[master]: port from osmo_stream_*_get_ofd() to osmo_stream_srv_get_fd()

2023-11-21 Thread laforge
Attention is currently required from: arehbein. laforge has posted comments on this change. ( https://gerrit.osmocom.org/c/libosmo-sccp/+/35073?usp=email ) Change subject: port from osmo_stream_*_get_ofd() to osmo_stream_srv_get_fd()

[M] Change in libosmo-sccp[master]: port from osmo_stream_*_get_ofd() to osmo_stream_srv_get_fd()

2023-11-21 Thread laforge
Attention is currently required from: arehbein. laforge has posted comments on this change. ( https://gerrit.osmocom.org/c/libosmo-sccp/+/35073?usp=email ) Change subject: port from osmo_stream_*_get_ofd() to osmo_stream_srv_get_fd()

[S] Change in osmo-hnodeb[master]: Use 'iuh/local-ip' as local IP for RTP sockets

2023-11-21 Thread laforge
Hello Jenkins Builder, I'd like you to reexamine a change. Please visit https://gerrit.osmocom.org/c/osmo-hnodeb/+/35075?usp=email to look at the new patch set (#2). The following approvals got outdated and were removed: Verified+1 by Jenkins Builder Change subject: Use 'iuh/local-ip' as

[M] Change in libosmocore[master]: add new osmo_sockaddr_from_str_and_uint() function

2023-11-21 Thread laforge
laforge has uploaded this change for review. ( https://gerrit.osmocom.org/c/libosmocore/+/35085?usp=email ) Change subject: add new osmo_sockaddr_from_str_and_uint() function .. add new osmo_sockaddr_from_str_and_uint()

[M] Change in libosmocore[master]: osmo_io: Factor out and use common send function from backend

2023-11-21 Thread lynxis lazus
Attention is currently required from: daniel. lynxis lazus has posted comments on this change. ( https://gerrit.osmocom.org/c/libosmocore/+/35078?usp=email ) Change subject: osmo_io: Factor out and use common send function from backend

[S] Change in osmo-bts[master]: LAPDm: Reject (release) establishment on DCC0, SAPI 0 without L3 payload

2023-11-21 Thread fixeria
Attention is currently required from: jolly. fixeria has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-bts/+/35082?usp=email ) Change subject: LAPDm: Reject (release) establishment on DCC0, SAPI 0 without L3 payload

[M] Change in osmo-bts[master]: Use polling based LAPDm with frame numbers

2023-11-21 Thread fixeria
Attention is currently required from: jolly, laforge. fixeria has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-bts/+/35007?usp=email ) Change subject: Use polling based LAPDm with frame numbers .. Patch

[M] Change in osmo-bts[master]: Use polling based LAPDm with frame numbers

2023-11-21 Thread fixeria
Attention is currently required from: jolly. fixeria has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-bts/+/35007?usp=email ) Change subject: Use polling based LAPDm with frame numbers .. Patch Set 5:

[S] Change in osmo-ggsn[master]: gtp: Add net GTP cause values and a function to check for success

2023-11-21 Thread lynxis lazus
Attention is currently required from: daniel, laforge, osmith. lynxis lazus has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-ggsn/+/35084?usp=email ) Change subject: gtp: Add net GTP cause values and a function to check for success

[S] Change in libosmocore[master]: soft_uart: check n_bits against 0 in osmo_soft_uart_tx_ubits()

2023-11-21 Thread laforge
Attention is currently required from: fixeria, jolly. laforge has posted comments on this change. ( https://gerrit.osmocom.org/c/libosmocore/+/35083?usp=email ) Change subject: soft_uart: check n_bits against 0 in osmo_soft_uart_tx_ubits()

[M] Change in libosmocore[master]: soft_uart: fix pulling a small number of Tx bits

2023-11-21 Thread laforge
laforge has submitted this change. ( https://gerrit.osmocom.org/c/libosmocore/+/35076?usp=email ) Change subject: soft_uart: fix pulling a small number of Tx bits .. soft_uart: fix pulling a small number of Tx bits Change-Id:

[S] Change in libosmocore[master]: soft_uart: check n_bits against 0 in osmo_soft_uart_tx_ubits()

2023-11-21 Thread laforge
laforge has submitted this change. ( https://gerrit.osmocom.org/c/libosmocore/+/35083?usp=email ) Change subject: soft_uart: check n_bits against 0 in osmo_soft_uart_tx_ubits() .. soft_uart: check n_bits against 0 in

[M] Change in libosmocore[master]: soft_uart: fix pulling a small number of Tx bits

2023-11-21 Thread laforge
Attention is currently required from: fixeria, jolly. laforge has posted comments on this change. ( https://gerrit.osmocom.org/c/libosmocore/+/35076?usp=email ) Change subject: soft_uart: fix pulling a small number of Tx bits

[M] Change in osmo-bts[master]: Use polling based LAPDm with frame numbers

2023-11-21 Thread laforge
Attention is currently required from: jolly. laforge has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-bts/+/35007?usp=email ) Change subject: Use polling based LAPDm with frame numbers .. Patch Set 5:

[S] Change in libosmocore[master]: osmo_io: Reject unknown/unsupported modes in osmo_iofd_setup()

2023-11-21 Thread laforge
Attention is currently required from: daniel. laforge has posted comments on this change. ( https://gerrit.osmocom.org/c/libosmocore/+/35063?usp=email ) Change subject: osmo_io: Reject unknown/unsupported modes in osmo_iofd_setup()

[S] Change in libosmocore[master]: io_uring: add some more source code comments/docs

2023-11-21 Thread laforge
Attention is currently required from: daniel. laforge has posted comments on this change. ( https://gerrit.osmocom.org/c/libosmocore/+/35061?usp=email ) Change subject: io_uring: add some more source code comments/docs ..

[S] Change in libosmocore[master]: osmo_io: Reject unknown/unsupported modes in osmo_iofd_setup()

2023-11-21 Thread laforge
Attention is currently required from: daniel. laforge has posted comments on this change. ( https://gerrit.osmocom.org/c/libosmocore/+/35063?usp=email ) Change subject: osmo_io: Reject unknown/unsupported modes in osmo_iofd_setup()

[S] Change in libosmocore[master]: io_uring: add some more source code comments/docs

2023-11-21 Thread laforge
Attention is currently required from: laforge. Hello Jenkins Builder, daniel, I'd like you to reexamine a change. Please visit https://gerrit.osmocom.org/c/libosmocore/+/35061?usp=email to look at the new patch set (#2). The following approvals got outdated and were removed: Verified+1 by

[S] Change in libosmocore[master]: osmo_io: rename unsupported SCTP mode to OSMO_IO_FD_MODE_SCTP_RECVMSG...

2023-11-21 Thread laforge
Attention is currently required from: fixeria. Hello Jenkins Builder, daniel, I'd like you to reexamine a change. Please visit https://gerrit.osmocom.org/c/libosmocore/+/35062?usp=email to look at the new patch set (#2). The following approvals got outdated and were removed: Verified+1 by

[S] Change in libosmocore[master]: osmo_io: Reject unknown/unsupported modes in osmo_iofd_setup()

2023-11-21 Thread laforge
Attention is currently required from: laforge. Hello Jenkins Builder, daniel, I'd like you to reexamine a change. Please visit https://gerrit.osmocom.org/c/libosmocore/+/35063?usp=email to look at the new patch set (#2). The following approvals got outdated and were removed: Verified+1 by

[S] Change in libosmocore[master]: osmo_io: rename unsupported SCTP mode to OSMO_IO_FD_MODE_SCTP_RECVMSG...

2023-11-21 Thread laforge
Attention is currently required from: fixeria. laforge has posted comments on this change. ( https://gerrit.osmocom.org/c/libosmocore/+/35062?usp=email ) Change subject: osmo_io: rename unsupported SCTP mode to OSMO_IO_FD_MODE_SCTP_RECVMSG_SEND

[S] Change in osmo-ggsn[master]: gtp: Add net GTP cause values and a function to check for success

2023-11-21 Thread Jenkins Builder
Jenkins Builder has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-ggsn/+/35084?usp=email ) Change subject: gtp: Add net GTP cause values and a function to check for success .. Patch Set 1: (1 comment)

[S] Change in osmo-ggsn[master]: gtp: Add net GTP cause values and a function to check for success

2023-11-21 Thread daniel
daniel has uploaded this change for review. ( https://gerrit.osmocom.org/c/osmo-ggsn/+/35084?usp=email ) Change subject: gtp: Add net GTP cause values and a function to check for success .. gtp: Add net GTP cause values and a

[M] Change in libosmocore[master]: soft_uart: demonstrate a problem with osmo_soft_uart_tx_ubits()

2023-11-21 Thread fixeria
fixeria has submitted this change. ( https://gerrit.osmocom.org/c/libosmocore/+/35074?usp=email ) Change subject: soft_uart: demonstrate a problem with osmo_soft_uart_tx_ubits() .. soft_uart: demonstrate a problem with

[M] Change in libosmocore[master]: soft_uart: implement OSMO_SUART_PARITY_{MARK,SPACE}

2023-11-21 Thread fixeria
fixeria has submitted this change. ( https://gerrit.osmocom.org/c/libosmocore/+/35067?usp=email ) ( 4 is the latest approved patch-set. No files were changed between the latest approved patch-set and the submitted one. )Change subject: soft_uart: implement OSMO_SUART_PARITY_{MARK,SPACE}

[S] Change in libosmocore[master]: soft_uart: fix handling of num_data_bits < 8

2023-11-21 Thread fixeria
fixeria has submitted this change. ( https://gerrit.osmocom.org/c/libosmocore/+/35066?usp=email ) ( 4 is the latest approved patch-set. No files were changed between the latest approved patch-set and the submitted one. )Change subject: soft_uart: fix handling of num_data_bits < 8

[S] Change in libosmocore[master]: soft_uart: fix Rx buffer flushing logic in suart_rx_ch()

2023-11-21 Thread fixeria
fixeria has submitted this change. ( https://gerrit.osmocom.org/c/libosmocore/+/35065?usp=email ) ( 4 is the latest approved patch-set. No files were changed between the latest approved patch-set and the submitted one. )Change subject: soft_uart: fix Rx buffer flushing logic in suart_rx_ch()

[L] Change in libosmocore[master]: soft_uart: add unit tests for the receiver and transmitter

2023-11-21 Thread fixeria
fixeria has submitted this change. ( https://gerrit.osmocom.org/c/libosmocore/+/35046?usp=email ) Change subject: soft_uart: add unit tests for the receiver and transmitter .. soft_uart: add unit tests for the receiver and

[S] Change in libosmocore[master]: soft_uart: allow manually flushing the receive buffer

2023-11-21 Thread fixeria
fixeria has submitted this change. ( https://gerrit.osmocom.org/c/libosmocore/+/35064?usp=email ) ( 3 is the latest approved patch-set. No files were changed between the latest approved patch-set and the submitted one. )Change subject: soft_uart: allow manually flushing the receive buffer

[L] Change in libosmocore[master]: soft_uart: add unit tests for the receiver and transmitter

2023-11-21 Thread fixeria
Attention is currently required from: jolly, laforge. fixeria has posted comments on this change. ( https://gerrit.osmocom.org/c/libosmocore/+/35046?usp=email ) Change subject: soft_uart: add unit tests for the receiver and transmitter

[S] Change in libosmocore[master]: soft_uart: check n_bits against 0 in osmo_soft_uart_tx_ubits()

2023-11-21 Thread osmith
Attention is currently required from: fixeria, jolly. osmith has posted comments on this change. ( https://gerrit.osmocom.org/c/libosmocore/+/35083?usp=email ) Change subject: soft_uart: check n_bits against 0 in osmo_soft_uart_tx_ubits()

[M] Change in libosmocore[master]: soft_uart: demonstrate a problem with osmo_soft_uart_tx_ubits()

2023-11-21 Thread osmith
Attention is currently required from: fixeria, laforge. osmith has posted comments on this change. ( https://gerrit.osmocom.org/c/libosmocore/+/35074?usp=email ) Change subject: soft_uart: demonstrate a problem with osmo_soft_uart_tx_ubits()

[L] Change in libosmocore[master]: soft_uart: add unit tests for the receiver and transmitter

2023-11-21 Thread osmith
Attention is currently required from: fixeria, jolly, laforge. osmith has posted comments on this change. ( https://gerrit.osmocom.org/c/libosmocore/+/35046?usp=email ) Change subject: soft_uart: add unit tests for the receiver and transmitter

[M] Change in libosmocore[master]: soft_uart: fix pulling a small number of Tx bits

2023-11-21 Thread fixeria
Attention is currently required from: jolly. fixeria has posted comments on this change. ( https://gerrit.osmocom.org/c/libosmocore/+/35076?usp=email ) Change subject: soft_uart: fix pulling a small number of Tx bits .. Patch

[S] Change in libosmocore[master]: soft_uart: fix Rx buffer flushing logic in suart_rx_ch()

2023-11-21 Thread fixeria
Attention is currently required from: fixeria, jolly. Hello Jenkins Builder, jolly, laforge, osmith, I'd like you to reexamine a change. Please visit https://gerrit.osmocom.org/c/libosmocore/+/35065?usp=email to look at the new patch set (#5). The following approvals got outdated and were

[M] Change in libosmocore[master]: soft_uart: implement OSMO_SUART_PARITY_{MARK,SPACE}

2023-11-21 Thread fixeria
Attention is currently required from: fixeria. Hello Jenkins Builder, jolly, laforge, I'd like you to reexamine a change. Please visit https://gerrit.osmocom.org/c/libosmocore/+/35067?usp=email to look at the new patch set (#5). The following approvals got outdated and were removed:

[M] Change in libosmocore[master]: soft_uart: demonstrate a problem with osmo_soft_uart_tx_ubits()

2023-11-21 Thread fixeria
Attention is currently required from: fixeria, laforge. Hello Jenkins Builder, laforge, I'd like you to reexamine a change. Please visit https://gerrit.osmocom.org/c/libosmocore/+/35074?usp=email to look at the new patch set (#3). The following approvals got outdated and were removed:

[S] Change in libosmocore[master]: soft_uart: check n_bits against 0 in osmo_soft_uart_tx_ubits()

2023-11-21 Thread fixeria
fixeria has uploaded this change for review. ( https://gerrit.osmocom.org/c/libosmocore/+/35083?usp=email ) Change subject: soft_uart: check n_bits against 0 in osmo_soft_uart_tx_ubits() .. soft_uart: check n_bits against 0 in

[S] Change in libosmocore[master]: soft_uart: fix handling of num_data_bits < 8

2023-11-21 Thread fixeria
Attention is currently required from: fixeria. Hello Jenkins Builder, jolly, laforge, I'd like you to reexamine a change. Please visit https://gerrit.osmocom.org/c/libosmocore/+/35066?usp=email to look at the new patch set (#5). The following approvals got outdated and were removed:

[L] Change in libosmocore[master]: soft_uart: add unit tests for the receiver and transmitter

2023-11-21 Thread fixeria
Attention is currently required from: fixeria, jolly, laforge. Hello Jenkins Builder, jolly, laforge, I'd like you to reexamine a change. Please visit https://gerrit.osmocom.org/c/libosmocore/+/35046?usp=email to look at the new patch set (#7). The following approvals got outdated and

[S] Change in libosmocore[master]: soft_uart: fix Rx buffer flushing logic in suart_rx_ch()

2023-11-21 Thread osmith
Attention is currently required from: fixeria, jolly. osmith has posted comments on this change. ( https://gerrit.osmocom.org/c/libosmocore/+/35065?usp=email ) Change subject: soft_uart: fix Rx buffer flushing logic in suart_rx_ch()

[S] Change in libosmocore[master]: soft_uart: allow manually flushing the receive buffer

2023-11-21 Thread osmith
Attention is currently required from: fixeria, jolly. osmith has posted comments on this change. ( https://gerrit.osmocom.org/c/libosmocore/+/35064?usp=email ) Change subject: soft_uart: allow manually flushing the receive buffer

[M] Change in osmo-bts[master]: Use polling based LAPDm with frame numbers

2023-11-21 Thread jolly
Attention is currently required from: jolly. Hello Jenkins Builder, I'd like you to reexamine a change. Please visit https://gerrit.osmocom.org/c/osmo-bts/+/35007?usp=email to look at the new patch set (#5). The following approvals got outdated and were removed: Verified-1 by Jenkins

[S] Change in osmo-bts[master]: LAPDm: Reject (release) establishment on DCC0, SAPI 0 without L3 payload

2023-11-21 Thread jolly
jolly has uploaded this change for review. ( https://gerrit.osmocom.org/c/osmo-bts/+/35082?usp=email ) Change subject: LAPDm: Reject (release) establishment on DCC0, SAPI 0 without L3 payload .. LAPDm: Reject (release)

[S] Change in osmo-ci[master]: scripts/docker-cleanup: buildkit cache too

2023-11-21 Thread laforge
laforge has submitted this change. ( https://gerrit.osmocom.org/c/osmo-ci/+/35081?usp=email ) Change subject: scripts/docker-cleanup: buildkit cache too .. scripts/docker-cleanup: buildkit cache too In newer docker versions, a

[S] Change in osmo-ci[master]: scripts/docker-cleanup: buildkit cache too

2023-11-21 Thread laforge
Attention is currently required from: osmith. laforge has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-ci/+/35081?usp=email ) Change subject: scripts/docker-cleanup: buildkit cache too .. Patch Set 1:

[S] Change in osmo-ci[master]: scripts/docker-cleanup: buildkit cache too

2023-11-21 Thread osmith
osmith has uploaded this change for review. ( https://gerrit.osmocom.org/c/osmo-ci/+/35081?usp=email ) Change subject: scripts/docker-cleanup: buildkit cache too .. scripts/docker-cleanup: buildkit cache too In newer docker

[S] Change in osmo-ttcn3-hacks[master]: BTS_Tests_LAPDm.TC_nr_seq_error: Fix test

2023-11-21 Thread laforge
Attention is currently required from: jolly. laforge has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/35047?usp=email ) Change subject: BTS_Tests_LAPDm.TC_nr_seq_error: Fix test .. Patch

[S] Change in osmocom-bb[master]: firmware/layer1: avoid 'for' loop initial declarations

2023-11-21 Thread laforge
laforge has submitted this change. ( https://gerrit.osmocom.org/c/osmocom-bb/+/35080?usp=email ) Change subject: firmware/layer1: avoid 'for' loop initial declarations .. firmware/layer1: avoid 'for' loop initial declarations

[S] Change in osmocom-bb[master]: firmware/layer1: avoid 'for' loop initial declarations

2023-11-21 Thread laforge
Attention is currently required from: fixeria. laforge has posted comments on this change. ( https://gerrit.osmocom.org/c/osmocom-bb/+/35080?usp=email ) Change subject: firmware/layer1: avoid 'for' loop initial declarations ..

[M] Change in libosmocore[master]: soft_uart: fix pulling a small number of Tx bits

2023-11-21 Thread laforge
Attention is currently required from: fixeria, jolly. laforge has posted comments on this change. ( https://gerrit.osmocom.org/c/libosmocore/+/35076?usp=email ) Change subject: soft_uart: fix pulling a small number of Tx bits

[M] Change in libosmocore[master]: soft_uart: demonstrate a problem with osmo_soft_uart_tx_ubits()

2023-11-21 Thread laforge
Attention is currently required from: fixeria. laforge has posted comments on this change. ( https://gerrit.osmocom.org/c/libosmocore/+/35074?usp=email ) Change subject: soft_uart: demonstrate a problem with osmo_soft_uart_tx_ubits()

[M] Change in libosmocore[master]: soft_uart: implement OSMO_SUART_PARITY_{MARK,SPACE}

2023-11-21 Thread laforge
Attention is currently required from: fixeria. laforge has posted comments on this change. ( https://gerrit.osmocom.org/c/libosmocore/+/35067?usp=email ) Change subject: soft_uart: implement OSMO_SUART_PARITY_{MARK,SPACE} ..

[S] Change in libosmocore[master]: soft_uart: fix handling of num_data_bits < 8

2023-11-21 Thread laforge
Attention is currently required from: fixeria. laforge has posted comments on this change. ( https://gerrit.osmocom.org/c/libosmocore/+/35066?usp=email ) Change subject: soft_uart: fix handling of num_data_bits < 8 .. Patch

[L] Change in libosmocore[master]: soft_uart: add unit tests for the receiver and transmitter

2023-11-21 Thread laforge
Attention is currently required from: fixeria, jolly. laforge has posted comments on this change. ( https://gerrit.osmocom.org/c/libosmocore/+/35046?usp=email ) Change subject: soft_uart: add unit tests for the receiver and transmitter

[L] Change in libosmocore[master]: core: Add software UART implementation

2023-11-21 Thread laforge
laforge has submitted this change. ( https://gerrit.osmocom.org/c/libosmocore/+/30763?usp=email ) Change subject: core: Add software UART implementation .. core: Add software UART implementation This patch brings a

[S] Change in libosmocore[master]: soft_uart: implement parity checking for the receiver

2023-11-21 Thread laforge
laforge has submitted this change. ( https://gerrit.osmocom.org/c/libosmocore/+/35023?usp=email ) Change subject: soft_uart: implement parity checking for the receiver .. soft_uart: implement parity checking for the receiver

[M] Change in libosmocore[master]: soft_uart: implement the transmitter

2023-11-21 Thread laforge
laforge has submitted this change. ( https://gerrit.osmocom.org/c/libosmocore/+/35044?usp=email ) Change subject: soft_uart: implement the transmitter .. soft_uart: implement the transmitter Change-Id:

[M] Change in libosmocore[master]: soft_uart: rework osmo_uart_rx_bit() to use flow state

2023-11-21 Thread laforge
laforge has submitted this change. ( https://gerrit.osmocom.org/c/libosmocore/+/35022?usp=email ) Change subject: soft_uart: rework osmo_uart_rx_bit() to use flow state .. soft_uart: rework osmo_uart_rx_bit() to use flow state

[S] Change in libosmocore[master]: soft_uart: make osmo_soft_uart_alloc() accept *cfg

2023-11-21 Thread laforge
laforge has submitted this change. ( https://gerrit.osmocom.org/c/libosmocore/+/35021?usp=email ) Change subject: soft_uart: make osmo_soft_uart_alloc() accept *cfg .. soft_uart: make osmo_soft_uart_alloc() accept *cfg Let the

[S] Change in libosmocore[master]: soft_uart: split osmo_soft_uart_enable()

2023-11-21 Thread laforge
laforge has submitted this change. ( https://gerrit.osmocom.org/c/libosmocore/+/35020?usp=email ) Change subject: soft_uart: split osmo_soft_uart_enable() .. soft_uart: split osmo_soft_uart_enable() The problem with a single

[S] Change in libosmocore[master]: soft_uart: add doxygen documentation

2023-11-21 Thread laforge
laforge has submitted this change. ( https://gerrit.osmocom.org/c/libosmocore/+/35019?usp=email ) Change subject: soft_uart: add doxygen documentation .. soft_uart: add doxygen documentation Change-Id:

[S] Change in libosmocore[master]: soft_uart: add osmo_soft_uart_free()

2023-11-21 Thread laforge
laforge has submitted this change. ( https://gerrit.osmocom.org/c/libosmocore/+/35018?usp=email ) Change subject: soft_uart: add osmo_soft_uart_free() .. soft_uart: add osmo_soft_uart_free() Change-Id:

[M] Change in libosmocore[master]: soft_uart: implement the transmitter

2023-11-21 Thread laforge
Attention is currently required from: fixeria, jolly. laforge has posted comments on this change. ( https://gerrit.osmocom.org/c/libosmocore/+/35044?usp=email ) Change subject: soft_uart: implement the transmitter .. Patch

[S] Change in libosmocore[master]: soft_uart: implement parity checking for the receiver

2023-11-21 Thread laforge
Attention is currently required from: fixeria. laforge has posted comments on this change. ( https://gerrit.osmocom.org/c/libosmocore/+/35023?usp=email ) Change subject: soft_uart: implement parity checking for the receiver ..

[M] Change in libosmocore[master]: soft_uart: rework osmo_uart_rx_bit() to use flow state

2023-11-21 Thread laforge
Attention is currently required from: fixeria. laforge has posted comments on this change. ( https://gerrit.osmocom.org/c/libosmocore/+/35022?usp=email ) Change subject: soft_uart: rework osmo_uart_rx_bit() to use flow state ..

[S] Change in libosmocore[master]: soft_uart: make osmo_soft_uart_alloc() accept *cfg

2023-11-21 Thread laforge
Attention is currently required from: fixeria. laforge has posted comments on this change. ( https://gerrit.osmocom.org/c/libosmocore/+/35021?usp=email ) Change subject: soft_uart: make osmo_soft_uart_alloc() accept *cfg ..

[S] Change in libosmocore[master]: soft_uart: split osmo_soft_uart_enable()

2023-11-21 Thread laforge
Attention is currently required from: fixeria. laforge has posted comments on this change. ( https://gerrit.osmocom.org/c/libosmocore/+/35020?usp=email ) Change subject: soft_uart: split osmo_soft_uart_enable() .. Patch Set

[S] Change in libosmocore[master]: soft_uart: add doxygen documentation

2023-11-21 Thread laforge
Attention is currently required from: fixeria. laforge has posted comments on this change. ( https://gerrit.osmocom.org/c/libosmocore/+/35019?usp=email ) Change subject: soft_uart: add doxygen documentation .. Patch Set 3:

[S] Change in libosmocore[master]: soft_uart: add osmo_soft_uart_free()

2023-11-21 Thread laforge
Attention is currently required from: fixeria. laforge has posted comments on this change. ( https://gerrit.osmocom.org/c/libosmocore/+/35018?usp=email ) Change subject: soft_uart: add osmo_soft_uart_free() .. Patch Set 3:

[L] Change in libosmocore[master]: core: Add software UART implementation

2023-11-21 Thread laforge
Attention is currently required from: fixeria, jolly. laforge has posted comments on this change. ( https://gerrit.osmocom.org/c/libosmocore/+/30763?usp=email ) Change subject: core: Add software UART implementation .. Patch

[M] Change in libosmocore[master]: osmo_io: Factor out and use common send function from backend

2023-11-21 Thread laforge
Attention is currently required from: daniel. laforge has posted comments on this change. ( https://gerrit.osmocom.org/c/libosmocore/+/35078?usp=email ) Change subject: osmo_io: Factor out and use common send function from backend

[S] Change in libosmocore[master]: osmo_io: Assert that iofd mode is correct when calling *_write_msgb

2023-11-21 Thread laforge
Attention is currently required from: daniel. laforge has posted comments on this change. ( https://gerrit.osmocom.org/c/libosmocore/+/35077?usp=email ) Change subject: osmo_io: Assert that iofd mode is correct when calling *_write_msgb

[S] Change in osmocom-bb[master]: firmware/layer1: avoid 'for' loop initial declarations

2023-11-21 Thread fixeria
fixeria has uploaded this change for review. ( https://gerrit.osmocom.org/c/osmocom-bb/+/35080?usp=email ) Change subject: firmware/layer1: avoid 'for' loop initial declarations .. firmware/layer1: avoid 'for' loop initial

[L] Change in libosmocore[master]: core: Add software UART implementation

2023-11-21 Thread laforge
Attention is currently required from: fixeria, jolly. laforge has posted comments on this change. ( https://gerrit.osmocom.org/c/libosmocore/+/30763?usp=email ) Change subject: core: Add software UART implementation .. Patch

  1   2   >