[S] Change in osmo-bts[master]: vty info: MS power levels in dBm are not negative

[keith]

keith has uploaded this change for review. ( 
https://gerrit.osmocom.org/c/osmo-bts/+/36497?usp=email )


Change subject: vty info: MS power levels in dBm are not negative
..

vty info: MS power levels in dBm are not negative

Change-Id: Ib928a1378bc00b8ccb0365e5536f010e1f8a3d43
---
M src/common/vty.c
1 file changed, 11 insertions(+), 2 deletions(-)



  git pull ssh://gerrit.osmocom.org:29418/osmo-bts refs/changes/97/36497/1

diff --git a/src/common/vty.c b/src/common/vty.c
index 6ec96da..c0008a8 100644
--- a/src/common/vty.c
+++ b/src/common/vty.c
@@ -1867,10 +1867,10 @@
int current_dbm = ms_pwr_dbm(trx->bts->band, st->current);
int max_dbm = ms_pwr_dbm(trx->bts->band, st->max);

-   cfg_out(vty, "Current power level: %u, -%d dBm",
+   cfg_out(vty, "Current power level: %u, %d dBm",
st->current, current_dbm);
if (st->dpc_params != NULL)
-   vty_out(vty, " (max %u, -%d dBm)", st->max, max_dbm);
+   vty_out(vty, " (max %u, %d dBm)", st->max, max_dbm);
vty_out(vty, "%s", VTY_NEWLINE);

if (st->dpc_params == NULL)

--
To view, visit https://gerrit.osmocom.org/c/osmo-bts/+/36497?usp=email
To unsubscribe, or for help writing mail filters, visit 
https://gerrit.osmocom.org/settings

Gerrit-Project: osmo-bts
Gerrit-Branch: master
Gerrit-Change-Id: Ib928a1378bc00b8ccb0365e5536f010e1f8a3d43
Gerrit-Change-Number: 36497
Gerrit-PatchSet: 1
Gerrit-Owner: keith 
Gerrit-MessageType: newchange

[S] Change in libosmo-abis[master]: DAHDI: Log hexdump of TX at level DEBUG, not ERROR

[keith]

keith has uploaded this change for review. ( 
https://gerrit.osmocom.org/c/libosmo-abis/+/35494?usp=email )


Change subject: DAHDI: Log hexdump of TX at level DEBUG, not ERROR
..

DAHDI: Log hexdump of TX at level DEBUG, not ERROR

Change-Id: I29aa82c8586d846a861e62d90d376ff9cfaa9654
---
M src/input/dahdi.c
1 file changed, 10 insertions(+), 1 deletion(-)



  git pull ssh://gerrit.osmocom.org:29418/libosmo-abis refs/changes/94/35494/1

diff --git a/src/input/dahdi.c b/src/input/dahdi.c
index efed38d..b9a3fcf 100644
--- a/src/input/dahdi.c
+++ b/src/input/dahdi.c
@@ -259,7 +259,7 @@
return 0;
}

-   LOGPITS(e1i_ts, DLMI, LOGL_ERROR, "TX: %s\n", osmo_hexdump(msg->data, 
msg->len));
+   LOGPITS(e1i_ts, DLMI, LOGL_DEBUG, "TX: %s\n", osmo_hexdump(msg->data, 
msg->len));
lapd_transmit(e1i_ts->lapd, sign_link->tei,
sign_link->sapi, msg);


--
To view, visit https://gerrit.osmocom.org/c/libosmo-abis/+/35494?usp=email
To unsubscribe, or for help writing mail filters, visit 
https://gerrit.osmocom.org/settings

Gerrit-Project: libosmo-abis
Gerrit-Branch: master
Gerrit-Change-Id: I29aa82c8586d846a861e62d90d376ff9cfaa9654
Gerrit-Change-Number: 35494
Gerrit-PatchSet: 1
Gerrit-Owner: keith 
Gerrit-MessageType: newchange

[S] Change in osmo-bsc[master]: VTY: fix config indentation for pcu-socket params

[keith]

keith has submitted this change. ( 
https://gerrit.osmocom.org/c/osmo-bsc/+/35443?usp=email )

Change subject: VTY: fix config indentation for pcu-socket params
..

VTY: fix config indentation for pcu-socket params

osmo-bsc would not start with a config written from the vty due
to incorrect identation on the pcu-socket parameters.

Change-Id: I36a66794e654989b4b8bf54bb3727ccbfc2131fa
---
M src/osmo-bsc/bsc_vty.c
1 file changed, 14 insertions(+), 2 deletions(-)

Approvals:
  Jenkins Builder: Verified
  fixeria: Looks good to me, but someone else must approve
  keith: Looks good to me, approved




diff --git a/src/osmo-bsc/bsc_vty.c b/src/osmo-bsc/bsc_vty.c
index 73c5cc2..925f21f 100644
--- a/src/osmo-bsc/bsc_vty.c
+++ b/src/osmo-bsc/bsc_vty.c
@@ -415,9 +415,9 @@
}

if (gsmnet->pcu_sock_path)
-   vty_out(vty, "  pcu-socket %s%s", gsmnet->pcu_sock_path, 
VTY_NEWLINE);
+   vty_out(vty, " pcu-socket %s%s", gsmnet->pcu_sock_path, 
VTY_NEWLINE);
if (gsmnet->pcu_sock_wqueue_len_max != BSC_PCU_SOCK_WQUEUE_LEN_DEFAULT)
-   vty_out(vty, "  pcu-socket-wqueue-length %u%s", 
gsmnet->pcu_sock_wqueue_len_max,
+   vty_out(vty, " pcu-socket-wqueue-length %u%s", 
gsmnet->pcu_sock_wqueue_len_max,
VTY_NEWLINE);

neighbor_ident_vty_write_network(vty, " ");

-- 
To view, visit https://gerrit.osmocom.org/c/osmo-bsc/+/35443?usp=email
To unsubscribe, or for help writing mail filters, visit 
https://gerrit.osmocom.org/settings

Gerrit-Project: osmo-bsc
Gerrit-Branch: master
Gerrit-Change-Id: I36a66794e654989b4b8bf54bb3727ccbfc2131fa
Gerrit-Change-Number: 35443
Gerrit-PatchSet: 4
Gerrit-Owner: keith 
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: fixeria 
Gerrit-Reviewer: keith 
Gerrit-Reviewer: laforge 
Gerrit-MessageType: merged

[S] Change in osmo-bsc[master]: VTY: fix config indentation for pcu-socket params

[keith]

Attention is currently required from: fixeria, laforge.

keith has posted comments on this change. ( 
https://gerrit.osmocom.org/c/osmo-bsc/+/35443?usp=email )

Change subject: VTY: fix config indentation for pcu-socket params
..


Patch Set 3: Code-Review+2


--
To view, visit https://gerrit.osmocom.org/c/osmo-bsc/+/35443?usp=email
To unsubscribe, or for help writing mail filters, visit 
https://gerrit.osmocom.org/settings

Gerrit-Project: osmo-bsc
Gerrit-Branch: master
Gerrit-Change-Id: I36a66794e654989b4b8bf54bb3727ccbfc2131fa
Gerrit-Change-Number: 35443
Gerrit-PatchSet: 3
Gerrit-Owner: keith 
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: fixeria 
Gerrit-Reviewer: keith 
Gerrit-Reviewer: laforge 
Gerrit-Attention: laforge 
Gerrit-Attention: fixeria 
Gerrit-Comment-Date: Wed, 27 Dec 2023 17:26:23 +
Gerrit-HasComments: No
Gerrit-Has-Labels: Yes
Gerrit-MessageType: comment

[S] Change in osmo-bsc[master]: VTY: fix config indentation for pcu-socket params

[keith]

Attention is currently required from: fixeria, laforge.

keith has posted comments on this change. ( 
https://gerrit.osmocom.org/c/osmo-bsc/+/35443?usp=email )

Change subject: VTY: fix config indentation for pcu-socket params
..


Patch Set 3: Code-Review+1

(1 comment)

File src/osmo-bsc/bsc_vty.c:

https://gerrit.osmocom.org/c/osmo-bsc/+/35443/comment/47319c96_32ed807f
PS2, Line 420: pcu-socket-wqueue-length
> please also fix this one
Done



--
To view, visit https://gerrit.osmocom.org/c/osmo-bsc/+/35443?usp=email
To unsubscribe, or for help writing mail filters, visit 
https://gerrit.osmocom.org/settings

Gerrit-Project: osmo-bsc
Gerrit-Branch: master
Gerrit-Change-Id: I36a66794e654989b4b8bf54bb3727ccbfc2131fa
Gerrit-Change-Number: 35443
Gerrit-PatchSet: 3
Gerrit-Owner: keith 
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: fixeria 
Gerrit-Reviewer: keith 
Gerrit-Reviewer: laforge 
Gerrit-Attention: laforge 
Gerrit-Attention: fixeria 
Gerrit-Comment-Date: Wed, 27 Dec 2023 17:11:30 +
Gerrit-HasComments: Yes
Gerrit-Has-Labels: Yes
Comment-In-Reply-To: fixeria 
Gerrit-MessageType: comment

[S] Change in osmo-bsc[master]: VTY: fix config indentation for pcu-socket params

[keith]

Attention is currently required from: keith, laforge.

Hello Jenkins Builder, laforge,

I'd like you to reexamine a change. Please visit

https://gerrit.osmocom.org/c/osmo-bsc/+/35443?usp=email

to look at the new patch set (#3).

The following approvals got outdated and were removed:
Code-Review+1 by laforge, Code-Review+2 by keith, Verified+1 by Jenkins Builder

The change is no longer submittable: Code-Review and Verified are unsatisfied 
now.


Change subject: VTY: fix config indentation for pcu-socket params
..

VTY: fix config indentation for pcu-socket params

osmo-bsc would not start with a config written from the vty due
to incorrect identation on the pcu-socket parameters.

Change-Id: I36a66794e654989b4b8bf54bb3727ccbfc2131fa
---
M src/osmo-bsc/bsc_vty.c
1 file changed, 14 insertions(+), 2 deletions(-)


  git pull ssh://gerrit.osmocom.org:29418/osmo-bsc refs/changes/43/35443/3
--
To view, visit https://gerrit.osmocom.org/c/osmo-bsc/+/35443?usp=email
To unsubscribe, or for help writing mail filters, visit 
https://gerrit.osmocom.org/settings

Gerrit-Project: osmo-bsc
Gerrit-Branch: master
Gerrit-Change-Id: I36a66794e654989b4b8bf54bb3727ccbfc2131fa
Gerrit-Change-Number: 35443
Gerrit-PatchSet: 3
Gerrit-Owner: keith 
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: keith 
Gerrit-Reviewer: laforge 
Gerrit-CC: fixeria 
Gerrit-Attention: laforge 
Gerrit-Attention: keith 
Gerrit-MessageType: newpatchset

[S] Change in osmo-bsc[master]: VTY: fix config indentation for pcu-socket

[keith]

keith has posted comments on this change. ( 
https://gerrit.osmocom.org/c/osmo-bsc/+/35443?usp=email )

Change subject: VTY: fix config indentation for pcu-socket
..


Patch Set 2:

(1 comment)

Patchset:

PS2:
I'd be tempted to just merge this based on
https://osmocom.org/projects/cellular-infrastructure/wiki/Gerrit#Exceptions-for-Trivial-Urgent-Patches



--
To view, visit https://gerrit.osmocom.org/c/osmo-bsc/+/35443?usp=email
To unsubscribe, or for help writing mail filters, visit 
https://gerrit.osmocom.org/settings

Gerrit-Project: osmo-bsc
Gerrit-Branch: master
Gerrit-Change-Id: I36a66794e654989b4b8bf54bb3727ccbfc2131fa
Gerrit-Change-Number: 35443
Gerrit-PatchSet: 2
Gerrit-Owner: keith 
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: keith 
Gerrit-Comment-Date: Tue, 26 Dec 2023 00:35:34 +
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Gerrit-MessageType: comment

[S] Change in osmo-bsc[master]: VTY: fix config indentation for pcu-socket

[keith]

keith has posted comments on this change. ( 
https://gerrit.osmocom.org/c/osmo-bsc/+/35443?usp=email )

Change subject: VTY: fix config indentation for pcu-socket
..


Patch Set 2: Code-Review+2


--
To view, visit https://gerrit.osmocom.org/c/osmo-bsc/+/35443?usp=email
To unsubscribe, or for help writing mail filters, visit 
https://gerrit.osmocom.org/settings

Gerrit-Project: osmo-bsc
Gerrit-Branch: master
Gerrit-Change-Id: I36a66794e654989b4b8bf54bb3727ccbfc2131fa
Gerrit-Change-Number: 35443
Gerrit-PatchSet: 2
Gerrit-Owner: keith 
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: keith 
Gerrit-Comment-Date: Tue, 26 Dec 2023 00:33:10 +
Gerrit-HasComments: No
Gerrit-Has-Labels: Yes
Gerrit-MessageType: comment

[S] Change in osmo-bsc[master]: VTY: fix config indentation for pcu-socket

[keith]

keith has uploaded a new patch set (#2). ( 
https://gerrit.osmocom.org/c/osmo-bsc/+/35443?usp=email )


Change subject: VTY: fix config indentation for pcu-socket
..

VTY: fix config indentation for pcu-socket

osmo-bsc would not start with a config written from the vty due
to incorrect identation on the pcu-socket parameter.

Change-Id: I36a66794e654989b4b8bf54bb3727ccbfc2131fa
---
M src/osmo-bsc/bsc_vty.c
1 file changed, 13 insertions(+), 1 deletion(-)


  git pull ssh://gerrit.osmocom.org:29418/osmo-bsc refs/changes/43/35443/2
--
To view, visit https://gerrit.osmocom.org/c/osmo-bsc/+/35443?usp=email
To unsubscribe, or for help writing mail filters, visit 
https://gerrit.osmocom.org/settings

Gerrit-Project: osmo-bsc
Gerrit-Branch: master
Gerrit-Change-Id: I36a66794e654989b4b8bf54bb3727ccbfc2131fa
Gerrit-Change-Number: 35443
Gerrit-PatchSet: 2
Gerrit-Owner: keith 
Gerrit-CC: Jenkins Builder
Gerrit-MessageType: newpatchset

[S] Change in osmo-bsc[master]: VTY: fix config indentation for pcu-socket

[keith]

keith has uploaded this change for review. ( 
https://gerrit.osmocom.org/c/osmo-bsc/+/35443?usp=email )


Change subject: VTY: fix config indentation for pcu-socket
..

VTY: fix config indentation for pcu-socket

osmo-bsc would not start with a config written from the vty due
to incorrect identation on the pcu-socket parameter.

Change-Id: I36a66794e654989b4b8bf54bb3727ccbfc2131fa
---
M src/osmo-bsc/bsc_vty.c
1 file changed, 13 insertions(+), 1 deletion(-)



  git pull ssh://gerrit.osmocom.org:29418/osmo-bsc refs/changes/43/35443/1

diff --git a/src/osmo-bsc/bsc_vty.c b/src/osmo-bsc/bsc_vty.c
index bdc18b6..cc0a61a 100644
--- a/src/osmo-bsc/bsc_vty.c
+++ b/src/osmo-bsc/bsc_vty.c
@@ -415,7 +415,7 @@
}

if (gsmnet->pcu_sock_path)
-   vty_out(vty, "  pcu-socket %s%s", gsmnet->pcu_sock_path, 
VTY_NEWLINE);
+   vty_out(vty, " pcu-socket %s%s", gsmnet->pcu_sock_path, 
VTY_NEWLINE);

neighbor_ident_vty_write_network(vty, " ");
mgcp_client_pool_config_write(vty, " ");

--
To view, visit https://gerrit.osmocom.org/c/osmo-bsc/+/35443?usp=email
To unsubscribe, or for help writing mail filters, visit 
https://gerrit.osmocom.org/settings

Gerrit-Project: osmo-bsc
Gerrit-Branch: master
Gerrit-Change-Id: I36a66794e654989b4b8bf54bb3727ccbfc2131fa
Gerrit-Change-Number: 35443
Gerrit-PatchSet: 1
Gerrit-Owner: keith 
Gerrit-MessageType: newchange

[S] Change in osmo-pcu[master]: TBF status: Fix VTY output text

[keith]

keith has submitted this change. ( 
https://gerrit.osmocom.org/c/osmo-pcu/+/35003?usp=email )

Change subject: TBF status: Fix VTY output text
..

TBF status: Fix VTY output text

The vty command 'show bts pdch' had the UL and DL TBF count reversed.
This patch corrects that.

Change-Id: Ic906ca9d02811cb96e4530af43fbc3769f6afce7
---
M src/pcu_vty_functions.cpp
1 file changed, 13 insertions(+), 1 deletion(-)

Approvals:
  Jenkins Builder: Verified
  fixeria: Looks good to me, approved




diff --git a/src/pcu_vty_functions.cpp b/src/pcu_vty_functions.cpp
index 8dd147c..09a1d77 100644
--- a/src/pcu_vty_functions.cpp
+++ b/src/pcu_vty_functions.cpp
@@ -289,7 +289,7 @@
for (ts_nr = 0; ts_nr < ARRAY_SIZE(trx->pdch); ts_nr++) {
const struct gprs_rlcmac_pdch *pdch = >pdch[ts_nr];

-   vty_out(vty, "  TS%u: PDCH %s, %u UL TBFs, %u DL 
TBFs%s", pdch->ts_no,
+   vty_out(vty, "  TS%u: PDCH %s, %u DL TBFs, %u UL 
TBFs%s", pdch->ts_no,
pdch->is_enabled() ? "enabled" : "disabled",
pdch->num_tbfs(GPRS_RLCMAC_DL_TBF),
pdch->num_tbfs(GPRS_RLCMAC_UL_TBF), 
VTY_NEWLINE);

--
To view, visit https://gerrit.osmocom.org/c/osmo-pcu/+/35003?usp=email
To unsubscribe, or for help writing mail filters, visit 
https://gerrit.osmocom.org/settings

Gerrit-Project: osmo-pcu
Gerrit-Branch: master
Gerrit-Change-Id: Ic906ca9d02811cb96e4530af43fbc3769f6afce7
Gerrit-Change-Number: 35003
Gerrit-PatchSet: 3
Gerrit-Owner: keith 
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: fixeria 
Gerrit-Reviewer: keith 
Gerrit-MessageType: merged

[S] Change in osmo-pcu[master]: TBF status: Fix VTY output text

[keith]

Hello Jenkins Builder,

I'd like you to reexamine a change. Please visit

https://gerrit.osmocom.org/c/osmo-pcu/+/35003?usp=email

to look at the new patch set (#3).


Change subject: TBF status: Fix VTY output text
..

TBF status: Fix VTY output text

The vty command 'show bts pdch' had the UL and DL TBF count reversed.
This patch corrects that.

Change-Id: Ic906ca9d02811cb96e4530af43fbc3769f6afce7
---
M src/pcu_vty_functions.cpp
1 file changed, 13 insertions(+), 1 deletion(-)


  git pull ssh://gerrit.osmocom.org:29418/osmo-pcu refs/changes/03/35003/3
--
To view, visit https://gerrit.osmocom.org/c/osmo-pcu/+/35003?usp=email
To unsubscribe, or for help writing mail filters, visit 
https://gerrit.osmocom.org/settings

Gerrit-Project: osmo-pcu
Gerrit-Branch: master
Gerrit-Change-Id: Ic906ca9d02811cb96e4530af43fbc3769f6afce7
Gerrit-Change-Number: 35003
Gerrit-PatchSet: 3
Gerrit-Owner: keith 
Gerrit-Reviewer: Jenkins Builder
Gerrit-MessageType: newpatchset

[S] Change in osmo-pcu[master]: TBF status: Fix VTY output text

[keith]

keith has uploaded a new patch set (#2). ( 
https://gerrit.osmocom.org/c/osmo-pcu/+/35003?usp=email )


Change subject: TBF status: Fix VTY output text
..

TBF status: Fix VTY output text

The vty command 'show bts pdch' had the UL and DL TBF count reversed.
The patch corrects this.

Change-Id: Ic906ca9d02811cb96e4530af43fbc3769f6afce7
---
M src/pcu_vty_functions.cpp
1 file changed, 13 insertions(+), 1 deletion(-)


  git pull ssh://gerrit.osmocom.org:29418/osmo-pcu refs/changes/03/35003/2
--
To view, visit https://gerrit.osmocom.org/c/osmo-pcu/+/35003?usp=email
To unsubscribe, or for help writing mail filters, visit 
https://gerrit.osmocom.org/settings

Gerrit-Project: osmo-pcu
Gerrit-Branch: master
Gerrit-Change-Id: Ic906ca9d02811cb96e4530af43fbc3769f6afce7
Gerrit-Change-Number: 35003
Gerrit-PatchSet: 2
Gerrit-Owner: keith 
Gerrit-CC: Jenkins Builder
Gerrit-MessageType: newpatchset

[S] Change in osmo-pcu[master]: Fix VTY output txt

[keith]

keith has uploaded this change for review. ( 
https://gerrit.osmocom.org/c/osmo-pcu/+/35003?usp=email )


Change subject: Fix VTY output txt
..

Fix VTY output txt

The vty command 'show bts pdch' had the UL and DL TBF count reversed.
Patch corrects this.

Change-Id: Ic906ca9d02811cb96e4530af43fbc3769f6afce7
---
M src/pcu_vty_functions.cpp
1 file changed, 13 insertions(+), 1 deletion(-)



  git pull ssh://gerrit.osmocom.org:29418/osmo-pcu refs/changes/03/35003/1

diff --git a/src/pcu_vty_functions.cpp b/src/pcu_vty_functions.cpp
index 8dd147c..09a1d77 100644
--- a/src/pcu_vty_functions.cpp
+++ b/src/pcu_vty_functions.cpp
@@ -289,7 +289,7 @@
for (ts_nr = 0; ts_nr < ARRAY_SIZE(trx->pdch); ts_nr++) {
const struct gprs_rlcmac_pdch *pdch = >pdch[ts_nr];

-   vty_out(vty, "  TS%u: PDCH %s, %u UL TBFs, %u DL 
TBFs%s", pdch->ts_no,
+   vty_out(vty, "  TS%u: PDCH %s, %u DL TBFs, %u UL 
TBFs%s", pdch->ts_no,
pdch->is_enabled() ? "enabled" : "disabled",
pdch->num_tbfs(GPRS_RLCMAC_DL_TBF),
pdch->num_tbfs(GPRS_RLCMAC_UL_TBF), 
VTY_NEWLINE);

--
To view, visit https://gerrit.osmocom.org/c/osmo-pcu/+/35003?usp=email
To unsubscribe, or for help writing mail filters, visit 
https://gerrit.osmocom.org/settings

Gerrit-Project: osmo-pcu
Gerrit-Branch: master
Gerrit-Change-Id: Ic906ca9d02811cb96e4530af43fbc3769f6afce7
Gerrit-Change-Number: 35003
Gerrit-PatchSet: 1
Gerrit-Owner: keith 
Gerrit-MessageType: newchange

[M] Change in osmo-mgw[master]: vty and log: also show local port for RTP conns

[keith]

Attention is currently required from: dexter, neels, osmith, pespin.

keith has posted comments on this change. ( 
https://gerrit.osmocom.org/c/osmo-mgw/+/34150?usp=email )

Change subject: vty and log: also show local port for RTP conns
..


Patch Set 4: Code-Review+1

(1 comment)

File src/libosmo-mgcp/mgcp_conn.c:

https://gerrit.osmocom.org/c/osmo-mgw/+/34150/comment/3e112894_625f9a83
PS3, Line 363:  if (!conn) {
> unneeded {}
Done



--
To view, visit https://gerrit.osmocom.org/c/osmo-mgw/+/34150?usp=email
To unsubscribe, or for help writing mail filters, visit 
https://gerrit.osmocom.org/settings

Gerrit-Project: osmo-mgw
Gerrit-Branch: master
Gerrit-Change-Id: Ib89a6779e1d68c6600f00699d4303f6c0ee07132
Gerrit-Change-Number: 34150
Gerrit-PatchSet: 4
Gerrit-Owner: keith 
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: dexter 
Gerrit-Reviewer: keith 
Gerrit-Reviewer: neels 
Gerrit-Reviewer: osmith 
Gerrit-Reviewer: pespin 
Gerrit-Attention: osmith 
Gerrit-Attention: neels 
Gerrit-Attention: pespin 
Gerrit-Attention: dexter 
Gerrit-Comment-Date: Thu, 02 Nov 2023 18:47:02 +
Gerrit-HasComments: Yes
Gerrit-Has-Labels: Yes
Comment-In-Reply-To: pespin 
Gerrit-MessageType: comment

[M] Change in osmo-mgw[master]: vty and log: also show local port for RTP conns

[keith]

Attention is currently required from: dexter, neels, osmith.

keith has posted comments on this change. ( 
https://gerrit.osmocom.org/c/osmo-mgw/+/34150?usp=email )

Change subject: vty and log: also show local port for RTP conns
..


Patch Set 3: Code-Review+1

(1 comment)

Patchset:

PS3:
Thanks for dealing with this! Dropping the RTCP port is good, as is the C vs 0x 
part.



--
To view, visit https://gerrit.osmocom.org/c/osmo-mgw/+/34150?usp=email
To unsubscribe, or for help writing mail filters, visit 
https://gerrit.osmocom.org/settings

Gerrit-Project: osmo-mgw
Gerrit-Branch: master
Gerrit-Change-Id: Ib89a6779e1d68c6600f00699d4303f6c0ee07132
Gerrit-Change-Number: 34150
Gerrit-PatchSet: 3
Gerrit-Owner: keith 
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: dexter 
Gerrit-Reviewer: keith 
Gerrit-Reviewer: neels 
Gerrit-Reviewer: osmith 
Gerrit-Reviewer: pespin 
Gerrit-Attention: osmith 
Gerrit-Attention: neels 
Gerrit-Attention: dexter 
Gerrit-Comment-Date: Thu, 02 Nov 2023 18:42:53 +
Gerrit-HasComments: Yes
Gerrit-Has-Labels: Yes
Gerrit-MessageType: comment

[L] Change in osmo-sip-connector[master]: forward SDP between SIP and MNCC

[keith]

Attention is currently required from: neels, pespin.

keith has posted comments on this change. ( 
https://gerrit.osmocom.org/c/osmo-sip-connector/+/16222?usp=email )

Change subject: forward SDP between SIP and MNCC
..


Patch Set 10: Code-Review+1

(1 comment)

Patchset:

PS10:
I think we should merge this, given that osmo-msc requires it. The whole 
picture is almost complete, and this is a good step forward.



--
To view, visit https://gerrit.osmocom.org/c/osmo-sip-connector/+/16222?usp=email
To unsubscribe, or for help writing mail filters, visit 
https://gerrit.osmocom.org/settings

Gerrit-Project: osmo-sip-connector
Gerrit-Branch: master
Gerrit-Change-Id: I3df5d06f38ee2d122706a9ebffde7db4f2bd6bae
Gerrit-Change-Number: 16222
Gerrit-PatchSet: 10
Gerrit-Owner: neels 
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: keith 
Gerrit-Reviewer: neels 
Gerrit-Reviewer: pespin 
Gerrit-Attention: neels 
Gerrit-Attention: pespin 
Gerrit-Comment-Date: Fri, 15 Sep 2023 03:49:12 +
Gerrit-HasComments: Yes
Gerrit-Has-Labels: Yes
Gerrit-MessageType: comment

[S] Change in osmo-mgw[master]: vty: include local port when dumping RTP conns

[keith]

Attention is currently required from: dexter, osmith, pespin.

keith has posted comments on this change. ( 
https://gerrit.osmocom.org/c/osmo-mgw/+/34150?usp=email )

Change subject: vty: include local port when dumping RTP conns
..


Patch Set 2:

(1 comment)

File src/libosmo-mgcp/mgcp_conn.c:

https://gerrit.osmocom.org/c/osmo-mgw/+/34150/comment/e81fdaab_0649f848
PS1, Line 373:  "rtp:%u<->%u rtcp:%u)",
> conn->name contains a number.. example: […]
Seeing as how we are not specifying RTCP port in the SDP, that is we adhere to 
RFC1889 [the corresponding RTCP stream uses the next higher (odd) port number]
I'm not sure it makes a lot of sense to take up screen space with this 
(derivable) data.



--
To view, visit https://gerrit.osmocom.org/c/osmo-mgw/+/34150?usp=email
To unsubscribe, or for help writing mail filters, visit 
https://gerrit.osmocom.org/settings

Gerrit-Project: osmo-mgw
Gerrit-Branch: master
Gerrit-Change-Id: Ib89a6779e1d68c6600f00699d4303f6c0ee07132
Gerrit-Change-Number: 34150
Gerrit-PatchSet: 2
Gerrit-Owner: keith 
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: dexter 
Gerrit-Reviewer: osmith 
Gerrit-Reviewer: pespin 
Gerrit-Attention: osmith 
Gerrit-Attention: pespin 
Gerrit-Attention: dexter 
Gerrit-Comment-Date: Thu, 14 Sep 2023 07:29:57 +
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: pespin 
Comment-In-Reply-To: keith 
Comment-In-Reply-To: dexter 
Gerrit-MessageType: comment

[S] Change in osmo-mgw[master]: vty: include local port when dumping RTP conns

[keith]

Attention is currently required from: dexter, osmith, pespin.

keith has posted comments on this change. ( 
https://gerrit.osmocom.org/c/osmo-mgw/+/34150?usp=email )

Change subject: vty: include local port when dumping RTP conns
..


Patch Set 2:

(1 comment)

File src/libosmo-mgcp/mgcp_conn.c:

https://gerrit.osmocom.org/c/osmo-mgw/+/34150/comment/bd79f1fb_de954401
PS1, Line 373:  "rtp:%u<->%u rtcp:%u)",
> with ip probe enabled, the local IP address may change for each connection 
> depending on the routing  […]
conn->name contains a number.. example:
CONN: (21/rtp, id:0x9B686BE3, ip:172.16.0.1, rtp:4004<->4008 rtcp:4009)



--
To view, visit https://gerrit.osmocom.org/c/osmo-mgw/+/34150?usp=email
To unsubscribe, or for help writing mail filters, visit 
https://gerrit.osmocom.org/settings

Gerrit-Project: osmo-mgw
Gerrit-Branch: master
Gerrit-Change-Id: Ib89a6779e1d68c6600f00699d4303f6c0ee07132
Gerrit-Change-Number: 34150
Gerrit-PatchSet: 2
Gerrit-Owner: keith 
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: dexter 
Gerrit-Reviewer: osmith 
Gerrit-Reviewer: pespin 
Gerrit-Attention: osmith 
Gerrit-Attention: pespin 
Gerrit-Attention: dexter 
Gerrit-Comment-Date: Thu, 14 Sep 2023 07:23:28 +
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: pespin 
Comment-In-Reply-To: keith 
Comment-In-Reply-To: dexter 
Gerrit-MessageType: comment

[S] Change in osmo-mgw[master]: vty: include local port when dumping RTP conns

[keith]

Attention is currently required from: dexter, keith, osmith, pespin.

Hello Jenkins Builder, dexter, osmith, pespin,

I'd like you to reexamine a change. Please visit

https://gerrit.osmocom.org/c/osmo-mgw/+/34150?usp=email

to look at the new patch set (#2).

The following approvals got outdated and were removed:
Code-Review+1 by dexter, Code-Review+1 by osmith, Code-Review-1 by pespin, 
Verified+1 by Jenkins Builder


Change subject: vty: include local port when dumping RTP conns
..

vty: include local port when dumping RTP conns

The CONN pairs associated with each endpoint show remote RTP
ports. When osmo-mgw is being used by both BSC and MSC, one
side of the pair is showing the internal loop connection inside
osmo-mgw, while my intuition suggested this connection pair
is showing me the RTP port tuple of a single RTP stream. Adding
the local port to the display makes it more clear, IMHO.
Seeing the local port can also help to correlate the MGW vty
dump with a capture of RTP.

Change-Id: Ib89a6779e1d68c6600f00699d4303f6c0ee07132
---
M src/libosmo-mgcp/mgcp_conn.c
1 file changed, 22 insertions(+), 2 deletions(-)


  git pull ssh://gerrit.osmocom.org:29418/osmo-mgw refs/changes/50/34150/2
--
To view, visit https://gerrit.osmocom.org/c/osmo-mgw/+/34150?usp=email
To unsubscribe, or for help writing mail filters, visit 
https://gerrit.osmocom.org/settings

Gerrit-Project: osmo-mgw
Gerrit-Branch: master
Gerrit-Change-Id: Ib89a6779e1d68c6600f00699d4303f6c0ee07132
Gerrit-Change-Number: 34150
Gerrit-PatchSet: 2
Gerrit-Owner: keith 
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: dexter 
Gerrit-Reviewer: osmith 
Gerrit-Reviewer: pespin 
Gerrit-Attention: osmith 
Gerrit-Attention: pespin 
Gerrit-Attention: keith 
Gerrit-Attention: dexter 
Gerrit-MessageType: newpatchset

[L] Change in osmo-sip-connector[master]: forward SDP between SIP and MNCC

[keith]

Attention is currently required from: neels, pespin.

keith has posted comments on this change. ( 
https://gerrit.osmocom.org/c/osmo-sip-connector/+/16222?usp=email )

Change subject: forward SDP between SIP and MNCC
..


Patch Set 9: Code-Review-1

(1 comment)

File src/sip.c:

https://gerrit.osmocom.org/c/osmo-sip-connector/+/16222/comment/18a0a1f8_2da5a8e8
PS9, Line 549:  SIPTAG_PAYLOAD_STR(sdp),
I'm slightly concerned about introducing the sending of SDP with the 180. It's 
not something I really ever see, and although some quick investigation suggests 
that UAs /should/ treat it like a 183, that is to say, we are telling the 
remote to expect early media (which come to think of it, are we? are generating 
ringback?) - I did come across a CISCO doc just now saying this behaviour is 
configurable. uf...

I'd say leave the 180 without SDP.

Actually, I just tested this, with an A leg hitting Freeswitch and the B leg 
towards osmo-sip-connector and indeed; no ringback from Freewitch as FS sees 
the SDP with the 180 and starts forwarding the media to the A leg, but nothing 
is generating ringback.



--
To view, visit https://gerrit.osmocom.org/c/osmo-sip-connector/+/16222?usp=email
To unsubscribe, or for help writing mail filters, visit 
https://gerrit.osmocom.org/settings

Gerrit-Project: osmo-sip-connector
Gerrit-Branch: master
Gerrit-Change-Id: I3df5d06f38ee2d122706a9ebffde7db4f2bd6bae
Gerrit-Change-Number: 16222
Gerrit-PatchSet: 9
Gerrit-Owner: neels 
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: keith 
Gerrit-Reviewer: neels 
Gerrit-Reviewer: pespin 
Gerrit-Attention: neels 
Gerrit-Attention: pespin 
Gerrit-Comment-Date: Thu, 14 Sep 2023 05:02:17 +
Gerrit-HasComments: Yes
Gerrit-Has-Labels: Yes
Gerrit-MessageType: comment

[S] Change in osmo-sip-connector[master]: sdp_get_sdp_mode(): fix wrong return value

[keith]

Attention is currently required from: neels, pespin.

keith has posted comments on this change. ( 
https://gerrit.osmocom.org/c/osmo-sip-connector/+/34410?usp=email )

Change subject: sdp_get_sdp_mode(): fix wrong return value
..


Patch Set 1: Code-Review+2


--
To view, visit https://gerrit.osmocom.org/c/osmo-sip-connector/+/34410?usp=email
To unsubscribe, or for help writing mail filters, visit 
https://gerrit.osmocom.org/settings

Gerrit-Project: osmo-sip-connector
Gerrit-Branch: master
Gerrit-Change-Id: Id27eb82a018293cf54d068877dc222e1c7eab253
Gerrit-Change-Number: 34410
Gerrit-PatchSet: 1
Gerrit-Owner: neels 
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: keith 
Gerrit-Reviewer: pespin 
Gerrit-Attention: neels 
Gerrit-Attention: pespin 
Gerrit-Comment-Date: Thu, 14 Sep 2023 02:57:19 +
Gerrit-HasComments: No
Gerrit-Has-Labels: Yes
Gerrit-MessageType: comment

[S] Change in osmo-sip-connector[master]: sdp_get_sdp_mode(): fix wrong return value

[keith]

Attention is currently required from: neels, pespin.

keith has posted comments on this change. ( 
https://gerrit.osmocom.org/c/osmo-sip-connector/+/34410?usp=email )

Change subject: sdp_get_sdp_mode(): fix wrong return value
..


Patch Set 1: Code-Review+1

(1 comment)

File src/sdp.c:

https://gerrit.osmocom.org/c/osmo-sip-connector/+/34410/comment/b2c53898_85cd4a81
PS1, Line 68:   return sdp_sendrecv;
> sdp_sendrecv is enum sdp_mode_t from sofia-sip. […]
I guess I was probably confused between updating passed pointers like it says 
on the tin and returning a bool to imply failure - and not paying attention to 
returned types and such things. Or maybe there was some copy/paste involved.
I was an even worse C programmer back in July 2019 than I am today.
Hmm, compiler does not complain though. 



--
To view, visit https://gerrit.osmocom.org/c/osmo-sip-connector/+/34410?usp=email
To unsubscribe, or for help writing mail filters, visit 
https://gerrit.osmocom.org/settings

Gerrit-Project: osmo-sip-connector
Gerrit-Branch: master
Gerrit-Change-Id: Id27eb82a018293cf54d068877dc222e1c7eab253
Gerrit-Change-Number: 34410
Gerrit-PatchSet: 1
Gerrit-Owner: neels 
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: keith 
Gerrit-Reviewer: pespin 
Gerrit-Attention: neels 
Gerrit-Attention: pespin 
Gerrit-Comment-Date: Thu, 14 Sep 2023 02:56:18 +
Gerrit-HasComments: Yes
Gerrit-Has-Labels: Yes
Comment-In-Reply-To: neels 
Comment-In-Reply-To: pespin 
Gerrit-MessageType: comment

[S] Change in osmo-mgw[master]: vty: include local port when dumping RTP conns

[keith]

Attention is currently required from: pespin, dexter.

keith has posted comments on this change. ( 
https://gerrit.osmocom.org/c/osmo-mgw/+/34150 )

Change subject: vty: include local port when dumping RTP conns
..


Patch Set 1:

(1 comment)

File src/libosmo-mgcp/mgcp_conn.c:

https://gerrit.osmocom.org/c/osmo-mgw/+/34150/comment/57dcd037_8f21cc49
PS1, Line 373:  "rtp:%u<->%u rtcp:%u)",
> You could also do something like "l:%s<->r:%s (rtcp: %u<->%u)" or alike.
One /could/ print the local IP here, yes, but will it ever change? There's only 
one bound IP for RTP in the MGW, correct?

I don't really want to get into bike shedding about it. I'm happy enough to 
maintain this in rhizomatica branch, or to +1 (or not) if somebody else wants 
to UL an alternative patch. :-)



--
To view, visit https://gerrit.osmocom.org/c/osmo-mgw/+/34150
To unsubscribe, or for help writing mail filters, visit 
https://gerrit.osmocom.org/settings

Gerrit-Project: osmo-mgw
Gerrit-Branch: master
Gerrit-Change-Id: Ib89a6779e1d68c6600f00699d4303f6c0ee07132
Gerrit-Change-Number: 34150
Gerrit-PatchSet: 1
Gerrit-Owner: keith 
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: dexter 
Gerrit-Reviewer: osmith 
Gerrit-Reviewer: pespin 
Gerrit-Attention: pespin 
Gerrit-Attention: dexter 
Gerrit-Comment-Date: Mon, 21 Aug 2023 22:29:58 +
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: pespin 
Comment-In-Reply-To: dexter 
Gerrit-MessageType: comment

[S] Change in osmo-mgw[master]: vty: include local port when dumping RTP conns

[keith]

keith has uploaded this change for review. ( 
https://gerrit.osmocom.org/c/osmo-mgw/+/34150 )


Change subject: vty: include local port when dumping RTP conns
..

vty: include local port when dumping RTP conns

The CONN pairs associated with each endpoint show remote RTP
ports. When osmo-mgw is being used by both BSC and MSC, one
side of the pair is showing the internal loop connection inside
osmo-mgw, while my intuition suggested this connection pair
is showing me the RTP port tuple of a single RTP stream. Adding
the local port to the display makes it more clear, IMHO.
Seeing the local port can also help to correlate the MGW vty
dump with a capture of RTP.

Change-Id: Ib89a6779e1d68c6600f00699d4303f6c0ee07132
---
M src/libosmo-mgcp/mgcp_conn.c
1 file changed, 20 insertions(+), 1 deletion(-)



  git pull ssh://gerrit.osmocom.org:29418/osmo-mgw refs/changes/50/34150/1

diff --git a/src/libosmo-mgcp/mgcp_conn.c b/src/libosmo-mgcp/mgcp_conn.c
index 0ba10e5..b756736 100644
--- a/src/libosmo-mgcp/mgcp_conn.c
+++ b/src/libosmo-mgcp/mgcp_conn.c
@@ -370,9 +370,10 @@
case MGCP_RTP_DEFAULT:
/* Dump RTP connection */
snprintf(str, sizeof(str), "(%s/rtp, id:0x%s, ip:%s, "
-   "rtp:%u rtcp:%u)",
+   "rtp:%u<->%u rtcp:%u)",
conn->name, conn->id,
osmo_sockaddr_ntop(>u.rtp.end.addr.u.sa, 
ipbuf),
+   conn->u.rtp.end.local_port,
osmo_sockaddr_port(>u.rtp.end.addr.u.sa),
ntohs(conn->u.rtp.end.rtcp_port));
break;

--
To view, visit https://gerrit.osmocom.org/c/osmo-mgw/+/34150
To unsubscribe, or for help writing mail filters, visit 
https://gerrit.osmocom.org/settings

Gerrit-Project: osmo-mgw
Gerrit-Branch: master
Gerrit-Change-Id: Ib89a6779e1d68c6600f00699d4303f6c0ee07132
Gerrit-Change-Number: 34150
Gerrit-PatchSet: 1
Gerrit-Owner: keith 
Gerrit-MessageType: newchange

[S] Change in osmo-bts[master]: Fix incorrect order of params passed to logging macro

[keith]

keith has uploaded this change for review. ( 
https://gerrit.osmocom.org/c/osmo-bts/+/34085 )


Change subject: Fix incorrect order of params passed to logging macro
..

Fix incorrect order of params passed to logging macro

Stops log lines like:
'DOML unknown 0x239616 (bts=0,trx=0,ts=1,ss=0) []'

Change-Id: Ie1ad41210280ae5dbe693de6bdc4378ff34621b7
---
M src/osmo-bts-sysmo/tch.c
1 file changed, 13 insertions(+), 1 deletion(-)



  git pull ssh://gerrit.osmocom.org:29418/osmo-bts refs/changes/85/34085/1

diff --git a/src/osmo-bts-sysmo/tch.c b/src/osmo-bts-sysmo/tch.c
index 0109771..a0d1cf8 100644
--- a/src/osmo-bts-sysmo/tch.c
+++ b/src/osmo-bts-sysmo/tch.c
@@ -635,7 +635,7 @@
if (is_recv_only(lchan->abis_ip.speech_mode))
return -EAGAIN;

-   LOGPLCFN(lchan, DL1P, LOGL_DEBUG, data_ind->u32Fn, "chan_nr %d Rx 
FACCH\n", chan_nr);
+   LOGPLCFN(lchan, data_ind->u32Fn, DL1P, LOGL_DEBUG, "chan_nr %d Rx 
FACCH\n", chan_nr);
/* Push empty payload to upper layers */
rmsg = msgb_alloc_headroom(256, 128, "L1P-to-RTP");
return add_l1sap_header(trx, rmsg, lchan, chan_nr, data_ind->u32Fn,

--
To view, visit https://gerrit.osmocom.org/c/osmo-bts/+/34085
To unsubscribe, or for help writing mail filters, visit 
https://gerrit.osmocom.org/settings

Gerrit-Project: osmo-bts
Gerrit-Branch: master
Gerrit-Change-Id: Ie1ad41210280ae5dbe693de6bdc4378ff34621b7
Gerrit-Change-Number: 34085
Gerrit-PatchSet: 1
Gerrit-Owner: keith 
Gerrit-MessageType: newchange

[S] Change in osmo-msc[master]: SMPP: Fix Memory leaks

[keith]

Hello Jenkins Builder,

I'd like you to reexamine a change. Please visit

https://gerrit.osmocom.org/c/osmo-msc/+/33890

to look at the new patch set (#2).

Change subject: SMPP: Fix Memory leaks
..

SMPP: Fix Memory leaks

Whenever we call build_tlv() we must
call destroy_tlv() after we are finished with it.

Similarly, smpp34_unpack() makes calls to smpp34_malloc()
and these need to be free'd by us later.

Change-Id: Ic2abcbe78cf7cf7b6ce36fe09aa9b4f8daee973f
---
M src/libsmpputil/smpp_msc.c
M src/libsmpputil/smpp_smsc.c
2 files changed, 18 insertions(+), 0 deletions(-)


  git pull ssh://gerrit.osmocom.org:29418/osmo-msc refs/changes/90/33890/2
--
To view, visit https://gerrit.osmocom.org/c/osmo-msc/+/33890
To unsubscribe, or for help writing mail filters, visit 
https://gerrit.osmocom.org/settings

Gerrit-Project: osmo-msc
Gerrit-Branch: master
Gerrit-Change-Id: Ic2abcbe78cf7cf7b6ce36fe09aa9b4f8daee973f
Gerrit-Change-Number: 33890
Gerrit-PatchSet: 2
Gerrit-Owner: keith 
Gerrit-Reviewer: Jenkins Builder
Gerrit-MessageType: newpatchset

[S] Change in osmo-msc[master]: SMPP: Fix Memory leak in deliver_to_esme()

[keith]

keith has uploaded this change for review. ( 
https://gerrit.osmocom.org/c/osmo-msc/+/33890 )


Change subject: SMPP: Fix Memory leak in deliver_to_esme()
..

SMPP: Fix Memory leak in deliver_to_esme()

After we call build_tlv, in this case via append_tlv_u16, we must
call destroy_tlv after we are finished with it.

Change-Id: Ic2abcbe78cf7cf7b6ce36fe09aa9b4f8daee973f
---
M src/libsmpputil/smpp_msc.c
1 file changed, 13 insertions(+), 0 deletions(-)



  git pull ssh://gerrit.osmocom.org:29418/osmo-msc refs/changes/90/33890/1

diff --git a/src/libsmpputil/smpp_msc.c b/src/libsmpputil/smpp_msc.c
index fed5858..cf17540 100644
--- a/src/libsmpputil/smpp_msc.c
+++ b/src/libsmpputil/smpp_msc.c
@@ -788,6 +788,7 @@
   sms->msg_ref);

ret = smpp_tx_deliver(esme, );
+   destroy_tlv(deliver.tlv);
if (ret < 0)
return ret;


--
To view, visit https://gerrit.osmocom.org/c/osmo-msc/+/33890
To unsubscribe, or for help writing mail filters, visit 
https://gerrit.osmocom.org/settings

Gerrit-Project: osmo-msc
Gerrit-Branch: master
Gerrit-Change-Id: Ic2abcbe78cf7cf7b6ce36fe09aa9b4f8daee973f
Gerrit-Change-Number: 33890
Gerrit-PatchSet: 1
Gerrit-Owner: keith 
Gerrit-MessageType: newchange

[L] Change in libosmo-abis[master]: e1d: reconnect to osmo-e1d after connection loss

[keith]

Attention is currently required from: laforge, dexter.

keith has posted comments on this change. ( 
https://gerrit.osmocom.org/c/libosmo-abis/+/32374 )

Change subject: e1d: reconnect to osmo-e1d after connection loss
..


Patch Set 2:

(1 comment)

Patchset:

PS2:
> I'm wondering why this is implemented in libosmo-abis, and not in 
> libosmo-e1d?  Isn't the same probl […]
I suppose because the issue being attended to here was observed and reported in 
libosmo-abis using applications.
Does it take much more work to move this to libosmo-e1d? If so then maybe we 
should attend to the issue here, if not I'll wait for a libosmo-e1d patch to 
review.



--
To view, visit https://gerrit.osmocom.org/c/libosmo-abis/+/32374
To unsubscribe, or for help writing mail filters, visit 
https://gerrit.osmocom.org/settings

Gerrit-Project: libosmo-abis
Gerrit-Branch: master
Gerrit-Change-Id: Iaf4d42c2f009b1d7666e319fabdeb2598aa0b338
Gerrit-Change-Number: 32374
Gerrit-PatchSet: 2
Gerrit-Owner: dexter 
Gerrit-Reviewer: Jenkins Builder
Gerrit-CC: keith 
Gerrit-CC: laforge 
Gerrit-Attention: laforge 
Gerrit-Attention: dexter 
Gerrit-Comment-Date: Thu, 20 Apr 2023 10:36:57 +
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: laforge 
Gerrit-MessageType: comment

[S] Change in osmo-bts[master]: osmo-bts-{sysmo,lc15,oc2g}: fix segfault in ph_tch_req()

[keith]

Attention is currently required from: fixeria.

keith has posted comments on this change. ( 
https://gerrit.osmocom.org/c/osmo-bts/+/31991 )

Change subject: osmo-bts-{sysmo,lc15,oc2g}: fix segfault in ph_tch_req()
..


Patch Set 1: Code-Review+1

(1 comment)

Patchset:

PS1:
tested re OS#5925 thanks @fixeria.



--
To view, visit https://gerrit.osmocom.org/c/osmo-bts/+/31991
To unsubscribe, or for help writing mail filters, visit 
https://gerrit.osmocom.org/settings

Gerrit-Project: osmo-bts
Gerrit-Branch: master
Gerrit-Change-Id: Ib349b74a9e4bd48c902286f872d3b0e9a068256c
Gerrit-Change-Number: 31991
Gerrit-PatchSet: 1
Gerrit-Owner: fixeria 
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: keith 
Gerrit-Reviewer: laforge 
Gerrit-Reviewer: pespin 
Gerrit-Attention: fixeria 
Gerrit-Comment-Date: Fri, 24 Mar 2023 18:22:42 +
Gerrit-HasComments: Yes
Gerrit-Has-Labels: Yes
Gerrit-MessageType: comment

[M] Change in osmo-bsc[master]: bts: bts: Explain Ericsson's interface switch (IS)

[keith]

Attention is currently required from: dexter.

keith has posted comments on this change. ( 
https://gerrit.osmocom.org/c/osmo-bsc/+/32029 )

Change subject: bts: bts: Explain Ericsson's interface switch (IS)
..


Patch Set 1: Code-Review+1

(2 comments)

Patchset:

PS1:
+1 for content, (with laforge's comments)

I don't know what's going on with the Jenkins errors.


File doc/manuals/chapters/bts.adoc:

https://gerrit.osmocom.org/c/osmo-bsc/+/32029/comment/7710e6b5_55dc78bf
PS1, Line 784: to the outside must be aligned to E1 timeslot boarders.
borders. (with 'a' it is Gäste)



--
To view, visit https://gerrit.osmocom.org/c/osmo-bsc/+/32029
To unsubscribe, or for help writing mail filters, visit 
https://gerrit.osmocom.org/settings

Gerrit-Project: osmo-bsc
Gerrit-Branch: master
Gerrit-Change-Id: Ib6ebd7fdfe9063c0d8cacf53ffd27f6099d9038a
Gerrit-Change-Number: 32029
Gerrit-PatchSet: 1
Gerrit-Owner: dexter 
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: keith 
Gerrit-Reviewer: laforge 
Gerrit-Attention: dexter 
Gerrit-Comment-Date: Fri, 24 Mar 2023 00:59:19 +
Gerrit-HasComments: Yes
Gerrit-Has-Labels: Yes
Gerrit-MessageType: comment

[M] Change in osmo-bsc[master]: doc: running: Describe how to configure a co-located PCU

[keith]

Attention is currently required from: dexter.

keith has posted comments on this change. ( 
https://gerrit.osmocom.org/c/osmo-bsc/+/32030 )

Change subject: doc: running: Describe how to configure a co-located PCU
..


Patch Set 1: Code-Review+1


--
To view, visit https://gerrit.osmocom.org/c/osmo-bsc/+/32030
To unsubscribe, or for help writing mail filters, visit 
https://gerrit.osmocom.org/settings

Gerrit-Project: osmo-bsc
Gerrit-Branch: master
Gerrit-Change-Id: I3af3cd8ef7099bb94f4cb25513e9dfdc5fcc1b5a
Gerrit-Change-Number: 32030
Gerrit-PatchSet: 1
Gerrit-Owner: dexter 
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: keith 
Gerrit-Reviewer: laforge 
Gerrit-Attention: dexter 
Gerrit-Comment-Date: Fri, 24 Mar 2023 00:38:36 +
Gerrit-HasComments: No
Gerrit-Has-Labels: Yes
Gerrit-MessageType: comment

[M] Change in libosmocore[master]: New osmo-gsmtap-logsend utility

[keith]

Attention is currently required from: neels, laforge.

keith has posted comments on this change. ( 
https://gerrit.osmocom.org/c/libosmocore/+/31916 )

Change subject: New osmo-gsmtap-logsend utility
..


Patch Set 4:

(1 comment)

File utils/gsmtap-logsend.c:

https://gerrit.osmocom.org/c/libosmocore/+/31916/comment/1f13107e_e5bae635
PS2, Line 18: #include 
: #include 
: #include 
: #include 
> apparently these 4 #includes are not needed. […]
tested that, and removed them.



--
To view, visit https://gerrit.osmocom.org/c/libosmocore/+/31916
To unsubscribe, or for help writing mail filters, visit 
https://gerrit.osmocom.org/settings

Gerrit-Project: libosmocore
Gerrit-Branch: master
Gerrit-Change-Id: Ida96e87d84e0c349c5069edc67fec1c3cf19d1ab
Gerrit-Change-Number: 31916
Gerrit-PatchSet: 4
Gerrit-Owner: laforge 
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: keith 
Gerrit-Reviewer: neels 
Gerrit-Attention: neels 
Gerrit-Attention: laforge 
Gerrit-Comment-Date: Tue, 14 Mar 2023 22:32:10 +
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: neels 
Gerrit-MessageType: comment

[M] Change in libosmocore[master]: New osmo-gsmtap-logsend utility

[keith]

Attention is currently required from: laforge, keith.

keith has uploaded a new patch set (#4) to the change originally created by 
laforge. ( https://gerrit.osmocom.org/c/libosmocore/+/31916 )

Change subject: New osmo-gsmtap-logsend utility
..

New osmo-gsmtap-logsend utility

This utility can be used to "pipe" stdin or some file as log lines
via GSMTAP logging.

Change-Id: Ida96e87d84e0c349c5069edc67fec1c3cf19d1ab
---
M debian/libosmocore-utils.install
M utils/Makefile.am
A utils/gsmtap-logsend.c
3 files changed, 155 insertions(+), 1 deletion(-)


  git pull ssh://gerrit.osmocom.org:29418/libosmocore refs/changes/16/31916/4
--
To view, visit https://gerrit.osmocom.org/c/libosmocore/+/31916
To unsubscribe, or for help writing mail filters, visit 
https://gerrit.osmocom.org/settings

Gerrit-Project: libosmocore
Gerrit-Branch: master
Gerrit-Change-Id: Ida96e87d84e0c349c5069edc67fec1c3cf19d1ab
Gerrit-Change-Number: 31916
Gerrit-PatchSet: 4
Gerrit-Owner: laforge 
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: keith 
Gerrit-Reviewer: neels 
Gerrit-Attention: laforge 
Gerrit-Attention: keith 
Gerrit-MessageType: newpatchset

[M] Change in libosmocore[master]: New osmo-gsmtap-logsend utility

[keith]

Attention is currently required from: laforge, keith.

keith has posted comments on this change. ( 
https://gerrit.osmocom.org/c/libosmocore/+/31916 )

Change subject: New osmo-gsmtap-logsend utility
..


Patch Set 3: Code-Review+1


--
To view, visit https://gerrit.osmocom.org/c/libosmocore/+/31916
To unsubscribe, or for help writing mail filters, visit 
https://gerrit.osmocom.org/settings

Gerrit-Project: libosmocore
Gerrit-Branch: master
Gerrit-Change-Id: Ida96e87d84e0c349c5069edc67fec1c3cf19d1ab
Gerrit-Change-Number: 31916
Gerrit-PatchSet: 3
Gerrit-Owner: laforge 
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: keith 
Gerrit-Reviewer: neels 
Gerrit-Attention: laforge 
Gerrit-Attention: keith 
Gerrit-Comment-Date: Tue, 14 Mar 2023 22:22:28 +
Gerrit-HasComments: No
Gerrit-Has-Labels: Yes
Gerrit-MessageType: comment

[M] Change in libosmocore[master]: New osmo-gsmtap-logsend utility

[keith]

keith has uploaded a new patch set (#3) to the change originally created by 
laforge. ( https://gerrit.osmocom.org/c/libosmocore/+/31916 )

Change subject: New osmo-gsmtap-logsend utility
..

New osmo-gsmtap-logsend utility

This utility can be used to "pipe" stdin or some file as log lines
via GSMTAP logging.

Change-Id: Ida96e87d84e0c349c5069edc67fec1c3cf19d1ab
---
M debian/libosmocore-utils.install
M utils/Makefile.am
A utils/gsmtap-logsend.c
3 files changed, 159 insertions(+), 1 deletion(-)


  git pull ssh://gerrit.osmocom.org:29418/libosmocore refs/changes/16/31916/3
--
To view, visit https://gerrit.osmocom.org/c/libosmocore/+/31916
To unsubscribe, or for help writing mail filters, visit 
https://gerrit.osmocom.org/settings

Gerrit-Project: libosmocore
Gerrit-Branch: master
Gerrit-Change-Id: Ida96e87d84e0c349c5069edc67fec1c3cf19d1ab
Gerrit-Change-Number: 31916
Gerrit-PatchSet: 3
Gerrit-Owner: laforge 
Gerrit-Reviewer: Jenkins Builder
Gerrit-MessageType: newpatchset

Change in osmo-msc[master]: LCLS: Fix Global Call Reference generation

[keith]

keith has submitted this change. ( 
https://gerrit.osmocom.org/c/osmo-msc/+/31131 )

Change subject: LCLS: Fix Global Call Reference generation
..

LCLS: Fix Global Call Reference generation

According to 3gpp spec the Call Reference part of GCR is 5 octets,
3 octets Call ID followed by 2 octets BSS ID.

We are using our internal call reference (4 octets) and the
location area code, or optionally Cell ID as BSS ID
(2 octets). Obviously it does not fit.

Let's use only 3 octets from the call reference, dropping the MSB.

Includes code by Vadim Yanitskiy 

Change-Id: I9c33a89c819e8925d89ca833d7705ed5ced6b566
---
M src/libmsc/transaction.c
1 file changed, 10 insertions(+), 4 deletions(-)

Approvals:
  Jenkins Builder: Verified
  fixeria: Looks good to me, approved



diff --git a/src/libmsc/transaction.c b/src/libmsc/transaction.c
index 25c0e3c..6c12409 100644
--- a/src/libmsc/transaction.c
+++ b/src/libmsc/transaction.c
@@ -153,11 +153,17 @@
/* net id from Q.1902.3 3-5 bytes, this function gives 3 bytes exactly 
*/
osmo_plmn_to_bcd(lcls->gcr.net, >net->plmn);

-   osmo_store32be(trans->callref, lcls->gcr.cr);
-   osmo_store16be(use_lac ? trans->msc_a->via_cell.lai.lac : 
trans->msc_a->via_cell.cell_identity, lcls->gcr.cr + 3);

-   LOGP(DCC, LOGL_INFO, "LCLS: allocated %s-based CR-ID %s\n", use_lac ? 
"LAC" : "CI",
-osmo_hexdump(lcls->gcr.cr, 5));
+   /* TS 29.205 Table B.2.1.9.2 Call Reference ID
+* 3 octets Call ID + 2 octets BSS ID
+*/
+   lcls->gcr.cr[2] = (trans->callref >>  0) & 0xff;
+   lcls->gcr.cr[1] = (trans->callref >>  8) & 0xff;
+   lcls->gcr.cr[0] = (trans->callref >> 16) & 0xff;
+   osmo_store16be(use_lac ? trans->msc_a->via_cell.lai.lac : 
trans->msc_a->via_cell.cell_identity, >gcr.cr[3]);
+
+   LOGP(DCC, LOGL_INFO, "LCLS: allocated %s-based CR-ID %sfor callref 
0x%04x\n", use_lac ? "LAC" : "CI",
+osmo_hexdump(lcls->gcr.cr, 5), trans->callref);

lcls->config = GSM0808_LCLS_CFG_BOTH_WAY;
lcls->control = GSM0808_LCLS_CSC_CONNECT;

--
To view, visit https://gerrit.osmocom.org/c/osmo-msc/+/31131
To unsubscribe, or for help writing mail filters, visit 
https://gerrit.osmocom.org/settings

Gerrit-Project: osmo-msc
Gerrit-Branch: master
Gerrit-Change-Id: I9c33a89c819e8925d89ca833d7705ed5ced6b566
Gerrit-Change-Number: 31131
Gerrit-PatchSet: 2
Gerrit-Owner: keith 
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: fixeria 
Gerrit-Reviewer: keith 
Gerrit-Reviewer: laforge 
Gerrit-MessageType: merged

Change in osmo-msc[master]: LCLS: Fix Global Call Reference generation

[keith]

Attention is currently required from: fixeria.
keith has posted comments on this change. ( 
https://gerrit.osmocom.org/c/osmo-msc/+/31131 )

Change subject: LCLS: Fix Global Call Reference generation
..


Patch Set 2:

(2 comments)

File src/libmsc/transaction.c:

https://gerrit.osmocom.org/c/osmo-msc/+/31131/comment/8e6a083b_e064df77
PS1, Line 165: %sfor
> missing space between '%s' and 'for'
Actually done intentionally, because osmo_hexdump() seems to add a space at the 
end. If I add the "missing" space then the log line will contain two spaces.


https://gerrit.osmocom.org/c/osmo-msc/+/31131/comment/4fe15bb1_ac4f8812
PS1, Line 165: 0x%x
> 0x04x to ensure consistent formatting
I'm guessing you mean 0x%04x, although I don't understand why. It's 4 octets 
anyway, no? -  the logging macro often logging callref uses:
.
LOGP(subsys, level, \
 "trans(%s %s callref-0x%x tid-%u%s) " fmt, \


But I trust your request, I hope I have it right.



--
To view, visit https://gerrit.osmocom.org/c/osmo-msc/+/31131
To unsubscribe, or for help writing mail filters, visit 
https://gerrit.osmocom.org/settings

Gerrit-Project: osmo-msc
Gerrit-Branch: master
Gerrit-Change-Id: I9c33a89c819e8925d89ca833d7705ed5ced6b566
Gerrit-Change-Number: 31131
Gerrit-PatchSet: 2
Gerrit-Owner: keith 
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: fixeria 
Gerrit-Reviewer: laforge 
Gerrit-Attention: fixeria 
Gerrit-Comment-Date: Wed, 01 Feb 2023 02:08:51 +
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: fixeria 
Gerrit-MessageType: comment

Change in osmo-msc[master]: LCLS: Fix Global Call Reference generation

[keith]

Attention is currently required from: keith.
Hello Jenkins Builder, laforge, fixeria,

I'd like you to reexamine a change. Please visit

https://gerrit.osmocom.org/c/osmo-msc/+/31131

to look at the new patch set (#2).

Change subject: LCLS: Fix Global Call Reference generation
..

LCLS: Fix Global Call Reference generation

According to 3gpp spec the Call Reference part of GCR is 5 octets,
3 octets Call ID followed by 2 octets BSS ID.

We are using our internal call reference (4 octets) and the
location area code, or optionally Cell ID as BSS ID
(2 octets). Obviously it does not fit.

Let's use only 3 octets from the call reference, dropping the MSB.

Includes code by Vadim Yanitskiy 

Change-Id: I9c33a89c819e8925d89ca833d7705ed5ced6b566
---
M src/libmsc/transaction.c
1 file changed, 10 insertions(+), 4 deletions(-)


  git pull ssh://gerrit.osmocom.org:29418/osmo-msc refs/changes/31/31131/2
--
To view, visit https://gerrit.osmocom.org/c/osmo-msc/+/31131
To unsubscribe, or for help writing mail filters, visit 
https://gerrit.osmocom.org/settings

Gerrit-Project: osmo-msc
Gerrit-Branch: master
Gerrit-Change-Id: I9c33a89c819e8925d89ca833d7705ed5ced6b566
Gerrit-Change-Number: 31131
Gerrit-PatchSet: 2
Gerrit-Owner: keith 
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: fixeria 
Gerrit-Reviewer: laforge 
Gerrit-Attention: keith 
Gerrit-MessageType: newpatchset

Change in osmo-msc[master]: LCLS: Fix Global Call Reference generation

[keith]

keith has uploaded this change for review. ( 
https://gerrit.osmocom.org/c/osmo-msc/+/31131 )


Change subject: LCLS: Fix Global Call Reference generation
..

LCLS: Fix Global Call Reference generation

According to 3gpp spec the Call Reference part of GCR is 5 octets,
3 octets Call ID followed by 2 octets BSS ID.

We are using our internal call reference (4 octets) and the
location area code, or optionally Cell ID as BSS ID
(2 octets). Obviously it does not fit.

Let's use only 3 octets from the call reference, dropping the MSB.

Includes code by Vadim Yanitskiy 

Change-Id: I9c33a89c819e8925d89ca833d7705ed5ced6b566
---
M src/libmsc/transaction.c
1 file changed, 10 insertions(+), 4 deletions(-)



  git pull ssh://gerrit.osmocom.org:29418/osmo-msc refs/changes/31/31131/1

diff --git a/src/libmsc/transaction.c b/src/libmsc/transaction.c
index 25c0e3c..34adce3 100644
--- a/src/libmsc/transaction.c
+++ b/src/libmsc/transaction.c
@@ -153,11 +153,17 @@
/* net id from Q.1902.3 3-5 bytes, this function gives 3 bytes exactly 
*/
osmo_plmn_to_bcd(lcls->gcr.net, >net->plmn);

-   osmo_store32be(trans->callref, lcls->gcr.cr);
-   osmo_store16be(use_lac ? trans->msc_a->via_cell.lai.lac : 
trans->msc_a->via_cell.cell_identity, lcls->gcr.cr + 3);

-   LOGP(DCC, LOGL_INFO, "LCLS: allocated %s-based CR-ID %s\n", use_lac ? 
"LAC" : "CI",
-osmo_hexdump(lcls->gcr.cr, 5));
+   /* TS 29.205 Table B.2.1.9.2 Call Reference ID
+* 3 octets Call ID + 2 octets BSS ID
+*/
+   lcls->gcr.cr[2] = (trans->callref >>  0) & 0xff;
+   lcls->gcr.cr[1] = (trans->callref >>  8) & 0xff;
+   lcls->gcr.cr[0] = (trans->callref >> 16) & 0xff;
+   osmo_store16be(use_lac ? trans->msc_a->via_cell.lai.lac : 
trans->msc_a->via_cell.cell_identity, >gcr.cr[3]);
+
+   LOGP(DCC, LOGL_INFO, "LCLS: allocated %s-based CR-ID %sfor callref 
0x%x\n", use_lac ? "LAC" : "CI",
+osmo_hexdump(lcls->gcr.cr, 5), trans->callref);

lcls->config = GSM0808_LCLS_CFG_BOTH_WAY;
lcls->control = GSM0808_LCLS_CSC_CONNECT;

--
To view, visit https://gerrit.osmocom.org/c/osmo-msc/+/31131
To unsubscribe, or for help writing mail filters, visit 
https://gerrit.osmocom.org/settings

Gerrit-Project: osmo-msc
Gerrit-Branch: master
Gerrit-Change-Id: I9c33a89c819e8925d89ca833d7705ed5ced6b566
Gerrit-Change-Number: 31131
Gerrit-PatchSet: 1
Gerrit-Owner: keith 
Gerrit-MessageType: newchange

Change in osmo-msc[master]: After RX of an SMPP Submit, send the SMS we just received.

[keith]

Attention is currently required from: neels, laforge.
keith has posted comments on this change. ( 
https://gerrit.osmocom.org/c/osmo-msc/+/28342 )

Change subject: After RX of an SMPP Submit, send the SMS we just received.
..


Patch Set 2:

(1 comment)

Patchset:

PS2:
> Out of many things I could understand I may have miscommunicated, I can't see 
> how I have suggested t […]
Uh.. reading this entire thread.. I've ended up write essays on gerrit recently 


I realise there's an incongruency. To be clear:

I do think it is better to try to deliver the SMS on receipt, that is to say: 
add it to the in memory "sms-queue", rather than just drop it into the database 
and wait/hope for the database getter to load it into the in-memory sms-queue.

The reason why I mentioned above that something "makes these patches 
unnecessary" is two-fold:
1) complete removal of sms-queue from osmo-msc. - much talked about at times, 
but I'm not holding my breath for it.
2) removal of the sqlite based storage which allows a more aggressive storage 
to in-memory queue getter, which somewhat mitigates the problem.



--
To view, visit https://gerrit.osmocom.org/c/osmo-msc/+/28342
To unsubscribe, or for help writing mail filters, visit 
https://gerrit.osmocom.org/settings

Gerrit-Project: osmo-msc
Gerrit-Branch: master
Gerrit-Change-Id: I9af51ef0d9c2e6c5acc5128efd6195df881b680c
Gerrit-Change-Number: 28342
Gerrit-PatchSet: 2
Gerrit-Owner: keith 
Gerrit-Reviewer: Jenkins Builder
Gerrit-CC: laforge 
Gerrit-CC: neels 
Gerrit-Attention: neels 
Gerrit-Attention: laforge 
Gerrit-Comment-Date: Mon, 30 Jan 2023 18:38:21 +
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: neels 
Comment-In-Reply-To: laforge 
Comment-In-Reply-To: keith 
Gerrit-MessageType: comment

Change in osmo-msc[master]: After RX of an SMPP Submit, send the SMS we just received.

[keith]

Attention is currently required from: neels, laforge.
keith has posted comments on this change. ( 
https://gerrit.osmocom.org/c/osmo-msc/+/28342 )

Change subject: After RX of an SMPP Submit, send the SMS we just received.
..


Patch Set 2:

(2 comments)

Patchset:

PS2:
> if this patch helps you in production setups, and it has been tested/verified 
> there, please rebase a […]
Out of many things I could understand I may have miscommunicated, I can't see 
how I have suggested that it "hardly matters". I think that delivering a sent 
SMS as soon as possible is rather important. I think I explained why this isn't 
happening. It's also been observed at the congress event.


PS2:
> if this patch helps you in production setups, and it has been tested/verified 
> there, please rebase a […]
This patch is actually part of a larger patch set that I am currently running 
in production setup. Some of the other patches had been submitted here, 
including
https://gerrit.osmocom.org/c/osmo-msc/+/28338/1 which was abandoned due to your 
valid comment there: "... It creates a merge nightmare for all of my work on a 
SQL-less SMS storage backend... "

The patch set that I am running, is not experiencing the bizarre, up to some 
minutes of duration stalls that we observed last year related to sqlite driver? 
or disk access/locking? or who knows what?  - I remember well that after 
valiant attempts to figure out what was going on, the conclusion was something 
like: I don't care (anymore) what sqlite is doing, let's simply remove it, 
hence your sprint to implement file based storage for the SMS queue..

I do not know which patch(es) is/are avoiding the lockups, but I have a feeling 
it has to do with all or some of:
1) not rapidly doing UPDATE followed by DELETE operations.
2) implementing a timer to prevent successive queue runs (possibly giving the 
sqlite/disk IO or I don't know what a chance to "catch up"?

My hypothesis is that current master osmo-msc continues to suffer from this 
stalling problem and I think it will be observed if there is significant SMS 
traffic, at for example a CCC event. Therefore, I don't see much point in 
submitting this patch alone. - This patch simply addresses an issue that I 
noticed while doing a pretty intense analysis of the SMS queue. This issue 
would be relevant regardless of the actual storage backend, if the queue is 
large enough.

A possibility for me at this point is: rebase and resumbit all the patches 
relevant to sqlite based SMS-Q and rebase laforge/nosql on top of that work. I 
don't know how complicated that might be, but it could be a solution to not 
creating that work for somebody else by merging the sqlite work to master.

At the same time, I'm not necessarily happy with the sqlite work as I don't 
know EXACTLY why it alleviates the problem and I have -ENOTEXIST desire to push 
patches that I do not understand through CR, or to create more pending patches 
that sit like this one for six months.

Maybe worth also saying that dropping sqlite and switching to file based SMS 
storage also creates a work load for me in that I have to adapt code that I run 
to deal with that. Mostly, the routine that checks for SMS sitting in local 
queue for a destination that is currently attached to another VLR, 
(distributed-GSM-SMSQ if you like) But it's probably as simple as changing the 
db access routines to file access routines.



--
To view, visit https://gerrit.osmocom.org/c/osmo-msc/+/28342
To unsubscribe, or for help writing mail filters, visit 
https://gerrit.osmocom.org/settings

Gerrit-Project: osmo-msc
Gerrit-Branch: master
Gerrit-Change-Id: I9af51ef0d9c2e6c5acc5128efd6195df881b680c
Gerrit-Change-Number: 28342
Gerrit-PatchSet: 2
Gerrit-Owner: keith 
Gerrit-Reviewer: Jenkins Builder
Gerrit-CC: laforge 
Gerrit-CC: neels 
Gerrit-Attention: neels 
Gerrit-Attention: laforge 
Gerrit-Comment-Date: Mon, 30 Jan 2023 18:29:29 +
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: neels 
Comment-In-Reply-To: laforge 
Comment-In-Reply-To: keith 
Gerrit-MessageType: comment

Change in osmo-hlr[master]: Add vty `reject-cause` to set the reject cause

[keith]

Attention is currently required from: neels, pespin, daniel, lynxis lazus.
keith has posted comments on this change. ( 
https://gerrit.osmocom.org/c/osmo-hlr/+/16808 )

Change subject: Add vty `reject-cause` to set the reject cause
..


Patch Set 11:

(1 comment)

Patchset:

PS11:
> Hi, […]
I created a feature request https://osmocom.org/issues/5865

It's not that I don't think this issue could be refined, but I don't think this 
patch does anything badly, per se, and can be built upon if anyway wants 
further functionality. So merging.



--
To view, visit https://gerrit.osmocom.org/c/osmo-hlr/+/16808
To unsubscribe, or for help writing mail filters, visit 
https://gerrit.osmocom.org/settings

Gerrit-Project: osmo-hlr
Gerrit-Branch: master
Gerrit-Change-Id: Icea39020c23fbbea9e92847df76af8986fdbf48a
Gerrit-Change-Number: 16808
Gerrit-PatchSet: 11
Gerrit-Owner: lynxis lazus 
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: daniel 
Gerrit-Reviewer: fixeria 
Gerrit-Reviewer: laforge 
Gerrit-Reviewer: lynxis lazus 
Gerrit-Reviewer: neels 
Gerrit-CC: keith 
Gerrit-CC: pespin 
Gerrit-Attention: neels 
Gerrit-Attention: pespin 
Gerrit-Attention: daniel 
Gerrit-Attention: lynxis lazus 
Gerrit-Comment-Date: Fri, 20 Jan 2023 14:02:50 +
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: pespin 
Comment-In-Reply-To: keith 
Comment-In-Reply-To: lynxis lazus 
Gerrit-MessageType: comment

Change in osmo-hlr[master]: Add vty `reject-cause` to set the reject cause

[keith]

keith has submitted this change. ( 
https://gerrit.osmocom.org/c/osmo-hlr/+/16808 )

Change subject: Add vty `reject-cause` to set the reject cause
..

Add vty `reject-cause` to set the reject cause

Allow to set the LU reject cause independently for both of the
following cases; either when an IMSI is unknown to the HLR or
when the mslookup client does not a receive a timely response
to a GSUP request for the remote home HLR.

Original patchset modified by 

Change-Id: Icea39020c23fbbea9e92847df76af8986fdbf48a
---
M include/osmocom/hlr/hlr.h
M include/osmocom/hlr/hlr_vty.h
M src/hlr.c
M src/hlr_vty.c
M src/lu_fsm.c
M src/proxy.c
M tests/test_nodes.vty
7 files changed, 98 insertions(+), 6 deletions(-)

Approvals:
  laforge: Looks good to me, but someone else must approve
  fixeria: Looks good to me, approved
  Jenkins Builder: Verified



diff --git a/include/osmocom/hlr/hlr.h b/include/osmocom/hlr/hlr.h
index 3acb3c5..b27fb3d 100644
--- a/include/osmocom/hlr/hlr.h
+++ b/include/osmocom/hlr/hlr.h
@@ -23,6 +23,7 @@
 #pragma once

 #include 
+#include 
 #include 
 #include 
 #include 
@@ -55,6 +56,8 @@

struct llist_head euse_list;
struct hlr_euse *euse_default;
+   enum gsm48_gmm_cause reject_cause;
+   enum gsm48_gmm_cause no_proxy_reject_cause;

/* NCSS (call independent) session guard timeout value */
int ncss_guard_timeout;
diff --git a/include/osmocom/hlr/hlr_vty.h b/include/osmocom/hlr/hlr_vty.h
index 10eddc3..83691b8 100644
--- a/include/osmocom/hlr/hlr_vty.h
+++ b/include/osmocom/hlr/hlr_vty.h
@@ -45,5 +45,5 @@

 int hlr_vty_is_config_node(struct vty *vty, int node);
 int hlr_vty_go_parent(struct vty *vty);
-void hlr_vty_init(void);
+void hlr_vty_init(void *hlr_ctx);
 void dgsm_vty_init(void);
diff --git a/src/hlr.c b/src/hlr.c
index c6ae4fc..8183d9b 100644
--- a/src/hlr.c
+++ b/src/hlr.c
@@ -324,7 +324,7 @@
  " Returning slightly 
inaccurate cause 'IMSI Unknown' via GSUP");
return rc;
case -ENOENT:
-   osmo_gsup_req_respond_err(req, GMM_CAUSE_IMSI_UNKNOWN, 
"IMSI unknown");
+   osmo_gsup_req_respond_err(req, g_hlr->reject_cause, 
"IMSI unknown");
return rc;
default:
osmo_gsup_req_respond_err(req, GMM_CAUSE_NET_FAIL, 
"failure to look up IMSI in db");
@@ -759,6 +759,8 @@
g_hlr->db_file_path = talloc_strdup(g_hlr, HLR_DEFAULT_DB_FILE_PATH);
g_hlr->mslookup.server.mdns.domain_suffix = talloc_strdup(g_hlr, 
OSMO_MDNS_DOMAIN_SUFFIX_DEFAULT);
g_hlr->mslookup.client.mdns.domain_suffix = talloc_strdup(g_hlr, 
OSMO_MDNS_DOMAIN_SUFFIX_DEFAULT);
+   g_hlr->reject_cause = GMM_CAUSE_IMSI_UNKNOWN;
+   g_hlr->no_proxy_reject_cause = GMM_CAUSE_IMSI_UNKNOWN;

/* Init default (call independent) SS session guard timeout value */
g_hlr->ncss_guard_timeout = NCSS_GUARD_TIMEOUT_DEFAULT;
@@ -775,7 +777,7 @@
osmo_stats_init(hlr_ctx);
vty_init(_info);
ctrl_vty_init(hlr_ctx);
-   hlr_vty_init();
+   hlr_vty_init(hlr_ctx);
dgsm_vty_init();
osmo_cpu_sched_vty_init(hlr_ctx);
handle_options(argc, argv);
diff --git a/src/hlr_vty.c b/src/hlr_vty.c
index a440c42..02e0cde 100644
--- a/src/hlr_vty.c
+++ b/src/hlr_vty.c
@@ -25,7 +25,10 @@
  *
  */

+#include 
+
 #include 
+#include 
 #include 
 #include 
 #include 
@@ -40,6 +43,36 @@
 #include 
 #include 

+static const struct value_string gsm48_gmm_cause_vty_names[] = {
+   { GMM_CAUSE_IMSI_UNKNOWN,   "imsi-unknown" },
+   { GMM_CAUSE_ILLEGAL_MS, "illegal-ms" },
+   { GMM_CAUSE_PLMN_NOTALLOWED,"plmn-not-allowed" },
+   { GMM_CAUSE_LA_NOTALLOWED,  "la-not-allowed" },
+   { GMM_CAUSE_ROAMING_NOTALLOWED, "roaming-not-allowed" },
+   { GMM_CAUSE_NO_SUIT_CELL_IN_LA, "no-suitable-cell-in-la" },
+   { GMM_CAUSE_NET_FAIL,   "net-fail" },
+   { GMM_CAUSE_CONGESTION, "congestion" },
+   { GMM_CAUSE_GSM_AUTH_UNACCEPT,  "auth-unacceptable" },
+   { GMM_CAUSE_PROTO_ERR_UNSPEC,   "proto-error-unspec" },
+   { 0, NULL },
+};
+
+/* TS 24.008 4.4.4.7 */
+static const struct value_string gsm48_gmm_cause_vty_descs[] = {
+   { GMM_CAUSE_IMSI_UNKNOWN,   " #02: (IMSI unknown in HLR)" },
+   { GMM_CAUSE_ILLEGAL_MS, " #03  (Illegal MS)" },
+   { GMM_CAUSE_PLMN_NOTALLOWED," #11: (PLMN not allowed)" },
+   { GMM_CAUSE_LA_NOTALLOWED,  " #12: (Location Area not allowed)" },
+   { GMM_CAUSE_ROAMING_NOTALLOWED, " #13: (Roaming not allowed in this 
location area)" },
+   { GMM_CAUSE

Change in osmo-hlr[master]: Add vty `reject-cause` to set the reject cause

[keith]

Attention is currently required from: neels, pespin, daniel, lynxis lazus.
keith has posted comments on this change. ( 
https://gerrit.osmocom.org/c/osmo-hlr/+/16808 )

Change subject: Add vty `reject-cause` to set the reject cause
..


Patch Set 11:

(1 comment)

Patchset:

PS11:
> This also would not be the first time that a feature that is entirely (even 
> it it were so) investiga […]
*from the spec what the intention is, AND HOW the MS behaviour...



--
To view, visit https://gerrit.osmocom.org/c/osmo-hlr/+/16808
To unsubscribe, or for help writing mail filters, visit 
https://gerrit.osmocom.org/settings

Gerrit-Project: osmo-hlr
Gerrit-Branch: master
Gerrit-Change-Id: Icea39020c23fbbea9e92847df76af8986fdbf48a
Gerrit-Change-Number: 16808
Gerrit-PatchSet: 11
Gerrit-Owner: lynxis lazus 
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: daniel 
Gerrit-Reviewer: fixeria 
Gerrit-Reviewer: laforge 
Gerrit-Reviewer: lynxis lazus 
Gerrit-Reviewer: neels 
Gerrit-CC: keith 
Gerrit-CC: pespin 
Gerrit-Attention: neels 
Gerrit-Attention: pespin 
Gerrit-Attention: daniel 
Gerrit-Attention: lynxis lazus 
Gerrit-Comment-Date: Thu, 19 Jan 2023 16:54:41 +
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: pespin 
Comment-In-Reply-To: keith 
Gerrit-MessageType: comment

Change in osmo-hlr[master]: Add vty `reject-cause` to set the reject cause

[keith]

Attention is currently required from: neels, pespin, daniel, lynxis lazus.
keith has posted comments on this change. ( 
https://gerrit.osmocom.org/c/osmo-hlr/+/16808 )

Change subject: Add vty `reject-cause` to set the reject cause
..


Patch Set 11:

(1 comment)

Patchset:

PS11:
> and I'm not against keeping the functionality clean, and I'm all for 
> questioning the need for patche […]
This also would not be the first time that a feature that is entirely (even it 
it were so) investigation/testing based was included in mainstream osmo

I wonder what does a commercial HLR look like, I mean there are quite some LU 
reject causes. osmo-hlr uses ONE of them, hard coded. Maybe it's one of those 
things in the spec where options kept getting added, but really there's only 
one or two in use. Probably not the HLRs decision anyway?
When would an operator decide between #12 and #15 for example? For me it's 
quite hard to see form the spec what the intention is as to have the MS 
behaviour differs between them.

The difference between "forbidden location areas for regional provision of 
service" and "forbidden location areas for roaming" seems subtle, as does the 
difference between "shall perform a cell selection" and "shall search for a 
suitable cell in another location area" - given that the LAI was added to the 
forbidden list.

Maybe #15 is never intended for use when a SIM attempts to connect to it's HOME 
network. I guess that kind of thing could be automatic in the code;

Is the IMSI "ours"? -> then #12 else #15



--
To view, visit https://gerrit.osmocom.org/c/osmo-hlr/+/16808
To unsubscribe, or for help writing mail filters, visit 
https://gerrit.osmocom.org/settings

Gerrit-Project: osmo-hlr
Gerrit-Branch: master
Gerrit-Change-Id: Icea39020c23fbbea9e92847df76af8986fdbf48a
Gerrit-Change-Number: 16808
Gerrit-PatchSet: 11
Gerrit-Owner: lynxis lazus 
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: daniel 
Gerrit-Reviewer: fixeria 
Gerrit-Reviewer: laforge 
Gerrit-Reviewer: lynxis lazus 
Gerrit-Reviewer: neels 
Gerrit-CC: keith 
Gerrit-CC: pespin 
Gerrit-Attention: neels 
Gerrit-Attention: pespin 
Gerrit-Attention: daniel 
Gerrit-Attention: lynxis lazus 
Gerrit-Comment-Date: Thu, 19 Jan 2023 16:52:46 +
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: pespin 
Comment-In-Reply-To: keith 
Gerrit-MessageType: comment

Change in osmo-hlr[master]: Add vty `reject-cause` to set the reject cause

[keith]

Attention is currently required from: neels, pespin, daniel, lynxis lazus.
keith has posted comments on this change. ( 
https://gerrit.osmocom.org/c/osmo-hlr/+/16808 )

Change subject: Add vty `reject-cause` to set the reject cause
..


Patch Set 11:

(1 comment)

Patchset:

PS11:
> I'm not against merging this patch, but I'm raising the topic since we seem 
> to merging a feature whi […]
and I'm not against keeping the functionality clean, and I'm all for 
questioning the need for patches and for hearing more voices on it.

That said, I'm stumped to know how the code would automatically know on which 
site the operator would like to reject [not found at this time in dGSM] IMSIs 
with CONGESTION and on which sites with "ROAMING NOT ALLOWED".

Maybe if I include libosmo-chatgpt.h
;-)

Also, I don't see that this patch, or any other for that matter, that does not 
change default behaviour, but rather adds an OPTIONAL vty param that the user 
is free to ignore, creates a need for the user to configure it.

I am now more curious about what lynxis' motivation at 36c3 was. I sort of 
remember something about it.



--
To view, visit https://gerrit.osmocom.org/c/osmo-hlr/+/16808
To unsubscribe, or for help writing mail filters, visit 
https://gerrit.osmocom.org/settings

Gerrit-Project: osmo-hlr
Gerrit-Branch: master
Gerrit-Change-Id: Icea39020c23fbbea9e92847df76af8986fdbf48a
Gerrit-Change-Number: 16808
Gerrit-PatchSet: 11
Gerrit-Owner: lynxis lazus 
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: daniel 
Gerrit-Reviewer: fixeria 
Gerrit-Reviewer: laforge 
Gerrit-Reviewer: lynxis lazus 
Gerrit-Reviewer: neels 
Gerrit-CC: keith 
Gerrit-CC: pespin 
Gerrit-Attention: neels 
Gerrit-Attention: pespin 
Gerrit-Attention: daniel 
Gerrit-Attention: lynxis lazus 
Gerrit-Comment-Date: Thu, 19 Jan 2023 16:31:42 +
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: pespin 
Gerrit-MessageType: comment

Change in osmo-hlr[master]: Add vty `reject-cause` to set the reject cause

[keith]

Attention is currently required from: pespin, lynxis lazus.
keith has posted comments on this change. ( 
https://gerrit.osmocom.org/c/osmo-hlr/+/16808 )

Change subject: Add vty `reject-cause` to set the reject cause
..


Patch Set 11:

(1 comment)

Patchset:

PS11:
> Hi @keith, maybe what I'm missing here is the rationale on WHY is this 
> needed. […]
Hi @pespin.
I my case, I was interested to see how the phones were actually behaving with 
the different LU Reject reasons. It seems like they don't really behave as in 
the spec. (TS24.008 4.4.4.7)

I got bored of recompiling osmo-msc with hard coded reject causes and then I 
noticed this patch in CR from @lynxis.

Given the patch originally almost made it through CR, and it seems like it was 
something that lynxis wanted at a c3 event for whatever reason, I decided to 
fix it up and submit a patchset. It might be interesting to know if lynxis 
remembers or still has any interest.

>From my point of view, there is one use case where I might want to configure 
>the LU reject cause at runtime, which has to do with dGSM.

If I reject an MS because no HLR responds to a distributed request for a home 
HLR; this may have happened because, 1) there is no home HLR or 2) the home HLR 
was offline/unreachable at the moment of the LUR.

In the first case, I guess I would like the phone to go away and never LUR 
again, (at least until T3245 expires), in the second case, I might like it to 
try again rather soon. Now, as I said, accord the the spec i mentioned above, 
if I were to send a cause @2 "IMSI unknown in HLR" - which is the current 
default, I would expect: "The mobile station shall set the update status to 
ROAMING NOT ALLOWED (and store it in the SIM/USIM and delete any TMSI, stored 
LAI [etc]
consider the SIM/USIM as invalid for non-GPRS services until switch-off or the 
SIM/USIM is removed or the timer T3245 expires as described in subclause 
4.1.1.6."

Howver, All the ME I tried DON'T do this, but rather they try again every 20 
seconds up to 8 times and then continuously on what seems like the T3212 timer. 
However, with cause #13 the ME seems to NOT retry in the cell again, at least 
not immediately. Anyway, seems like one might like to do some trial and error 
with one's own situation in this and therefore being able to configure this via 
the vty might be "handy" (sorry for unintended bad pun, German speakers)

We have some sites that don't have many phones trying to connect, we also have 
some that have 1000s, so on the busy site, I might prefer to set a cuase then 
makes them back off, at the expense of loosing the odd "orphan" "roaming" user 
(until they power cycles/toggle airplane mode) - whereas on the not busy site, 
I might set a reject cause like CONGESTION that allows that phone to keep 
trying in the hope their home HLR came back online.

@pespin, if you'ld like any of the above in the commit msg for this patchset, 
please feel free to copy and paste, I also have a series of commits related to 
dGSM in the works, including documentation update, so I can include some of the 
above text there also.



--
To view, visit https://gerrit.osmocom.org/c/osmo-hlr/+/16808
To unsubscribe, or for help writing mail filters, visit 
https://gerrit.osmocom.org/settings

Gerrit-Project: osmo-hlr
Gerrit-Branch: master
Gerrit-Change-Id: Icea39020c23fbbea9e92847df76af8986fdbf48a
Gerrit-Change-Number: 16808
Gerrit-PatchSet: 11
Gerrit-Owner: lynxis lazus 
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: fixeria 
Gerrit-Reviewer: laforge 
Gerrit-Reviewer: lynxis lazus 
Gerrit-CC: keith 
Gerrit-CC: pespin 
Gerrit-Attention: pespin 
Gerrit-Attention: lynxis lazus 
Gerrit-Comment-Date: Wed, 18 Jan 2023 20:48:32 +
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: pespin 
Gerrit-MessageType: comment

Change in osmo-hlr[master]: fix memleak of proxy_subscr_listentry

[keith]

Attention is currently required from: neels.
keith has posted comments on this change. ( 
https://gerrit.osmocom.org/c/osmo-hlr/+/30981 )

Change subject: fix memleak of proxy_subscr_listentry
..


Patch Set 1: Code-Review+1


--
To view, visit https://gerrit.osmocom.org/c/osmo-hlr/+/30981
To unsubscribe, or for help writing mail filters, visit 
https://gerrit.osmocom.org/settings

Gerrit-Project: osmo-hlr
Gerrit-Branch: master
Gerrit-Change-Id: Ic1ec4911fa5ae91cc75aa865c8201edd83af41ed
Gerrit-Change-Number: 30981
Gerrit-PatchSet: 1
Gerrit-Owner: neels 
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: keith 
Gerrit-Attention: neels 
Gerrit-Comment-Date: Mon, 16 Jan 2023 05:06:01 +
Gerrit-HasComments: No
Gerrit-Has-Labels: Yes
Gerrit-MessageType: comment

Change in osmo-hlr[master]: Add vty `reject-cause` to set the reject cause

[keith]

Attention is currently required from: fixeria, lynxis lazus.
keith has posted comments on this change. ( 
https://gerrit.osmocom.org/c/osmo-hlr/+/16808 )

Change subject: Add vty `reject-cause` to set the reject cause
..


Patch Set 11:

(1 comment)

File src/hlr_vty.c:

https://gerrit.osmocom.org/c/osmo-hlr/+/16808/comment/43a98a45_ea580d86
PS4, Line 88: imsi_cause_code
> It seems to be a common practice in Osmocom to not print parameters with 
> default values. […]
Done



--
To view, visit https://gerrit.osmocom.org/c/osmo-hlr/+/16808
To unsubscribe, or for help writing mail filters, visit 
https://gerrit.osmocom.org/settings

Gerrit-Project: osmo-hlr
Gerrit-Branch: master
Gerrit-Change-Id: Icea39020c23fbbea9e92847df76af8986fdbf48a
Gerrit-Change-Number: 16808
Gerrit-PatchSet: 11
Gerrit-Owner: lynxis lazus 
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: fixeria 
Gerrit-Reviewer: laforge 
Gerrit-Reviewer: lynxis lazus 
Gerrit-CC: keith 
Gerrit-CC: pespin 
Gerrit-Attention: fixeria 
Gerrit-Attention: lynxis lazus 
Gerrit-Comment-Date: Thu, 12 Jan 2023 22:05:29 +
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: fixeria 
Comment-In-Reply-To: lynxis lazus 
Gerrit-MessageType: comment

Change in osmo-hlr[master]: Add vty `reject-cause` to set the reject cause

[keith]

Attention is currently required from: keith, lynxis lazus.
keith has uploaded a new patch set (#10) to the change originally created by 
lynxis lazus. ( https://gerrit.osmocom.org/c/osmo-hlr/+/16808 )

Change subject: Add vty `reject-cause` to set the reject cause
..

Add vty `reject-cause` to set the reject cause

Allow to set the LU reject cause independently for both of the
following cases; either when an IMSI is unknown to the HLR or
when the mslookup client does not a receive a timely response
to a GSUP request for the remote home HLR.

Original patchset modified by 

Change-Id: Icea39020c23fbbea9e92847df76af8986fdbf48a
---
M include/osmocom/hlr/hlr.h
M include/osmocom/hlr/hlr_vty.h
M src/hlr.c
M src/hlr_vty.c
M src/lu_fsm.c
M src/proxy.c
M tests/test_nodes.vty
7 files changed, 98 insertions(+), 6 deletions(-)


  git pull ssh://gerrit.osmocom.org:29418/osmo-hlr refs/changes/08/16808/10
--
To view, visit https://gerrit.osmocom.org/c/osmo-hlr/+/16808
To unsubscribe, or for help writing mail filters, visit 
https://gerrit.osmocom.org/settings

Gerrit-Project: osmo-hlr
Gerrit-Branch: master
Gerrit-Change-Id: Icea39020c23fbbea9e92847df76af8986fdbf48a
Gerrit-Change-Number: 16808
Gerrit-PatchSet: 10
Gerrit-Owner: lynxis lazus 
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: fixeria 
Gerrit-Reviewer: laforge 
Gerrit-Reviewer: lynxis lazus 
Gerrit-CC: pespin 
Gerrit-Attention: keith 
Gerrit-Attention: lynxis lazus 
Gerrit-MessageType: newpatchset

Change in osmo-hlr[master]: Add vty `reject-cause` to set the reject cause

[keith]

Attention is currently required from: keith, lynxis lazus.
keith has uploaded a new patch set (#9) to the change originally created by 
lynxis lazus. ( https://gerrit.osmocom.org/c/osmo-hlr/+/16808 )

Change subject: Add vty `reject-cause` to set the reject cause
..

Add vty `reject-cause` to set the reject cause

Allow to set the reject cause when an IMSI is unknown to the HLR.
Most common on reject causes are GMM_CAUSE_IMSI_UNKNOWN (2) or
CAUSE_ROAMING_NOTALLOWED (11).

Change-Id: Icea39020c23fbbea9e92847df76af8986fdbf48a
---
M include/osmocom/hlr/hlr.h
M include/osmocom/hlr/hlr_vty.h
M src/hlr.c
M src/hlr_vty.c
M src/lu_fsm.c
M src/proxy.c
M tests/test_nodes.vty
7 files changed, 98 insertions(+), 6 deletions(-)


  git pull ssh://gerrit.osmocom.org:29418/osmo-hlr refs/changes/08/16808/9
--
To view, visit https://gerrit.osmocom.org/c/osmo-hlr/+/16808
To unsubscribe, or for help writing mail filters, visit 
https://gerrit.osmocom.org/settings

Gerrit-Project: osmo-hlr
Gerrit-Branch: master
Gerrit-Change-Id: Icea39020c23fbbea9e92847df76af8986fdbf48a
Gerrit-Change-Number: 16808
Gerrit-PatchSet: 9
Gerrit-Owner: lynxis lazus 
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: fixeria 
Gerrit-Reviewer: laforge 
Gerrit-Reviewer: lynxis lazus 
Gerrit-CC: pespin 
Gerrit-Attention: keith 
Gerrit-Attention: lynxis lazus 
Gerrit-MessageType: newpatchset

Change in osmo-hlr[master]: Add vty `reject-cause` to set the reject cause

[keith]

Attention is currently required from: keith, lynxis lazus.
keith has uploaded a new patch set (#8) to the change originally created by 
lynxis lazus. ( https://gerrit.osmocom.org/c/osmo-hlr/+/16808 )

Change subject: Add vty `reject-cause` to set the reject cause
..

Add vty `reject-cause` to set the reject cause

Allow to set the reject cause when an IMSI is unknown to the HLR.
Most common on reject causes are GMM_CAUSE_IMSI_UNKNOWN (2) or
CAUSE_ROAMING_NOTALLOWED (11).

Change-Id: Icea39020c23fbbea9e92847df76af8986fdbf48a
---
M include/osmocom/hlr/hlr.h
M include/osmocom/hlr/hlr_vty.h
M src/hlr.c
M src/hlr_vty.c
M tests/test_nodes.vty
5 files changed, 87 insertions(+), 4 deletions(-)


  git pull ssh://gerrit.osmocom.org:29418/osmo-hlr refs/changes/08/16808/8
--
To view, visit https://gerrit.osmocom.org/c/osmo-hlr/+/16808
To unsubscribe, or for help writing mail filters, visit 
https://gerrit.osmocom.org/settings

Gerrit-Project: osmo-hlr
Gerrit-Branch: master
Gerrit-Change-Id: Icea39020c23fbbea9e92847df76af8986fdbf48a
Gerrit-Change-Number: 16808
Gerrit-PatchSet: 8
Gerrit-Owner: lynxis lazus 
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: fixeria 
Gerrit-Reviewer: laforge 
Gerrit-Reviewer: lynxis lazus 
Gerrit-CC: pespin 
Gerrit-Attention: keith 
Gerrit-Attention: lynxis lazus 
Gerrit-MessageType: newpatchset

Change in osmo-hlr[master]: Add vty `reject-cause` to set the reject cause

[keith]

Attention is currently required from: lynxis lazus.
keith has uploaded a new patch set (#7) to the change originally created by 
lynxis lazus. ( https://gerrit.osmocom.org/c/osmo-hlr/+/16808 )

Change subject: Add vty `reject-cause` to set the reject cause
..

Add vty `reject-cause` to set the reject cause

Allow to set the reject cause when an IMSI is unknown to the HLR.
Most common on reject causes are GMM_CAUSE_IMSI_UNKNOWN (2) or
CAUSE_ROAMING_NOTALLOWED (11).

Change-Id: Icea39020c23fbbea9e92847df76af8986fdbf48a
---
M include/osmocom/hlr/hlr.h
M src/hlr.c
M src/hlr_vty.c
M tests/test_nodes.vty
4 files changed, 75 insertions(+), 2 deletions(-)


  git pull ssh://gerrit.osmocom.org:29418/osmo-hlr refs/changes/08/16808/7
--
To view, visit https://gerrit.osmocom.org/c/osmo-hlr/+/16808
To unsubscribe, or for help writing mail filters, visit 
https://gerrit.osmocom.org/settings

Gerrit-Project: osmo-hlr
Gerrit-Branch: master
Gerrit-Change-Id: Icea39020c23fbbea9e92847df76af8986fdbf48a
Gerrit-Change-Number: 16808
Gerrit-PatchSet: 7
Gerrit-Owner: lynxis lazus 
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: fixeria 
Gerrit-Reviewer: laforge 
Gerrit-Reviewer: lynxis lazus 
Gerrit-CC: pespin 
Gerrit-Attention: lynxis lazus 
Gerrit-MessageType: newpatchset

Change in osmo-hlr[master]: Vty: Fixup config shown/written from vty

[keith]

Attention is currently required from: neels, keith.
Hello Jenkins Builder, neels,

I'd like you to reexamine a change. Please visit

https://gerrit.osmocom.org/c/osmo-hlr/+/30699

to look at the new patch set (#4).

Change subject: Vty: Fixup config shown/written from vty
..

Vty: Fixup config shown/written from vty

This commit fixes the following errors:
Missing timeout param for mslookup.
Fails to start reading a written config if an msc node
is configured in the mslookup server.
Places the individual msc node services in the
top-level wildcard node due to incorrect indentation.

* Add missing timeout param.
* Add missing "ipa-name" part to mslookup-server-msc section.
* Add one extra space indentation for msc services.

This commit also adds a DEFINE for the default timeout value.

Change-Id: Ibb60e74a0803f05f37ac13ca529d77b4cb736025
---
M include/osmocom/hlr/dgsm.h
M src/dgsm.c
M src/dgsm_vty.c
M tests/test_nodes.vty
4 files changed, 29 insertions(+), 24 deletions(-)


  git pull ssh://gerrit.osmocom.org:29418/osmo-hlr refs/changes/99/30699/4
--
To view, visit https://gerrit.osmocom.org/c/osmo-hlr/+/30699
To unsubscribe, or for help writing mail filters, visit 
https://gerrit.osmocom.org/settings

Gerrit-Project: osmo-hlr
Gerrit-Branch: master
Gerrit-Change-Id: Ibb60e74a0803f05f37ac13ca529d77b4cb736025
Gerrit-Change-Number: 30699
Gerrit-PatchSet: 4
Gerrit-Owner: keith 
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: neels 
Gerrit-CC: pespin 
Gerrit-Attention: neels 
Gerrit-Attention: keith 
Gerrit-MessageType: newpatchset

Change in osmo-hlr[master]: Vty: Fixup config shown/written from vty

[keith]

Attention is currently required from: neels, pespin, keith.
Hello Jenkins Builder, neels,

I'd like you to reexamine a change. Please visit

https://gerrit.osmocom.org/c/osmo-hlr/+/30699

to look at the new patch set (#3).

Change subject: Vty: Fixup config shown/written from vty
..

Vty: Fixup config shown/written from vty

This commit fixes the following errors:
Missing timeout param for mslookup.
Fails to start reading a written config if an msc node
is configured in the mslookup server.
Places the individual msc node services in the
top-level wildcard node due to incorrect indentation.

* Add missing timeout param.
* Add missing "ipa-name" part to mslookup-server-msc section.
* Add one extra space indentation for msc services.

This commit also adds a DEFINE for the default timeout value.

Change-Id: Ibb60e74a0803f05f37ac13ca529d77b4cb736025
---
M include/osmocom/hlr/dgsm.h
M src/dgsm.c
M src/dgsm_vty.c
M tests/test_nodes.vty
4 files changed, 20 insertions(+), 15 deletions(-)


  git pull ssh://gerrit.osmocom.org:29418/osmo-hlr refs/changes/99/30699/3
--
To view, visit https://gerrit.osmocom.org/c/osmo-hlr/+/30699
To unsubscribe, or for help writing mail filters, visit 
https://gerrit.osmocom.org/settings

Gerrit-Project: osmo-hlr
Gerrit-Branch: master
Gerrit-Change-Id: Ibb60e74a0803f05f37ac13ca529d77b4cb736025
Gerrit-Change-Number: 30699
Gerrit-PatchSet: 3
Gerrit-Owner: keith 
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: neels 
Gerrit-CC: pespin 
Gerrit-Attention: neels 
Gerrit-Attention: pespin 
Gerrit-Attention: keith 
Gerrit-MessageType: newpatchset

Change in osmo-hlr[master]: Vty: Fixup config shown/written from vty

[keith]

Attention is currently required from: pespin.
Hello Jenkins Builder,

I'd like you to reexamine a change. Please visit

https://gerrit.osmocom.org/c/osmo-hlr/+/30699

to look at the new patch set (#2).

Change subject: Vty: Fixup config shown/written from vty
..

Vty: Fixup config shown/written from vty

This commit fixes the following errors:
Missing timeout param for mslookup.
Fails to start reading a written config if an msc node
is configured in the mslookup server.
Places the individual msc node services in the
top-level wildcard node due to incorrect indentation.

* Add missing timeout param.
* Add missing "ipa-name" part to mslookup-server-msc section.
* Add one extra space indentation for msc services.

This commit also adds a DEFINE for the default timeout value.

Change-Id: Ibb60e74a0803f05f37ac13ca529d77b4cb736025
---
M include/osmocom/hlr/dgsm.h
M src/dgsm.c
M src/dgsm_vty.c
3 files changed, 8 insertions(+), 3 deletions(-)


  git pull ssh://gerrit.osmocom.org:29418/osmo-hlr refs/changes/99/30699/2
--
To view, visit https://gerrit.osmocom.org/c/osmo-hlr/+/30699
To unsubscribe, or for help writing mail filters, visit 
https://gerrit.osmocom.org/settings

Gerrit-Project: osmo-hlr
Gerrit-Branch: master
Gerrit-Change-Id: Ibb60e74a0803f05f37ac13ca529d77b4cb736025
Gerrit-Change-Number: 30699
Gerrit-PatchSet: 2
Gerrit-Owner: keith 
Gerrit-Reviewer: Jenkins Builder
Gerrit-CC: pespin 
Gerrit-Attention: pespin 
Gerrit-MessageType: newpatchset

Change in osmo-hlr[master]: Vty: Add missing param to config write

[keith]

Attention is currently required from: pespin.
keith has posted comments on this change. ( 
https://gerrit.osmocom.org/c/osmo-hlr/+/30699 )

Change subject: Vty: Add missing param to config write
..


Patch Set 1:

(1 comment)

File src/dgsm_vty.c:

https://gerrit.osmocom.org/c/osmo-hlr/+/30699/comment/ba1285a9_0b4147cc
PS1, Line 479:  vty_out(vty, "  timeout %u%s",
> are you sure you are not missing the "mdns" prefix here?
yes, I'm sure, see below, Do you think the timeout should have this prefix?


DEFUN(cfg_mslookup_client_timeout,
  cfg_mslookup_client_timeout_cmd,
  "timeout <1-10>",

OsmoHLR(config-mslookup-client)#
  help   Description of the interactive help system
  list   Print command list
  show   Show running system information
  write  Write running configuration to memory, network, or terminal
  exit   Exit current mode and down to previous mode
  endEnd current mode and change to enable mode.
  timeoutHow long should the mslookup client wait for remote responses 
before evaluating received results
  mdns   Multicast DNS related configuration
  no Negate a command or set its defaults
  gateway-proxy  Configure a fixed IP address to send all GSUP requests for 
unknown IMSIs to, without invoking a lookup for IMSI



--
To view, visit https://gerrit.osmocom.org/c/osmo-hlr/+/30699
To unsubscribe, or for help writing mail filters, visit 
https://gerrit.osmocom.org/settings

Gerrit-Project: osmo-hlr
Gerrit-Branch: master
Gerrit-Change-Id: Ibb60e74a0803f05f37ac13ca529d77b4cb736025
Gerrit-Change-Number: 30699
Gerrit-PatchSet: 1
Gerrit-Owner: keith 
Gerrit-Reviewer: Jenkins Builder
Gerrit-CC: pespin 
Gerrit-Attention: pespin 
Gerrit-Comment-Date: Mon, 19 Dec 2022 19:06:41 +
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: pespin 
Gerrit-MessageType: comment

Change in osmo-hlr[master]: Vty: Add missing param to config write

[keith]

keith has uploaded this change for review. ( 
https://gerrit.osmocom.org/c/osmo-hlr/+/30699 )


Change subject: Vty: Add missing param to config write
..

Vty: Add missing param to config write

The mslookup client timeout parameter was not being written back
to the config.

This commit also add a define for the default timeout value.

Change-Id: Ibb60e74a0803f05f37ac13ca529d77b4cb736025
---
M include/osmocom/hlr/dgsm.h
M src/dgsm.c
M src/dgsm_vty.c
3 files changed, 6 insertions(+), 1 deletion(-)



  git pull ssh://gerrit.osmocom.org:29418/osmo-hlr refs/changes/99/30699/1

diff --git a/include/osmocom/hlr/dgsm.h b/include/osmocom/hlr/dgsm.h
index cc8f3d2..1114fbe 100644
--- a/include/osmocom/hlr/dgsm.h
+++ b/include/osmocom/hlr/dgsm.h
@@ -25,6 +25,7 @@
 #include 
 #include 

+#define OSMO_DGSM_DEFAULT_RESULT_TIMEOUT_MS2000
 #define LOG_DGSM(imsi, level, fmt, args...) \
LOGP(DDGSM, level, "(IMSI-%s) " fmt, imsi, ##args)

diff --git a/src/dgsm.c b/src/dgsm.c
index cdd82a2..f96bca6 100644
--- a/src/dgsm.c
+++ b/src/dgsm.c
@@ -170,7 +170,7 @@

g_hlr->mslookup.server.local_attach_max_age = 60 * 60;

-   g_hlr->mslookup.client.result_timeout_milliseconds = 2000;
+   g_hlr->mslookup.client.result_timeout_milliseconds = 
OSMO_DGSM_DEFAULT_RESULT_TIMEOUT_MS;

g_hlr->gsup_unit_name.unit_name = "HLR";
g_hlr->gsup_unit_name.serno = "unnamed-HLR";
diff --git a/src/dgsm_vty.c b/src/dgsm_vty.c
index 00a60ea..6598045 100644
--- a/src/dgsm_vty.c
+++ b/src/dgsm_vty.c
@@ -475,6 +475,10 @@
vty_out(vty, "  mdns domain-suffix %s%s",
g_hlr->mslookup.client.mdns.domain_suffix,
VTY_NEWLINE);
+   if (g_hlr->mslookup.client.result_timeout_milliseconds != 
OSMO_DGSM_DEFAULT_RESULT_TIMEOUT_MS)
+   vty_out(vty, "  timeout %u%s",
+   
g_hlr->mslookup.client.result_timeout_milliseconds,
+   VTY_NEWLINE);
}

return CMD_SUCCESS;

--
To view, visit https://gerrit.osmocom.org/c/osmo-hlr/+/30699
To unsubscribe, or for help writing mail filters, visit 
https://gerrit.osmocom.org/settings

Gerrit-Project: osmo-hlr
Gerrit-Branch: master
Gerrit-Change-Id: Ibb60e74a0803f05f37ac13ca529d77b4cb736025
Gerrit-Change-Number: 30699
Gerrit-PatchSet: 1
Gerrit-Owner: keith 
Gerrit-MessageType: newchange

Change in osmo-pcu[master]: gprs_ms: Document functions setting/updating TLLI

[keith]

Attention is currently required from: pespin.
keith has posted comments on this change. ( 
https://gerrit.osmocom.org/c/osmo-pcu/+/29838 )

Change subject: gprs_ms: Document functions setting/updating TLLI
..


Patch Set 1: Code-Review+1


--
To view, visit https://gerrit.osmocom.org/c/osmo-pcu/+/29838
To unsubscribe, or for help writing mail filters, visit 
https://gerrit.osmocom.org/settings

Gerrit-Project: osmo-pcu
Gerrit-Branch: master
Gerrit-Change-Id: Ia440c672a8d2e11169b41f787239bfbba0989231
Gerrit-Change-Number: 29838
Gerrit-PatchSet: 1
Gerrit-Owner: pespin 
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: fixeria 
Gerrit-Reviewer: keith 
Gerrit-Attention: pespin 
Gerrit-Comment-Date: Fri, 21 Oct 2022 19:35:11 +
Gerrit-HasComments: No
Gerrit-Has-Labels: Yes
Gerrit-MessageType: comment

Change in osmo-bts[master]: osmo-bts-trx: respond to tx-attenuation config in real time.

[keith]

keith has submitted this change. ( 
https://gerrit.osmocom.org/c/osmo-bts/+/29649 )

Change subject: osmo-bts-trx: respond to tx-attenuation config in real time.
..

osmo-bts-trx: respond to tx-attenuation config in real time.

Some osmo-bts varieties have a method to make an immediate change to
TX power from the vty. In osmo-bts-trx there does not seem to be any
way, so lets start the power ramp loop when the parameter
osmotrx tx-attenution is changed on a running TRX.

Change-Id: I1fa5e8130202fb509593db4132863b762b0f40b7
---
M src/osmo-bts-trx/trx_vty.c
1 file changed, 10 insertions(+), 6 deletions(-)

Approvals:
  fixeria: Looks good to me, approved
  pespin: Looks good to me, but someone else must approve
  Jenkins Builder: Verified



diff --git a/src/osmo-bts-trx/trx_vty.c b/src/osmo-bts-trx/trx_vty.c
index 70e9b36..9cc9805 100644
--- a/src/osmo-bts-trx/trx_vty.c
+++ b/src/osmo-bts-trx/trx_vty.c
@@ -394,12 +394,13 @@
return CMD_SUCCESS;
 }
 
-DEFUN(cfg_phyinst_tx_atten, cfg_phyinst_tx_atten_cmd,
-   "osmotrx tx-attenuation (oml|<0-50>)",
-   OSMOTRX_STR
-   "Set the transmitter attenuation\n"
-   "Use NM_ATT_RF_MAXPOWR_R (max power reduction) from BSC via OML 
(default)\n"
-   "Fixed attenuation in dB, overriding OML (default)\n")
+DEFUN_ATTR(cfg_phyinst_tx_atten, cfg_phyinst_tx_atten_cmd,
+  "osmotrx tx-attenuation (oml|<0-50>)",
+  OSMOTRX_STR
+  "Set the transmitter attenuation\n"
+  "Use NM_ATT_RF_MAXPOWR_R (max power reduction) from BSC via OML 
(default)\n"
+  "Fixed attenuation in dB, overriding OML (default)\n",
+  CMD_ATTR_IMMEDIATE)
 {
struct phy_instance *pinst = vty->index;
struct trx_l1h *l1h = pinst->u.osmotrx.hdl;
@@ -409,6 +410,9 @@
else
l1h->config.forced_max_power_red = atoi(argv[0]);

+   if (pinst->trx && pinst->trx->mo.nm_state.operational == 
NM_OPSTATE_ENABLED)
+   l1if_trx_start_power_ramp(pinst->trx, NULL);
+
return CMD_SUCCESS;
 }


--
To view, visit https://gerrit.osmocom.org/c/osmo-bts/+/29649
To unsubscribe, or for help writing mail filters, visit 
https://gerrit.osmocom.org/settings

Gerrit-Project: osmo-bts
Gerrit-Branch: master
Gerrit-Change-Id: I1fa5e8130202fb509593db4132863b762b0f40b7
Gerrit-Change-Number: 29649
Gerrit-PatchSet: 7
Gerrit-Owner: keith 
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: fixeria 
Gerrit-Reviewer: keith 
Gerrit-Reviewer: pespin 
Gerrit-MessageType: merged

Change in osmo-bts[master]: osmo-bts-trx: respond to tx-attenuation config in real time.

[keith]

Attention is currently required from: pespin, fixeria.
keith has posted comments on this change. ( 
https://gerrit.osmocom.org/c/osmo-bts/+/29649 )

Change subject: osmo-bts-trx: respond to tx-attenuation config in real time.
..


Patch Set 6:

(1 comment)

File src/osmo-bts-trx/trx_vty.c:

https://gerrit.osmocom.org/c/osmo-bts/+/29649/comment/1717bd96_779fe99c
PS5, Line 398:  "osmotrx tx-attenuation (oml|<0-50>)",
> You need to adjust the indentation after applying the changes.
Done



--
To view, visit https://gerrit.osmocom.org/c/osmo-bts/+/29649
To unsubscribe, or for help writing mail filters, visit 
https://gerrit.osmocom.org/settings

Gerrit-Project: osmo-bts
Gerrit-Branch: master
Gerrit-Change-Id: I1fa5e8130202fb509593db4132863b762b0f40b7
Gerrit-Change-Number: 29649
Gerrit-PatchSet: 6
Gerrit-Owner: keith 
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: fixeria 
Gerrit-Reviewer: keith 
Gerrit-Reviewer: pespin 
Gerrit-Attention: pespin 
Gerrit-Attention: fixeria 
Gerrit-Comment-Date: Thu, 13 Oct 2022 03:18:26 +
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: pespin 
Gerrit-MessageType: comment

Change in osmo-bts[master]: osmo-bts-trx: respond to tx-attenuation config in real time.

[keith]

Attention is currently required from: fixeria, keith.
Hello Jenkins Builder, fixeria, pespin,

I'd like you to reexamine a change. Please visit

https://gerrit.osmocom.org/c/osmo-bts/+/29649

to look at the new patch set (#6).

Change subject: osmo-bts-trx: respond to tx-attenuation config in real time.
..

osmo-bts-trx: respond to tx-attenuation config in real time.

Some osmo-bts varieties have a method to make an immediate change to
TX power from the vty. In osmo-bts-trx there does not seem to be any
way, so lets start the power ramp loop when the parameter
osmotrx tx-attenution is changed on a running TRX.

Change-Id: I1fa5e8130202fb509593db4132863b762b0f40b7
---
M src/osmo-bts-trx/trx_vty.c
1 file changed, 10 insertions(+), 6 deletions(-)


  git pull ssh://gerrit.osmocom.org:29418/osmo-bts refs/changes/49/29649/6
--
To view, visit https://gerrit.osmocom.org/c/osmo-bts/+/29649
To unsubscribe, or for help writing mail filters, visit 
https://gerrit.osmocom.org/settings

Gerrit-Project: osmo-bts
Gerrit-Branch: master
Gerrit-Change-Id: I1fa5e8130202fb509593db4132863b762b0f40b7
Gerrit-Change-Number: 29649
Gerrit-PatchSet: 6
Gerrit-Owner: keith 
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: fixeria 
Gerrit-Reviewer: keith 
Gerrit-Reviewer: pespin 
Gerrit-Attention: fixeria 
Gerrit-Attention: keith 
Gerrit-MessageType: newpatchset

Change in osmo-bts[master]: osmo-bts-trx: respond to tx-attenuation config in real time.

[keith]

Attention is currently required from: pespin, fixeria.
keith has posted comments on this change. ( 
https://gerrit.osmocom.org/c/osmo-bts/+/29649 )

Change subject: osmo-bts-trx: respond to tx-attenuation config in real time.
..


Patch Set 5:

(1 comment)

File src/osmo-bts-trx/trx_vty.c:

https://gerrit.osmocom.org/c/osmo-bts/+/29649/comment/bbf65aca_3ef0176a
PS4, Line 397: DEFUN
> Ack
I don't see anything changing in the vty help, but here it is anyway.
Thanks for reminding me of these things!



--
To view, visit https://gerrit.osmocom.org/c/osmo-bts/+/29649
To unsubscribe, or for help writing mail filters, visit 
https://gerrit.osmocom.org/settings

Gerrit-Project: osmo-bts
Gerrit-Branch: master
Gerrit-Change-Id: I1fa5e8130202fb509593db4132863b762b0f40b7
Gerrit-Change-Number: 29649
Gerrit-PatchSet: 5
Gerrit-Owner: keith 
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: fixeria 
Gerrit-Reviewer: keith 
Gerrit-Reviewer: pespin 
Gerrit-Attention: pespin 
Gerrit-Attention: fixeria 
Gerrit-Comment-Date: Wed, 12 Oct 2022 16:50:51 +
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: pespin 
Comment-In-Reply-To: fixeria 
Gerrit-MessageType: comment

Change in osmo-bts[master]: osmo-bts-trx: respond to tx-attenuation config in real time.

[keith]

Attention is currently required from: fixeria, keith.
Hello Jenkins Builder, fixeria, pespin,

I'd like you to reexamine a change. Please visit

https://gerrit.osmocom.org/c/osmo-bts/+/29649

to look at the new patch set (#5).

Change subject: osmo-bts-trx: respond to tx-attenuation config in real time.
..

osmo-bts-trx: respond to tx-attenuation config in real time.

Some osmo-bts varieties have a method to make an immediate change to
TX power from the vty. In osmo-bts-trx there does not seem to be any
way, so lets start the power ramp loop when the parameter
osmotrx tx-attenution is changed on a running TRX.

Change-Id: I1fa5e8130202fb509593db4132863b762b0f40b7
---
M src/osmo-bts-trx/trx_vty.c
1 file changed, 6 insertions(+), 2 deletions(-)


  git pull ssh://gerrit.osmocom.org:29418/osmo-bts refs/changes/49/29649/5
--
To view, visit https://gerrit.osmocom.org/c/osmo-bts/+/29649
To unsubscribe, or for help writing mail filters, visit 
https://gerrit.osmocom.org/settings

Gerrit-Project: osmo-bts
Gerrit-Branch: master
Gerrit-Change-Id: I1fa5e8130202fb509593db4132863b762b0f40b7
Gerrit-Change-Number: 29649
Gerrit-PatchSet: 5
Gerrit-Owner: keith 
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: fixeria 
Gerrit-Reviewer: keith 
Gerrit-Reviewer: pespin 
Gerrit-Attention: fixeria 
Gerrit-Attention: keith 
Gerrit-MessageType: newpatchset

Change in osmo-pcu[master]: Fix typo in log message

[keith]

Attention is currently required from: pespin.
keith has posted comments on this change. ( 
https://gerrit.osmocom.org/c/osmo-pcu/+/29718 )

Change subject: Fix typo in log message
..


Patch Set 1:

(1 comment)

Patchset:

PS1:
I wonder if we might actually clarify what is it that does not exist?
You'll see this message, but if you do show ms tlli [tlli from log message] it 
will be there. So I think the log message is wrong.



--
To view, visit https://gerrit.osmocom.org/c/osmo-pcu/+/29718
To unsubscribe, or for help writing mail filters, visit 
https://gerrit.osmocom.org/settings

Gerrit-Project: osmo-pcu
Gerrit-Branch: master
Gerrit-Change-Id: I29a290d1e8b6e237a74ac8fab8dd5e5e5db71796
Gerrit-Change-Number: 29718
Gerrit-PatchSet: 1
Gerrit-Owner: pespin 
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: keith 
Gerrit-Reviewer: msuraev 
Gerrit-Attention: pespin 
Gerrit-Comment-Date: Wed, 12 Oct 2022 16:33:16 +
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Gerrit-MessageType: comment

Change in osmo-sgsn[master]: Constify LLC/SNDCP parameters

[keith]

Attention is currently required from: msuraev.
keith has posted comments on this change. ( 
https://gerrit.osmocom.org/c/osmo-sgsn/+/29678 )

Change subject: Constify LLC/SNDCP parameters
..


Patch Set 2: Code-Review+1

(1 comment)

Patchset:

PS2:
tested with two reasonably busy PCU, and I trust laforge's +1



--
To view, visit https://gerrit.osmocom.org/c/osmo-sgsn/+/29678
To unsubscribe, or for help writing mail filters, visit 
https://gerrit.osmocom.org/settings

Gerrit-Project: osmo-sgsn
Gerrit-Branch: master
Gerrit-Change-Id: I903f8a747a8d3b7f734dac7b0c12373ecbb90b11
Gerrit-Change-Number: 29678
Gerrit-PatchSet: 2
Gerrit-Owner: msuraev 
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: keith 
Gerrit-Reviewer: laforge 
Gerrit-Attention: msuraev 
Gerrit-Comment-Date: Tue, 11 Oct 2022 00:22:48 +
Gerrit-HasComments: Yes
Gerrit-Has-Labels: Yes
Gerrit-MessageType: comment

Change in osmo-sgsn[master]: GMM: permit E_GMM_COMMON_PROC_SUCCESS in normal state

[keith]

Attention is currently required from: msuraev.
keith has posted comments on this change. ( 
https://gerrit.osmocom.org/c/osmo-sgsn/+/29676 )

Change subject: GMM: permit E_GMM_COMMON_PROC_SUCCESS in normal state
..


Patch Set 1: Code-Review+1

(1 comment)

Patchset:

PS1:
+1 on the basis that I'm running it for a while and I see nothing unexpected 
happening. I'm not fully familiar with the fsm though.



--
To view, visit https://gerrit.osmocom.org/c/osmo-sgsn/+/29676
To unsubscribe, or for help writing mail filters, visit 
https://gerrit.osmocom.org/settings

Gerrit-Project: osmo-sgsn
Gerrit-Branch: master
Gerrit-Change-Id: Ia97b50aac6c665812ddca9010de7f97b17b78bd5
Gerrit-Change-Number: 29676
Gerrit-PatchSet: 1
Gerrit-Owner: msuraev 
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: keith 
Gerrit-Reviewer: laforge 
Gerrit-Attention: msuraev 
Gerrit-Comment-Date: Tue, 11 Oct 2022 00:18:06 +
Gerrit-HasComments: Yes
Gerrit-Has-Labels: Yes
Gerrit-MessageType: comment

Change in osmo-sgsn[master]: SNDCP: log more details on failure

[keith]

Attention is currently required from: msuraev.
keith has posted comments on this change. ( 
https://gerrit.osmocom.org/c/osmo-sgsn/+/29675 )

Change subject: SNDCP: log more details on failure
..


Patch Set 1: Code-Review+1


--
To view, visit https://gerrit.osmocom.org/c/osmo-sgsn/+/29675
To unsubscribe, or for help writing mail filters, visit 
https://gerrit.osmocom.org/settings

Gerrit-Project: osmo-sgsn
Gerrit-Branch: master
Gerrit-Change-Id: Iad3ebbc28909a827db7b3a0ae2d3e1de7991210f
Gerrit-Change-Number: 29675
Gerrit-PatchSet: 1
Gerrit-Owner: msuraev 
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: keith 
Gerrit-Reviewer: laforge 
Gerrit-Attention: msuraev 
Gerrit-Comment-Date: Mon, 10 Oct 2022 14:31:32 +
Gerrit-HasComments: No
Gerrit-Has-Labels: Yes
Gerrit-MessageType: comment

Change in osmo-bts[master]: osmo-bts-trx: respond to tx-attenuation config in real time.

[keith]

Attention is currently required from: pespin.
keith has posted comments on this change. ( 
https://gerrit.osmocom.org/c/osmo-bts/+/29649 )

Change subject: osmo-bts-trx: respond to tx-attenuation config in real time.
..


Patch Set 4: Code-Review+1

(1 comment)

File src/osmo-bts-trx/trx_vty.c:

https://gerrit.osmocom.org/c/osmo-bts/+/29649/comment/8083299b_b5ac0b7c
PS3, Line 411:  if (pinst->trx && pinst->trx->mo.nm_state.operational 
== NM_OPSTATE_ENABLED) {
> That really depends on the order you use in the config file I think, so 
> better not to rely only on p […]
Ack



--
To view, visit https://gerrit.osmocom.org/c/osmo-bts/+/29649
To unsubscribe, or for help writing mail filters, visit 
https://gerrit.osmocom.org/settings

Gerrit-Project: osmo-bts
Gerrit-Branch: master
Gerrit-Change-Id: I1fa5e8130202fb509593db4132863b762b0f40b7
Gerrit-Change-Number: 29649
Gerrit-PatchSet: 4
Gerrit-Owner: keith 
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: keith 
Gerrit-Reviewer: pespin 
Gerrit-Attention: pespin 
Gerrit-Comment-Date: Thu, 06 Oct 2022 17:06:20 +
Gerrit-HasComments: Yes
Gerrit-Has-Labels: Yes
Comment-In-Reply-To: pespin 
Comment-In-Reply-To: keith 
Gerrit-MessageType: comment

Change in osmo-bts[master]: osmo-bts-trx: respond to tx-attenuation config in real time.

[keith]

Attention is currently required from: keith.
Hello Jenkins Builder, pespin,

I'd like you to reexamine a change. Please visit

https://gerrit.osmocom.org/c/osmo-bts/+/29649

to look at the new patch set (#4).

Change subject: osmo-bts-trx: respond to tx-attenuation config in real time.
..

osmo-bts-trx: respond to tx-attenuation config in real time.

Some osmo-bts varieties have a method to make an immediate change to
TX power from the vty. In osmo-bts-trx there does not seem to be any
way, so lets start the power ramp loop when the parameter
osmotrx tx-attenution is changed on a running TRX.

Change-Id: I1fa5e8130202fb509593db4132863b762b0f40b7
---
M src/osmo-bts-trx/trx_vty.c
1 file changed, 3 insertions(+), 0 deletions(-)


  git pull ssh://gerrit.osmocom.org:29418/osmo-bts refs/changes/49/29649/4
--
To view, visit https://gerrit.osmocom.org/c/osmo-bts/+/29649
To unsubscribe, or for help writing mail filters, visit 
https://gerrit.osmocom.org/settings

Gerrit-Project: osmo-bts
Gerrit-Branch: master
Gerrit-Change-Id: I1fa5e8130202fb509593db4132863b762b0f40b7
Gerrit-Change-Number: 29649
Gerrit-PatchSet: 4
Gerrit-Owner: keith 
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: pespin 
Gerrit-Attention: keith 
Gerrit-MessageType: newpatchset

Change in osmo-bts[master]: osmo-bts-trx: respond to tx-attenuation config in real time.

[keith]

keith has posted comments on this change. ( 
https://gerrit.osmocom.org/c/osmo-bts/+/29649 )

Change subject: osmo-bts-trx: respond to tx-attenuation config in real time.
..


Patch Set 3:

(1 comment)

File src/osmo-bts-trx/trx_vty.c:

https://gerrit.osmocom.org/c/osmo-bts/+/29649/comment/c09570d3_704a2817
PS3, Line 411:  if (pinst->trx && pinst->trx->mo.nm_state.operational 
== NM_OPSTATE_ENABLED) {
Actually, from adding some printf locally, I see checking for pinst->trx was 
enough to not trigger the power ramp on initially reading the config file. I 
suppose the check for opstate does no harm.



--
To view, visit https://gerrit.osmocom.org/c/osmo-bts/+/29649
To unsubscribe, or for help writing mail filters, visit 
https://gerrit.osmocom.org/settings

Gerrit-Project: osmo-bts
Gerrit-Branch: master
Gerrit-Change-Id: I1fa5e8130202fb509593db4132863b762b0f40b7
Gerrit-Change-Number: 29649
Gerrit-PatchSet: 3
Gerrit-Owner: keith 
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: pespin 
Gerrit-Comment-Date: Thu, 06 Oct 2022 16:52:44 +
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Gerrit-MessageType: comment

Change in osmo-bts[master]: osmo-bts-trx: respond to tx-attenuation config in real time.

[keith]

Attention is currently required from: keith.
Hello Jenkins Builder, pespin,

I'd like you to reexamine a change. Please visit

https://gerrit.osmocom.org/c/osmo-bts/+/29649

to look at the new patch set (#3).

Change subject: osmo-bts-trx: respond to tx-attenuation config in real time.
..

osmo-bts-trx: respond to tx-attenuation config in real time.

Some osmo-bts varieties have a method to make an immediate change to
TX power from the vty. In osmo-bts-trx there does not seem to be any
way, so lets start the power ramp loop when the parameter
osmotrx tx-attenution is changed on a running TRX.

Change-Id: I1fa5e8130202fb509593db4132863b762b0f40b7
---
M src/osmo-bts-trx/trx_vty.c
1 file changed, 5 insertions(+), 1 deletion(-)


  git pull ssh://gerrit.osmocom.org:29418/osmo-bts refs/changes/49/29649/3
--
To view, visit https://gerrit.osmocom.org/c/osmo-bts/+/29649
To unsubscribe, or for help writing mail filters, visit 
https://gerrit.osmocom.org/settings

Gerrit-Project: osmo-bts
Gerrit-Branch: master
Gerrit-Change-Id: I1fa5e8130202fb509593db4132863b762b0f40b7
Gerrit-Change-Number: 29649
Gerrit-PatchSet: 3
Gerrit-Owner: keith 
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: pespin 
Gerrit-Attention: keith 
Gerrit-MessageType: newpatchset

Change in osmo-bts[master]: osmo-bts-trx: respond to tx-attenuation config in real time.

[keith]

Attention is currently required from: pespin.
Hello pespin,

I'd like you to reexamine a change. Please visit

https://gerrit.osmocom.org/c/osmo-bts/+/29649

to look at the new patch set (#2).

Change subject: osmo-bts-trx: respond to tx-attenuation config in real time.
..

osmo-bts-trx: respond to tx-attenuation config in real time.

Some osmo-bts varieties have a method to make an immediate change to
TX power from the vty. In osmo-bts-trx there does not seem to be any
way, so lets start the power ramp loop when the parameter
osmotrx tx-attenution is changed on a running TRX.

Change-Id: I1fa5e8130202fb509593db4132863b762b0f40b7
---
M src/osmo-bts-trx/trx_vty.c
1 file changed, 3 insertions(+), 0 deletions(-)


  git pull ssh://gerrit.osmocom.org:29418/osmo-bts refs/changes/49/29649/2
--
To view, visit https://gerrit.osmocom.org/c/osmo-bts/+/29649
To unsubscribe, or for help writing mail filters, visit 
https://gerrit.osmocom.org/settings

Gerrit-Project: osmo-bts
Gerrit-Branch: master
Gerrit-Change-Id: I1fa5e8130202fb509593db4132863b762b0f40b7
Gerrit-Change-Number: 29649
Gerrit-PatchSet: 2
Gerrit-Owner: keith 
Gerrit-Reviewer: pespin 
Gerrit-CC: Jenkins Builder
Gerrit-Attention: pespin 
Gerrit-MessageType: newpatchset

Change in osmo-bts[master]: osmo-bts-trx: respond to tx-attenuation config in real time.

[keith]

keith has uploaded this change for review. ( 
https://gerrit.osmocom.org/c/osmo-bts/+/29649 )


Change subject: osmo-bts-trx: respond to tx-attenuation config in real time.
..

osmo-bts-trx: respond to tx-attenuation config in real time.

Some osmo-bts varieties have a method to make an immediate change to
TX power from the vty. In osmo-bts-trx there does not seem to be any way,
so lets start the power ramp loop when the parameter osmotrx tx-attenution
is changed on a running TRX.

Change-Id: I1fa5e8130202fb509593db4132863b762b0f40b7
---
M src/osmo-bts-trx/trx_vty.c
1 file changed, 3 insertions(+), 0 deletions(-)



  git pull ssh://gerrit.osmocom.org:29418/osmo-bts refs/changes/49/29649/1

diff --git a/src/osmo-bts-trx/trx_vty.c b/src/osmo-bts-trx/trx_vty.c
index 70e9b36..de48bc5 100644
--- a/src/osmo-bts-trx/trx_vty.c
+++ b/src/osmo-bts-trx/trx_vty.c
@@ -409,6 +409,9 @@
else
l1h->config.forced_max_power_red = atoi(argv[0]);

+   if (pinst->trx)
+   l1if_trx_start_power_ramp(pinst->trx, NULL);
+
return CMD_SUCCESS;
 }


--
To view, visit https://gerrit.osmocom.org/c/osmo-bts/+/29649
To unsubscribe, or for help writing mail filters, visit 
https://gerrit.osmocom.org/settings

Gerrit-Project: osmo-bts
Gerrit-Branch: master
Gerrit-Change-Id: I1fa5e8130202fb509593db4132863b762b0f40b7
Gerrit-Change-Number: 29649
Gerrit-PatchSet: 1
Gerrit-Owner: keith 
Gerrit-MessageType: newchange

Change in libosmocore[master]: Fix Typo in gsm0808_msgt_names[]

[keith]

keith has uploaded this change for review. ( 
https://gerrit.osmocom.org/c/libosmocore/+/29637 )


Change subject: Fix Typo in gsm0808_msgt_names[]
..

Fix Typo in gsm0808_msgt_names[]

Change-Id: I91585d81efd6e18f4b8f9eae50412253d93b
---
M src/gsm/gsm0808.c
1 file changed, 1 insertion(+), 1 deletion(-)



  git pull ssh://gerrit.osmocom.org:29418/libosmocore refs/changes/37/29637/1

diff --git a/src/gsm/gsm0808.c b/src/gsm/gsm0808.c
index 42debac..e057832 100644
--- a/src/gsm/gsm0808.c
+++ b/src/gsm/gsm0808.c
@@ -1728,7 +1728,7 @@
{ BSS_MAP_MSG_UPLINK_APP_DATA,  "UPLINK APP DATA" },

{ BSS_MAP_MSG_LCLS_CONNECT_CTRL,"LCLS-CONNECT-CONTROL" },
-   { BSS_MAP_MSG_LCLS_CONNECT_CTRL_ACK,"CLS-CONNECT-CONTROL-ACK" },
+   { BSS_MAP_MSG_LCLS_CONNECT_CTRL_ACK,"LCLS-CONNECT-CONTROL-ACK" },
{ BSS_MAP_MSG_LCLS_NOTIFICATION,"LCLS-NOTIFICATION" },

{ 0, NULL }

--
To view, visit https://gerrit.osmocom.org/c/libosmocore/+/29637
To unsubscribe, or for help writing mail filters, visit 
https://gerrit.osmocom.org/settings

Gerrit-Project: libosmocore
Gerrit-Branch: master
Gerrit-Change-Id: I91585d81efd6e18f4b8f9eae50412253d93b
Gerrit-Change-Number: 29637
Gerrit-PatchSet: 1
Gerrit-Owner: keith 
Gerrit-MessageType: newchange

Change in libosmocore[master]: Fix LCLS-CONNECT-CONTROL generation

[keith]

keith has uploaded this change for review. ( 
https://gerrit.osmocom.org/c/libosmocore/+/29636 )


Change subject: Fix LCLS-CONNECT-CONTROL generation
..

Fix LCLS-CONNECT-CONTROL generation

gsm0808_create_lcls_conn_ctrl() was adding the LCLS-Configuration IE twice.

Correct is LCLS-Configuration followed by LCLS-Connection-Status-Control
(TS 48.008 3.2.1.91)

Change-Id: I455ac7695ad33ef9073bea7d1711508717732607
---
M src/gsm/gsm0808.c
1 file changed, 1 insertion(+), 1 deletion(-)



  git pull ssh://gerrit.osmocom.org:29418/libosmocore refs/changes/36/29636/1

diff --git a/src/gsm/gsm0808.c b/src/gsm/gsm0808.c
index 4bb7303..42debac 100644
--- a/src/gsm/gsm0808.c
+++ b/src/gsm/gsm0808.c
@@ -373,7 +373,7 @@
if (config != GSM0808_LCLS_CFG_NA)
msgb_tv_put(msg, GSM0808_IE_LCLS_CONFIG, config);
if (control != GSM0808_LCLS_CSC_NA)
-   msgb_tv_put(msg, GSM0808_IE_LCLS_CONFIG, control);
+   msgb_tv_put(msg, GSM0808_IE_LCLS_CONN_STATUS_CTRL, control);
msg->l3h = msgb_tv_push(msg, BSSAP_MSG_BSS_MANAGEMENT, 
msgb_length(msg));

return msg;

--
To view, visit https://gerrit.osmocom.org/c/libosmocore/+/29636
To unsubscribe, or for help writing mail filters, visit 
https://gerrit.osmocom.org/settings

Gerrit-Project: libosmocore
Gerrit-Branch: master
Gerrit-Change-Id: I455ac7695ad33ef9073bea7d1711508717732607
Gerrit-Change-Number: 29636
Gerrit-PatchSet: 1
Gerrit-Owner: keith 
Gerrit-MessageType: newchange

Change in osmo-msc[master]: Change CC_CAUSE returned on unanswered MT Call

[keith]

keith has submitted this change. ( 
https://gerrit.osmocom.org/c/osmo-msc/+/28509 )

Change subject: Change CC_CAUSE returned on unanswered MT Call
..

Change CC_CAUSE returned on unanswered MT Call

The timer "mgw X2" (RTP stream establishing timeout)
is set by default to 30 seconds.
When an MT call is ringing and remains unanswered, it
is this timer that will expire, and the call is terminated.

Up to now this results in a CC_CAUSE of Resource Unavailable
and if osmo-sip-connector is in use, the SIP agent will
get 503 Service Unavailable.
While "resource unavailable" may be technically correct, in
that the MGW did not return an rtp stream in time, returning
"No User Responding" (resulting in SIP 480) is probably a
more accurate description of what actually happened,
allowing the switch to inform the caller.

Change-Id: I4a9cfc388ec9ecb743d154a114a6db638eac4701
---
M src/libmsc/gsm_04_08_cc.c
1 file changed, 2 insertions(+), 0 deletions(-)

Approvals:
  laforge: Looks good to me, but someone else must approve
  neels: Looks good to me, but someone else must approve
  keith: Looks good to me, approved
  pespin: Looks good to me, but someone else must approve
  Jenkins Builder: Verified



diff --git a/src/libmsc/gsm_04_08_cc.c b/src/libmsc/gsm_04_08_cc.c
index 8132de5..99174de 100644
--- a/src/libmsc/gsm_04_08_cc.c
+++ b/src/libmsc/gsm_04_08_cc.c
@@ -278,6 +278,8 @@
if (trans->cc.mncc_initiated) {
mncc_release_ind(trans->net, trans, trans->callref,
 GSM48_CAUSE_LOC_PRN_S_LU,
+(trans->cc.state == 
GSM_CSTATE_CALL_RECEIVED) ?
+GSM48_CC_CAUSE_USER_NOTRESPOND :
 GSM48_CC_CAUSE_RESOURCE_UNAVAIL);
}


--
To view, visit https://gerrit.osmocom.org/c/osmo-msc/+/28509
To unsubscribe, or for help writing mail filters, visit 
https://gerrit.osmocom.org/settings

Gerrit-Project: osmo-msc
Gerrit-Branch: master
Gerrit-Change-Id: I4a9cfc388ec9ecb743d154a114a6db638eac4701
Gerrit-Change-Number: 28509
Gerrit-PatchSet: 3
Gerrit-Owner: keith 
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: dexter 
Gerrit-Reviewer: fixeria 
Gerrit-Reviewer: keith 
Gerrit-Reviewer: laforge 
Gerrit-Reviewer: neels 
Gerrit-Reviewer: pespin 
Gerrit-MessageType: merged

Change in osmo-msc[master]: Change CC_CAUSE returned on unanswered MT Call

[keith]

Attention is currently required from: neels, fixeria, dexter.
keith has posted comments on this change. ( 
https://gerrit.osmocom.org/c/osmo-msc/+/28509 )

Change subject: Change CC_CAUSE returned on unanswered MT Call
..


Patch Set 2: Code-Review+2


--
To view, visit https://gerrit.osmocom.org/c/osmo-msc/+/28509
To unsubscribe, or for help writing mail filters, visit 
https://gerrit.osmocom.org/settings

Gerrit-Project: osmo-msc
Gerrit-Branch: master
Gerrit-Change-Id: I4a9cfc388ec9ecb743d154a114a6db638eac4701
Gerrit-Change-Number: 28509
Gerrit-PatchSet: 2
Gerrit-Owner: keith 
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: dexter 
Gerrit-Reviewer: fixeria 
Gerrit-Reviewer: keith 
Gerrit-Reviewer: laforge 
Gerrit-Reviewer: neels 
Gerrit-Reviewer: pespin 
Gerrit-Attention: neels 
Gerrit-Attention: fixeria 
Gerrit-Attention: dexter 
Gerrit-Comment-Date: Mon, 03 Oct 2022 19:16:04 +
Gerrit-HasComments: No
Gerrit-Has-Labels: Yes
Gerrit-MessageType: comment

Change in osmo-msc[master]: Change CC_CAUSE returned on unanswered MT Call

[keith]

Attention is currently required from: neels, laforge, fixeria, dexter.
keith has posted comments on this change. ( 
https://gerrit.osmocom.org/c/osmo-msc/+/28509 )

Change subject: Change CC_CAUSE returned on unanswered MT Call
..


Patch Set 2:

(1 comment)

Patchset:

PS1:
> Looking at that, and reading the comments, that guard timeout is designed to 
> overall protect against […]
reading further, I see we have implemented spec compliant T301.



--
To view, visit https://gerrit.osmocom.org/c/osmo-msc/+/28509
To unsubscribe, or for help writing mail filters, visit 
https://gerrit.osmocom.org/settings

Gerrit-Project: osmo-msc
Gerrit-Branch: master
Gerrit-Change-Id: I4a9cfc388ec9ecb743d154a114a6db638eac4701
Gerrit-Change-Number: 28509
Gerrit-PatchSet: 2
Gerrit-Owner: keith 
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: dexter 
Gerrit-Reviewer: fixeria 
Gerrit-Reviewer: neels 
Gerrit-Reviewer: pespin 
Gerrit-CC: laforge 
Gerrit-Attention: neels 
Gerrit-Attention: laforge 
Gerrit-Attention: fixeria 
Gerrit-Attention: dexter 
Gerrit-Comment-Date: Mon, 03 Oct 2022 18:18:26 +
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: neels 
Comment-In-Reply-To: keith 
Gerrit-MessageType: comment

Change in osmo-msc[master]: Change CC_CAUSE returned on unanswered MT Call

[keith]

Attention is currently required from: neels, laforge, fixeria, dexter.
keith has posted comments on this change. ( 
https://gerrit.osmocom.org/c/osmo-msc/+/28509 )

Change subject: Change CC_CAUSE returned on unanswered MT Call
..


Patch Set 2:

(1 comment)

Patchset:

PS1:
> regarding proper CC timeout: the old cc implementation apparently only has 
> one overall guard timer,  […]
Looking at that, and reading the comments, that guard timeout is designed to 
overall protect against something becoming non responsive:

 /*NOTE: The purpose of this timer is to prevent the cc state machine
 * from hanging [..]
 * So if the cc state machine does not show any activity for an
 * extended amount of time during call setup or teardown the guard
 * timer will time out and hard-clear the connection. */


One /could/ start adding conditions to this timer, but I think that might get 
in the way of it's stated purpose. It would seem that what is more needed is 
the proper implementation of T301 (I think it is T301) See TS 04.08 5.2.2.3.2



--
To view, visit https://gerrit.osmocom.org/c/osmo-msc/+/28509
To unsubscribe, or for help writing mail filters, visit 
https://gerrit.osmocom.org/settings

Gerrit-Project: osmo-msc
Gerrit-Branch: master
Gerrit-Change-Id: I4a9cfc388ec9ecb743d154a114a6db638eac4701
Gerrit-Change-Number: 28509
Gerrit-PatchSet: 2
Gerrit-Owner: keith 
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: dexter 
Gerrit-Reviewer: fixeria 
Gerrit-Reviewer: neels 
Gerrit-Reviewer: pespin 
Gerrit-CC: laforge 
Gerrit-Attention: neels 
Gerrit-Attention: laforge 
Gerrit-Attention: fixeria 
Gerrit-Attention: dexter 
Gerrit-Comment-Date: Mon, 03 Oct 2022 18:07:31 +
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: neels 
Gerrit-MessageType: comment

Change in osmo-msc[master]: Update MNCC field validation mask.

[keith]

keith has submitted this change. ( 
https://gerrit.osmocom.org/c/osmo-msc/+/29559 )

Change subject: Update MNCC field validation mask.
..

Update MNCC field validation mask.

In c6921e5068ba62cde67707fb3c8103919d1e0c0e, 0x4000 was added to the
possible MNCC field flags, but before this commit, using it would
result in an ERROR of "Unknown MNCC field mask 0x."

Related: OS#5282
Change-Id: I9e7d224e7f2d6d2824b2466752b6e8c994ac5a3d
---
M src/libmsc/mncc.c
1 file changed, 1 insertion(+), 1 deletion(-)

Approvals:
  fixeria: Looks good to me, but someone else must approve
  pespin: Looks good to me, but someone else must approve
  keith: Looks good to me, approved
  Jenkins Builder: Verified



diff --git a/src/libmsc/mncc.c b/src/libmsc/mncc.c
index 0a38997..f446f98 100644
--- a/src/libmsc/mncc.c
+++ b/src/libmsc/mncc.c
@@ -110,7 +110,7 @@
  * MNCC validation code. Move to libosmocore once headers are merged
  /

-#define MNCC_F_ALL 0x3fff
+#define MNCC_F_ALL 0x7fff

 static int check_string_terminated(const char *str, unsigned int size)
 {

--
To view, visit https://gerrit.osmocom.org/c/osmo-msc/+/29559
To unsubscribe, or for help writing mail filters, visit 
https://gerrit.osmocom.org/settings

Gerrit-Project: osmo-msc
Gerrit-Branch: master
Gerrit-Change-Id: I9e7d224e7f2d6d2824b2466752b6e8c994ac5a3d
Gerrit-Change-Number: 29559
Gerrit-PatchSet: 2
Gerrit-Owner: keith 
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: fixeria 
Gerrit-Reviewer: keith 
Gerrit-Reviewer: pespin 
Gerrit-MessageType: merged

Change in osmo-msc[master]: Update MNCC field validation mask.

[keith]

Attention is currently required from: fixeria.
keith has posted comments on this change. ( 
https://gerrit.osmocom.org/c/osmo-msc/+/29559 )

Change subject: Update MNCC field validation mask.
..


Patch Set 2: Code-Review+2


--
To view, visit https://gerrit.osmocom.org/c/osmo-msc/+/29559
To unsubscribe, or for help writing mail filters, visit 
https://gerrit.osmocom.org/settings

Gerrit-Project: osmo-msc
Gerrit-Branch: master
Gerrit-Change-Id: I9e7d224e7f2d6d2824b2466752b6e8c994ac5a3d
Gerrit-Change-Number: 29559
Gerrit-PatchSet: 2
Gerrit-Owner: keith 
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: fixeria 
Gerrit-Reviewer: keith 
Gerrit-Reviewer: pespin 
Gerrit-Attention: fixeria 
Gerrit-Comment-Date: Mon, 03 Oct 2022 15:24:18 +
Gerrit-HasComments: No
Gerrit-Has-Labels: Yes
Gerrit-MessageType: comment

Change in osmo-sip-connector[master]: Set MNCC_F_GCR field when the gcr is present

[keith]

keith has submitted this change. ( 
https://gerrit.osmocom.org/c/osmo-sip-connector/+/29560 )

Change subject: Set MNCC_F_GCR field when the gcr is present
..

Set MNCC_F_GCR field when the gcr is present

Commit bd66804082bf813a1f925c6af4df28fd664ac1de established that the
MNCC field flag MNCC_F_GCR should be set when the GCR is present,
but did not set it.

Change-Id: Idad3210055a0d25be6220301b965e3d4c7323692
---
M src/mncc.c
1 file changed, 4 insertions(+), 2 deletions(-)

Approvals:
  Jenkins Builder: Verified
  pespin: Looks good to me, but someone else must approve
  fixeria: Looks good to me, approved



diff --git a/src/mncc.c b/src/mncc.c
index f302b3e..02ba2cc 100644
--- a/src/mncc.c
+++ b/src/mncc.c
@@ -936,10 +936,12 @@
/* Encode the Global Call Reference (if present) */
if (call->gcr_present) {
msg = msgb_alloc(sizeof(mncc.gcr), "MNCC GCR");
-   if (msg == NULL || (rc = osmo_enc_gcr(msg, >gcr)) == 0)
+   if (msg == NULL || (rc = osmo_enc_gcr(msg, >gcr)) == 0) {
LOGP(DMNCC, LOGL_ERROR, "MNCC leg(%u) failed to encode 
GCR\n", call->id);
-   else
+   } else {
memcpy([0], msg->data, rc);
+   mncc.fields |= MNCC_F_GCR;
+   }
msgb_free(msg);
}


--
To view, visit https://gerrit.osmocom.org/c/osmo-sip-connector/+/29560
To unsubscribe, or for help writing mail filters, visit 
https://gerrit.osmocom.org/settings

Gerrit-Project: osmo-sip-connector
Gerrit-Branch: master
Gerrit-Change-Id: Idad3210055a0d25be6220301b965e3d4c7323692
Gerrit-Change-Number: 29560
Gerrit-PatchSet: 2
Gerrit-Owner: keith 
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: fixeria 
Gerrit-Reviewer: keith 
Gerrit-Reviewer: pespin 
Gerrit-MessageType: merged

Change in osmo-sip-connector[master]: mncc: fix MNCC_SETUP_REQ: set MNCC_F_GCR if GCR is present

[keith]

Attention is currently required from: pespin, fixeria.
keith has posted comments on this change. ( 
https://gerrit.osmocom.org/c/osmo-sip-connector/+/29561 )

Change subject: mncc: fix MNCC_SETUP_REQ: set MNCC_F_GCR if GCR is present
..


Patch Set 1:

(1 comment)

Patchset:

PS1:
> Haven't i seen this patch already somewhere else?
Yes, I already submitted it. I guess I should have added fiexeria to reviewers.



--
To view, visit https://gerrit.osmocom.org/c/osmo-sip-connector/+/29561
To unsubscribe, or for help writing mail filters, visit 
https://gerrit.osmocom.org/settings

Gerrit-Project: osmo-sip-connector
Gerrit-Branch: master
Gerrit-Change-Id: I9dd22caef78e37543dac8a6b31a6ee349e7e5aa8
Gerrit-Change-Number: 29561
Gerrit-PatchSet: 1
Gerrit-Owner: fixeria 
Gerrit-Reviewer: Jenkins Builder
Gerrit-CC: keith 
Gerrit-CC: pespin 
Gerrit-Attention: pespin 
Gerrit-Attention: fixeria 
Gerrit-Comment-Date: Mon, 03 Oct 2022 15:14:27 +
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: pespin 
Gerrit-MessageType: comment

Change in osmo-msc[master]: mncc: move MNCC_F_ALL from mncc.c to mncc.h

[keith]

Attention is currently required from: fixeria, pespin.
keith has posted comments on this change. ( 
https://gerrit.osmocom.org/c/osmo-msc/+/29562 )

Change subject: mncc: move MNCC_F_ALL from mncc.c to mncc.h
..


Patch Set 1: Code-Review+1


--
To view, visit https://gerrit.osmocom.org/c/osmo-msc/+/29562
To unsubscribe, or for help writing mail filters, visit 
https://gerrit.osmocom.org/settings

Gerrit-Project: osmo-msc
Gerrit-Branch: master
Gerrit-Change-Id: If1a12a696b87184c9eee14f475594c317927427b
Gerrit-Change-Number: 29562
Gerrit-PatchSet: 1
Gerrit-Owner: fixeria 
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: keith 
Gerrit-Reviewer: pespin 
Gerrit-Attention: fixeria 
Gerrit-Attention: pespin 
Gerrit-Comment-Date: Mon, 03 Oct 2022 15:07:45 +
Gerrit-HasComments: No
Gerrit-Has-Labels: Yes
Gerrit-MessageType: comment

Change in osmo-sip-connector[master]: Set MNCC_F_GCR field when the gcr is present

[keith]

Hello Jenkins Builder,

I'd like you to reexamine a change. Please visit

https://gerrit.osmocom.org/c/osmo-sip-connector/+/29560

to look at the new patch set (#2).

Change subject: Set MNCC_F_GCR field when the gcr is present
..

Set MNCC_F_GCR field when the gcr is present

Commit bd66804082bf813a1f925c6af4df28fd664ac1de established that the
MNCC field flag MNCC_F_GCR should be set when the GCR is present,
but did not set it.

Change-Id: Idad3210055a0d25be6220301b965e3d4c7323692
---
M src/mncc.c
1 file changed, 4 insertions(+), 2 deletions(-)


  git pull ssh://gerrit.osmocom.org:29418/osmo-sip-connector 
refs/changes/60/29560/2
--
To view, visit https://gerrit.osmocom.org/c/osmo-sip-connector/+/29560
To unsubscribe, or for help writing mail filters, visit 
https://gerrit.osmocom.org/settings

Gerrit-Project: osmo-sip-connector
Gerrit-Branch: master
Gerrit-Change-Id: Idad3210055a0d25be6220301b965e3d4c7323692
Gerrit-Change-Number: 29560
Gerrit-PatchSet: 2
Gerrit-Owner: keith 
Gerrit-Reviewer: Jenkins Builder
Gerrit-MessageType: newpatchset

Change in osmo-sip-connector[master]: Set MNCC_F_GCR field when the gcr is present

[keith]

keith has uploaded this change for review. ( 
https://gerrit.osmocom.org/c/osmo-sip-connector/+/29560 )


Change subject: Set MNCC_F_GCR field when the gcr is present
..

Set MNCC_F_GCR field when the gcr is present

Commit bd66804082bf813a1f925c6af4df28fd664ac1de established that the
MNCC field flag MNCC_F_GCR should be set when the GCR is present,
but did not set it.

Change-Id: Idad3210055a0d25be6220301b965e3d4c7323692
---
M src/mncc.c
1 file changed, 5 insertions(+), 2 deletions(-)



  git pull ssh://gerrit.osmocom.org:29418/osmo-sip-connector 
refs/changes/60/29560/1

diff --git a/src/mncc.c b/src/mncc.c
index f302b3e..ddc1ae6 100644
--- a/src/mncc.c
+++ b/src/mncc.c
@@ -936,10 +936,13 @@
/* Encode the Global Call Reference (if present) */
if (call->gcr_present) {
msg = msgb_alloc(sizeof(mncc.gcr), "MNCC GCR");
-   if (msg == NULL || (rc = osmo_enc_gcr(msg, >gcr)) == 0)
+   if (msg == NULL || (rc = osmo_enc_gcr(msg, >gcr)) == 0) {
LOGP(DMNCC, LOGL_ERROR, "MNCC leg(%u) failed to encode 
GCR\n", call->id);
-   else
+   } else {
memcpy([0], msg->data, rc);
+   mncc.fields |= MNCC_F_GCR;
+   }
+
msgb_free(msg);
}


--
To view, visit https://gerrit.osmocom.org/c/osmo-sip-connector/+/29560
To unsubscribe, or for help writing mail filters, visit 
https://gerrit.osmocom.org/settings

Gerrit-Project: osmo-sip-connector
Gerrit-Branch: master
Gerrit-Change-Id: Idad3210055a0d25be6220301b965e3d4c7323692
Gerrit-Change-Number: 29560
Gerrit-PatchSet: 1
Gerrit-Owner: keith 
Gerrit-MessageType: newchange

Change in osmo-msc[master]: Update MNCC field validation mask.

[keith]

keith has uploaded this change for review. ( 
https://gerrit.osmocom.org/c/osmo-msc/+/29559 )


Change subject: Update MNCC field validation mask.
..

Update MNCC field validation mask.

In c6921e5068ba62cde67707fb3c8103919d1e0c0e, 0x4000 was added to the
possible MNCC field flags, but before this commit, using it would
result in an ERROR of "Unknown MNCC field mask 0x."

Related: #OS5282
Change-Id: I9e7d224e7f2d6d2824b2466752b6e8c994ac5a3d
---
M src/libmsc/mncc.c
1 file changed, 1 insertion(+), 1 deletion(-)



  git pull ssh://gerrit.osmocom.org:29418/osmo-msc refs/changes/59/29559/1

diff --git a/src/libmsc/mncc.c b/src/libmsc/mncc.c
index 0a38997..f446f98 100644
--- a/src/libmsc/mncc.c
+++ b/src/libmsc/mncc.c
@@ -110,7 +110,7 @@
  * MNCC validation code. Move to libosmocore once headers are merged
  /

-#define MNCC_F_ALL 0x3fff
+#define MNCC_F_ALL 0x7fff
 
 static int check_string_terminated(const char *str, unsigned int size)
 {

--
To view, visit https://gerrit.osmocom.org/c/osmo-msc/+/29559
To unsubscribe, or for help writing mail filters, visit 
https://gerrit.osmocom.org/settings

Gerrit-Project: osmo-msc
Gerrit-Branch: master
Gerrit-Change-Id: I9e7d224e7f2d6d2824b2466752b6e8c994ac5a3d
Gerrit-Change-Number: 29559
Gerrit-PatchSet: 1
Gerrit-Owner: keith 
Gerrit-MessageType: newchange

Change in osmo-msc[master]: After RX of an SMPP Submit, send the SMS we just received.

[keith]

Attention is currently required from: neels.
keith has posted comments on this change. ( 
https://gerrit.osmocom.org/c/osmo-msc/+/28342 )

Change subject: After RX of an SMPP Submit, send the SMS we just received.
..


Patch Set 2:

(1 comment)

Patchset:

PS2:
> is this essentially bypassing the SMS queue? Each incoming SMS gets sent 
> immediately? […]
I would not use the term "bypass".

If the immediate attempt to send were to fail then the fallback would be to the 
normal sms queue mechanism.

Yes, it's a strange beast. It's been a few months since I thought about all 
this, but IIRC, these patches were a result of attempts to refactor the SMS 
queue to do things,
1) stop it from consuming ENORMOUS amounts of CPU and blocking osmo-msc and
2) Make delivery of both newly submitted and existing queued SMS reliable 
according to the destination ME availability.

But, there is a pending removal of SMS queue from osmo-msc which makes these 
patches unnecessary.



--
To view, visit https://gerrit.osmocom.org/c/osmo-msc/+/28342
To unsubscribe, or for help writing mail filters, visit 
https://gerrit.osmocom.org/settings

Gerrit-Project: osmo-msc
Gerrit-Branch: master
Gerrit-Change-Id: I9af51ef0d9c2e6c5acc5128efd6195df881b680c
Gerrit-Change-Number: 28342
Gerrit-PatchSet: 2
Gerrit-Owner: keith 
Gerrit-Reviewer: Jenkins Builder
Gerrit-CC: neels 
Gerrit-Attention: neels 
Gerrit-Comment-Date: Fri, 16 Sep 2022 21:36:18 +
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: neels 
Gerrit-MessageType: comment

Change in osmo-msc[master]: Turn off secure_delete in sqlite

[keith]

keith has submitted this change. ( 
https://gerrit.osmocom.org/c/osmo-msc/+/28341 )

Change subject: Turn off secure_delete in sqlite
..

Turn off secure_delete in sqlite

libsqlite3 that ships with some distributions may have secure_delete
activated by default. This means all database records are overwritten
with zeros on DELETE. We don't needs this extra overhead.

Change-Id: I9da6499a38096c8df2025bb9d35ec789864b7c5e
---
M src/libmsc/db.c
1 file changed, 7 insertions(+), 0 deletions(-)

Approvals:
  keith: Looks good to me, approved
  Jenkins Builder: Verified



diff --git a/src/libmsc/db.c b/src/libmsc/db.c
index 0237716..d12f04c 100644
--- a/src/libmsc/db.c
+++ b/src/libmsc/db.c
@@ -569,6 +569,13 @@
/* non-fatal */
}

+   rc = sqlite3_exec(g_dbc->db, "PRAGMA secure_delete=0;", 0, 0, _msg);
+   if (rc != SQLITE_OK) {
+   LOGP(DDB, LOGL_ERROR, "Unable to disable SECURE_DELETE: %s\n", 
err_msg);
+   sqlite3_free(err_msg);
+   /* non-fatal */
+   }
+
return 0;
 }


--
To view, visit https://gerrit.osmocom.org/c/osmo-msc/+/28341
To unsubscribe, or for help writing mail filters, visit 
https://gerrit.osmocom.org/settings

Gerrit-Project: osmo-msc
Gerrit-Branch: master
Gerrit-Change-Id: I9da6499a38096c8df2025bb9d35ec789864b7c5e
Gerrit-Change-Number: 28341
Gerrit-PatchSet: 5
Gerrit-Owner: keith 
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: dexter 
Gerrit-Reviewer: fixeria 
Gerrit-Reviewer: keith 
Gerrit-Reviewer: pespin 
Gerrit-MessageType: merged

Change in osmo-msc[master]: Turn off secure_delete in sqlite

[keith]

keith has posted comments on this change. ( 
https://gerrit.osmocom.org/c/osmo-msc/+/28341 )

Change subject: Turn off secure_delete in sqlite
..


Patch Set 5: Code-Review+2


--
To view, visit https://gerrit.osmocom.org/c/osmo-msc/+/28341
To unsubscribe, or for help writing mail filters, visit 
https://gerrit.osmocom.org/settings

Gerrit-Project: osmo-msc
Gerrit-Branch: master
Gerrit-Change-Id: I9da6499a38096c8df2025bb9d35ec789864b7c5e
Gerrit-Change-Number: 28341
Gerrit-PatchSet: 5
Gerrit-Owner: keith 
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: dexter 
Gerrit-Reviewer: fixeria 
Gerrit-Reviewer: keith 
Gerrit-Reviewer: pespin 
Gerrit-Comment-Date: Fri, 08 Jul 2022 00:09:44 +
Gerrit-HasComments: No
Gerrit-Has-Labels: Yes
Gerrit-MessageType: comment

Change in osmo-msc[master]: Turn off secure_delete in sqlite

[keith]

Attention is currently required from: keith.
Hello Jenkins Builder, fixeria, pespin, dexter,

I'd like you to reexamine a change. Please visit

https://gerrit.osmocom.org/c/osmo-msc/+/28341

to look at the new patch set (#5).

Change subject: Turn off secure_delete in sqlite
..

Turn off secure_delete in sqlite

libsqlite3 that ships with some distributions may have secure_delete
activated by default. This means all database records are overwritten
with zeros on DELETE. We don't needs this extra overhead.

Change-Id: I9da6499a38096c8df2025bb9d35ec789864b7c5e
---
M src/libmsc/db.c
1 file changed, 7 insertions(+), 0 deletions(-)


  git pull ssh://gerrit.osmocom.org:29418/osmo-msc refs/changes/41/28341/5
--
To view, visit https://gerrit.osmocom.org/c/osmo-msc/+/28341
To unsubscribe, or for help writing mail filters, visit 
https://gerrit.osmocom.org/settings

Gerrit-Project: osmo-msc
Gerrit-Branch: master
Gerrit-Change-Id: I9da6499a38096c8df2025bb9d35ec789864b7c5e
Gerrit-Change-Number: 28341
Gerrit-PatchSet: 5
Gerrit-Owner: keith 
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: dexter 
Gerrit-Reviewer: fixeria 
Gerrit-Reviewer: pespin 
Gerrit-Attention: keith 
Gerrit-MessageType: newpatchset

Change in osmo-msc[master]: Turn off secure_delete in sqlite

[keith]

Attention is currently required from: keith.
Hello Jenkins Builder, fixeria, pespin, dexter,

I'd like you to reexamine a change. Please visit

https://gerrit.osmocom.org/c/osmo-msc/+/28341

to look at the new patch set (#4).

Change subject: Turn off secure_delete in sqlite
..

Turn off secure_delete in sqlite

libsqlite3 that ships with some distributions may have secure_delete
activated by default. This means all database records are overwritten with
zeros on DELETE. We don't needs this extra overhead.

Change-Id: I9da6499a38096c8df2025bb9d35ec789864b7c5e
---
M src/libmsc/db.c
1 file changed, 7 insertions(+), 0 deletions(-)


  git pull ssh://gerrit.osmocom.org:29418/osmo-msc refs/changes/41/28341/4
--
To view, visit https://gerrit.osmocom.org/c/osmo-msc/+/28341
To unsubscribe, or for help writing mail filters, visit 
https://gerrit.osmocom.org/settings

Gerrit-Project: osmo-msc
Gerrit-Branch: master
Gerrit-Change-Id: I9da6499a38096c8df2025bb9d35ec789864b7c5e
Gerrit-Change-Number: 28341
Gerrit-PatchSet: 4
Gerrit-Owner: keith 
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: dexter 
Gerrit-Reviewer: fixeria 
Gerrit-Reviewer: pespin 
Gerrit-Attention: keith 
Gerrit-MessageType: newpatchset

Change in osmo-msc[master]: Turn off secure_delete in sqlite

[keith]

Attention is currently required from: keith.
Hello Jenkins Builder, fixeria, pespin, dexter,

I'd like you to reexamine a change. Please visit

https://gerrit.osmocom.org/c/osmo-msc/+/28341

to look at the new patch set (#3).

Change subject: Turn off secure_delete in sqlite
..

Turn off secure_delete in sqlite

libsqlite3 that ships with some distributions may have secure_delete
activated by default. This means all database records are overwritten with
zeros on DELETE. We don't needs this extra overhead.

Change-Id: I9da6499a38096c8df2025bb9d35ec789864b7c5e
---
M src/libmsc/db.c
1 file changed, 13 insertions(+), 0 deletions(-)


  git pull ssh://gerrit.osmocom.org:29418/osmo-msc refs/changes/41/28341/3
--
To view, visit https://gerrit.osmocom.org/c/osmo-msc/+/28341
To unsubscribe, or for help writing mail filters, visit 
https://gerrit.osmocom.org/settings

Gerrit-Project: osmo-msc
Gerrit-Branch: master
Gerrit-Change-Id: I9da6499a38096c8df2025bb9d35ec789864b7c5e
Gerrit-Change-Number: 28341
Gerrit-PatchSet: 3
Gerrit-Owner: keith 
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: dexter 
Gerrit-Reviewer: fixeria 
Gerrit-Reviewer: pespin 
Gerrit-Attention: keith 
Gerrit-MessageType: newpatchset

Change in osmo-msc[master]: Turn off secure_delete in sqlite

[keith]

Attention is currently required from: keith.
Hello Jenkins Builder, fixeria, pespin, dexter,

I'd like you to reexamine a change. Please visit

https://gerrit.osmocom.org/c/osmo-msc/+/28341

to look at the new patch set (#2).

Change subject: Turn off secure_delete in sqlite
..

Turn off secure_delete in sqlite

libsqlite3 that ships with some distributions may have secure_delete
activated by default. This means all database records are overwritten with
zeros on DELETE. We don't needs this extra overhead.

Change-Id: I9da6499a38096c8df2025bb9d35ec789864b7c5e
---
M src/libmsc/db.c
1 file changed, 13 insertions(+), 0 deletions(-)


  git pull ssh://gerrit.osmocom.org:29418/osmo-msc refs/changes/41/28341/2
--
To view, visit https://gerrit.osmocom.org/c/osmo-msc/+/28341
To unsubscribe, or for help writing mail filters, visit 
https://gerrit.osmocom.org/settings

Gerrit-Project: osmo-msc
Gerrit-Branch: master
Gerrit-Change-Id: I9da6499a38096c8df2025bb9d35ec789864b7c5e
Gerrit-Change-Number: 28341
Gerrit-PatchSet: 2
Gerrit-Owner: keith 
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: dexter 
Gerrit-Reviewer: fixeria 
Gerrit-Reviewer: pespin 
Gerrit-Attention: keith 
Gerrit-MessageType: newpatchset

Change in osmo-msc[master]: Change CC_CAUSE returned on unanswered MT Call

[keith]

Attention is currently required from: neels, laforge, pespin, fixeria, dexter.
keith has posted comments on this change. ( 
https://gerrit.osmocom.org/c/osmo-msc/+/28509 )

Change subject: Change CC_CAUSE returned on unanswered MT Call
..


Patch Set 1:

(1 comment)

Patchset:

PS1:
> If I understand you / the situation correctly, then: […]
I could not find any configurable timeout for MT not responding.

That can be configured at the freeswitch PBX of course, so one could set
 timer mgw X2 60

and then have the switch allow ringing for 45 seconds or some such.



--
To view, visit https://gerrit.osmocom.org/c/osmo-msc/+/28509
To unsubscribe, or for help writing mail filters, visit 
https://gerrit.osmocom.org/settings

Gerrit-Project: osmo-msc
Gerrit-Branch: master
Gerrit-Change-Id: I4a9cfc388ec9ecb743d154a114a6db638eac4701
Gerrit-Change-Number: 28509
Gerrit-PatchSet: 1
Gerrit-Owner: keith 
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: dexter 
Gerrit-Reviewer: fixeria 
Gerrit-Reviewer: neels 
Gerrit-Reviewer: pespin 
Gerrit-CC: laforge 
Gerrit-Attention: neels 
Gerrit-Attention: laforge 
Gerrit-Attention: pespin 
Gerrit-Attention: fixeria 
Gerrit-Attention: dexter 
Gerrit-Comment-Date: Sun, 03 Jul 2022 18:53:03 +
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: laforge 
Gerrit-MessageType: comment

Change in osmo-msc[master]: Change CC_CAUSE returned on unanswered MT Call

[keith]

keith has posted comments on this change. ( 
https://gerrit.osmocom.org/c/osmo-msc/+/28509 )

Change subject: Change CC_CAUSE returned on unanswered MT Call
..


Patch Set 1:

(1 comment)

File src/libmsc/gsm_04_08_cc.c:

https://gerrit.osmocom.org/c/osmo-msc/+/28509/comment/cf08d5bd_b34a264a
PS1, Line 281:   (trans->cc.state == 
GSM_CSTATE_CALL_RECEIVED) ?
In adding this check, I should point out that I do not know what other CC state 
is possible when we reach this code, but in order to at least try not use the 
wrong cause for other situations, I decided to limit it to 
GSM_CSTATE_CALL_RECEIVED.

It might be better to know here if it was actually timer mgw X2 that expired. 
Maybe there is a way to know that, I don't see it glancing at what seems to be 
immediately available in trans or the msc_a. The timer expiration is quite some 
ways up the stack through various FSM callbacks. Or maybe there is another 
state we can check, for example, I thought to check for 
COMPLETE_LAYER3_PAGING_RESP. Even so, with those conditions in place, I don't 
think there is any way to know if the call was simply unanswered or if the MGW 
suffered some other problem?



--
To view, visit https://gerrit.osmocom.org/c/osmo-msc/+/28509
To unsubscribe, or for help writing mail filters, visit 
https://gerrit.osmocom.org/settings

Gerrit-Project: osmo-msc
Gerrit-Branch: master
Gerrit-Change-Id: I4a9cfc388ec9ecb743d154a114a6db638eac4701
Gerrit-Change-Number: 28509
Gerrit-PatchSet: 1
Gerrit-Owner: keith 
Gerrit-Reviewer: Jenkins Builder
Gerrit-Comment-Date: Sun, 03 Jul 2022 03:35:49 +
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Gerrit-MessageType: comment

Change in osmo-msc[master]: Change CC_CAUSE returned on unanswered MT Call

[keith]

keith has uploaded this change for review. ( 
https://gerrit.osmocom.org/c/osmo-msc/+/28509 )


Change subject: Change CC_CAUSE returned on unanswered MT Call
..

Change CC_CAUSE returned on unanswered MT Call

The timer "mgw X2" (RTP stream establishing timeout)
is set by default to 30 seconds.
When an MT call is ringing and remains unanswered, it
is this timer that will expire, and the call is terminated.

Up to now this results in a CC_CAUSE of Resource Unavailable
and if osmo-sip-connector is in use, the SIP agent will
get 503 Service Unavailable.
While "resource unavailable" may be technically correct, in
that the MGW did not return an rtp stream in time, returning
"No User Responding" (resulting in SIP 480) is probably a
more accurate description of what actually happened,
allowing the switch to inform the caller.

Change-Id: I4a9cfc388ec9ecb743d154a114a6db638eac4701
---
M src/libmsc/gsm_04_08_cc.c
1 file changed, 2 insertions(+), 0 deletions(-)



  git pull ssh://gerrit.osmocom.org:29418/osmo-msc refs/changes/09/28509/1

diff --git a/src/libmsc/gsm_04_08_cc.c b/src/libmsc/gsm_04_08_cc.c
index 6562daa..9b7495f 100644
--- a/src/libmsc/gsm_04_08_cc.c
+++ b/src/libmsc/gsm_04_08_cc.c
@@ -278,6 +278,8 @@
if (trans->cc.mncc_initiated) {
mncc_release_ind(trans->net, trans, trans->callref,
 GSM48_CAUSE_LOC_PRN_S_LU,
+(trans->cc.state == 
GSM_CSTATE_CALL_RECEIVED) ?
+GSM48_CC_CAUSE_USER_NOTRESPOND :
 GSM48_CC_CAUSE_RESOURCE_UNAVAIL);
}


--
To view, visit https://gerrit.osmocom.org/c/osmo-msc/+/28509
To unsubscribe, or for help writing mail filters, visit 
https://gerrit.osmocom.org/settings

Gerrit-Project: osmo-msc
Gerrit-Branch: master
Gerrit-Change-Id: I4a9cfc388ec9ecb743d154a114a6db638eac4701
Gerrit-Change-Number: 28509
Gerrit-PatchSet: 1
Gerrit-Owner: keith 
Gerrit-MessageType: newchange

Change in osmo-bsc[master]: Improve parsing of om2000 fault reports

[keith]

keith has uploaded this change for review. ( 
https://gerrit.osmocom.org/c/osmo-bsc/+/28420 )


Change subject: Improve parsing of om2000 fault reports
..

Improve parsing of om2000 fault reports

Fault Reports are commonly oberved with a TLV id 0xd2
as are reports with up to 20 TLVs.
Let's not have these cause logging at level ERROR.

Closes: OS#5593
Change-Id: Ibe0b38835362c59d1576a206b2f64cea4427295f
---
M src/osmo-bsc/abis_om2000.c
1 file changed, 3 insertions(+), 1 deletion(-)



  git pull ssh://gerrit.osmocom.org:29418/osmo-bsc refs/changes/20/28420/1

diff --git a/src/osmo-bsc/abis_om2000.c b/src/osmo-bsc/abis_om2000.c
index 1deab13..84fb7ac 100644
--- a/src/osmo-bsc/abis_om2000.c
+++ b/src/osmo-bsc/abis_om2000.c
@@ -310,6 +310,7 @@
OM2K_DEI_MAX_ALLOWED_POWER  = 0xa9,
OM2K_DEI_MAX_ALLOWED_NUM_TRXCS  = 0xaa,
OM2K_DEI_MCTR_FEAT_STATUS_BMAP  = 0xab,
+   OM2K_DEI_SEEN_UNKNOWN_D2= 0xd2,
 };

 enum abis_om2k_mostate {
@@ -388,6 +389,7 @@
[OM2K_DEI_FS_OFFSET] =  { TLV_TYPE_FIXED, 5 },
[OM2K_DEI_EXT_COND_MAP_2_EXT] = { TLV_TYPE_FIXED, 4 },
[OM2K_DEI_TSS_MO_STATE] =   { TLV_TYPE_FIXED, 4 },
+   [OM2K_DEI_SEEN_UNKNOWN_D2] ={ TLV_TYPE_FIXED, 6 },
},
 };

@@ -2882,7 +2884,7 @@

/* Bail if an the maximum number of TLV fields
 * have been parsed */
-   if (tlv_count >= 11) {
+   if (tlv_count >= 20) {
LOGP(DNM, LOGL_ERROR, "Rx MO=%s Fault Report: too many 
tlv elements!\n",
 abis_om2k_mo_name(mo));
return;

-- 
To view, visit https://gerrit.osmocom.org/c/osmo-bsc/+/28420
To unsubscribe, or for help writing mail filters, visit 
https://gerrit.osmocom.org/settings

Gerrit-Project: osmo-bsc
Gerrit-Branch: master
Gerrit-Change-Id: Ibe0b38835362c59d1576a206b2f64cea4427295f
Gerrit-Change-Number: 28420
Gerrit-PatchSet: 1
Gerrit-Owner: keith 
Gerrit-MessageType: newchange