[S] Change in osmo-ttcn3-hacks[master]: pcap-client: initial testenv.cfg
Attention is currently required from: osmith. pespin has posted comments on this change by osmith. ( https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/38267?usp=email ) Change subject: pcap-client: initial testenv.cfg .. Patch Set 1: Code-Review+1 -- To view, visit https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/38267?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: osmo-ttcn3-hacks Gerrit-Branch: master Gerrit-Change-Id: I44479dfa19390e325e42fa3416cf93260f74aea6 Gerrit-Change-Number: 38267 Gerrit-PatchSet: 1 Gerrit-Owner: osmith Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: pespin Gerrit-Attention: osmith Gerrit-Comment-Date: Mon, 23 Sep 2024 10:29:43 + Gerrit-HasComments: No Gerrit-Has-Labels: Yes
[L] Change in osmo-ttcn3-hacks[master]: ggsn: add testenv.cfg for open5gs
Attention is currently required from: osmith. pespin has posted comments on this change by osmith. ( https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/38266?usp=email ) Change subject: ggsn: add testenv.cfg for open5gs .. Patch Set 1: Code-Review+1 -- To view, visit https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/38266?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: osmo-ttcn3-hacks Gerrit-Branch: master Gerrit-Change-Id: If11c0fcba84122d2398cb50208f161b9a3961df6 Gerrit-Change-Number: 38266 Gerrit-PatchSet: 1 Gerrit-Owner: osmith Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: pespin Gerrit-Attention: osmith Gerrit-Comment-Date: Mon, 23 Sep 2024 10:29:23 + Gerrit-HasComments: No Gerrit-Has-Labels: Yes
[L] Change in osmo-ttcn3-hacks[master]: ggsn: add testenv.cfgs for osmo-ggsn
Attention is currently required from: osmith. pespin has posted comments on this change by osmith. ( https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/38265?usp=email ) Change subject: ggsn: add testenv.cfgs for osmo-ggsn .. Patch Set 1: Code-Review+1 -- To view, visit https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/38265?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: osmo-ttcn3-hacks Gerrit-Branch: master Gerrit-Change-Id: I941b859261c1fbf27360673f14f8a79f0cf6f509 Gerrit-Change-Number: 38265 Gerrit-PatchSet: 1 Gerrit-Owner: osmith Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: pespin Gerrit-Attention: osmith Gerrit-Comment-Date: Mon, 23 Sep 2024 10:28:33 + Gerrit-HasComments: No Gerrit-Has-Labels: Yes
[S] Change in osmo-ttcn3-hacks[master]: ggsn: f_wait_icmp4: ignore ICMPv4 redirect
Attention is currently required from: osmith. pespin has posted comments on this change by osmith. ( https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/38264?usp=email ) Change subject: ggsn: f_wait_icmp4: ignore ICMPv4 redirect .. Patch Set 1: (1 comment) Patchset: PS1: Do you know why this redirect happens with podman? I never heard about this ICMP redirect btw. -- To view, visit https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/38264?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: osmo-ttcn3-hacks Gerrit-Branch: master Gerrit-Change-Id: I6dff4db1fb0803a02f412ff23bb5dcac8e50a504 Gerrit-Change-Number: 38264 Gerrit-PatchSet: 1 Gerrit-Owner: osmith Gerrit-Reviewer: Jenkins Builder Gerrit-CC: pespin Gerrit-Attention: osmith Gerrit-Comment-Date: Mon, 23 Sep 2024 10:28:04 + Gerrit-HasComments: Yes Gerrit-Has-Labels: No
[S] Change in osmo-ttcn3-hacks[master]: ggsn: sync GGSN_Tests.cfg with docker-playground
Attention is currently required from: osmith. pespin has posted comments on this change by osmith. ( https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/38263?usp=email ) Change subject: ggsn: sync GGSN_Tests.cfg with docker-playground .. Patch Set 1: Code-Review+1 -- To view, visit https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/38263?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: osmo-ttcn3-hacks Gerrit-Branch: master Gerrit-Change-Id: I16a8cbd77f52a1ca5c52c045b8d0932e681cc380 Gerrit-Change-Number: 38263 Gerrit-PatchSet: 1 Gerrit-Owner: osmith Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: pespin Gerrit-Attention: osmith Gerrit-Comment-Date: Mon, 23 Sep 2024 10:26:23 + Gerrit-HasComments: No Gerrit-Has-Labels: Yes
[S] Change in osmo-ttcn3-hacks[master]: testenv: copy=: support copying directories too
Attention is currently required from: osmith. pespin has posted comments on this change by osmith. ( https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/38262?usp=email ) Change subject: testenv: copy=: support copying directories too .. Patch Set 1: Code-Review+1 -- To view, visit https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/38262?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: osmo-ttcn3-hacks Gerrit-Branch: master Gerrit-Change-Id: I8e680fbd93516030614c015d7c3b5bdb153ec487 Gerrit-Change-Number: 38262 Gerrit-PatchSet: 1 Gerrit-Owner: osmith Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: pespin Gerrit-Attention: osmith Gerrit-Comment-Date: Mon, 23 Sep 2024 10:25:47 + Gerrit-HasComments: No Gerrit-Has-Labels: Yes
[S] Change in osmo-ttcn3-hacks[master]: testenv: clean_run_scripts: skip if podman stopped
Attention is currently required from: osmith. pespin has posted comments on this change by osmith. ( https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/38261?usp=email ) Change subject: testenv: clean_run_scripts: skip if podman stopped .. Patch Set 1: Code-Review+1 -- To view, visit https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/38261?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: osmo-ttcn3-hacks Gerrit-Branch: master Gerrit-Change-Id: I3cc05aabd97b73b65c3089e8806f7a9b32e5975c Gerrit-Change-Number: 38261 Gerrit-PatchSet: 1 Gerrit-Owner: osmith Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: pespin Gerrit-Attention: osmith Gerrit-Comment-Date: Mon, 23 Sep 2024 10:24:06 + Gerrit-HasComments: No Gerrit-Has-Labels: Yes
[S] Change in osmo-ttcn3-hacks[master]: testenv/README: document current working dir
Attention is currently required from: osmith. pespin has posted comments on this change by osmith. ( https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/38260?usp=email ) Change subject: testenv/README: document current working dir .. Patch Set 1: Code-Review+1 -- To view, visit https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/38260?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: osmo-ttcn3-hacks Gerrit-Branch: master Gerrit-Change-Id: I218507bcbec94a36976fbf57d12ffd083fd2acfb Gerrit-Change-Number: 38260 Gerrit-PatchSet: 1 Gerrit-Owner: osmith Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: pespin Gerrit-Attention: osmith Gerrit-Comment-Date: Mon, 23 Sep 2024 10:23:45 + Gerrit-HasComments: No Gerrit-Has-Labels: Yes
[XS] Change in osmo-ttcn3-hacks[master]: testenv: podman.exec_cmd: better error if stopped
Attention is currently required from: osmith. pespin has posted comments on this change by osmith. ( https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/38258?usp=email ) Change subject: testenv: podman.exec_cmd: better error if stopped .. Patch Set 1: Code-Review+1 -- To view, visit https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/38258?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: osmo-ttcn3-hacks Gerrit-Branch: master Gerrit-Change-Id: I29ebe200258a9a9ffb127ec8fa1260b7e2124c38 Gerrit-Change-Number: 38258 Gerrit-PatchSet: 1 Gerrit-Owner: osmith Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: pespin Gerrit-Attention: osmith Gerrit-Comment-Date: Mon, 23 Sep 2024 10:23:22 + Gerrit-HasComments: No Gerrit-Has-Labels: Yes
[XS] Change in osmo-ttcn3-hacks[master]: testenv/README: consistency fix
Attention is currently required from: osmith. pespin has posted comments on this change by osmith. ( https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/38257?usp=email ) Change subject: testenv/README: consistency fix .. Patch Set 1: Code-Review+1 -- To view, visit https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/38257?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: osmo-ttcn3-hacks Gerrit-Branch: master Gerrit-Change-Id: Ic9828b67f5a81498d0e951dd71b80b36cdd36173 Gerrit-Change-Number: 38257 Gerrit-PatchSet: 1 Gerrit-Owner: osmith Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: pespin Gerrit-Attention: osmith Gerrit-Comment-Date: Mon, 23 Sep 2024 10:20:34 + Gerrit-HasComments: No Gerrit-Has-Labels: Yes
[XS] Change in osmo-ttcn3-hacks[master]: testenv: testsuite: use rsync with --executability
Attention is currently required from: osmith. pespin has posted comments on this change by osmith. ( https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/38256?usp=email ) Change subject: testenv: testsuite: use rsync with --executability .. Patch Set 1: Code-Review+1 -- To view, visit https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/38256?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: osmo-ttcn3-hacks Gerrit-Branch: master Gerrit-Change-Id: Ia9737bd8ba22a555615862bf5e14dbdf0dea19b4 Gerrit-Change-Number: 38256 Gerrit-PatchSet: 1 Gerrit-Owner: osmith Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: pespin Gerrit-Attention: osmith Gerrit-Comment-Date: Mon, 23 Sep 2024 10:20:00 + Gerrit-HasComments: No Gerrit-Has-Labels: Yes
[S] Change in osmo-msc[master]: Remove speech codec list from bearer_cap for phase 1 mobile station
Attention is currently required from: fixeria, jolly, neels, nt2mku. pespin has posted comments on this change by jolly. ( https://gerrit.osmocom.org/c/osmo-msc/+/38197?usp=email ) Change subject: Remove speech codec list from bearer_cap for phase 1 mobile station .. Patch Set 3: Code-Review+2 -- To view, visit https://gerrit.osmocom.org/c/osmo-msc/+/38197?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: osmo-msc Gerrit-Branch: master Gerrit-Change-Id: Idd267dad0ade18cee7d5be813a57e1ee3168e2db Gerrit-Change-Number: 38197 Gerrit-PatchSet: 3 Gerrit-Owner: jolly Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: laforge Gerrit-Reviewer: neels Gerrit-Reviewer: nt2mku Gerrit-Reviewer: pespin Gerrit-CC: fixeria Gerrit-Attention: jolly Gerrit-Attention: neels Gerrit-Attention: nt2mku Gerrit-Attention: fixeria Gerrit-Comment-Date: Mon, 23 Sep 2024 10:16:38 + Gerrit-HasComments: No Gerrit-Has-Labels: Yes
[M] Change in ...osmo-s1gw[master]: s1ap_proxy: Support replying errors
Attention is currently required from: fixeria, lynxis lazus. pespin has posted comments on this change by pespin. ( https://gerrit.osmocom.org/c/erlang/osmo-s1gw/+/37924?usp=email ) Change subject: s1ap_proxy: Support replying errors .. Patch Set 5: (1 comment) Patchset: PS4: > Just to clarify: I am fine with the follow-up patch adding metrics, and I > have no objections about m […] Please do whatever you deem necessary so it can finally get merged. I really see no point on why this needs to be stuck here for 1 month instead of being merged and tests worked on now once we have better test infrastructure to add them. All this just makes it harder for other people to develop, test and use the project. -- To view, visit https://gerrit.osmocom.org/c/erlang/osmo-s1gw/+/37924?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: erlang/osmo-s1gw Gerrit-Branch: master Gerrit-Change-Id: I242e84fb09b00f4794b6e1aa770f348a0e60aea4 Gerrit-Change-Number: 37924 Gerrit-PatchSet: 5 Gerrit-Owner: pespin Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria Gerrit-Reviewer: laforge Gerrit-Reviewer: lynxis lazus Gerrit-Attention: fixeria Gerrit-Attention: lynxis lazus Gerrit-Comment-Date: Mon, 23 Sep 2024 10:14:05 + Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: fixeria Comment-In-Reply-To: pespin
[XS] Change in osmo-ttcn3-hacks[master]: testenv/README: deduplicate clean= description
Attention is currently required from: osmith. pespin has posted comments on this change by osmith. ( https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/38259?usp=email ) Change subject: testenv/README: deduplicate clean= description .. Patch Set 1: Code-Review+1 -- To view, visit https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/38259?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: osmo-ttcn3-hacks Gerrit-Branch: master Gerrit-Change-Id: I12dc9adb508a409a6156f9682c9db5684f551b06 Gerrit-Change-Number: 38259 Gerrit-PatchSet: 1 Gerrit-Owner: osmith Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: pespin Gerrit-Attention: osmith Gerrit-Comment-Date: Mon, 23 Sep 2024 10:06:37 + Gerrit-HasComments: No Gerrit-Has-Labels: Yes
[M] Change in ...osmo-s1gw[master]: s1ap_proxy: Support replying errors
Attention is currently required from: fixeria, lynxis lazus. pespin has posted comments on this change by pespin. ( https://gerrit.osmocom.org/c/erlang/osmo-s1gw/+/37924?usp=email ) Change subject: s1ap_proxy: Support replying errors .. Patch Set 5: (1 comment) Patchset: PS4: > And yet another week passed with this commit blocked. One month after submission and my patch is still blocked in here. -- To view, visit https://gerrit.osmocom.org/c/erlang/osmo-s1gw/+/37924?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: erlang/osmo-s1gw Gerrit-Branch: master Gerrit-Change-Id: I242e84fb09b00f4794b6e1aa770f348a0e60aea4 Gerrit-Change-Number: 37924 Gerrit-PatchSet: 5 Gerrit-Owner: pespin Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria Gerrit-Reviewer: laforge Gerrit-Reviewer: lynxis lazus Gerrit-Attention: fixeria Gerrit-Attention: lynxis lazus Gerrit-Comment-Date: Mon, 23 Sep 2024 09:27:51 + Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: pespin Comment-In-Reply-To: fixeria
[XS] Change in pysim[master]: gitignore: add files generated with jenkins.sh
Attention is currently required from: osmith. pespin has posted comments on this change by osmith. ( https://gerrit.osmocom.org/c/pysim/+/38252?usp=email ) Change subject: gitignore: add files generated with jenkins.sh .. Patch Set 1: Code-Review+1 -- To view, visit https://gerrit.osmocom.org/c/pysim/+/38252?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: pysim Gerrit-Branch: master Gerrit-Change-Id: Iaffe04a3dfebd46efc479dc3665fd67f2c95f375 Gerrit-Change-Number: 38252 Gerrit-PatchSet: 1 Gerrit-Owner: osmith Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: pespin Gerrit-Attention: osmith Gerrit-Comment-Date: Mon, 23 Sep 2024 09:08:52 + Gerrit-HasComments: No Gerrit-Has-Labels: Yes
[XS] Change in pysim[master]: contrib/jenkins: add SKIP_CLEAN_WORKSPACE
Attention is currently required from: laforge, osmith. pespin has posted comments on this change by osmith. ( https://gerrit.osmocom.org/c/pysim/+/38253?usp=email ) Change subject: contrib/jenkins: add SKIP_CLEAN_WORKSPACE .. Patch Set 1: Code-Review+1 -- To view, visit https://gerrit.osmocom.org/c/pysim/+/38253?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: pysim Gerrit-Branch: master Gerrit-Change-Id: Ic8dc9b85da17719195f7374d37eccb4dedba6ce8 Gerrit-Change-Number: 38253 Gerrit-PatchSet: 1 Gerrit-Owner: osmith Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: laforge Gerrit-Reviewer: pespin Gerrit-Attention: osmith Gerrit-Attention: laforge Gerrit-Comment-Date: Mon, 23 Sep 2024 09:08:31 + Gerrit-HasComments: No Gerrit-Has-Labels: Yes
[S] Change in osmo-ci[master]: manuals: publish pyosmocom manuals for releases
Attention is currently required from: laforge, osmith. pespin has posted comments on this change by osmith. ( https://gerrit.osmocom.org/c/osmo-ci/+/38251?usp=email ) Change subject: manuals: publish pyosmocom manuals for releases .. Patch Set 1: Code-Review+1 -- To view, visit https://gerrit.osmocom.org/c/osmo-ci/+/38251?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: osmo-ci Gerrit-Branch: master Gerrit-Change-Id: I3799cf825937cdd8dfca9fbd98e8b6b159f7cea8 Gerrit-Change-Number: 38251 Gerrit-PatchSet: 1 Gerrit-Owner: osmith Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: laforge Gerrit-Reviewer: pespin Gerrit-Attention: osmith Gerrit-Attention: laforge Gerrit-Comment-Date: Mon, 23 Sep 2024 09:07:45 + Gerrit-HasComments: No Gerrit-Has-Labels: Yes
[L] Change in osmo-ttcn3-hacks[master]: library/PFCP_Emulation: a better PDU routing concept
Attention is currently required from: fixeria. pespin has posted comments on this change by fixeria. ( https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/38207?usp=email ) Change subject: library/PFCP_Emulation: a better PDU routing concept .. Patch Set 4: Code-Review+2 -- To view, visit https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/38207?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: osmo-ttcn3-hacks Gerrit-Branch: master Gerrit-Change-Id: I25802471519fa297ad4cb2b056adaa6748b00af2 Gerrit-Change-Number: 38207 Gerrit-PatchSet: 4 Gerrit-Owner: fixeria Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: laforge Gerrit-Reviewer: pespin Gerrit-Attention: fixeria Gerrit-Comment-Date: Mon, 23 Sep 2024 09:06:30 + Gerrit-HasComments: No Gerrit-Has-Labels: Yes
[XS] Change in osmo-ttcn3-hacks[master]: gen_links.sh.inc: 'set -e' to abort on error
Attention is currently required from: fixeria. pespin has posted comments on this change by fixeria. ( https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/38245?usp=email ) Change subject: gen_links.sh.inc: 'set -e' to abort on error .. Patch Set 1: Code-Review+2 -- To view, visit https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/38245?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: osmo-ttcn3-hacks Gerrit-Branch: master Gerrit-Change-Id: Id9367e4c45c84dcbf1c308581360be73242c0d38 Gerrit-Change-Number: 38245 Gerrit-PatchSet: 1 Gerrit-Owner: fixeria Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: laforge Gerrit-Reviewer: pespin Gerrit-Attention: fixeria Gerrit-Comment-Date: Mon, 23 Sep 2024 09:04:01 + Gerrit-HasComments: No Gerrit-Has-Labels: Yes
[XS] Change in osmo-ttcn3-hacks[master]: {bsc-nat,selftest,sysinfo}/gen_links.sh: use bash, not sh
Attention is currently required from: fixeria.
pespin has posted comments on this change by fixeria. (
https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/38244?usp=email )
Change subject: {bsc-nat,selftest,sysinfo}/gen_links.sh: use bash, not sh
..
Patch Set 1: Code-Review+2
--
To view, visit https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/38244?usp=email
To unsubscribe, or for help writing mail filters, visit
https://gerrit.osmocom.org/settings?usp=email
Gerrit-MessageType: comment
Gerrit-Project: osmo-ttcn3-hacks
Gerrit-Branch: master
Gerrit-Change-Id: I994e241efb73f6f8b78803cf4ecdfb057b210a3b
Gerrit-Change-Number: 38244
Gerrit-PatchSet: 1
Gerrit-Owner: fixeria
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: laforge
Gerrit-Reviewer: pespin
Gerrit-Attention: fixeria
Gerrit-Comment-Date: Mon, 23 Sep 2024 09:03:41 +
Gerrit-HasComments: No
Gerrit-Has-Labels: Yes
[XS] Change in osmo-ttcn3-hacks[master]: library/s1ap: fix wrong field in S1AP-RABReleaseInd
Attention is currently required from: fixeria. pespin has posted comments on this change by fixeria. ( https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/38243?usp=email ) Change subject: library/s1ap: fix wrong field in S1AP-RABReleaseInd .. Patch Set 1: Code-Review+2 -- To view, visit https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/38243?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: osmo-ttcn3-hacks Gerrit-Branch: master Gerrit-Change-Id: I7a24b6401a19a6e37392083b26657bcb45b35cbe Gerrit-Change-Number: 38243 Gerrit-PatchSet: 1 Gerrit-Owner: fixeria Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: pespin Gerrit-Attention: fixeria Gerrit-Comment-Date: Fri, 20 Sep 2024 22:42:02 + Gerrit-HasComments: No Gerrit-Has-Labels: Yes
[S] Change in ...osmo-s1gw[master]: s1ap_proxy: print unique E-RAB ID in error messages
Attention is currently required from: fixeria. pespin has posted comments on this change by fixeria. ( https://gerrit.osmocom.org/c/erlang/osmo-s1gw/+/38239?usp=email ) Change subject: s1ap_proxy: print unique E-RAB ID in error messages .. Patch Set 1: Code-Review+1 -- To view, visit https://gerrit.osmocom.org/c/erlang/osmo-s1gw/+/38239?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: erlang/osmo-s1gw Gerrit-Branch: master Gerrit-Change-Id: I7327e25ea407b3a21706e8b5e4487135675d91d5 Gerrit-Change-Number: 38239 Gerrit-PatchSet: 1 Gerrit-Owner: fixeria Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: pespin Gerrit-Attention: fixeria Gerrit-Comment-Date: Fri, 20 Sep 2024 22:41:00 + Gerrit-HasComments: No Gerrit-Has-Labels: Yes
[M] Change in ...osmo-s1gw[master]: s1ap_proxy: handle E-RAB RELEASE INDICATION
Attention is currently required from: fixeria. pespin has posted comments on this change by fixeria. ( https://gerrit.osmocom.org/c/erlang/osmo-s1gw/+/38241?usp=email ) Change subject: s1ap_proxy: handle E-RAB RELEASE INDICATION .. Patch Set 3: Code-Review+1 -- To view, visit https://gerrit.osmocom.org/c/erlang/osmo-s1gw/+/38241?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: erlang/osmo-s1gw Gerrit-Branch: master Gerrit-Change-Id: I13584620e28edf529325dc661c4b40d09acacc3f Gerrit-Change-Number: 38241 Gerrit-PatchSet: 3 Gerrit-Owner: fixeria Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: pespin Gerrit-Attention: fixeria Gerrit-Comment-Date: Fri, 20 Sep 2024 22:39:51 + Gerrit-HasComments: No Gerrit-Has-Labels: Yes
[L] Change in osmo-ttcn3-hacks[master]: library/PFCP_Emulation: a better PDU routing concept
Attention is currently required from: fixeria. pespin has posted comments on this change by fixeria. ( https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/38207?usp=email ) Change subject: library/PFCP_Emulation: a better PDU routing concept .. Patch Set 3: (1 comment) File hnbgw/HNBGW_Tests.ttcn: https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/38207/comment/6930122a_87f36493?usp=email : PS3, Line 1983: f_PFCPEM_unsubscribe_seid(c_SEID0); You have the same problem here. -- To view, visit https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/38207?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: osmo-ttcn3-hacks Gerrit-Branch: master Gerrit-Change-Id: I25802471519fa297ad4cb2b056adaa6748b00af2 Gerrit-Change-Number: 38207 Gerrit-PatchSet: 3 Gerrit-Owner: fixeria Gerrit-Reviewer: Jenkins Builder Gerrit-CC: pespin Gerrit-Attention: fixeria Gerrit-Comment-Date: Fri, 20 Sep 2024 22:32:48 + Gerrit-HasComments: Yes Gerrit-Has-Labels: No
[S] Change in ...osmo-s1gw[master]: s1ap_proxy_test: re-generate E-RAB RELEASE.{cmd,rsp} PDU blobs
Attention is currently required from: fixeria.
pespin has posted comments on this change by fixeria. (
https://gerrit.osmocom.org/c/erlang/osmo-s1gw/+/38240?usp=email )
Change subject: s1ap_proxy_test: re-generate E-RAB RELEASE.{cmd,rsp} PDU blobs
..
Patch Set 1: Code-Review+1
--
To view, visit https://gerrit.osmocom.org/c/erlang/osmo-s1gw/+/38240?usp=email
To unsubscribe, or for help writing mail filters, visit
https://gerrit.osmocom.org/settings?usp=email
Gerrit-MessageType: comment
Gerrit-Project: erlang/osmo-s1gw
Gerrit-Branch: master
Gerrit-Change-Id: I229c47148fd7408e44f1339ae2a2909f570c73ec
Gerrit-Change-Number: 38240
Gerrit-PatchSet: 1
Gerrit-Owner: fixeria
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: pespin
Gerrit-Attention: fixeria
Gerrit-Comment-Date: Fri, 20 Sep 2024 22:38:27 +
Gerrit-HasComments: No
Gerrit-Has-Labels: Yes
[XS] Change in osmo-ttcn3-hacks[master]: s1gw: f_ConnHdlr_erab_release_cmd(): add missing logging
Attention is currently required from: fixeria. pespin has posted comments on this change by fixeria. ( https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/38236?usp=email ) Change subject: s1gw: f_ConnHdlr_erab_release_cmd(): add missing logging .. Patch Set 1: Code-Review+1 -- To view, visit https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/38236?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: osmo-ttcn3-hacks Gerrit-Branch: master Gerrit-Change-Id: I6e4574ebda2459f0a5f23ee51a21a883d079c54a Gerrit-Change-Number: 38236 Gerrit-PatchSet: 1 Gerrit-Owner: fixeria Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: pespin Gerrit-Attention: fixeria Gerrit-Comment-Date: Fri, 20 Sep 2024 22:37:42 + Gerrit-HasComments: No Gerrit-Has-Labels: Yes
[XS] Change in osmo-ttcn3-hacks[master]: library/s1ap: fix wrong IE ID in E-RABReleaseListBearerRelComp
Attention is currently required from: fixeria. pespin has posted comments on this change by fixeria. ( https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/38237?usp=email ) Change subject: library/s1ap: fix wrong IE ID in E-RABReleaseListBearerRelComp .. Patch Set 1: Code-Review+1 -- To view, visit https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/38237?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: osmo-ttcn3-hacks Gerrit-Branch: master Gerrit-Change-Id: I22e80f418787c10ccd002e30a329c0271cdd1b8a Gerrit-Change-Number: 38237 Gerrit-PatchSet: 1 Gerrit-Owner: fixeria Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: pespin Gerrit-Attention: fixeria Gerrit-Comment-Date: Fri, 20 Sep 2024 22:37:28 + Gerrit-HasComments: No Gerrit-Has-Labels: Yes
[S] Change in osmo-ttcn3-hacks[master]: s1gw: TC_e_rab_setup: complete E-RAB release
Attention is currently required from: fixeria. pespin has posted comments on this change by fixeria. ( https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/38238?usp=email ) Change subject: s1gw: TC_e_rab_setup: complete E-RAB release .. Patch Set 2: Code-Review+1 -- To view, visit https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/38238?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: osmo-ttcn3-hacks Gerrit-Branch: master Gerrit-Change-Id: I856248d825b6ecf0635590b7bf02593cfae893d3 Gerrit-Change-Number: 38238 Gerrit-PatchSet: 2 Gerrit-Owner: fixeria Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: pespin Gerrit-Attention: fixeria Gerrit-Comment-Date: Fri, 20 Sep 2024 22:36:59 + Gerrit-HasComments: No Gerrit-Has-Labels: Yes
[M] Change in osmo-ttcn3-hacks[master]: s1gw: add TC_e_rab_release_ind
Attention is currently required from: fixeria. pespin has posted comments on this change by fixeria. ( https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/38217?usp=email ) Change subject: s1gw: add TC_e_rab_release_ind .. Patch Set 3: Code-Review+1 -- To view, visit https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/38217?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: osmo-ttcn3-hacks Gerrit-Branch: master Gerrit-Change-Id: Icc28a596b7646441761cc3f56653c5f7b3ddaaca Gerrit-Change-Number: 38217 Gerrit-PatchSet: 3 Gerrit-Owner: fixeria Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: pespin Gerrit-Attention: fixeria Gerrit-Comment-Date: Fri, 20 Sep 2024 22:35:14 + Gerrit-HasComments: No Gerrit-Has-Labels: Yes
[XS] Change in osmo-ttcn3-hacks[master]: .gitignore: ignore ctags
Attention is currently required from: fixeria. pespin has posted comments on this change by fixeria. ( https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/38234?usp=email ) Change subject: .gitignore: ignore ctags .. Patch Set 1: Code-Review+1 -- To view, visit https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/38234?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: osmo-ttcn3-hacks Gerrit-Branch: master Gerrit-Change-Id: I90f468049189d919aa0cbc3c1da1ac6f8422bc36 Gerrit-Change-Number: 38234 Gerrit-PatchSet: 1 Gerrit-Owner: fixeria Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: pespin Gerrit-Attention: fixeria Gerrit-Comment-Date: Fri, 20 Sep 2024 22:34:43 + Gerrit-HasComments: No Gerrit-Has-Labels: Yes
[XS] Change in osmo-ttcn3-hacks[master]: .gitignore: ignore '.make.*' files (like .make.deps)
Attention is currently required from: fixeria. pespin has posted comments on this change by fixeria. ( https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/38233?usp=email ) Change subject: .gitignore: ignore '.make.*' files (like .make.deps) .. Patch Set 1: Code-Review+1 -- To view, visit https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/38233?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: osmo-ttcn3-hacks Gerrit-Branch: master Gerrit-Change-Id: I79dfa38bc874a48cb09a6e6fb3f06405ba869491 Gerrit-Change-Number: 38233 Gerrit-PatchSet: 1 Gerrit-Owner: fixeria Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: pespin Gerrit-Attention: fixeria Gerrit-Comment-Date: Fri, 20 Sep 2024 22:34:33 + Gerrit-HasComments: No Gerrit-Has-Labels: Yes
[M] Change in osmo-ttcn3-hacks[master]: Remove dead links and generated code in bin/*
Attention is currently required from: fixeria. pespin has posted comments on this change by fixeria. ( https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/38235?usp=email ) Change subject: Remove dead links and generated code in bin/* .. Patch Set 1: Code-Review+1 -- To view, visit https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/38235?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: osmo-ttcn3-hacks Gerrit-Branch: master Gerrit-Change-Id: I60929c5d4acba4d0d8df3696fade370d7e0100f8 Gerrit-Change-Number: 38235 Gerrit-PatchSet: 1 Gerrit-Owner: fixeria Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: pespin Gerrit-Attention: fixeria Gerrit-Comment-Date: Fri, 20 Sep 2024 22:34:18 + Gerrit-HasComments: No Gerrit-Has-Labels: Yes
[S] Change in osmo-ttcn3-hacks[master]: s1gw: add f_ConnHdlrList_all_done()
Attention is currently required from: fixeria. pespin has posted comments on this change by fixeria. ( https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/38214?usp=email ) Change subject: s1gw: add f_ConnHdlrList_all_done() .. Patch Set 5: Code-Review+2 -- To view, visit https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/38214?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: osmo-ttcn3-hacks Gerrit-Branch: master Gerrit-Change-Id: I20c472dd8ce7f5a25c349cc079bd5bd873be2950 Gerrit-Change-Number: 38214 Gerrit-PatchSet: 5 Gerrit-Owner: fixeria Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: pespin Gerrit-Attention: fixeria Gerrit-Comment-Date: Fri, 20 Sep 2024 22:31:07 + Gerrit-HasComments: No Gerrit-Has-Labels: Yes
[M] Change in osmo-ttcn3-hacks[master]: s1gw: add multi-eNB variants of TC_e_rab_setup
Attention is currently required from: fixeria. pespin has posted comments on this change by fixeria. ( https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/38213?usp=email ) Change subject: s1gw: add multi-eNB variants of TC_e_rab_setup .. Patch Set 5: (1 comment) File s1gw/S1GW_Tests.ttcn: https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/38213/comment/f5df50db_818b2189?usp=email : PS4, Line 83: vc_mutex_disp := f_MutexDisp_start(); > What kind of additional complexity we're talking about? Spawning a component > that waits for messages […] Having more stuff startd and stopped running and logging into the logs files. It's just a matter of adding a boolean use_mutex := false above and check it here. -- To view, visit https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/38213?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: osmo-ttcn3-hacks Gerrit-Branch: master Gerrit-Change-Id: I9e2eb25a7ae78ff623b94802d881af4894d0cacd Gerrit-Change-Number: 38213 Gerrit-PatchSet: 5 Gerrit-Owner: fixeria Gerrit-Reviewer: Jenkins Builder Gerrit-CC: pespin Gerrit-Attention: fixeria Gerrit-Comment-Date: Fri, 20 Sep 2024 22:29:39 + Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: fixeria Comment-In-Reply-To: pespin
[XS] Change in osmo-ttcn3-hacks[master]: library: as_pfcp_ignore(): log SeqNr of received PDUs
Attention is currently required from: fixeria. pespin has posted comments on this change by fixeria. ( https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/38208?usp=email ) Change subject: library: as_pfcp_ignore(): log SeqNr of received PDUs .. Patch Set 2: Code-Review+1 -- To view, visit https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/38208?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: osmo-ttcn3-hacks Gerrit-Branch: master Gerrit-Change-Id: I803ff46def4ae0182310bc01e753fe0c05112836 Gerrit-Change-Number: 38208 Gerrit-PatchSet: 2 Gerrit-Owner: fixeria Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: laforge Gerrit-Reviewer: pespin Gerrit-Attention: fixeria Gerrit-Comment-Date: Fri, 20 Sep 2024 15:18:17 + Gerrit-HasComments: No Gerrit-Has-Labels: Yes
[XS] Change in osmo-ttcn3-hacks[master]: library: as_pfcp_ignore(): log SeqNr of received PDUs
Attention is currently required from: fixeria.
pespin has posted comments on this change by fixeria. (
https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/38208?usp=email )
Change subject: library: as_pfcp_ignore(): log SeqNr of received PDUs
..
Patch Set 2:
(1 comment)
File library/PFCP_Emulation.ttcn:
https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/38208/comment/0df3329c_dd38ca0f?usp=email
:
PS2, Line 398: log("Ignoring PFCP PDU (SeqNr := ",
pdu.sequence_number, ")");
> You can always get very detailed logging by enabling `TTCN_MATCHING`. […]
Yeah yeah, but then we end up every week during weekly meeting looking at Junit
output from jenkins with totally meaningless error reports.
This way at least you now quickly more or less which point in test it fails
without needing to dig into pcaps, ttcn3 log files, etc.
--
To view, visit https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/38208?usp=email
To unsubscribe, or for help writing mail filters, visit
https://gerrit.osmocom.org/settings?usp=email
Gerrit-MessageType: comment
Gerrit-Project: osmo-ttcn3-hacks
Gerrit-Branch: master
Gerrit-Change-Id: I803ff46def4ae0182310bc01e753fe0c05112836
Gerrit-Change-Number: 38208
Gerrit-PatchSet: 2
Gerrit-Owner: fixeria
Gerrit-Reviewer: Jenkins Builder
Gerrit-CC: pespin
Gerrit-Attention: fixeria
Gerrit-Comment-Date: Fri, 20 Sep 2024 14:26:37 +
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: fixeria
Comment-In-Reply-To: pespin
[L] Change in osmo-ttcn3-hacks[master]: library/PFCP_Emulation: a better PDU routing concept
Attention is currently required from: fixeria. pespin has posted comments on this change by fixeria. ( https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/38207?usp=email ) Change subject: library/PFCP_Emulation: a better PDU routing concept .. Patch Set 2: (1 comment) File hnbgw/HNBGW_Tests.ttcn: https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/38207/comment/642b934f_f20ee44b?usp=email : PS2, Line 1967: f_PFCPEM_subscribe_seid(c_SEID0); > (lines 1963..1967)? yes. > I don't expect to receive any PFCP PDUs at that moment at all. Yes, that's the point. You don't expect, but then if IUT misbehaves and sends one, you won't see it in the test since it will be discarded by the emulation :) Anyway, just mentioning since it can be quickly fixed, feel free to merge as is and modify later if you want. It also saves a few lines in each test. -- To view, visit https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/38207?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: osmo-ttcn3-hacks Gerrit-Branch: master Gerrit-Change-Id: I25802471519fa297ad4cb2b056adaa6748b00af2 Gerrit-Change-Number: 38207 Gerrit-PatchSet: 2 Gerrit-Owner: fixeria Gerrit-Reviewer: Jenkins Builder Gerrit-CC: pespin Gerrit-Attention: fixeria Gerrit-Comment-Date: Fri, 20 Sep 2024 14:25:17 + Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: fixeria Comment-In-Reply-To: pespin
[M] Change in osmo-ttcn3-hacks[master]: library: add generic Mutex API for parallel components
Attention is currently required from: fixeria, laforge.
pespin has posted comments on this change by fixeria. (
https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/38206?usp=email )
Change subject: library: add generic Mutex API for parallel components
..
Patch Set 2:
(1 comment)
File library/Mutex.ttcn:
https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/38206/comment/47ac92a8_0632c62d?usp=email
:
PS2, Line 19: port MutexPT LOCK; /* port for LOCKing the mutex */
> But why would you want to lock the Mutex twice? Is this a normal scenario?
Sure reentrant mutexes are a thing :) This is usually only needed in more
complex scenarios than what we aim here though.
This can be used for instance to implement semaphores, which eg. allow up to
N-concurrent users where N can be defined.
> Can you explain your idea a bit more?
Yes, you have 1 port which has LOCK and UNLOCK operations.
alt {
[lock_count == 0] pt.get_call(LOCK) -> sender {
lock_sender = sender;
lock_count++;
pt.send_response(sender, LOCK);
}
[lock_count > 0] pt.get_call(LOCK) -> sender {
if (lock_count > 0) {
if(and sender != lock_sender) {
error();
} else {
/* Make the component wait until mutex is unlocked: */
lock_queue := lock_queue & { sender };
return;
}
lock_sender = sender;
lock_count++;
pt.send_response(sender, LOCK);
}
[lock_count == 0] pt.get_call(UNLOCK) -> sender {
errror();
}
[lock_count > 0] pt.get_call(UNLOCK) -> sender {
if (sender != lock_sender)
error();
lock_count--;
pt.send_response(sender, UNLOCK);
if (lock_count == 0) {
if (lengthof(lock_queue) > 0)
sender := lock_queue[0]
//TODO: HERE pop lock_queue[0] from queue
/* Tell first component waiting in the queue that it
finally acquired the lock: */
pt.send_response(sender, LOCK);
lock_count++;
}
}
}
--
To view, visit https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/38206?usp=email
To unsubscribe, or for help writing mail filters, visit
https://gerrit.osmocom.org/settings?usp=email
Gerrit-MessageType: comment
Gerrit-Project: osmo-ttcn3-hacks
Gerrit-Branch: master
Gerrit-Change-Id: Id71f43bd5fc78d4bb4417d6c01fcff8112ea6032
Gerrit-Change-Number: 38206
Gerrit-PatchSet: 2
Gerrit-Owner: fixeria
Gerrit-Reviewer: Jenkins Builder
Gerrit-CC: laforge
Gerrit-CC: pespin
Gerrit-Attention: laforge
Gerrit-Attention: fixeria
Gerrit-Comment-Date: Fri, 20 Sep 2024 14:21:59 +
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: fixeria
Comment-In-Reply-To: pespin
[XS] Change in osmo-ci[master]: scripts: adjust to pyosmocom move to gerrit
Attention is currently required from: osmith. pespin has posted comments on this change by osmith. ( https://gerrit.osmocom.org/c/osmo-ci/+/38230?usp=email ) Change subject: scripts: adjust to pyosmocom move to gerrit .. Patch Set 1: Code-Review+1 -- To view, visit https://gerrit.osmocom.org/c/osmo-ci/+/38230?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: osmo-ci Gerrit-Branch: master Gerrit-Change-Id: I5ebbbd87c562e7bfa21792db0eadb556716ad252 Gerrit-Change-Number: 38230 Gerrit-PatchSet: 1 Gerrit-Owner: osmith Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: pespin Gerrit-Attention: osmith Gerrit-Comment-Date: Fri, 20 Sep 2024 13:41:52 + Gerrit-HasComments: No Gerrit-Has-Labels: Yes
[M] Change in osmo-ttcn3-hacks[master]: library: add generic Mutex API for parallel components
Attention is currently required from: fixeria. pespin has posted comments on this change by fixeria. ( https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/38206?usp=email ) Change subject: library: add generic Mutex API for parallel components .. Patch Set 2: (1 comment) File library/Mutex.ttcn: https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/38206/comment/83343dd3_1683c523?usp=email : PS2, Line 19: port MutexPT LOCK; /* port for LOCKing the mutex */ > Ah ok so you are using the port queue based on the the sender to > decide/filter whether to operate/wa […] Ah no erase what I said above. The mutex you are implementing here is no reentrant. If a component calls LOCK operation twice, it will deadlock/timeout. By implementing it they way I mention you then get a reentrant Mutex. But I guess your implementation is good enough for what we need here for now. -- To view, visit https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/38206?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: osmo-ttcn3-hacks Gerrit-Branch: master Gerrit-Change-Id: Id71f43bd5fc78d4bb4417d6c01fcff8112ea6032 Gerrit-Change-Number: 38206 Gerrit-PatchSet: 2 Gerrit-Owner: fixeria Gerrit-Reviewer: Jenkins Builder Gerrit-CC: laforge Gerrit-CC: pespin Gerrit-Attention: fixeria Gerrit-Comment-Date: Fri, 20 Sep 2024 13:41:25 + Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: pespin Comment-In-Reply-To: fixeria
[M] Change in osmo-ttcn3-hacks[master]: library: add generic Mutex API for parallel components
Attention is currently required from: fixeria. pespin has posted comments on this change by fixeria. ( https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/38206?usp=email ) Change subject: library: add generic Mutex API for parallel components .. Patch Set 2: (1 comment) File library/Mutex.ttcn: https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/38206/comment/a508af9d_a43d1321?usp=email : PS2, Line 19: port MutexPT LOCK; /* port for LOCKing the mutex */ > The point is that multiple parallel components are sending `MUTEX_LOCK` > requests and they're getting […] Ah ok so you are using the port queue based on the the sender to decide/filter whether to operate/wait for the lock operator. I'd have done that with 1 port and then maintaining a queue of vc_conn lock operations internally in the component, but fine your way too then. Waiting for feedback to Harald's comment to provide +1. -- To view, visit https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/38206?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: osmo-ttcn3-hacks Gerrit-Branch: master Gerrit-Change-Id: Id71f43bd5fc78d4bb4417d6c01fcff8112ea6032 Gerrit-Change-Number: 38206 Gerrit-PatchSet: 2 Gerrit-Owner: fixeria Gerrit-Reviewer: Jenkins Builder Gerrit-CC: laforge Gerrit-CC: pespin Gerrit-Attention: fixeria Gerrit-Comment-Date: Fri, 20 Sep 2024 13:37:26 + Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: fixeria Comment-In-Reply-To: pespin
[XS] Change in libosmocore[master]: iuup.c: Add more relevant spec references to the file
pespin has uploaded this change for review. ( https://gerrit.osmocom.org/c/libosmocore/+/38229?usp=email ) Change subject: iuup.c: Add more relevant spec references to the file .. iuup.c: Add more relevant spec references to the file Those are specs which are usually of interested for somebody opening the iuup.c and iuup.h files in order to work on Tx/Rx/forward of IuUP frames eg. on top of RTP. Change-Id: I0cf70e84def2162c3c8621cdbbd8632b25276d70 --- M src/gsm/iuup.c 1 file changed, 5 insertions(+), 1 deletion(-) git pull ssh://gerrit.osmocom.org:29418/libosmocore refs/changes/29/38229/1 diff --git a/src/gsm/iuup.c b/src/gsm/iuup.c index 16a6f5e..4991213 100644 --- a/src/gsm/iuup.c +++ b/src/gsm/iuup.c @@ -1,5 +1,9 @@ /*! \file iu_up.c - * IuUP (Iu User Plane) according to 3GPP TS 25.415 */ + * IuUP (Iu User Plane) according to 3GPP TS 25.415 + * See also 3GPP TS 25.414 regarding data transport. + * See also 3GPP TS 29.414 and 3GPP TS 29.415 regarding Nb counterparts + * of the above specs. + */ /* * (C) 2017 by Harald Welte * -- To view, visit https://gerrit.osmocom.org/c/libosmocore/+/38229?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: newchange Gerrit-Project: libosmocore Gerrit-Branch: master Gerrit-Change-Id: I0cf70e84def2162c3c8621cdbbd8632b25276d70 Gerrit-Change-Number: 38229 Gerrit-PatchSet: 1 Gerrit-Owner: pespin
[S] Change in osmo-ttcn3-hacks[master]: deps: make output readable
Attention is currently required from: osmith. pespin has posted comments on this change by osmith. ( https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/38221?usp=email ) Change subject: deps: make output readable .. Patch Set 3: Code-Review+1 -- To view, visit https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/38221?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: osmo-ttcn3-hacks Gerrit-Branch: master Gerrit-Change-Id: I0231488b02fdb5aa19b864e51864682ebbb3b0c6 Gerrit-Change-Number: 38221 Gerrit-PatchSet: 3 Gerrit-Owner: osmith Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: pespin Gerrit-Attention: osmith Gerrit-Comment-Date: Fri, 20 Sep 2024 11:56:56 + Gerrit-HasComments: No Gerrit-Has-Labels: Yes
[XS] Change in osmo-ci[master]: jobs/gerrit: osmo-ttcn3-hacks: drop chown
Attention is currently required from: osmith. pespin has posted comments on this change by osmith. ( https://gerrit.osmocom.org/c/osmo-ci/+/38228?usp=email ) Change subject: jobs/gerrit: osmo-ttcn3-hacks: drop chown .. Patch Set 1: Code-Review+1 -- To view, visit https://gerrit.osmocom.org/c/osmo-ci/+/38228?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: osmo-ci Gerrit-Branch: master Gerrit-Change-Id: I4bea336097e8180b19b3afa41c0b984d93c21bd1 Gerrit-Change-Number: 38228 Gerrit-PatchSet: 1 Gerrit-Owner: osmith Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: pespin Gerrit-Attention: osmith Gerrit-Comment-Date: Fri, 20 Sep 2024 11:56:30 + Gerrit-HasComments: No Gerrit-Has-Labels: Yes
[XS] Change in docker-playground[master]: debian-bookworm-titan: chown 1000 for deps
Attention is currently required from: osmith. pespin has posted comments on this change by osmith. ( https://gerrit.osmocom.org/c/docker-playground/+/38227?usp=email ) Change subject: debian-bookworm-titan: chown 1000 for deps .. Patch Set 1: (1 comment) File debian-bookworm-titan/Dockerfile: https://gerrit.osmocom.org/c/docker-playground/+/38227/comment/8a00f19a_da570e68?usp=email : PS1, Line 82: chown -R 1000:1000 /osmo-ttcn3-hacks/deps I think a comment here (or above) explaining why this line is needed here would be welcome (ie. explain Dockerfiles inheriting this one will need access to the files.) -- To view, visit https://gerrit.osmocom.org/c/docker-playground/+/38227?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: docker-playground Gerrit-Branch: master Gerrit-Change-Id: Id51885d0929f4966b1a4a181b3453c06d7956b53 Gerrit-Change-Number: 38227 Gerrit-PatchSet: 1 Gerrit-Owner: osmith Gerrit-Reviewer: Jenkins Builder Gerrit-CC: pespin Gerrit-Attention: osmith Gerrit-Comment-Date: Fri, 20 Sep 2024 11:56:08 + Gerrit-HasComments: Yes Gerrit-Has-Labels: No
[S] Change in osmo-ci[master]: jobs/gerrit: osmo-ttcn3-hacks: tweak make lines
Attention is currently required from: osmith. pespin has posted comments on this change by osmith. ( https://gerrit.osmocom.org/c/osmo-ci/+/38225?usp=email ) Change subject: jobs/gerrit: osmo-ttcn3-hacks: tweak make lines .. Patch Set 1: Code-Review+1 -- To view, visit https://gerrit.osmocom.org/c/osmo-ci/+/38225?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: osmo-ci Gerrit-Branch: master Gerrit-Change-Id: Iac179bfb26478ecab51f47e469b4be7b0f9a5a94 Gerrit-Change-Number: 38225 Gerrit-PatchSet: 1 Gerrit-Owner: osmith Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: pespin Gerrit-Attention: osmith Gerrit-Comment-Date: Fri, 20 Sep 2024 11:25:57 + Gerrit-HasComments: No Gerrit-Has-Labels: Yes
[XS] Change in osmo-ci[master]: jobs/gerrit: use deps cache from docker image
Attention is currently required from: osmith. pespin has posted comments on this change by osmith. ( https://gerrit.osmocom.org/c/osmo-ci/+/38226?usp=email ) Change subject: jobs/gerrit: use deps cache from docker image .. Patch Set 1: Code-Review+1 -- To view, visit https://gerrit.osmocom.org/c/osmo-ci/+/38226?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: osmo-ci Gerrit-Branch: master Gerrit-Change-Id: I895011edf49f612d0df7f4759dc374bab60c32a6 Gerrit-Change-Number: 38226 Gerrit-PatchSet: 1 Gerrit-Owner: osmith Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: pespin Gerrit-Attention: osmith Gerrit-Comment-Date: Fri, 20 Sep 2024 11:26:54 + Gerrit-HasComments: No Gerrit-Has-Labels: Yes
[XS] Change in osmo-ttcn3-hacks[master]: deps/update: skip checkout if nothing to do
Attention is currently required from: osmith. pespin has posted comments on this change by osmith. ( https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/38222?usp=email ) Change subject: deps/update: skip checkout if nothing to do .. Patch Set 1: Code-Review+1 -- To view, visit https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/38222?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: osmo-ttcn3-hacks Gerrit-Branch: master Gerrit-Change-Id: I572ab11afd56e34d9d0d04cd1372af749caa7d48 Gerrit-Change-Number: 38222 Gerrit-PatchSet: 1 Gerrit-Owner: osmith Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: pespin Gerrit-Attention: osmith Gerrit-Comment-Date: Fri, 20 Sep 2024 10:36:18 + Gerrit-HasComments: No Gerrit-Has-Labels: Yes
[S] Change in osmo-ttcn3-hacks[master]: deps: make output readable
Attention is currently required from: osmith. pespin has posted comments on this change by osmith. ( https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/38221?usp=email ) Change subject: deps: make output readable .. Patch Set 1: Code-Review+1 -- To view, visit https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/38221?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: osmo-ttcn3-hacks Gerrit-Branch: master Gerrit-Change-Id: I0231488b02fdb5aa19b864e51864682ebbb3b0c6 Gerrit-Change-Number: 38221 Gerrit-PatchSet: 1 Gerrit-Owner: osmith Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: pespin Gerrit-Attention: osmith Gerrit-Comment-Date: Fri, 20 Sep 2024 10:35:52 + Gerrit-HasComments: No Gerrit-Has-Labels: Yes
[XS] Change in osmo-ttcn3-hacks[master]: deps/update: don't fetch repos where COMMIT exists
Attention is currently required from: osmith. pespin has posted comments on this change by osmith. ( https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/38220?usp=email ) Change subject: deps/update: don't fetch repos where COMMIT exists .. Patch Set 1: Code-Review+1 -- To view, visit https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/38220?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: osmo-ttcn3-hacks Gerrit-Branch: master Gerrit-Change-Id: I342957668892e7d29666fada82362cb4a6c7aac5 Gerrit-Change-Number: 38220 Gerrit-PatchSet: 1 Gerrit-Owner: osmith Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: pespin Gerrit-Attention: osmith Gerrit-Comment-Date: Fri, 20 Sep 2024 10:35:13 + Gerrit-HasComments: No Gerrit-Has-Labels: Yes
[S] Change in osmo-ttcn3-hacks[master]: deps/update.sh: split update cmds from Makefile
Attention is currently required from: osmith. pespin has posted comments on this change by osmith. ( https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/38219?usp=email ) Change subject: deps/update.sh: split update cmds from Makefile .. Patch Set 1: Code-Review+1 -- To view, visit https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/38219?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: osmo-ttcn3-hacks Gerrit-Branch: master Gerrit-Change-Id: Ifab1158000ccb39f0b384bbd81841e417ed24f37 Gerrit-Change-Number: 38219 Gerrit-PatchSet: 1 Gerrit-Owner: osmith Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: pespin Gerrit-Attention: osmith Gerrit-Comment-Date: Fri, 20 Sep 2024 10:34:52 + Gerrit-HasComments: No Gerrit-Has-Labels: Yes
[S] Change in ...osmo-s1gw[master]: pfcp_peer: do not assign SEID=0, increment properly
Attention is currently required from: fixeria. pespin has posted comments on this change by fixeria. ( https://gerrit.osmocom.org/c/erlang/osmo-s1gw/+/38215?usp=email ) Change subject: pfcp_peer: do not assign SEID=0, increment properly .. Patch Set 1: Code-Review+1 -- To view, visit https://gerrit.osmocom.org/c/erlang/osmo-s1gw/+/38215?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: erlang/osmo-s1gw Gerrit-Branch: master Gerrit-Change-Id: I76b921047784e727d67cd6c6a5aeb6d827b65e56 Gerrit-Change-Number: 38215 Gerrit-PatchSet: 1 Gerrit-Owner: fixeria Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: pespin Gerrit-Attention: fixeria Gerrit-Comment-Date: Fri, 20 Sep 2024 10:33:36 + Gerrit-HasComments: No Gerrit-Has-Labels: Yes
[M] Change in osmo-ttcn3-hacks[master]: s1gw: add TC_e_rab_release_ind
Attention is currently required from: fixeria. pespin has posted comments on this change by fixeria. ( https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/38217?usp=email ) Change subject: s1gw: add TC_e_rab_release_ind .. Patch Set 1: Code-Review+1 -- To view, visit https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/38217?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: osmo-ttcn3-hacks Gerrit-Branch: master Gerrit-Change-Id: Icc28a596b7646441761cc3f56653c5f7b3ddaaca Gerrit-Change-Number: 38217 Gerrit-PatchSet: 1 Gerrit-Owner: fixeria Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: pespin Gerrit-Attention: fixeria Gerrit-Comment-Date: Fri, 20 Sep 2024 10:32:16 + Gerrit-HasComments: No Gerrit-Has-Labels: Yes
[XS] Change in osmo-ttcn3-hacks[master]: s1gw: f_ConnHdlr_rx_erab_release_cmd(): fix wrong template
Attention is currently required from: fixeria. pespin has posted comments on this change by fixeria. ( https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/38216?usp=email ) Change subject: s1gw: f_ConnHdlr_rx_erab_release_cmd(): fix wrong template .. Patch Set 1: Code-Review+2 -- To view, visit https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/38216?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: osmo-ttcn3-hacks Gerrit-Branch: master Gerrit-Change-Id: Ib6b9f346216aaa9587025e1c580876611e6fa7bc Gerrit-Change-Number: 38216 Gerrit-PatchSet: 1 Gerrit-Owner: fixeria Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: pespin Gerrit-Attention: fixeria Gerrit-Comment-Date: Fri, 20 Sep 2024 10:31:38 + Gerrit-HasComments: No Gerrit-Has-Labels: Yes
[S] Change in osmo-ttcn3-hacks[master]: s1gw: add f_ConnHdlrList_done()
Attention is currently required from: fixeria. pespin has posted comments on this change by fixeria. ( https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/38214?usp=email ) Change subject: s1gw: add f_ConnHdlrList_done() .. Patch Set 4: Code-Review+1 (1 comment) File s1gw/S1GW_Tests.ttcn: https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/38214/comment/3c3e1de5_030efa23?usp=email : PS4, Line 192: function f_ConnHdlrList_done(in ConnHdlrList vc_conns) maybe "..._all_done" would be more informative. -- To view, visit https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/38214?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: osmo-ttcn3-hacks Gerrit-Branch: master Gerrit-Change-Id: I20c472dd8ce7f5a25c349cc079bd5bd873be2950 Gerrit-Change-Number: 38214 Gerrit-PatchSet: 4 Gerrit-Owner: fixeria Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: pespin Gerrit-Attention: fixeria Gerrit-Comment-Date: Fri, 20 Sep 2024 10:31:22 + Gerrit-HasComments: Yes Gerrit-Has-Labels: Yes
[M] Change in osmo-ttcn3-hacks[master]: s1gw: add multi-eNB variants of TC_e_rab_setup
Attention is currently required from: fixeria. pespin has posted comments on this change by fixeria. ( https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/38213?usp=email ) Change subject: s1gw: add multi-eNB variants of TC_e_rab_setup .. Patch Set 4: (1 comment) File s1gw/S1GW_Tests.ttcn: https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/38213/comment/2fa1eed0_92f6ac51?usp=email : PS4, Line 83: vc_mutex_disp := f_MutexDisp_start(); This is only needed in few tests, it probably makes sense to do it conditionally, to avoid adding complexity to lots of tests which don't need it. -- To view, visit https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/38213?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: osmo-ttcn3-hacks Gerrit-Branch: master Gerrit-Change-Id: I9e2eb25a7ae78ff623b94802d881af4894d0cacd Gerrit-Change-Number: 38213 Gerrit-PatchSet: 4 Gerrit-Owner: fixeria Gerrit-Reviewer: Jenkins Builder Gerrit-CC: pespin Gerrit-Attention: fixeria Gerrit-Comment-Date: Fri, 20 Sep 2024 10:30:44 + Gerrit-HasComments: Yes Gerrit-Has-Labels: No
[S] Change in osmo-ttcn3-hacks[master]: s1gw: move PFCP association handling into a dedicated ConnHdlr
Attention is currently required from: fixeria. pespin has posted comments on this change by fixeria. ( https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/38212?usp=email ) Change subject: s1gw: move PFCP association handling into a dedicated ConnHdlr .. Patch Set 3: Code-Review+1 -- To view, visit https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/38212?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: osmo-ttcn3-hacks Gerrit-Branch: master Gerrit-Change-Id: I5e1a14105a35b785bf598dc2a8c436ea6fb6b0f1 Gerrit-Change-Number: 38212 Gerrit-PatchSet: 3 Gerrit-Owner: fixeria Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: pespin Gerrit-Attention: fixeria Gerrit-Comment-Date: Fri, 20 Sep 2024 10:27:46 + Gerrit-HasComments: No Gerrit-Has-Labels: Yes
[XS] Change in osmo-ttcn3-hacks[master]: Revert "s1gw: cache PFCP Recovery Timestamp in ConnHdlr"
Attention is currently required from: fixeria. pespin has posted comments on this change by fixeria. ( https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/38211?usp=email ) Change subject: Revert "s1gw: cache PFCP Recovery Timestamp in ConnHdlr" .. Patch Set 2: Code-Review+1 -- To view, visit https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/38211?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: osmo-ttcn3-hacks Gerrit-Branch: master Gerrit-Change-Id: I3b1c488e3ec251c7659cd9bc3197cca2f9d03144 Gerrit-Change-Number: 38211 Gerrit-PatchSet: 2 Gerrit-Owner: fixeria Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: pespin Gerrit-Attention: fixeria Gerrit-Comment-Date: Fri, 20 Sep 2024 10:25:22 + Gerrit-HasComments: No Gerrit-Has-Labels: Yes
[S] Change in osmo-ttcn3-hacks[master]: s1gw: make number of eNBs configurable via module params
Attention is currently required from: fixeria. pespin has posted comments on this change by fixeria. ( https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/38210?usp=email ) Change subject: s1gw: make number of eNBs configurable via module params .. Patch Set 2: (1 comment) File s1gw/S1GW_Tests.ttcn: https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/38210/comment/1e6e480c_9a1db23d?usp=email : PS2, Line 226: vc_conns[i] := f_ConnHdlr_spawn(refers(f_TC_setup_multi), pars); Does this work with a List? Sounds weird, given that you could have a lengthof(vc_conns)==4 and then do vc_conns[4543] = ... -- To view, visit https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/38210?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: osmo-ttcn3-hacks Gerrit-Branch: master Gerrit-Change-Id: Ia80b9118e66a5d6721b89d3ba068227d30dcc01f Gerrit-Change-Number: 38210 Gerrit-PatchSet: 2 Gerrit-Owner: fixeria Gerrit-Reviewer: Jenkins Builder Gerrit-CC: pespin Gerrit-Attention: fixeria Gerrit-Comment-Date: Fri, 20 Sep 2024 10:24:59 + Gerrit-HasComments: Yes Gerrit-Has-Labels: No
[XS] Change in osmo-ttcn3-hacks[master]: s1gw: f_init_pfcp(): use 'PFCPEM' as the prefix
Attention is currently required from: fixeria. pespin has posted comments on this change by fixeria. ( https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/38209?usp=email ) Change subject: s1gw: f_init_pfcp(): use 'PFCPEM' as the prefix .. Patch Set 2: Code-Review+2 -- To view, visit https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/38209?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: osmo-ttcn3-hacks Gerrit-Branch: master Gerrit-Change-Id: Ia5413313cffb265f83ea0850e31dfb35274c28ba Gerrit-Change-Number: 38209 Gerrit-PatchSet: 2 Gerrit-Owner: fixeria Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: pespin Gerrit-Attention: fixeria Gerrit-Comment-Date: Fri, 20 Sep 2024 10:23:18 + Gerrit-HasComments: No Gerrit-Has-Labels: Yes
[XS] Change in osmo-ttcn3-hacks[master]: library: as_pfcp_ignore(): log SeqNr of received PDUs
Attention is currently required from: fixeria.
pespin has posted comments on this change by fixeria. (
https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/38208?usp=email )
Change subject: library: as_pfcp_ignore(): log SeqNr of received PDUs
..
Patch Set 2:
(1 comment)
File library/PFCP_Emulation.ttcn:
https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/38208/comment/b583ec90_513bbf5e?usp=email
:
PS2, Line 398: log("Ignoring PFCP PDU (SeqNr := ",
pdu.sequence_number, ")");
I'd say printing pfcp_expect *and* seq number may be more informative.
--
To view, visit https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/38208?usp=email
To unsubscribe, or for help writing mail filters, visit
https://gerrit.osmocom.org/settings?usp=email
Gerrit-MessageType: comment
Gerrit-Project: osmo-ttcn3-hacks
Gerrit-Branch: master
Gerrit-Change-Id: I803ff46def4ae0182310bc01e753fe0c05112836
Gerrit-Change-Number: 38208
Gerrit-PatchSet: 2
Gerrit-Owner: fixeria
Gerrit-Reviewer: Jenkins Builder
Gerrit-CC: pespin
Gerrit-Attention: fixeria
Gerrit-Comment-Date: Fri, 20 Sep 2024 10:23:06 +
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
[L] Change in osmo-ttcn3-hacks[master]: library/PFCP_Emulation: a better PDU routing concept
Attention is currently required from: fixeria. pespin has posted comments on this change by fixeria. ( https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/38207?usp=email ) Change subject: library/PFCP_Emulation: a better PDU routing concept .. Patch Set 2: (1 comment) File hnbgw/HNBGW_Tests.ttcn: https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/38207/comment/d644255f_68763dda?usp=email : PS2, Line 1967: f_PFCPEM_subscribe_seid(c_SEID0); I'd probably make sense to have internally in this API a field in the message "boolean unsubscribe_bcast" which by default would be false and if set to true, would to the 2 things atomically. Otherwise there may be race conditions in between the 2 where you lose messages. -- To view, visit https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/38207?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: osmo-ttcn3-hacks Gerrit-Branch: master Gerrit-Change-Id: I25802471519fa297ad4cb2b056adaa6748b00af2 Gerrit-Change-Number: 38207 Gerrit-PatchSet: 2 Gerrit-Owner: fixeria Gerrit-Reviewer: Jenkins Builder Gerrit-CC: pespin Gerrit-Attention: fixeria Gerrit-Comment-Date: Fri, 20 Sep 2024 10:21:39 + Gerrit-HasComments: Yes Gerrit-Has-Labels: No
[M] Change in osmo-ttcn3-hacks[master]: library: add generic Mutex API for parallel components
Attention is currently required from: fixeria. pespin has posted comments on this change by fixeria. ( https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/38206?usp=email ) Change subject: library: add generic Mutex API for parallel components .. Patch Set 2: (1 comment) File library/Mutex.ttcn: https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/38206/comment/c98fd202_d350fc42?usp=email : PS2, Line 19: port MutexPT LOCK; /* port for LOCKing the mutex */ What's the point in having 2 ports instead of 1? Sounds way more complex than it should by doing so, with more race scenarios to think about, more difficult to debug, etc. -- To view, visit https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/38206?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: osmo-ttcn3-hacks Gerrit-Branch: master Gerrit-Change-Id: Id71f43bd5fc78d4bb4417d6c01fcff8112ea6032 Gerrit-Change-Number: 38206 Gerrit-PatchSet: 2 Gerrit-Owner: fixeria Gerrit-Reviewer: Jenkins Builder Gerrit-CC: pespin Gerrit-Attention: fixeria Gerrit-Comment-Date: Fri, 20 Sep 2024 10:18:25 + Gerrit-HasComments: Yes Gerrit-Has-Labels: No
[S] Change in osmo-msc[master]: Remove speech codec list from bearer_cap for phase 1 mobile station
Attention is currently required from: jolly, neels, nt2mku. pespin has posted comments on this change by jolly. ( https://gerrit.osmocom.org/c/osmo-msc/+/38197?usp=email ) Change subject: Remove speech codec list from bearer_cap for phase 1 mobile station .. Patch Set 1: (8 comments) File src/libmsc/gsm_04_08_cc.c: https://gerrit.osmocom.org/c/osmo-msc/+/38197/comment/8d2c09cf_0f3c80c0?usp=email : PS1, Line 929: /* Remove codecs in bearer_cap that are unsupported by phase 1 mobile stations. It probably makes sense to move this to a helper function, eg bearer_cap_filter_rev_lev(sutrct gsm_mncc_bearer_cap *bearer_cap, unsigned rev_len); https://gerrit.osmocom.org/c/osmo-msc/+/38197/comment/58108fe0_9e5d3c8d?usp=email : PS1, Line 990: /* Speech codec list (oictets 3a ect.) must not be sent to phase 1 mobile stations. octets https://gerrit.osmocom.org/c/osmo-msc/+/38197/comment/851005b8_8b6e2404?usp=email : PS1, Line 992: if (trans->vsub->classmark.classmark1.rev_lev == 0) I guess you could do this in the GSM48_BCAP_ITCAP_SPEECH code path above? https://gerrit.osmocom.org/c/osmo-msc/+/38197/comment/e7bd8c28_e8d4e767?usp=email : PS1, Line 1158: /* Speech codec list (oictets 3a ect.) must not be sent to phase 1 mobile stations. octets https://gerrit.osmocom.org/c/osmo-msc/+/38197/comment/85b6308d_0c6a655a?usp=email : PS1, Line 1878: /* Speech codec list (oictets 3a ect.) must not be sent to phase 1 mobile stations. octets https://gerrit.osmocom.org/c/osmo-msc/+/38197/comment/be1dd5a7_f750d7c7?usp=email : PS1, Line 1930: /* Speech codec list (oictets 3a ect.) must not be sent to phase 1 mobile stations. octets https://gerrit.osmocom.org/c/osmo-msc/+/38197/comment/3eeed32e_c0886c4f?usp=email : PS1, Line 1988: /* Speech codec list (oictets 3a ect.) must not be sent to phase 1 mobile stations. octets https://gerrit.osmocom.org/c/osmo-msc/+/38197/comment/262c1abf_059b30de?usp=email : PS1, Line 1991: modify->bearer_cap.speech_ver[0] = -1; I see this being done in lots of places, it may make sense to move the logic to a helper function to have it once so it can easily be identified when this logic is used. -- To view, visit https://gerrit.osmocom.org/c/osmo-msc/+/38197?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: osmo-msc Gerrit-Branch: master Gerrit-Change-Id: Idd267dad0ade18cee7d5be813a57e1ee3168e2db Gerrit-Change-Number: 38197 Gerrit-PatchSet: 1 Gerrit-Owner: jolly Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: neels Gerrit-Reviewer: nt2mku Gerrit-CC: pespin Gerrit-Attention: jolly Gerrit-Attention: neels Gerrit-Attention: nt2mku Gerrit-Comment-Date: Wed, 18 Sep 2024 13:34:12 + Gerrit-HasComments: Yes Gerrit-Has-Labels: No
[XS] Change in pysim[master]: filesystem, cosmetic: remove excess whitespace
Attention is currently required from: dexter. pespin has posted comments on this change by dexter. ( https://gerrit.osmocom.org/c/pysim/+/38196?usp=email ) Change subject: filesystem, cosmetic: remove excess whitespace .. Patch Set 1: Code-Review+2 -- To view, visit https://gerrit.osmocom.org/c/pysim/+/38196?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: pysim Gerrit-Branch: master Gerrit-Change-Id: I902670590ae75a5d197616ae37d8268a60125121 Gerrit-Change-Number: 38196 Gerrit-PatchSet: 1 Gerrit-Owner: dexter Gerrit-Reviewer: pespin Gerrit-CC: Jenkins Builder Gerrit-Attention: dexter Gerrit-Comment-Date: Wed, 18 Sep 2024 09:55:33 + Gerrit-HasComments: No Gerrit-Has-Labels: Yes
[XS] Change in osmo-ci[master]: jobs/osmo-gsm-tester_gerrit: disable
Attention is currently required from: osmith. pespin has posted comments on this change by osmith. ( https://gerrit.osmocom.org/c/osmo-ci/+/38190?usp=email ) Change subject: jobs/osmo-gsm-tester_gerrit: disable .. Patch Set 1: Code-Review+1 -- To view, visit https://gerrit.osmocom.org/c/osmo-ci/+/38190?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: osmo-ci Gerrit-Branch: master Gerrit-Change-Id: Idf5dd17ca24e9589ef9175de42b5102c79285a7d Gerrit-Change-Number: 38190 Gerrit-PatchSet: 1 Gerrit-Owner: osmith Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: pespin Gerrit-Attention: osmith Gerrit-Comment-Date: Tue, 17 Sep 2024 14:25:48 + Gerrit-HasComments: No Gerrit-Has-Labels: Yes
[S] Change in osmo-ci[master]: jobs/osmo-gsm-tester-runner: fix syntax errors
Attention is currently required from: osmith. pespin has posted comments on this change by osmith. ( https://gerrit.osmocom.org/c/osmo-ci/+/38188?usp=email ) Change subject: jobs/osmo-gsm-tester-runner: fix syntax errors .. Patch Set 1: Code-Review+1 -- To view, visit https://gerrit.osmocom.org/c/osmo-ci/+/38188?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: osmo-ci Gerrit-Branch: master Gerrit-Change-Id: I5401d75ac40b8267b59443792079249f00b02111 Gerrit-Change-Number: 38188 Gerrit-PatchSet: 1 Gerrit-Owner: osmith Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: pespin Gerrit-Attention: osmith Gerrit-Comment-Date: Tue, 17 Sep 2024 14:25:16 + Gerrit-HasComments: No Gerrit-Has-Labels: Yes
[XS] Change in osmo-ci[master]: jobs/osmo-gsm-tester-runner: include-raw -> include-raw-expand
Attention is currently required from: osmith. pespin has posted comments on this change by osmith. ( https://gerrit.osmocom.org/c/osmo-ci/+/38189?usp=email ) Change subject: jobs/osmo-gsm-tester-runner: include-raw -> include-raw-expand .. Patch Set 1: Code-Review+1 -- To view, visit https://gerrit.osmocom.org/c/osmo-ci/+/38189?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: osmo-ci Gerrit-Branch: master Gerrit-Change-Id: Ieceeb87fea88fb5f9591153d424cd25569763a31 Gerrit-Change-Number: 38189 Gerrit-PatchSet: 1 Gerrit-Owner: osmith Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: pespin Gerrit-Attention: osmith Gerrit-Comment-Date: Tue, 17 Sep 2024 14:25:31 + Gerrit-HasComments: No Gerrit-Has-Labels: Yes
[M] Change in osmo-ttcn3-hacks[master]: testenv: get coredump + backtrace on crash
Attention is currently required from: osmith. pespin has posted comments on this change by osmith. ( https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/38185?usp=email ) Change subject: testenv: get coredump + backtrace on crash .. Patch Set 1: Code-Review+2 (1 comment) Patchset: PS1: <3 -- To view, visit https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/38185?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: osmo-ttcn3-hacks Gerrit-Branch: master Gerrit-Change-Id: I743c20968bda9b6d6fb9c2d23bef70ee11950761 Gerrit-Change-Number: 38185 Gerrit-PatchSet: 1 Gerrit-Owner: osmith Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: pespin Gerrit-Attention: osmith Gerrit-Comment-Date: Tue, 17 Sep 2024 13:47:58 + Gerrit-HasComments: Yes Gerrit-Has-Labels: Yes
[S] Change in libosmo-abis[master]: trau2rtp EFR unit test: add patterns with bad CRC
Attention is currently required from: falconia. pespin has posted comments on this change by falconia. ( https://gerrit.osmocom.org/c/libosmo-abis/+/38184?usp=email ) Change subject: trau2rtp EFR unit test: add patterns with bad CRC .. Patch Set 1: Code-Review+1 -- To view, visit https://gerrit.osmocom.org/c/libosmo-abis/+/38184?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: libosmo-abis Gerrit-Branch: master Gerrit-Change-Id: Iee69b6a1593bdc8d11904a5f2ad46cd0fc6052a9 Gerrit-Change-Number: 38184 Gerrit-PatchSet: 1 Gerrit-Owner: falconia Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: pespin Gerrit-Attention: falconia Gerrit-Comment-Date: Tue, 17 Sep 2024 11:48:36 + Gerrit-HasComments: No Gerrit-Has-Labels: Yes
[M] Change in libosmo-abis[master]: trau2rtp unit test: add patterns that showcase BFI=1 SID=0
Attention is currently required from: falconia. pespin has posted comments on this change by falconia. ( https://gerrit.osmocom.org/c/libosmo-abis/+/38183?usp=email ) Change subject: trau2rtp unit test: add patterns that showcase BFI=1 SID=0 .. Patch Set 1: Code-Review+1 -- To view, visit https://gerrit.osmocom.org/c/libosmo-abis/+/38183?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: libosmo-abis Gerrit-Branch: master Gerrit-Change-Id: Ic6a0ad289864fe3e11192d158e3bbe221994eaaa Gerrit-Change-Number: 38183 Gerrit-PatchSet: 1 Gerrit-Owner: falconia Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: pespin Gerrit-Attention: falconia Gerrit-Comment-Date: Mon, 16 Sep 2024 22:02:53 + Gerrit-HasComments: No Gerrit-Has-Labels: Yes
[M] Change in libosmo-abis[master]: trau2rtp TW-TS-001: handle corner case of BFI with stale SID bits
Attention is currently required from: falconia. pespin has posted comments on this change by falconia. ( https://gerrit.osmocom.org/c/libosmo-abis/+/38182?usp=email ) Change subject: trau2rtp TW-TS-001: handle corner case of BFI with stale SID bits .. Patch Set 1: Code-Review+1 -- To view, visit https://gerrit.osmocom.org/c/libosmo-abis/+/38182?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: libosmo-abis Gerrit-Branch: master Gerrit-Change-Id: I2800301f7ac25537c4d7fb14acefd73a80590d7c Gerrit-Change-Number: 38182 Gerrit-PatchSet: 1 Gerrit-Owner: falconia Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: pespin Gerrit-Attention: falconia Gerrit-Comment-Date: Mon, 16 Sep 2024 22:01:34 + Gerrit-HasComments: No Gerrit-Has-Labels: Yes
[S] Change in osmo-ttcn3-hacks[master]: asterisk: TC_ims_reregistration: Expect re-register using existing ip...
pespin has submitted this change. (
https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/38179?usp=email )
Change subject: asterisk: TC_ims_reregistration: Expect re-register using
existing ipsec ctx
..
asterisk: TC_ims_reregistration: Expect re-register using existing ipsec ctx
Change-Id: I8d100dbba6cddfa5f31437c9cdc8c48f1bbd5701
---
M asterisk/Asterisk_Tests.ttcn
M asterisk/IMS_ConnectionHandler.ttcn
2 files changed, 13 insertions(+), 13 deletions(-)
Approvals:
jolly: Looks good to me, but someone else must approve
pespin: Looks good to me, approved
laforge: Looks good to me, but someone else must approve
Jenkins Builder: Verified
diff --git a/asterisk/Asterisk_Tests.ttcn b/asterisk/Asterisk_Tests.ttcn
index 20e01e7..dccf9fa 100644
--- a/asterisk/Asterisk_Tests.ttcn
+++ b/asterisk/Asterisk_Tests.ttcn
@@ -706,11 +706,11 @@
f_create_sip_expect(valueof(ts_SipUrl_from_Addr_Union(g_pars.subscr.registrar_sip_record.addr)));
as_IMS_register();
- /* Re-Register: This should optimally be a as_IMS_2nd_register()
instead... */
timer Trereg;
Trereg.start(int2float(g_pars.subscr.registrar_expires) - 5.0);
+ g_pars.subscr.registrar_expires := c_def_expires;
alt {
- [] as_IMS_register();
+ [] as_IMS_2nd_register();
[] Trereg.timeout {
Misc_Helpers.f_shutdown(__BFILE__, __LINE__, fail,
log2str(g_name & ": Timeout waiting for re-registration"));
}
@@ -730,8 +730,8 @@
f_AMI_IMS_register(pars);
- /* Re-Register: if this was a 2nd REGISTER, then reauth shouldn't be
needed... */
- as_AMI_IMS_register_Auth(pars, resync := false);
+ /* Wait for Asterisk to re-register and IMS_ConnHdlr to handle it... */
+ f_sleep(int2float(pars.subscr.registrar_expires));
/* Trigger unregistration: */
f_AMI_IMS_unregister(pars);
diff --git a/asterisk/IMS_ConnectionHandler.ttcn
b/asterisk/IMS_ConnectionHandler.ttcn
index 12f624c..39abc59 100644
--- a/asterisk/IMS_ConnectionHandler.ttcn
+++ b/asterisk/IMS_ConnectionHandler.ttcn
@@ -102,6 +102,7 @@
integer registrar_expires,
SipUrl local_sip_url_ext,
SipAddr local_sip_record,
+ WwwAuthenticate www_auth optional,
Contact registered_contact optional,
P_Associated_Uri p_associated_uri,
IMS_CallPars cp optional
@@ -241,6 +242,7 @@
ts_UserInfo(imsi)),
local_sip_record := ts_SipAddr(ts_HostPort(domain),
ts_UserInfo(imsi)),
+ www_auth := omit,
registered_contact := omit,
p_associated_uri := ts_P_Associated_Uri({}),
cp := cp
@@ -781,7 +783,6 @@
var CallidString sip_call_id;
var template (value) From from_addr;
var template (value) To to_addr;
- var WwwAuthenticate wwwAuthenticate;
var Security_server security_server;
var template (value) Require require :=
ts_Require({"sec-agree"});
var template (value) Supported supported :=
ts_Supported({"sec-agree"});
@@ -835,7 +836,7 @@
}
to_addr.toParams := f_sip_param_set(to_addr.toParams, "tag",
f_sip_rand_tag());
- wwwAuthenticate := f_gen_WwwAuthenticate();
+ g_pars.subscr.www_auth := f_gen_WwwAuthenticate();
security_server := f_gen_Security_server();
/* Tx 401 Unauthorized */
@@ -843,7 +844,7 @@
from_addr,
to_addr,
via,
- wwwAuthenticate,
+ g_pars.subscr.www_auth,
sip_seq_nr,
"REGISTER",
p_associated_uri :=
g_pars.subscr.p_associated_uri,
@@ -857,7 +858,7 @@
/* Now we should receive a new non-protected REGISTER
* with Authoritzation containing auts in base64: */
var template (present) Authorization authorization :=
- f_tr_Authorization_AKAv1MD5(wwwAuthenticate,
+
f_tr_Authorization_AKAv1MD5(g_pars.subscr.www_auth,
g_pars.subscr.imsi
& "@" & g_pars.realm,
f_sip_SipUrl_to_str(g_pars.registrar_sip_req_uri));
exp_req :=
@@ -906,7 +907,7 @@
from_addr,
to_addr,
[S] Change in osmo-ttcn3-hacks[master]: asterisk: TC_ims_reregistration: Expect re-register using existing ip...
pespin has posted comments on this change by pespin. ( https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/38179?usp=email ) Change subject: asterisk: TC_ims_reregistration: Expect re-register using existing ipsec ctx .. Patch Set 1: Code-Review+2 -- To view, visit https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/38179?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: osmo-ttcn3-hacks Gerrit-Branch: master Gerrit-Change-Id: I8d100dbba6cddfa5f31437c9cdc8c48f1bbd5701 Gerrit-Change-Number: 38179 Gerrit-PatchSet: 1 Gerrit-Owner: pespin Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: jolly Gerrit-Reviewer: laforge Gerrit-Reviewer: pespin Gerrit-Comment-Date: Mon, 16 Sep 2024 16:51:52 + Gerrit-HasComments: No Gerrit-Has-Labels: Yes
[S] Change in libosmo-sigtran[master]: SS7: Support secondary point codes
Attention is currently required from: laforge, neels. pespin has posted comments on this change by laforge. ( https://gerrit.osmocom.org/c/libosmo-sigtran/+/38180?usp=email ) Change subject: SS7: Support secondary point codes .. Patch Set 1: Code-Review+2 -- To view, visit https://gerrit.osmocom.org/c/libosmo-sigtran/+/38180?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: libosmo-sigtran Gerrit-Branch: master Gerrit-Change-Id: I3c4c0d89d2a0ea36aa5df0887225d99a16b810f0 Gerrit-Change-Number: 38180 Gerrit-PatchSet: 1 Gerrit-Owner: laforge Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria Gerrit-Reviewer: neels Gerrit-Reviewer: pespin Gerrit-Attention: neels Gerrit-Attention: laforge Gerrit-Comment-Date: Mon, 16 Sep 2024 16:36:45 + Gerrit-HasComments: No Gerrit-Has-Labels: Yes
[S] Change in osmo-ttcn3-hacks[master]: asterisk: TC_ims_reregistration: Expect re-register using existing ip...
pespin has uploaded this change for review. (
https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/38179?usp=email )
Change subject: asterisk: TC_ims_reregistration: Expect re-register using
existing ipsec ctx
..
asterisk: TC_ims_reregistration: Expect re-register using existing ipsec ctx
Change-Id: I8d100dbba6cddfa5f31437c9cdc8c48f1bbd5701
---
M asterisk/Asterisk_Tests.ttcn
M asterisk/IMS_ConnectionHandler.ttcn
2 files changed, 13 insertions(+), 13 deletions(-)
git pull ssh://gerrit.osmocom.org:29418/osmo-ttcn3-hacks
refs/changes/79/38179/1
diff --git a/asterisk/Asterisk_Tests.ttcn b/asterisk/Asterisk_Tests.ttcn
index 20e01e7..dccf9fa 100644
--- a/asterisk/Asterisk_Tests.ttcn
+++ b/asterisk/Asterisk_Tests.ttcn
@@ -706,11 +706,11 @@
f_create_sip_expect(valueof(ts_SipUrl_from_Addr_Union(g_pars.subscr.registrar_sip_record.addr)));
as_IMS_register();
- /* Re-Register: This should optimally be a as_IMS_2nd_register()
instead... */
timer Trereg;
Trereg.start(int2float(g_pars.subscr.registrar_expires) - 5.0);
+ g_pars.subscr.registrar_expires := c_def_expires;
alt {
- [] as_IMS_register();
+ [] as_IMS_2nd_register();
[] Trereg.timeout {
Misc_Helpers.f_shutdown(__BFILE__, __LINE__, fail,
log2str(g_name & ": Timeout waiting for re-registration"));
}
@@ -730,8 +730,8 @@
f_AMI_IMS_register(pars);
- /* Re-Register: if this was a 2nd REGISTER, then reauth shouldn't be
needed... */
- as_AMI_IMS_register_Auth(pars, resync := false);
+ /* Wait for Asterisk to re-register and IMS_ConnHdlr to handle it... */
+ f_sleep(int2float(pars.subscr.registrar_expires));
/* Trigger unregistration: */
f_AMI_IMS_unregister(pars);
diff --git a/asterisk/IMS_ConnectionHandler.ttcn
b/asterisk/IMS_ConnectionHandler.ttcn
index 12f624c..39abc59 100644
--- a/asterisk/IMS_ConnectionHandler.ttcn
+++ b/asterisk/IMS_ConnectionHandler.ttcn
@@ -102,6 +102,7 @@
integer registrar_expires,
SipUrl local_sip_url_ext,
SipAddr local_sip_record,
+ WwwAuthenticate www_auth optional,
Contact registered_contact optional,
P_Associated_Uri p_associated_uri,
IMS_CallPars cp optional
@@ -241,6 +242,7 @@
ts_UserInfo(imsi)),
local_sip_record := ts_SipAddr(ts_HostPort(domain),
ts_UserInfo(imsi)),
+ www_auth := omit,
registered_contact := omit,
p_associated_uri := ts_P_Associated_Uri({}),
cp := cp
@@ -781,7 +783,6 @@
var CallidString sip_call_id;
var template (value) From from_addr;
var template (value) To to_addr;
- var WwwAuthenticate wwwAuthenticate;
var Security_server security_server;
var template (value) Require require :=
ts_Require({"sec-agree"});
var template (value) Supported supported :=
ts_Supported({"sec-agree"});
@@ -835,7 +836,7 @@
}
to_addr.toParams := f_sip_param_set(to_addr.toParams, "tag",
f_sip_rand_tag());
- wwwAuthenticate := f_gen_WwwAuthenticate();
+ g_pars.subscr.www_auth := f_gen_WwwAuthenticate();
security_server := f_gen_Security_server();
/* Tx 401 Unauthorized */
@@ -843,7 +844,7 @@
from_addr,
to_addr,
via,
- wwwAuthenticate,
+ g_pars.subscr.www_auth,
sip_seq_nr,
"REGISTER",
p_associated_uri :=
g_pars.subscr.p_associated_uri,
@@ -857,7 +858,7 @@
/* Now we should receive a new non-protected REGISTER
* with Authoritzation containing auts in base64: */
var template (present) Authorization authorization :=
- f_tr_Authorization_AKAv1MD5(wwwAuthenticate,
+
f_tr_Authorization_AKAv1MD5(g_pars.subscr.www_auth,
g_pars.subscr.imsi
& "@" & g_pars.realm,
f_sip_SipUrl_to_str(g_pars.registrar_sip_req_uri));
exp_req :=
@@ -906,7 +907,7 @@
from_addr,
to_addr,
via,
- wwwAuthent
[M] Change in libosmo-sigtran[master]: Reject M3UA with "M3UA Network Appearance"
Attention is currently required from: laforge. pespin has posted comments on this change by laforge. ( https://gerrit.osmocom.org/c/libosmo-sigtran/+/38177?usp=email ) Change subject: Reject M3UA with "M3UA Network Appearance" .. Patch Set 1: Code-Review+1 -- To view, visit https://gerrit.osmocom.org/c/libosmo-sigtran/+/38177?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: libosmo-sigtran Gerrit-Branch: master Gerrit-Change-Id: Ia2c2004a7495376fd3f44d26f6cf1b6d277c9b2f Gerrit-Change-Number: 38177 Gerrit-PatchSet: 1 Gerrit-Owner: laforge Gerrit-Reviewer: pespin Gerrit-CC: Jenkins Builder Gerrit-CC: jolly Gerrit-Attention: laforge Gerrit-Comment-Date: Mon, 16 Sep 2024 14:31:13 + Gerrit-HasComments: No Gerrit-Has-Labels: Yes
[S] Change in osmo-gsm-tester[master]: contrib/jenkins-*: libosmo-sccp -> libosmo-sigtran
Attention is currently required from: osmith. pespin has posted comments on this change by osmith. ( https://gerrit.osmocom.org/c/osmo-gsm-tester/+/38176?usp=email ) Change subject: contrib/jenkins-*: libosmo-sccp -> libosmo-sigtran .. Patch Set 1: Code-Review+2 -- To view, visit https://gerrit.osmocom.org/c/osmo-gsm-tester/+/38176?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: osmo-gsm-tester Gerrit-Branch: master Gerrit-Change-Id: I9793c2bb7658d11318dd33c7bd6ad75a8e79bcbf Gerrit-Change-Number: 38176 Gerrit-PatchSet: 1 Gerrit-Owner: osmith Gerrit-Reviewer: pespin Gerrit-Attention: osmith Gerrit-Comment-Date: Mon, 16 Sep 2024 12:00:15 + Gerrit-HasComments: No Gerrit-Has-Labels: Yes
[L] Change in ...osmo-s1gw[master]: Introduce initial metrics support
Attention is currently required from: fixeria. pespin has posted comments on this change by pespin. ( https://gerrit.osmocom.org/c/erlang/osmo-s1gw/+/37955?usp=email ) Change subject: Introduce initial metrics support .. Patch Set 3: (1 comment) File src/s1gw_metrics.erl: https://gerrit.osmocom.org/c/erlang/osmo-s1gw/+/37955/comment/f0ecda03_74b1b77d?usp=email : PS2, Line 150: LOG_ERROR > I believe this should be `LOG_DEBUG`. Also, two prints is redundant, one > would be enough. Done -- To view, visit https://gerrit.osmocom.org/c/erlang/osmo-s1gw/+/37955?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: erlang/osmo-s1gw Gerrit-Branch: master Gerrit-Change-Id: I952e198238384dca4be94f91a01d7cfff0a1471f Gerrit-Change-Number: 37955 Gerrit-PatchSet: 3 Gerrit-Owner: pespin Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria Gerrit-Attention: fixeria Gerrit-Comment-Date: Mon, 16 Sep 2024 10:41:35 + Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: fixeria
[S] Change in osmo-sgsn[osmith/1.12.1]: Bump version: 1.12.0.5-193b7 → 1.12.1
Attention is currently required from: osmith. pespin has posted comments on this change by osmith. ( https://gerrit.osmocom.org/c/osmo-sgsn/+/38159?usp=email ) Change subject: Bump version: 1.12.0.5-193b7 → 1.12.1 .. Patch Set 2: Code-Review+2 -- To view, visit https://gerrit.osmocom.org/c/osmo-sgsn/+/38159?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: osmo-sgsn Gerrit-Branch: osmith/1.12.1 Gerrit-Change-Id: I3470865febcc53b63e59cf791869f02d0be3aaa7 Gerrit-Change-Number: 38159 Gerrit-PatchSet: 2 Gerrit-Owner: osmith Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: pespin Gerrit-Attention: osmith Gerrit-Comment-Date: Mon, 16 Sep 2024 10:39:26 + Gerrit-HasComments: No Gerrit-Has-Labels: Yes
[S] Change in osmo-sgsn[osmith/1.12.1]: Fix double free during RAU with unexpected Old RAI
Attention is currently required from: osmith. pespin has posted comments on this change by osmith. ( https://gerrit.osmocom.org/c/osmo-sgsn/+/38155?usp=email ) Change subject: Fix double free during RAU with unexpected Old RAI .. Patch Set 1: (1 comment) Patchset: PS1: > not sure why the linter fails here, this is just a backported patch and it > passed there: https://ger […] ACK -- To view, visit https://gerrit.osmocom.org/c/osmo-sgsn/+/38155?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: osmo-sgsn Gerrit-Branch: osmith/1.12.1 Gerrit-Change-Id: I5a4328c6e945b85dd815215724feecadba59c435 Gerrit-Change-Number: 38155 Gerrit-PatchSet: 1 Gerrit-Owner: osmith Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: osmith Gerrit-Reviewer: pespin Gerrit-Attention: osmith Gerrit-Comment-Date: Mon, 16 Sep 2024 10:38:54 + Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: osmith
[XS] Change in osmo-hnodeb[master]: contrib/jenkins: libosmo-sccp -> libosmo-sigtran
Attention is currently required from: osmith. pespin has posted comments on this change by osmith. ( https://gerrit.osmocom.org/c/osmo-hnodeb/+/38172?usp=email ) Change subject: contrib/jenkins: libosmo-sccp -> libosmo-sigtran .. Patch Set 1: Code-Review+2 -- To view, visit https://gerrit.osmocom.org/c/osmo-hnodeb/+/38172?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: osmo-hnodeb Gerrit-Branch: master Gerrit-Change-Id: If99ac6d1181363a3abc830f7d9152f307879d3c9 Gerrit-Change-Number: 38172 Gerrit-PatchSet: 1 Gerrit-Owner: osmith Gerrit-Reviewer: pespin Gerrit-CC: Jenkins Builder Gerrit-Attention: osmith Gerrit-Comment-Date: Mon, 16 Sep 2024 10:38:22 + Gerrit-HasComments: No Gerrit-Has-Labels: Yes
[XS] Change in osmo-bsc[master]: contrib/jenkins: libosmo-sccp -> libosmo-sigtran
Attention is currently required from: osmith. pespin has posted comments on this change by osmith. ( https://gerrit.osmocom.org/c/osmo-bsc/+/38170?usp=email ) Change subject: contrib/jenkins: libosmo-sccp -> libosmo-sigtran .. Patch Set 1: Code-Review+2 -- To view, visit https://gerrit.osmocom.org/c/osmo-bsc/+/38170?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: osmo-bsc Gerrit-Branch: master Gerrit-Change-Id: I4146c4594a45c9e10b051774affe9aaffa95d314 Gerrit-Change-Number: 38170 Gerrit-PatchSet: 1 Gerrit-Owner: osmith Gerrit-Reviewer: pespin Gerrit-CC: Jenkins Builder Gerrit-Attention: osmith Gerrit-Comment-Date: Mon, 16 Sep 2024 10:35:58 + Gerrit-HasComments: No Gerrit-Has-Labels: Yes
[L] Change in ...osmo-s1gw[master]: Introduce initial metrics support
Attention is currently required from: pespin. Hello Jenkins Builder, fixeria, I'd like you to reexamine a change. Please visit https://gerrit.osmocom.org/c/erlang/osmo-s1gw/+/37955?usp=email to look at the new patch set (#3). The following approvals got outdated and were removed: Verified+1 by Jenkins Builder Change subject: Introduce initial metrics support .. Introduce initial metrics support metrics are implemented with the "exometer" library. A reference config to export the metrics through statsd is provided. Change-Id: I952e198238384dca4be94f91a01d7cfff0a1471f --- M config/sys.config A include/s1gw_metrics.hrl M rebar.config M rebar.lock M src/osmo_s1gw.app.src M src/osmo_s1gw_sup.erl M src/pfcp_peer.erl M src/s1ap_proxy.erl A src/s1gw_metrics.erl M src/sctp_proxy.erl M src/sctp_server.erl A test/exometer_mock.erl M test/s1ap_proxy_test.erl 13 files changed, 329 insertions(+), 8 deletions(-) git pull ssh://gerrit.osmocom.org:29418/erlang/osmo-s1gw refs/changes/55/37955/3 -- To view, visit https://gerrit.osmocom.org/c/erlang/osmo-s1gw/+/37955?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: newpatchset Gerrit-Project: erlang/osmo-s1gw Gerrit-Branch: master Gerrit-Change-Id: I952e198238384dca4be94f91a01d7cfff0a1471f Gerrit-Change-Number: 37955 Gerrit-PatchSet: 3 Gerrit-Owner: pespin Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria Gerrit-Attention: pespin
[S] Change in osmo-bsc[master]: Introduce hashtable to lookup bts by
pespin has submitted this change. (
https://gerrit.osmocom.org/c/osmo-bsc/+/38127?usp=email )
Change subject: Introduce hashtable to lookup bts by
..
Introduce hashtable to lookup bts by
This is useful to quickly lookup pagings aiming at a LAC+CI.
Until now, we first looked up in the LAC hashtable and then iterated
over it. However, that means a potential configuration where all BTS
share the same LAC will end up in iterating over 256 bts, which is not
nice.
Change-Id: I47db6c7543e5c6c3b8f0de3ae5ee1b53c2b5f16f
Related: SYS#7062
---
M include/osmocom/bsc/bts.h
M include/osmocom/bsc/gsm_data.h
M src/osmo-bsc/bts.c
M src/osmo-bsc/bts_vty.c
M src/osmo-bsc/neighbor_ident.c
M src/osmo-bsc/osmo_bsc_bssap.c
6 files changed, 20 insertions(+), 3 deletions(-)
Approvals:
Jenkins Builder: Verified
fixeria: Looks good to me, approved
diff --git a/include/osmocom/bsc/bts.h b/include/osmocom/bsc/bts.h
index 308c5b9..251c161 100644
--- a/include/osmocom/bsc/bts.h
+++ b/include/osmocom/bsc/bts.h
@@ -345,6 +345,8 @@
struct hlist_node node_by_nr;
/*! Entry in hash table network->bts_by_lac. */
struct hlist_node node_by_lac;
+ /*! Entry in hash table network->bts_by_lac_ci. */
+ struct hlist_node node_by_lac_ci;
/*! Entry in hash table network->bts_by_ci. */
struct hlist_node node_by_ci;
diff --git a/include/osmocom/bsc/gsm_data.h b/include/osmocom/bsc/gsm_data.h
index 98414d0..59d22d7 100644
--- a/include/osmocom/bsc/gsm_data.h
+++ b/include/osmocom/bsc/gsm_data.h
@@ -989,6 +989,8 @@
struct llist_head bts_rejected;
DECLARE_HASHTABLE(bts_by_nr, 10);
DECLARE_HASHTABLE(bts_by_lac, 10);
+ DECLARE_HASHTABLE(bts_by_lac_ci, 10);
+#define LAC_CI_HASHTABLE_KEY(lac, ci) uint32_t)(ci)) << sizeof(lac)) |
(uint32_t)(lac))
DECLARE_HASHTABLE(bts_by_ci, 10);
/* BTS-based counters when we can't find the actual BTS
diff --git a/src/osmo-bsc/bts.c b/src/osmo-bsc/bts.c
index 9e31167..c21e5b3 100644
--- a/src/osmo-bsc/bts.c
+++ b/src/osmo-bsc/bts.c
@@ -161,6 +161,7 @@
llist_del(&bts->list);
hash_del(&bts->node_by_nr);
hash_del(&bts->node_by_lac);
+ hash_del(&bts->node_by_lac_ci);
hash_del(&bts->node_by_ci);
paging_destructor(bts);
@@ -209,6 +210,7 @@
/* Default bts->location_area_code == GSM_LAC_RESERVED_DETACHED, don't
add to hashtable: */
INIT_HLIST_NODE(&bts->node_by_lac);
+ INIT_HLIST_NODE(&bts->node_by_lac_ci);
/* Default CI = 0: */
hash_add(net->bts_by_ci, &bts->node_by_ci, bts->cell_identity);
diff --git a/src/osmo-bsc/bts_vty.c b/src/osmo-bsc/bts_vty.c
index d439d72..f6ee514 100644
--- a/src/osmo-bsc/bts_vty.c
+++ b/src/osmo-bsc/bts_vty.c
@@ -271,6 +271,11 @@
bts->cell_identity = ci;
hash_del(&bts->node_by_ci);
hash_add(bts->network->bts_by_ci, &bts->node_by_ci, bts->cell_identity);
+ if (bts->location_area_code != GSM_LAC_RESERVED_DETACHED) {
+ hash_del(&bts->node_by_lac_ci);
+ hash_add(bts->network->bts_by_lac_ci, &bts->node_by_lac_ci,
+LAC_CI_HASHTABLE_KEY(bts->location_area_code,
bts->cell_identity));
+ }
return CMD_SUCCESS;
}
@@ -296,7 +301,10 @@
bts->location_area_code = lac;
hash_del(&bts->node_by_lac);
+ hash_del(&bts->node_by_lac_ci);
hash_add(bts->network->bts_by_lac, &bts->node_by_lac,
bts->location_area_code);
+ hash_add(bts->network->bts_by_lac_ci, &bts->node_by_lac_ci,
+LAC_CI_HASHTABLE_KEY(bts->location_area_code,
bts->cell_identity));
return CMD_SUCCESS;
}
diff --git a/src/osmo-bsc/neighbor_ident.c b/src/osmo-bsc/neighbor_ident.c
index 4d52c50..6fbd4f5 100644
--- a/src/osmo-bsc/neighbor_ident.c
+++ b/src/osmo-bsc/neighbor_ident.c
@@ -377,7 +377,8 @@
struct gsm_bts *local_neighbor = NULL;
struct gsm0808_cell_id_list2 remote_neighbors = { 0 };
- hash_for_each_possible(net->bts_by_lac, bts_tmp, node_by_lac, lac) {
+ hash_for_each_possible(net->bts_by_lac_ci, bts_tmp, node_by_lac_ci,
+ LAC_CI_HASHTABLE_KEY(lac, cell_id)) {
if (bts_tmp->location_area_code != lac)
continue;
if (bts_tmp->cell_identity != cell_id)
diff --git a/src/osmo-bsc/osmo_bsc_bssap.c b/src/osmo-bsc/osmo_bsc_bssap.c
index 869a31b..6299279 100644
--- a/src/osmo-bsc/osmo_bsc_bssap.c
+++ b/src/osmo-bsc/osmo_bsc_bssap.c
@@ -150,7 +150,8 @@
if (!osmo_plmn_cmp(&id->lai.plmn, &bsc_gsmnet->plmn)) {
int paged = 0;
[XS] Change in osmo-sgsn[master]: contrib/jenkins: libosmo-sccp -> libosmo-sigtran
Attention is currently required from: osmith. pespin has posted comments on this change by osmith. ( https://gerrit.osmocom.org/c/osmo-sgsn/+/38169?usp=email ) Change subject: contrib/jenkins: libosmo-sccp -> libosmo-sigtran .. Patch Set 1: Code-Review+2 -- To view, visit https://gerrit.osmocom.org/c/osmo-sgsn/+/38169?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: osmo-sgsn Gerrit-Branch: master Gerrit-Change-Id: Id587ed1a8604c4881fd82784ad400c91d9125e32 Gerrit-Change-Number: 38169 Gerrit-PatchSet: 1 Gerrit-Owner: osmith Gerrit-Reviewer: pespin Gerrit-CC: Jenkins Builder Gerrit-Attention: osmith Gerrit-Comment-Date: Mon, 16 Sep 2024 10:33:24 + Gerrit-HasComments: No Gerrit-Has-Labels: Yes
[S] Change in osmo-smlc[master]: Bump version: 0.3.0.2-bc0a → 0.3.1
Attention is currently required from: osmith. pespin has posted comments on this change by osmith. ( https://gerrit.osmocom.org/c/osmo-smlc/+/38153?usp=email ) Change subject: Bump version: 0.3.0.2-bc0a → 0.3.1 .. Patch Set 2: Code-Review+2 -- To view, visit https://gerrit.osmocom.org/c/osmo-smlc/+/38153?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: osmo-smlc Gerrit-Branch: master Gerrit-Change-Id: I52964c60edfc09cf832b8acb2fff61d0ceed3837 Gerrit-Change-Number: 38153 Gerrit-PatchSet: 2 Gerrit-Owner: osmith Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: pespin Gerrit-Attention: osmith Gerrit-Comment-Date: Mon, 16 Sep 2024 10:32:59 + Gerrit-HasComments: No Gerrit-Has-Labels: Yes
[XS] Change in osmo-smlc[master]: contrib/jenkins: libosmo-sccp -> libosmo-sigtran
Attention is currently required from: osmith. pespin has posted comments on this change by osmith. ( https://gerrit.osmocom.org/c/osmo-smlc/+/38168?usp=email ) Change subject: contrib/jenkins: libosmo-sccp -> libosmo-sigtran .. Patch Set 1: Code-Review+2 -- To view, visit https://gerrit.osmocom.org/c/osmo-smlc/+/38168?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: osmo-smlc Gerrit-Branch: master Gerrit-Change-Id: Ia17342097f781f5b8134b5f74c541af84110db78 Gerrit-Change-Number: 38168 Gerrit-PatchSet: 1 Gerrit-Owner: osmith Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: pespin Gerrit-Attention: osmith Gerrit-Comment-Date: Mon, 16 Sep 2024 10:32:48 + Gerrit-HasComments: No Gerrit-Has-Labels: Yes
[S] Change in osmo-msc[master]: Bump version: 1.12.0.6-44f34 → 1.12.1
Attention is currently required from: laforge, osmith. pespin has posted comments on this change by osmith. ( https://gerrit.osmocom.org/c/osmo-msc/+/38152?usp=email ) Change subject: Bump version: 1.12.0.6-44f34 → 1.12.1 .. Patch Set 4: Code-Review+2 -- To view, visit https://gerrit.osmocom.org/c/osmo-msc/+/38152?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: osmo-msc Gerrit-Branch: master Gerrit-Change-Id: Ieee012f36c8bd230ce96e6c5df3da36a41b03a3d Gerrit-Change-Number: 38152 Gerrit-PatchSet: 4 Gerrit-Owner: osmith Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: laforge Gerrit-Reviewer: pespin Gerrit-Attention: osmith Gerrit-Attention: laforge Gerrit-Comment-Date: Mon, 16 Sep 2024 10:32:24 + Gerrit-HasComments: No Gerrit-Has-Labels: Yes
[XS] Change in osmo-msc[master]: contrib/jenkins: libosmo-sccp -> libosmo-sigtran
Attention is currently required from: osmith. pespin has posted comments on this change by osmith. ( https://gerrit.osmocom.org/c/osmo-msc/+/38167?usp=email ) Change subject: contrib/jenkins: libosmo-sccp -> libosmo-sigtran .. Patch Set 1: Code-Review+2 -- To view, visit https://gerrit.osmocom.org/c/osmo-msc/+/38167?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: osmo-msc Gerrit-Branch: master Gerrit-Change-Id: I85b73284ca3ca5abcc076da71d5e0c5609149a2f Gerrit-Change-Number: 38167 Gerrit-PatchSet: 1 Gerrit-Owner: osmith Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: pespin Gerrit-Attention: osmith Gerrit-Comment-Date: Mon, 16 Sep 2024 10:32:01 + Gerrit-HasComments: No Gerrit-Has-Labels: Yes
[XS] Change in osmo-sgsn[osmith/1.12.1]: debian/control: remove build-dep: libosmo-sccp-dev
Attention is currently required from: osmith. pespin has posted comments on this change by osmith. ( https://gerrit.osmocom.org/c/osmo-sgsn/+/38158?usp=email ) Change subject: debian/control: remove build-dep: libosmo-sccp-dev .. Patch Set 1: Code-Review+2 -- To view, visit https://gerrit.osmocom.org/c/osmo-sgsn/+/38158?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: osmo-sgsn Gerrit-Branch: osmith/1.12.1 Gerrit-Change-Id: I2fc827cf15b7f78173e5ee489abe2c6d12b82c2f Gerrit-Change-Number: 38158 Gerrit-PatchSet: 1 Gerrit-Owner: osmith Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: pespin Gerrit-Attention: osmith Gerrit-Comment-Date: Mon, 16 Sep 2024 10:31:03 + Gerrit-HasComments: No Gerrit-Has-Labels: Yes
[XS] Change in osmo-sgsn[osmith/1.12.1]: sm: pdpctx_timer_stop(): warn about timer not running
Attention is currently required from: osmith. pespin has posted comments on this change by osmith. ( https://gerrit.osmocom.org/c/osmo-sgsn/+/38157?usp=email ) Change subject: sm: pdpctx_timer_stop(): warn about timer not running .. Patch Set 1: (1 comment) Patchset: PS1: imho this is not a bug fix and should not be part of this patch release. It can well wait until next general release. -- To view, visit https://gerrit.osmocom.org/c/osmo-sgsn/+/38157?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: osmo-sgsn Gerrit-Branch: osmith/1.12.1 Gerrit-Change-Id: I64932d1cbd93667ab2e94e04691d6601435dba81 Gerrit-Change-Number: 38157 Gerrit-PatchSet: 1 Gerrit-Owner: osmith Gerrit-Reviewer: Jenkins Builder Gerrit-CC: fixeria Gerrit-CC: pespin Gerrit-Attention: osmith Gerrit-Comment-Date: Mon, 16 Sep 2024 10:30:54 + Gerrit-HasComments: Yes Gerrit-Has-Labels: No
[XS] Change in osmo-sgsn[osmith/1.12.1]: llc: Mark old/current tlli as all 1's when unassigning LLME
Attention is currently required from: osmith. pespin has posted comments on this change by osmith. ( https://gerrit.osmocom.org/c/osmo-sgsn/+/38156?usp=email ) Change subject: llc: Mark old/current tlli as all 1's when unassigning LLME .. Patch Set 1: Code-Review+2 -- To view, visit https://gerrit.osmocom.org/c/osmo-sgsn/+/38156?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: osmo-sgsn Gerrit-Branch: osmith/1.12.1 Gerrit-Change-Id: I660c8d0ef08b34f8cb74fd51b5c59e5628d687ae Gerrit-Change-Number: 38156 Gerrit-PatchSet: 1 Gerrit-Owner: osmith Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: pespin Gerrit-Attention: osmith Gerrit-Comment-Date: Mon, 16 Sep 2024 10:29:56 + Gerrit-HasComments: No Gerrit-Has-Labels: Yes
[S] Change in osmo-sgsn[osmith/1.12.1]: Fix double free during RAU with unexpected Old RAI
Attention is currently required from: osmith. pespin has posted comments on this change by osmith. ( https://gerrit.osmocom.org/c/osmo-sgsn/+/38155?usp=email ) Change subject: Fix double free during RAU with unexpected Old RAI .. Patch Set 1: Code-Review+2 -- To view, visit https://gerrit.osmocom.org/c/osmo-sgsn/+/38155?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: osmo-sgsn Gerrit-Branch: osmith/1.12.1 Gerrit-Change-Id: I5a4328c6e945b85dd815215724feecadba59c435 Gerrit-Change-Number: 38155 Gerrit-PatchSet: 1 Gerrit-Owner: osmith Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: pespin Gerrit-Attention: osmith Gerrit-Comment-Date: Mon, 16 Sep 2024 10:29:49 + Gerrit-HasComments: No Gerrit-Has-Labels: Yes
[S] Change in osmo-sgsn[osmith/1.12.1]: Fix DeactPDPCtxAcc when UE goes PMM ENABLED but lost its PDP context
Attention is currently required from: osmith. pespin has posted comments on this change by osmith. ( https://gerrit.osmocom.org/c/osmo-sgsn/+/38154?usp=email ) Change subject: Fix DeactPDPCtxAcc when UE goes PMM ENABLED but lost its PDP context .. Patch Set 1: Code-Review+2 -- To view, visit https://gerrit.osmocom.org/c/osmo-sgsn/+/38154?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: osmo-sgsn Gerrit-Branch: osmith/1.12.1 Gerrit-Change-Id: I0ccd9228d71c29248b5f510356dbfdb09565dc30 Gerrit-Change-Number: 38154 Gerrit-PatchSet: 1 Gerrit-Owner: osmith Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: pespin Gerrit-Attention: osmith Gerrit-Comment-Date: Mon, 16 Sep 2024 10:28:25 + Gerrit-HasComments: No Gerrit-Has-Labels: Yes
[S] Change in osmo-msc[master]: Bump version: 1.12.0.5-620c6 → 1.12.1
Attention is currently required from: osmith. pespin has posted comments on this change by osmith. ( https://gerrit.osmocom.org/c/osmo-msc/+/38152?usp=email ) Change subject: Bump version: 1.12.0.5-620c6 → 1.12.1 .. Patch Set 2: Code-Review+1 -- To view, visit https://gerrit.osmocom.org/c/osmo-msc/+/38152?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: osmo-msc Gerrit-Branch: master Gerrit-Change-Id: Ieee012f36c8bd230ce96e6c5df3da36a41b03a3d Gerrit-Change-Number: 38152 Gerrit-PatchSet: 2 Gerrit-Owner: osmith Gerrit-Reviewer: pespin Gerrit-CC: Jenkins Builder Gerrit-Attention: osmith Gerrit-Comment-Date: Mon, 16 Sep 2024 10:03:38 + Gerrit-HasComments: No Gerrit-Has-Labels: Yes
[S] Change in osmo-bsc[master]: Introduce hashtable to lookup bts by
Attention is currently required from: fixeria, laforge. Hello Jenkins Builder, fixeria, laforge, I'd like you to reexamine a change. Please visit https://gerrit.osmocom.org/c/osmo-bsc/+/38127?usp=email to look at the new patch set (#3). The following approvals got outdated and were removed: Code-Review+1 by fixeria, Code-Review+1 by laforge, Verified+1 by Jenkins Builder Change subject: Introduce hashtable to lookup bts by .. Introduce hashtable to lookup bts by This is useful to quickly lookup pagings aiming at a LAC+CI. Until now, we first looked up in the LAC hashtable and then iterated over it. However, that means a potential configuration where all BTS share the same LAC will end up in iterating over 256 bts, which is not nice. Change-Id: I47db6c7543e5c6c3b8f0de3ae5ee1b53c2b5f16f Related: SYS#7062 --- M include/osmocom/bsc/bts.h M include/osmocom/bsc/gsm_data.h M src/osmo-bsc/bts.c M src/osmo-bsc/bts_vty.c M src/osmo-bsc/neighbor_ident.c M src/osmo-bsc/osmo_bsc_bssap.c 6 files changed, 20 insertions(+), 3 deletions(-) git pull ssh://gerrit.osmocom.org:29418/osmo-bsc refs/changes/27/38127/3 -- To view, visit https://gerrit.osmocom.org/c/osmo-bsc/+/38127?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: newpatchset Gerrit-Project: osmo-bsc Gerrit-Branch: master Gerrit-Change-Id: I47db6c7543e5c6c3b8f0de3ae5ee1b53c2b5f16f Gerrit-Change-Number: 38127 Gerrit-PatchSet: 3 Gerrit-Owner: pespin Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria Gerrit-Reviewer: laforge Gerrit-Attention: laforge Gerrit-Attention: fixeria
[S] Change in osmo-bsc[master]: Introduce hashtable to lookup bts by LAC
pespin has submitted this change. (
https://gerrit.osmocom.org/c/osmo-bsc/+/38087?usp=email )
Change subject: Introduce hashtable to lookup bts by LAC
..
Introduce hashtable to lookup bts by LAC
The BTS is not added to the hashtable during allocation, because the
default LAC value is 0, which is GSM_LAC_RESERVED_DETACHED
(reserved by GSM 04.08), so it's also detached from the hashtable
(cannot be found based on a reserved value).
Related: SYS#7062
Change-Id: Id523027b49e0f58cd2c8c9b4dee619de415dbd15
---
M include/osmocom/bsc/bts.h
M include/osmocom/bsc/gsm_data.h
M src/osmo-bsc/bts.c
M src/osmo-bsc/bts_vty.c
M src/osmo-bsc/neighbor_ident.c
M src/osmo-bsc/net_init.c
M src/osmo-bsc/osmo_bsc_bssap.c
7 files changed, 17 insertions(+), 7 deletions(-)
Approvals:
fixeria: Looks good to me, but someone else must approve
laforge: Looks good to me, but someone else must approve
pespin: Looks good to me, approved
Jenkins Builder: Verified
diff --git a/include/osmocom/bsc/bts.h b/include/osmocom/bsc/bts.h
index 8e530ef..9e70ee5 100644
--- a/include/osmocom/bsc/bts.h
+++ b/include/osmocom/bsc/bts.h
@@ -343,6 +343,8 @@
/*! Entry in hash table network->bts_by_nr. */
struct hlist_node node_by_nr;
+ /*! Entry in hash table network->bts_by_lac. */
+ struct hlist_node node_by_lac;
/* number of this BTS in network */
gsm_bts_nr_t nr;
diff --git a/include/osmocom/bsc/gsm_data.h b/include/osmocom/bsc/gsm_data.h
index 5ed339d..1dda9ae 100644
--- a/include/osmocom/bsc/gsm_data.h
+++ b/include/osmocom/bsc/gsm_data.h
@@ -988,6 +988,7 @@
struct llist_head bts_list;
struct llist_head bts_rejected;
DECLARE_HASHTABLE(bts_by_nr, 10);
+ DECLARE_HASHTABLE(bts_by_lac, 10);
/* BTS-based counters when we can't find the actual BTS
* e.g. when conn->lchan is NULL */
diff --git a/src/osmo-bsc/bts.c b/src/osmo-bsc/bts.c
index 38e5f11..d928a4b 100644
--- a/src/osmo-bsc/bts.c
+++ b/src/osmo-bsc/bts.c
@@ -160,6 +160,7 @@
llist_del(&bts->list);
hash_del(&bts->node_by_nr);
+ hash_del(&bts->node_by_lac);
paging_destructor(bts);
bts_setup_ramp_remove(bts);
@@ -205,6 +206,9 @@
hash_add(net->bts_by_nr, &bts->node_by_nr, bts->nr);
net->num_bts++;
+ /* Default bts->location_area_code == GSM_LAC_RESERVED_DETACHED, don't
add to hashtable: */
+ INIT_HLIST_NODE(&bts->node_by_lac);
+
bts->num_trx = 0;
INIT_LLIST_HEAD(&bts->trx_list);
bts->network = net;
diff --git a/src/osmo-bsc/bts_vty.c b/src/osmo-bsc/bts_vty.c
index 81c4022..4ef582f 100644
--- a/src/osmo-bsc/bts_vty.c
+++ b/src/osmo-bsc/bts_vty.c
@@ -278,8 +278,8 @@
X(BSC_VTY_ATTR_RESTART_ABIS_RSL_LINK),
"location_area_code (<0-65535>|<0x-0x>)",
"Set the Location Area Code (LAC) of this BTS\n"
- "LAC in decimal format\n"
- "LAC in hexadecimal format\n")
+ "LAC in decimal format (default 0, reserved by GSM 04.08)\n"
+ "LAC in hexadecimal format (default 0x, reserved by GSM
04.08)\n")
{
struct gsm_bts *bts = vty->index;
int lac;
@@ -293,6 +293,8 @@
}
bts->location_area_code = lac;
+ hash_del(&bts->node_by_lac);
+ hash_add(bts->network->bts_by_lac, &bts->node_by_lac,
bts->location_area_code);
return CMD_SUCCESS;
}
diff --git a/src/osmo-bsc/neighbor_ident.c b/src/osmo-bsc/neighbor_ident.c
index 3e42c5f..4d52c50 100644
--- a/src/osmo-bsc/neighbor_ident.c
+++ b/src/osmo-bsc/neighbor_ident.c
@@ -377,7 +377,7 @@
struct gsm_bts *local_neighbor = NULL;
struct gsm0808_cell_id_list2 remote_neighbors = { 0 };
- llist_for_each_entry(bts_tmp, &net->bts_list, list) {
+ hash_for_each_possible(net->bts_by_lac, bts_tmp, node_by_lac, lac) {
if (bts_tmp->location_area_code != lac)
continue;
if (bts_tmp->cell_identity != cell_id)
diff --git a/src/osmo-bsc/net_init.c b/src/osmo-bsc/net_init.c
index fc29d43..62b3ee4 100644
--- a/src/osmo-bsc/net_init.c
+++ b/src/osmo-bsc/net_init.c
@@ -125,6 +125,7 @@
INIT_LLIST_HEAD(&net->bts_list);
net->num_bts = 0;
hash_init(net->bts_by_nr);
+ hash_init(net->bts_by_lac);
net->T_defs = gsm_network_T_defs;
osmo_tdefs_reset(net->T_defs);
diff --git a/src/osmo-bsc/osmo_bsc_bssap.c b/src/osmo-bsc/osmo_bsc_bssap.c
index c9e8e5e..82bdeb7 100644
--- a/src/osmo-bsc/osmo_bsc_bssap.c
+++ b/src/osmo-bsc/osmo_bsc_bssap.c
@@ -150,7 +150,7 @@
if (!osmo_plmn_cmp(&id->lai.plmn, &bsc_gsmnet->plmn)) {
[S] Change in osmo-bsc[master]: Introduce hashtable to lookup bts by CI
pespin has submitted this change. (
https://gerrit.osmocom.org/c/osmo-bsc/+/38126?usp=email )
Change subject: Introduce hashtable to lookup bts by CI
..
Introduce hashtable to lookup bts by CI
Change-Id: Ia9d6a38496609fc906cc78124929e594e6a9d06e
---
M include/osmocom/bsc/bts.h
M include/osmocom/bsc/gsm_data.h
M src/osmo-bsc/bts.c
M src/osmo-bsc/bts_vty.c
M src/osmo-bsc/net_init.c
M src/osmo-bsc/osmo_bsc_bssap.c
6 files changed, 11 insertions(+), 2 deletions(-)
Approvals:
laforge: Looks good to me, approved
fixeria: Looks good to me, but someone else must approve
Jenkins Builder: Verified
diff --git a/include/osmocom/bsc/bts.h b/include/osmocom/bsc/bts.h
index 9e70ee5..308c5b9 100644
--- a/include/osmocom/bsc/bts.h
+++ b/include/osmocom/bsc/bts.h
@@ -345,6 +345,8 @@
struct hlist_node node_by_nr;
/*! Entry in hash table network->bts_by_lac. */
struct hlist_node node_by_lac;
+ /*! Entry in hash table network->bts_by_ci. */
+ struct hlist_node node_by_ci;
/* number of this BTS in network */
gsm_bts_nr_t nr;
diff --git a/include/osmocom/bsc/gsm_data.h b/include/osmocom/bsc/gsm_data.h
index 1dda9ae..98414d0 100644
--- a/include/osmocom/bsc/gsm_data.h
+++ b/include/osmocom/bsc/gsm_data.h
@@ -989,6 +989,7 @@
struct llist_head bts_rejected;
DECLARE_HASHTABLE(bts_by_nr, 10);
DECLARE_HASHTABLE(bts_by_lac, 10);
+ DECLARE_HASHTABLE(bts_by_ci, 10);
/* BTS-based counters when we can't find the actual BTS
* e.g. when conn->lchan is NULL */
diff --git a/src/osmo-bsc/bts.c b/src/osmo-bsc/bts.c
index d928a4b..9e31167 100644
--- a/src/osmo-bsc/bts.c
+++ b/src/osmo-bsc/bts.c
@@ -161,6 +161,7 @@
llist_del(&bts->list);
hash_del(&bts->node_by_nr);
hash_del(&bts->node_by_lac);
+ hash_del(&bts->node_by_ci);
paging_destructor(bts);
bts_setup_ramp_remove(bts);
@@ -208,6 +209,8 @@
/* Default bts->location_area_code == GSM_LAC_RESERVED_DETACHED, don't
add to hashtable: */
INIT_HLIST_NODE(&bts->node_by_lac);
+ /* Default CI = 0: */
+ hash_add(net->bts_by_ci, &bts->node_by_ci, bts->cell_identity);
bts->num_trx = 0;
INIT_LLIST_HEAD(&bts->trx_list);
diff --git a/src/osmo-bsc/bts_vty.c b/src/osmo-bsc/bts_vty.c
index 4ef582f..d439d72 100644
--- a/src/osmo-bsc/bts_vty.c
+++ b/src/osmo-bsc/bts_vty.c
@@ -258,7 +258,7 @@
cfg_bts_ci_cmd,
X(BSC_VTY_ATTR_RESTART_ABIS_RSL_LINK),
"cell_identity <0-65535>",
- "Set the Cell identity of this BTS\n" "Cell Identity\n")
+ "Set the Cell identity of this BTS\n" "Cell Identity (default
0)\n")
{
struct gsm_bts *bts = vty->index;
int ci = atoi(argv[0]);
@@ -269,6 +269,8 @@
return CMD_WARNING;
}
bts->cell_identity = ci;
+ hash_del(&bts->node_by_ci);
+ hash_add(bts->network->bts_by_ci, &bts->node_by_ci, bts->cell_identity);
return CMD_SUCCESS;
}
diff --git a/src/osmo-bsc/net_init.c b/src/osmo-bsc/net_init.c
index 62b3ee4..79afdc8 100644
--- a/src/osmo-bsc/net_init.c
+++ b/src/osmo-bsc/net_init.c
@@ -126,6 +126,7 @@
net->num_bts = 0;
hash_init(net->bts_by_nr);
hash_init(net->bts_by_lac);
+ hash_init(net->bts_by_ci);
net->T_defs = gsm_network_T_defs;
osmo_tdefs_reset(net->T_defs);
diff --git a/src/osmo-bsc/osmo_bsc_bssap.c b/src/osmo-bsc/osmo_bsc_bssap.c
index 82bdeb7..869a31b 100644
--- a/src/osmo-bsc/osmo_bsc_bssap.c
+++ b/src/osmo-bsc/osmo_bsc_bssap.c
@@ -201,7 +201,7 @@
uint16_t ci = params->cil.id_list[i].ci;
int paged = 0;
struct gsm_bts *bts;
- llist_for_each_entry(bts, &bsc_gsmnet->bts_list, list) {
+ hash_for_each_possible(bsc_gsmnet->bts_by_ci, bts, node_by_ci,
ci) {
if (bts->cell_identity != ci)
continue;
page_subscriber(params, bts, GSM_LAC_RESERVED_ALL_BTS);
--
To view, visit https://gerrit.osmocom.org/c/osmo-bsc/+/38126?usp=email
To unsubscribe, or for help writing mail filters, visit
https://gerrit.osmocom.org/settings?usp=email
Gerrit-MessageType: merged
Gerrit-Project: osmo-bsc
Gerrit-Branch: master
Gerrit-Change-Id: Ia9d6a38496609fc906cc78124929e594e6a9d06e
Gerrit-Change-Number: 38126
Gerrit-PatchSet: 1
Gerrit-Owner: pespin
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: fixeria
Gerrit-Reviewer: laforge
Gerrit-Reviewer: pespin
