Change in ...osmo-sgsn[master]: gprs_sgsn.c: Remove recently introduced assert

2019-08-13 Thread pespin
subscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-sgsn Gerrit-Branch: master Gerrit-Change-Id: I482acdbdf05ce0cb0a5804206672512854067f5b Gerrit-Change-Number: 15188 Gerrit-PatchSet: 2 Gerrit-Owner: pespin Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: lynxis lazus Gerrit-MessageType: newpatchset

Change in ...osmo-sgsn[master]: gprs_gmm.c: Fix typo in log message

2019-08-13 Thread pespin
pespin has uploaded this change for review. ( https://gerrit.osmocom.org/c/osmo-sgsn/+/15189 Change subject: gprs_gmm.c: Fix typo in log message .. gprs_gmm.c: Fix typo in log message Change-Id

Change in ...osmo-iuh[master]: iu_client: introduce a connection state

2019-08-13 Thread pespin
pespin has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-iuh/+/15181 ) Change subject: iu_client: introduce a connection state .. Patch Set 2: My previous comments were still not discussed/applied

Change in ...osmo-iuh[master]: iu_client: introduce ranap_iu_free_ue() to free the UE connections

2019-08-13 Thread pespin
pespin has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-iuh/+/15161 ) Change subject: iu_client: introduce ranap_iu_free_ue() to free the UE connections .. Patch Set 5: Comments still not applied

Change in ...osmo-sgsn[master]: gprs_gmm: Clarify comment during TLLI assignment

2019-08-13 Thread pespin
pespin has submitted this change and it was merged. ( https://gerrit.osmocom.org/c/osmo-sgsn/+/15187 ) Change subject: gprs_gmm: Clarify comment during TLLI assignment .. gprs_gmm: Clarify comment during TLLI assignment TS

Change in ...osmo-iuh[master]: iu_client: introduce ranap_iu_free_ue() to free the UE connections

2019-08-13 Thread pespin
pespin has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-iuh/+/15161 ) Change subject: iu_client: introduce ranap_iu_free_ue() to free the UE connections .. Patch Set 3: (2 comments) https

Change in ...osmo-iuh[master]: iu_client: define RANAP_IU_EVENT_SECURITY_MODE_FAILED

2019-08-13 Thread pespin
pespin has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-iuh/+/15177 ) Change subject: iu_client: define RANAP_IU_EVENT_SECURITY_MODE_FAILED .. Patch Set 2: Can we keep it out and merge this one once

Change in ...osmo-sgsn[master]: gprs_gmm: only update gb/iu cell information when Iu/Gb present

2019-08-13 Thread pespin
pespin has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-sgsn/+/15172 ) Change subject: gprs_gmm: only update gb/iu cell information when Iu/Gb present .. Patch Set 2: Code-Review+1 -- To view, visit

Change in ...osmo-iuh[master]: iu_client: ensure UE is not NULL on CO primitives

2019-08-13 Thread pespin
pespin has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-iuh/+/15178 ) Change subject: iu_client: ensure UE is not NULL on CO primitives .. Patch Set 1: Code-Review-1 (1 comment) https

Change in ...osmo-iuh[master]: iu_client: sccp_sap_up: set rc early

2019-08-13 Thread pespin
pespin has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-iuh/+/15179 ) Change subject: iu_client: sccp_sap_up: set rc early .. Patch Set 1: Code-Review-1 (1 comment) https://gerrit.osmocom.org/#/c/15179

Change in ...osmo-ttcn3-hacks[master]: start-testsuite.sh: Add commented-out section for using custom TITAN

2019-08-14 Thread pespin
pespin has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/15192 ) Change subject: start-testsuite.sh: Add commented-out section for using custom TITAN .. Patch Set 1: (1 comment) https

Change in ...osmo-ttcn3-hacks[master]: library: Add S1AP Templates

2019-08-14 Thread pespin
pespin has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/15195 ) Change subject: library: Add S1AP Templates .. Patch Set 1: Code-Review+2 -- To view, visit https://gerrit.osmocom.org/c

Change in ...osmo-ttcn3-hacks[master]: library: S1AP encoding/decoding using libfftranscode and ASN.1 from V...

2019-08-14 Thread pespin
pespin has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/15194 ) Change subject: library: S1AP encoding/decoding using libfftranscode and ASN.1 from V15.5.0 .. Patch Set 1: Code-Review+1

Change in ...osmo-ttcn3-hacks[master]: mme: Add GTPv2 support

2019-08-14 Thread pespin
pespin has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/15204 ) Change subject: mme: Add GTPv2 support .. Patch Set 1: (2 comments) https://gerrit.osmocom.org/#/c/15204/1//COMMIT_MSG

Change in ...osmo-ttcn3-hacks[master]: mme: Integrate DIAMETER support into MME testsuite

2019-08-14 Thread pespin
pespin has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/15207 ) Change subject: mme: Integrate DIAMETER support into MME testsuite .. Patch Set 1: Code-Review+2 -- To view, visit https

Change in ...osmo-ttcn3-hacks[master]: start-testsuite.sh: Add commented-out section for using custom TITAN

2019-08-14 Thread pespin
pespin has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/15192 ) Change subject: start-testsuite.sh: Add commented-out section for using custom TITAN .. Patch Set 1: Code-Review+2

Change in ...osmo-ttcn3-hacks[master]: mme: initial skeleton for MME / SGsAP tetss

2019-08-14 Thread pespin
pespin has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/15193 ) Change subject: mme: initial skeleton for MME / SGsAP tetss .. Patch Set 1: Code-Review+2 -- To view, visit https

Change in ...osmo-ttcn3-hacks[master]: library: Add initial set of LTE/EPC NAS templates

2019-08-14 Thread pespin
pespin has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/15197 ) Change subject: library: Add initial set of LTE/EPC NAS templates .. Patch Set 1: Code-Review+2 -- To view, visit https

Change in ...osmo-ttcn3-hacks[master]: library: Add S1AP CodecPort/Emulation

2019-08-14 Thread pespin
pespin has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/15196 ) Change subject: library: Add S1AP CodecPort/Emulation .. Patch Set 1: Code-Review+1 -- To view, visit https

Change in ...osmo-ttcn3-hacks[master]: snow-3g: const-ify S-boxes

2019-08-14 Thread pespin
pespin has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/15199 ) Change subject: snow-3g: const-ify S-boxes .. Patch Set 1: Code-Review+2 -- To view, visit https://gerrit.osmocom.org/c

Change in ...osmo-ttcn3-hacks[master]: snow-3g.c: Mark all internal primitive functions as static

2019-08-14 Thread pespin
pespin has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/15200 ) Change subject: snow-3g.c: Mark all internal primitive functions as static .. Patch Set 1: Code-Review+2 -- To view, visit

Change in ...osmo-ttcn3-hacks[master]: remove ogslib dependency from snow

2019-08-14 Thread pespin
pespin has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/15201 ) Change subject: remove ogslib dependency from snow .. Patch Set 1: Code-Review+2 -- To view, visit https

Change in ...osmo-ttcn3-hacks[master]: Import snow-3g.[ch] from nextepc source code

2019-08-14 Thread pespin
pespin has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/15198 ) Change subject: Import snow-3g.[ch] from nextepc source code .. Patch Set 1: Code-Review+1 -- To view, visit https

Change in ...osmo-ttcn3-hacks[master]: mme: Extend MME tests to also include S1AP interface testing

2019-08-14 Thread pespin
pespin has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/15203 ) Change subject: mme: Extend MME tests to also include S1AP interface testing .. Patch Set 1: Code-Review+2 -- To view

Change in ...osmo-ttcn3-hacks[master]: TTCN-3 native function wrapper for SNOW-3G

2019-08-14 Thread pespin
pespin has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/15202 ) Change subject: TTCN-3 native function wrapper for SNOW-3G .. Patch Set 1: Code-Review+2 -- To view, visit https

Change in ...osmo-ttcn3-hacks[master]: library: Add [generated] DIAMETER_Types.ttcn

2019-08-14 Thread pespin
pespin has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/15205 ) Change subject: library: Add [generated] DIAMETER_Types.ttcn .. Patch Set 1: Code-Review+2 -- To view, visit https

Change in ...osmo-ttcn3-hacks[master]: library: Add DIAMETER Templates, Emulation, CodecPort

2019-08-14 Thread pespin
pespin has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/15206 ) Change subject: library: Add DIAMETER Templates, Emulation, CodecPort .. Patch Set 1: Code-Review+2 -- To view, visit https

Change in ...osmo-ttcn3-hacks[master]: library: S1AP encoding/decoding using libfftranscode and ASN.1 from V...

2019-08-14 Thread pespin
pespin has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/15194 ) Change subject: library: S1AP encoding/decoding using libfftranscode and ASN.1 from V15.5.0 .. Patch Set 1: Code-Review+2

Change in ...osmo-gsm-manuals[master]: common: trx_if.adoc: Improve documentation

2019-07-31 Thread pespin
pespin has submitted this change and it was merged. ( https://gerrit.osmocom.org/c/osmo-gsm-manuals/+/14938 ) Change subject: common: trx_if.adoc: Improve documentation .. common: trx_if.adoc: Improve documentation Several

Change in ...osmo-gsm-manuals[master]: common: trx_if.adoc: Add documentation about TRXDv1 and SETFORMAT

2019-07-31 Thread pespin
pespin has submitted this change and it was merged. ( https://gerrit.osmocom.org/c/osmo-gsm-manuals/+/14940 ) Change subject: common: trx_if.adoc: Add documentation about TRXDv1 and SETFORMAT .. common: trx_if.adoc: Add

Change in ...libosmocore[master]: Workaround TLS gcc compiler bug in ARM

2019-08-02 Thread pespin
pespin has abandoned this change. ( https://gerrit.osmocom.org/c/libosmocore/+/15025 ) Change subject: Workaround TLS gcc compiler bug in ARM .. Abandoned Abandonning as per comments from reviewer. -- To view, visit https

Change in ...libosmocore[master]: utils: share static buffer in osmo_str_to{lower, upper}()

2019-08-02 Thread pespin
: I032803faa0e27c2efdff1ff276acabab95a8319a Gerrit-Change-Number: 15024 Gerrit-PatchSet: 2 Gerrit-Owner: pespin Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria Gerrit-MessageType: newpatchset

Change in ...osmo-gsm-manuals[master]: Makefile.asciidoc.inc: always run verbose asciidoc

2019-08-02 Thread pespin
pespin has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-gsm-manuals/+/15030 ) Change subject: Makefile.asciidoc.inc: always run verbose asciidoc .. Patch Set 1: (1 comment) https://gerrit.osmocom.org

Change in ...osmo-gsm-manuals[master]: Makefile.asciidoc.inc: warnings check not default

2019-08-02 Thread pespin
pespin has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-gsm-manuals/+/15031 ) Change subject: Makefile.asciidoc.inc: warnings check not default .. Patch Set 1: (1 comment) https://gerrit.osmocom.org

Change in ...libosmocore[master]: Get rid of osmo_str_tolower() use inside libosmocore code

2019-08-02 Thread pespin
pespin has uploaded this change for review. ( https://gerrit.osmocom.org/c/libosmocore/+/15032 Change subject: Get rid of osmo_str_tolower() use inside libosmocore code .. Get rid of osmo_str_tolower() use inside libosmocore

Change in ...osmo-gsm-manuals[master]: Makefile.asciidoc.inc: warnings check not default

2019-08-03 Thread pespin
pespin has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-gsm-manuals/+/15031 ) Change subject: Makefile.asciidoc.inc: warnings check not default .. Patch Set 1: Code-Review+2 -- To view, visit https

Change in ...osmo-ggsn[master]: Remove packets in tx queue belonging pdp being freed

2019-08-16 Thread pespin
-Branch: master Gerrit-Change-Id: Id86d0b241454d3ad49c64c28087fd2710fa2d17a Gerrit-Change-Number: 15228 Gerrit-PatchSet: 2 Gerrit-Owner: pespin Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: keith Gerrit-Reviewer: lynxis lazus Gerrit-Reviewer: pespin Gerrit-MessageType: newpatchset

Change in ...osmo-ggsn[master]: Remove packets in tx queue belonging pdp being freed

2019-08-16 Thread pespin
pespin has uploaded this change for review. ( https://gerrit.osmocom.org/c/osmo-ggsn/+/15228 Change subject: Remove packets in tx queue belonging pdp being freed .. Remove packets in tx queue belonging pdp being freed Doing

Change in ...osmo-bts[master]: scheduler_trx: Deal with osmo_amr_rtp_enc() returning negative

2019-08-12 Thread pespin
pespin has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-bts/+/14876 ) Change subject: scheduler_trx: Deal with osmo_amr_rtp_enc() returning negative .. Patch Set 3: It seems there's some LOGP parameter

Change in ...libosmocore[master]: No fail if no /proc/cpuinfo

2019-08-12 Thread pespin
pespin has posted comments on this change. ( https://gerrit.osmocom.org/c/libosmocore/+/14798 ) Change subject: No fail if no /proc/cpuinfo .. Patch Set 2: Code-Review+2 -- To view, visit https://gerrit.osmocom.org/c

Change in ...docker-playground[master]: ttcn3-sgsn: Unifi osmo-sgsn.cfg's logging setup to resemble other pro...

2019-08-12 Thread pespin
pespin has uploaded this change for review. ( https://gerrit.osmocom.org/c/docker-playground/+/15153 Change subject: ttcn3-sgsn: Unifi osmo-sgsn.cfg's logging setup to resemble other projects .. ttcn3-sgsn: Unifi osmo

Change in ...libosmocore[master]: osmo-release.sh: Support releasing openbsc.git

2019-08-12 Thread pespin
pespin has posted comments on this change. ( https://gerrit.osmocom.org/c/libosmocore/+/15127 ) Change subject: osmo-release.sh: Support releasing openbsc.git .. Patch Set 2: Code-Review+2 Merging now (because I set meta

Change in ...libosmocore[master]: osmo-release.sh: Support releasing openbsc.git

2019-08-12 Thread pespin
pespin has submitted this change and it was merged. ( https://gerrit.osmocom.org/c/libosmocore/+/15127 ) Change subject: osmo-release.sh: Support releasing openbsc.git .. osmo-release.sh: Support releasing openbsc.git

Change in ...osmo-ggsn[master]: libgtp: Remove packets in tx queue belonging pdp being freed

2019-08-16 Thread pespin
: osmo-ggsn Gerrit-Branch: master Gerrit-Change-Id: Id86d0b241454d3ad49c64c28087fd2710fa2d17a Gerrit-Change-Number: 15228 Gerrit-PatchSet: 4 Gerrit-Owner: pespin Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: keith Gerrit-Reviewer: lynxis lazus Gerrit-Reviewer: pespin Gerrit-MessageType

Change in ...osmo-ggsn[master]: Remove packets in tx queue belonging pdp being freed

2019-08-16 Thread pespin
-Branch: master Gerrit-Change-Id: Id86d0b241454d3ad49c64c28087fd2710fa2d17a Gerrit-Change-Number: 15228 Gerrit-PatchSet: 3 Gerrit-Owner: pespin Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: keith Gerrit-Reviewer: lynxis lazus Gerrit-Reviewer: pespin Gerrit-MessageType: newpatchset

Change in ...osmo-sgsn[master]: gprs_gmm: Introduce assert to guard against unexpected condition

2019-08-17 Thread pespin
pespin has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-sgsn/+/15167 ) Change subject: gprs_gmm: Introduce assert to guard against unexpected condition .. Patch Set 3: Code-Review+2 -- To view, visit

Change in ...osmo-sgsn[master]: gprs_gmm.c: Flag mmctx_set_(p)mm_state() functions static

2019-08-17 Thread pespin
pespin has submitted this change and it was merged. ( https://gerrit.osmocom.org/c/osmo-sgsn/+/15185 ) Change subject: gprs_gmm.c: Flag mmctx_set_(p)mm_state() functions static .. gprs_gmm.c: Flag mmctx_set_(p)mm_state

Change in ...osmo-sgsn[master]: gprs_gmm.c: Use correct function to set MM_IDLE state during cleanup

2019-08-17 Thread pespin
pespin has submitted this change and it was merged. ( https://gerrit.osmocom.org/c/osmo-sgsn/+/15183 ) Change subject: gprs_gmm.c: Use correct function to set MM_IDLE state during cleanup .. gprs_gmm.c: Use correct function

Change in ...osmo-sgsn[master]: gprs_sgsn.h: Flag MM_CTX_T_GERAN_Iu as not supported

2019-08-17 Thread pespin
pespin has submitted this change and it was merged. ( https://gerrit.osmocom.org/c/osmo-sgsn/+/15184 ) Change subject: gprs_sgsn.h: Flag MM_CTX_T_GERAN_Iu as not supported .. gprs_sgsn.h: Flag MM_CTX_T_GERAN_Iu as not supported

Change in ...osmo-sgsn[master]: gprs_gmm: Introduce assert to guard against unexpected condition

2019-08-17 Thread pespin
pespin has submitted this change and it was merged. ( https://gerrit.osmocom.org/c/osmo-sgsn/+/15167 ) Change subject: gprs_gmm: Introduce assert to guard against unexpected condition .. gprs_gmm: Introduce assert to guard

Change in ...osmo-ggsn[master]: libgtp: Remove packets in tx queue belonging pdp being freed

2019-08-17 Thread pespin
pespin has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-ggsn/+/15228 ) Change subject: libgtp: Remove packets in tx queue belonging pdp being freed .. Patch Set 4: libgtp already depends on libosmocore

Change in ...osmo-sgsn[master]: gprs_gmm: Introduce assert to guard against unexpected condition

2019-08-17 Thread pespin
pespin has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-sgsn/+/15167 ) Change subject: gprs_gmm: Introduce assert to guard against unexpected condition .. Patch Set 3: +1+1=+2 -- To view, visit https

Change in ...osmo-iuh[master]: iu_client: introduce ranap_iu_free_ue() to free the UE connections

2019-08-17 Thread pespin
pespin has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-iuh/+/15161 ) Change subject: iu_client: introduce ranap_iu_free_ue() to free the UE connections .. Patch Set 6: -Code-Review -- To view, visit

Change in ...osmo-ttcn3-hacks[master]: MSC_Tests: do not send an SGsAP-MO-CSFB-INDICATION when testing MT-Call

2019-08-15 Thread pespin
pespin has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/15220 ) Change subject: MSC_Tests: do not send an SGsAP-MO-CSFB-INDICATION when testing MT-Call .. Patch Set 1: Code-Review+1

Change in ...osmo-sgsn[master]: gprs_gmm.c: Use osmo_rai_name() in log line

2019-08-15 Thread pespin
pespin has uploaded this change for review. ( https://gerrit.osmocom.org/c/osmo-sgsn/+/15224 Change subject: gprs_gmm.c: Use osmo_rai_name() in log line .. gprs_gmm.c: Use osmo_rai_name() in log line Change-Id

Change in ...osmo-ggsn[master]: build: switch AC_CANONICAL_TARGET for AC_CANONICAL_HOST

2019-08-15 Thread pespin
pespin has uploaded this change for review. ( https://gerrit.osmocom.org/c/osmo-ggsn/+/15219 Change subject: build: switch AC_CANONICAL_TARGET for AC_CANONICAL_HOST .. build: switch AC_CANONICAL_TARGET for AC_CANONICAL_HOST

Change in ...osmo-sgsn[master]: gprs/gprs_gmm: implement T3314. Timeout to reset MM state READY->STANDBY

2019-08-15 Thread pespin
pespin has uploaded a new patch set (#2) to the change originally created by laforge. ( https://gerrit.osmocom.org/c/osmo-sgsn/+/12009 ) Change subject: gprs/gprs_gmm: implement T3314. Timeout to reset MM state READY->STAN

Change in ...meta-telephony[201705]: libosmocore: Package osmo-config-merge

2019-08-15 Thread pespin
pespin has posted comments on this change. ( https://gerrit.osmocom.org/c/meta-telephony/+/15223 ) Change subject: libosmocore: Package osmo-config-merge .. Patch Set 1: Code-Review+2 -- To view, visit https

Change in ...osmo-sgsn[master]: gprs_gmm: Introduce assert to guard against unexpected condition

2019-08-15 Thread pespin
, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-sgsn Gerrit-Branch: master Gerrit-Change-Id: I8e1eaeb9b3ebee8e45704b4fe007190c7db609e4 Gerrit-Change-Number: 15167 Gerrit-PatchSet: 3 Gerrit-Owner: pespin Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: laforge Gerrit-Reviewer

Change in ...osmo-sgsn[master]: tests: Verify that timers can be set over VTY

2019-08-15 Thread pespin
: pespin Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria Gerrit-Reviewer: neels Gerrit-MessageType: newpatchset

Change in ...osmo-sgsn[master]: Introduce and use log macros when no mm ctx available

2019-08-15 Thread pespin
: Iba22060d8646bc8ec6227684ccb91d98cb4c7be2 Gerrit-Change-Number: 15211 Gerrit-PatchSet: 2 Gerrit-Owner: pespin Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: laforge Gerrit-Reviewer: neels Gerrit-Reviewer: pespin Gerrit-MessageType: newpatchset

Change in ...osmo-sgsn[master]: gprs_gmm: Avoid spaces in fsm events and enum strings

2019-08-15 Thread pespin
mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-sgsn Gerrit-Branch: master Gerrit-Change-Id: I16ede8bf8352b09bc772fd7b43fad2c2274b3ec1 Gerrit-Change-Number: 15212 Gerrit-PatchSet: 2 Gerrit-Owner: pespin Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: neels Gerrit

Change in ...osmo-sgsn[master]: gprs_gmm.c: Call mmctx_set_(p)mm_state only on related ran_type

2019-08-15 Thread pespin
-Change-Id: I65ad9e180177bc9fc7c4a037cd85cfe33b161f73 Gerrit-Change-Number: 15186 Gerrit-PatchSet: 3 Gerrit-Owner: pespin Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: pespin Gerrit-CC: fixeria Gerrit-CC: neels Gerrit-MessageType: newpatchset

Change in ...osmo-sgsn[master]: gprs_sgsn.h: Flag MM_CTX_T_GERAN_Iu as not supported

2019-08-15 Thread pespin
-Change-Number: 15184 Gerrit-PatchSet: 3 Gerrit-Owner: pespin Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria Gerrit-Reviewer: laforge Gerrit-Reviewer: neels Gerrit-MessageType: newpatchset

Change in ...osmo-sgsn[master]: Replace own timer infra with libosmocore osmo_tdef

2019-08-15 Thread pespin
: Ia0cf5f0a49737fbc419e2ccc86312d01c6e0056e Gerrit-Change-Number: 15214 Gerrit-PatchSet: 2 Gerrit-Owner: pespin Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria Gerrit-Reviewer: neels Gerrit-Reviewer: pespin Gerrit-MessageType: newpatchset

Change in ...osmo-msc[master]: sgs_iface: do not use SGsAP-MO-CSFB-INDICATION for CSFB return

2019-08-15 Thread pespin
pespin has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-msc/+/15221 ) Change subject: sgs_iface: do not use SGsAP-MO-CSFB-INDICATION for CSFB return .. Patch Set 1: Code-Review+1 -- To view, visit

Change in ...osmo-ggsn[master]: build: switch AC_CANONICAL_TARGET for AC_CANONICAL_HOST

2019-08-15 Thread pespin
pespin has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-ggsn/+/15219 ) Change subject: build: switch AC_CANONICAL_TARGET for AC_CANONICAL_HOST .. Patch Set 1: Code-Review+1 -- To view, visit https

Change in ...osmo-msc[master]: msc_a: switch RAN type back to SGs when a CSFB-Call is cleared

2019-08-15 Thread pespin
pespin has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-msc/+/15222 ) Change subject: msc_a: switch RAN type back to SGs when a CSFB-Call is cleared .. Patch Set 1: Code-Review+1 (1 comment) https

Change in ...osmo-sgsn[master]: libgtp: don't call sgsn_pdp_ctx_free() with NULL pdp

2019-08-15 Thread pespin
pespin has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-sgsn/+/13929 ) Change subject: libgtp: don't call sgsn_pdp_ctx_free() with NULL pdp .. Patch Set 5: Code-Review-2 (1 comment) https

Change in ...osmo-sgsn[master]: libgtp: don't call sgsn_pdp_ctx_free() with NULL pdp

2019-08-15 Thread pespin
pespin has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-sgsn/+/13929 ) Change subject: libgtp: don't call sgsn_pdp_ctx_free() with NULL pdp .. Patch Set 5: See last comment: https://osmocom.org/issues

Change in ...osmo-sgsn[master]: Introduce and use log macros when no mm ctx available

2019-08-15 Thread pespin
pespin has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-sgsn/+/15211 ) Change subject: Introduce and use log macros when no mm ctx available .. Patch Set 1: (3 comments) https://gerrit.osmocom.org/#/c

Change in ...osmo-sgsn[master]: gprs_gmm: Avoid spaces in fsm events and enum strings

2019-08-15 Thread pespin
pespin has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-sgsn/+/15212 ) Change subject: gprs_gmm: Avoid spaces in fsm events and enum strings .. Patch Set 1: (2 comments) https://gerrit.osmocom.org/#/c

Change in ...osmo-sgsn[master]: gprs_gmm: Introduce assert to guard against unexpected condition

2019-08-15 Thread pespin
pespin has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-sgsn/+/15167 ) Change subject: gprs_gmm: Introduce assert to guard against unexpected condition .. Patch Set 2: (1 comment) https

Change in ...libosmocore[master]: osmo_tdef_get(): allow passing -1 as default timeout

2019-08-15 Thread pespin
pespin has posted comments on this change. ( https://gerrit.osmocom.org/c/libosmocore/+/15218 ) Change subject: osmo_tdef_get(): allow passing -1 as default timeout .. Patch Set 2: Code-Review+2 -- To view, visit https

Change in ...osmo-sgsn[master]: Replace own timer infra with libosmocore osmo_tdef

2019-08-15 Thread pespin
pespin has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-sgsn/+/15214 ) Change subject: Replace own timer infra with libosmocore osmo_tdef .. Patch Set 1: (1 comment) https://gerrit.osmocom.org/#/c

Change in ...osmo-ttcn3-hacks[master]: sgsn: Add test to verify duplicate DeactPDPCtx crashing osmo-sgsn

2019-08-15 Thread pespin
pespin has uploaded this change for review. ( https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/15225 Change subject: sgsn: Add test to verify duplicate DeactPDPCtx crashing osmo-sgsn .. sgsn: Add test to verify duplicate

Change in ...osmo-ttcn3-hacks[master]: sgsn: Add test to verify duplicate DeactPDPCtx crashing osmo-sgsn

2019-08-15 Thread pespin
pespin has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/15225 ) Change subject: sgsn: Add test to verify duplicate DeactPDPCtx crashing osmo-sgsn .. Patch Set 1: Don't merge yet

Change in ...osmo-msc[master]: add 'encryption uea 1 2' cfg / fix ttcn3 iu tests

2019-08-14 Thread pespin
pespin has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-msc/+/15175 ) Change subject: add 'encryption uea 1 2' cfg / fix ttcn3 iu tests .. Patch Set 4: Code-Review+1 -- To view, visit https

Change in ...osmo-gsm-tester[master]: bts-trx: Improve logging and trap SIGTERM in ssh_sigkiller.sh

2019-08-14 Thread pespin
pespin has uploaded this change for review. ( https://gerrit.osmocom.org/c/osmo-gsm-tester/+/15190 Change subject: bts-trx: Improve logging and trap SIGTERM in ssh_sigkiller.sh .. bts-trx: Improve logging and trap SIGTERM

Change in ...osmo-gsm-tester[master]: default-suites: Drop multi-trx osmo-trx-lms tests

2019-08-14 Thread pespin
pespin has uploaded this change for review. ( https://gerrit.osmocom.org/c/osmo-gsm-tester/+/15191 Change subject: default-suites: Drop multi-trx osmo-trx-lms tests .. default-suites: Drop multi-trx osmo-trx-lms tests

Change in ...osmo-mgw[master]: test_mgcp_codec_pt_translate(): more tests

2019-08-14 Thread pespin
pespin has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-mgw/+/15135 ) Change subject: test_mgcp_codec_pt_translate(): more tests .. Patch Set 4: Code-Review+1 Thanks, much clearer now -- To view

Change in ...osmo-mgw[master]: mgcp_codec: codec_set(): log about all possible errors

2019-08-14 Thread pespin
pespin has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-mgw/+/15138 ) Change subject: mgcp_codec: codec_set(): log about all possible errors .. Patch Set 4: (1 comment) https://gerrit.osmocom.org/#/c

Change in ...osmo-bsc[master]: gsm_08_08.c: always pick first msc for unsolicit paging responses

2019-08-14 Thread pespin
pespin has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-bsc/+/15209 ) Change subject: gsm_08_08.c: always pick first msc for unsolicit paging responses .. Patch Set 1: (1 comment) https

Change in ...osmo-ttcn3-hacks[master]: BSC_Tests: Change test-expectation of TC_paging_resp_unsol

2019-08-14 Thread pespin
pespin has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/15208 ) Change subject: BSC_Tests: Change test-expectation of TC_paging_resp_unsol .. Patch Set 1: (1 comment) https

Change in ...osmo-mgw[master]: mgcp_test: extend / rewrite test_mgcp_codec_pt_translate()

2019-08-13 Thread pespin
pespin has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-mgw/+/15134 ) Change subject: mgcp_test: extend / rewrite test_mgcp_codec_pt_translate() .. Patch Set 3: Code-Review+1 -- To view, visit https

Change in ...osmo-mgw[master]: ptmap: implicitly match '/8000' and '/8000/1'

2019-08-13 Thread pespin
pespin has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-mgw/+/15137 ) Change subject: ptmap: implicitly match '/8000' and '/8000/1' .. Patch Set 3: Code-Review+1 -- To view, visit https

Change in ...osmo-mgw[master]: tweak mgcp_parse_audio_ptime_rtpmap()

2019-08-13 Thread pespin
pespin has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-mgw/+/15140 ) Change subject: tweak mgcp_parse_audio_ptime_rtpmap() .. Patch Set 3: Code-Review+1 (1 comment) https://gerrit.osmocom.org/#/c

Change in ...osmo-sgsn[master]: gprs_sgsn.c: Warn upon llme free unexpected scenarios

2019-08-13 Thread pespin
pespin has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-sgsn/+/15166 ) Change subject: gprs_sgsn.c: Warn upon llme free unexpected scenarios .. Patch Set 1: > Patch Set 1: Code-Review+2 > > L

Change in ...osmo-sgsn[master]: gprs_llc.h: Improve documentation of some structs

2019-08-13 Thread pespin
pespin has submitted this change and it was merged. ( https://gerrit.osmocom.org/c/osmo-sgsn/+/15159 ) Change subject: gprs_llc.h: Improve documentation of some structs .. gprs_llc.h: Improve documentation of some structs

Change in ...osmo-sgsn[master]: gprs_gmm: Introduce macros to access msgb's associated IU UE ctx

2019-08-13 Thread pespin
pespin has submitted this change and it was merged. ( https://gerrit.osmocom.org/c/osmo-sgsn/+/15158 ) Change subject: gprs_gmm: Introduce macros to access msgb's associated IU UE ctx .. gprs_gmm: Introduce macros to access

Change in ...osmo-sgsn[master]: gprs_gmm.c: Drop unneeded brackets

2019-08-13 Thread pespin
pespin has submitted this change and it was merged. ( https://gerrit.osmocom.org/c/osmo-sgsn/+/15164 ) Change subject: gprs_gmm.c: Drop unneeded brackets .. gprs_gmm.c: Drop unneeded brackets Change-Id

Change in ...osmo-sgsn[master]: gprs_gmm.c: Improve doc on nullable parameters

2019-08-13 Thread pespin
pespin has submitted this change and it was merged. ( https://gerrit.osmocom.org/c/osmo-sgsn/+/15160 ) Change subject: gprs_gmm.c: Improve doc on nullable parameters .. gprs_gmm.c: Improve doc on nullable parameters Change-Id

Change in ...osmo-sgsn[master]: Introduce define TLLI_UNASSIGNED

2019-08-13 Thread pespin
pespin has submitted this change and it was merged. ( https://gerrit.osmocom.org/c/osmo-sgsn/+/15165 ) Change subject: Introduce define TLLI_UNASSIGNED .. Introduce define TLLI_UNASSIGNED Change-Id

Change in ...osmo-mgw[master]: test_mgcp_codec_pt_translate(): more tests

2019-08-13 Thread pespin
pespin has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-mgw/+/15135 ) Change subject: test_mgcp_codec_pt_translate(): more tests .. Patch Set 3: Code-Review+1 (1 comment) https://gerrit.osmocom.org/#/c

Change in ...osmo-mgw[master]: differentiate AMR octet-aligned=0 vs =1

2019-08-13 Thread pespin
pespin has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-mgw/+/15136 ) Change subject: differentiate AMR octet-aligned=0 vs =1 .. Patch Set 3: Code-Review+2 -- To view, visit https://gerrit.osmocom.org

Change in ...osmo-mgw[master]: mgcp_codec: codec_set(): log about all possible errors

2019-08-13 Thread pespin
pespin has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-mgw/+/15138 ) Change subject: mgcp_codec: codec_set(): log about all possible errors .. Patch Set 3: (1 comment) https://gerrit.osmocom.org/#/c

Change in ...osmo-sgsn[master]: gprs_sgsn.c: Warn upon llme free unexpected scenarios

2019-08-13 Thread pespin
pespin has submitted this change and it was merged. ( https://gerrit.osmocom.org/c/osmo-sgsn/+/15166 ) Change subject: gprs_sgsn.c: Warn upon llme free unexpected scenarios .. gprs_sgsn.c: Warn upon llme free unexpected

Change in ...osmo-hlr[master]: tests: Fix db_test err file to expect error code name instead of value

2019-08-13 Thread pespin
pespin has uploaded this change for review. ( https://gerrit.osmocom.org/c/osmo-hlr/+/15170 Change subject: tests: Fix db_test err file to expect error code name instead of value .. tests: Fix db_test err file to expect error

Change in ...osmo-mgw[master]: mgcp_codec: split codec_free() off of codec_init()

2019-08-13 Thread pespin
pespin has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-mgw/+/15132 ) Change subject: mgcp_codec: split codec_free() off of codec_init() .. Patch Set 2: Code-Review+1 (1 comment) https

Change in ...osmo-mgw[master]: fix memleak: actually free strings in mgcp_codec_reset_all()

2019-08-13 Thread pespin
pespin has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-mgw/+/15133 ) Change subject: fix memleak: actually free strings in mgcp_codec_reset_all() .. Patch Set 2: Code-Review+2 -- To view, visit https

<    1   2   3   4   5   6   7   8   9   10   >