Change in ...osmo-sgsn[master]: src/gprs/Makefile.am: Move build of shared .c files to an internal lib

2019-09-02 Thread pespin
pespin has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-sgsn/+/15360 ) Change subject: src/gprs/Makefile.am: Move build of shared .c files to an internal lib .. Patch Set 2: (2 comments) https

Change in ...osmo-sgsn[master]: sgsn_vty: Print correct Iu mmctx id in 'show mm-context'

2019-09-02 Thread pespin
pespin has submitted this change and it was merged. ( https://gerrit.osmocom.org/c/osmo-sgsn/+/15355 ) Change subject: sgsn_vty: Print correct Iu mmctx id in 'show mm-context' .. sgsn_vty: Print correct Iu mmctx id in 'show mm

Change in ...osmo-sgsn[master]: sgsn_vty: Fix mmctx rate_ctr output indentation

2019-09-02 Thread pespin
pespin has submitted this change and it was merged. ( https://gerrit.osmocom.org/c/osmo-sgsn/+/15356 ) Change subject: sgsn_vty: Fix mmctx rate_ctr output indentation .. sgsn_vty: Fix mmctx rate_ctr output indentation Change

Change in ...osmo-sgsn[master]: sgsn_cdr.c: Fix ip addr string buffer size

2019-09-02 Thread pespin
pespin has submitted this change and it was merged. ( https://gerrit.osmocom.org/c/osmo-sgsn/+/15358 ) Change subject: sgsn_cdr.c: Fix ip addr string buffer size .. sgsn_cdr.c: Fix ip addr string buffer size INET(6)_ADDRSTRLEN

Change in ...osmo-sgsn[master]: enum gprs_gmm_state: Fix spec reference

2019-09-02 Thread pespin
pespin has uploaded this change for review. ( https://gerrit.osmocom.org/c/osmo-sgsn/+/15383 Change subject: enum gprs_gmm_state: Fix spec reference .. enum gprs_gmm_state: Fix spec reference Change-Id

Change in ...osmo-sgsn[master]: Implement GMM State using osmocom FSM

2019-09-02 Thread pespin
pespin has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-sgsn/+/15385 ) Change subject: Implement GMM State using osmocom FSM .. Patch Set 1: (1 comment) https://gerrit.osmocom.org/#/c/15385/1/include

Change in ...osmo-sgsn[master]: Implement GMM State using osmocom FSM

2019-09-02 Thread pespin
pespin has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-sgsn/+/15385 ) Change subject: Implement GMM State using osmocom FSM .. Patch Set 1: I tested manually GPRS still works fine, and verifies all

Change in ...osmo-sgsn[master]: Implement GMM State using osmocom FSM

2019-09-02 Thread pespin
pespin has uploaded this change for review. ( https://gerrit.osmocom.org/c/osmo-sgsn/+/15385 Change subject: Implement GMM State using osmocom FSM .. Implement GMM State using osmocom FSM State machine inspired in the one

Change in ...osmo-sgsn[master]: src/gprs/Makefile.am: Move build of shared .c files to an internal lib

2019-09-02 Thread pespin
://gerrit.osmocom.org/settings Gerrit-Project: osmo-sgsn Gerrit-Branch: master Gerrit-Change-Id: Ib7665c530c086a5f3135c395bb8bf19ed4a882b6 Gerrit-Change-Number: 15360 Gerrit-PatchSet: 3 Gerrit-Owner: pespin Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: laforge Gerrit-Reviewer: pespin Gerrit-CC

Change in ...osmo-sgsn[master]: Introduce FSM mm_state_iu_fsm

2019-09-02 Thread pespin
pespin has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-sgsn/+/15354 ) Change subject: Introduce FSM mm_state_iu_fsm .. Patch Set 2: While I agree that tests should be added at some point, the truth

Change in ...osmo-sip-connector[master]: mncc: check fd before closing a connection

2019-09-02 Thread pespin
pespin has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-sip-connector/+/15303 ) Change subject: mncc: check fd before closing a connection .. Patch Set 5: Code-Review+1 -- To view, visit https

Change in ...osmo-ggsn[master]: libgtp: announce pdp ctx deletion upon CreatePdpCtx being rejected

2019-08-21 Thread pespin
pespin has uploaded this change for review. ( https://gerrit.osmocom.org/c/osmo-ggsn/+/15259 Change subject: libgtp: announce pdp ctx deletion upon CreatePdpCtx being rejected .. libgtp: announce pdp ctx deletion upon

Change in ...osmo-ci[master]: gerrit, master builds: use ASCIIDOC_WARNINGS_CHECK

2019-08-21 Thread pespin
pespin has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-ci/+/15029 ) Change subject: gerrit, master builds: use ASCIIDOC_WARNINGS_CHECK .. Patch Set 1: Does warn checking (if warns are found) mean job

Change in ...osmo-trx[master]: Drop old setPriority related code

2019-08-21 Thread pespin
pespin has uploaded this change for review. ( https://gerrit.osmocom.org/c/osmo-trx/+/15258 Change subject: Drop old setPriority related code .. Drop old setPriority related code This code is not needed anymore since we

Change in ...osmo-ttcn3-hacks[master]: ggsn: Introduce test TC_pdp46_act_deact_apn4

2019-08-21 Thread pespin
pespin has uploaded this change for review. ( https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/15262 Change subject: ggsn: Introduce test TC_pdp46_act_deact_apn4 .. ggsn: Introduce test TC_pdp46_act_deact_apn4 Related osmo

Change in ...osmo-ttcn3-hacks[master]: ggsn: Update test xfail->pass in expected-results.xml

2019-08-21 Thread pespin
pespin has uploaded this change for review. ( https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/15261 Change subject: ggsn: Update test xfail->pass in expected-results.xml .. ggsn: Update test xfail->pass in expected-resul

Change in ...osmo-ttcn3-hacks[master]: ggsn: Add missing v4v6 tests in expected-results.xml

2019-08-21 Thread pespin
pespin has uploaded this change for review. ( https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/15260 Change subject: ggsn: Add missing v4v6 tests in expected-results.xml .. ggsn: Add missing v4v6 tests in expected-results.xml

Change in ...osmo-ci[master]: gerrit, master builds: use ASCIIDOC_WARNINGS_CHECK

2019-08-21 Thread pespin
pespin has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-ci/+/15029 ) Change subject: gerrit, master builds: use ASCIIDOC_WARNINGS_CHECK .. Patch Set 3: Code-Review+2 -- To view, visit https

Change in ...osmo-sgsn[master]: vty: Introduce cs7-instance-iu

2019-08-21 Thread pespin
pespin has submitted this change and it was merged. ( https://gerrit.osmocom.org/c/osmo-sgsn/+/15239 ) Change subject: vty: Introduce cs7-instance-iu .. vty: Introduce cs7-instance-iu Similar to what we already have in osmo

Change in ...osmo-gsm-manuals[master]: Makefile.asciidoc.inc: always run verbose asciidoc

2019-08-21 Thread pespin
pespin has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-gsm-manuals/+/15030 ) Change subject: Makefile.asciidoc.inc: always run verbose asciidoc .. Patch Set 2: Code-Review+2 -- To view, visit https

Change in ...osmo-sgsn[master]: gprs_gmm.c: Print value_string of reject cause

2019-08-21 Thread pespin
pespin has uploaded this change for review. ( https://gerrit.osmocom.org/c/osmo-sgsn/+/15263 Change subject: gprs_gmm.c: Print value_string of reject cause .. gprs_gmm.c: Print value_string of reject cause Change-Id

Change in ...osmo-sgsn[master]: gprs_gmm.c: Add spec document to function documentation

2019-08-21 Thread pespin
pespin has uploaded this change for review. ( https://gerrit.osmocom.org/c/osmo-sgsn/+/15264 Change subject: gprs_gmm.c: Add spec document to function documentation .. gprs_gmm.c: Add spec document to function documentation

Change in ...osmo-ttcn3-hacks[master]: sgsn: Proper shutdown of RAN_Adapter components

2019-08-27 Thread pespin
cn3-hacks Gerrit-Branch: master Gerrit-Change-Id: I471eb851e5d41de5d8d974ec81be27024d7d313a Gerrit-Change-Number: 15295 Gerrit-PatchSet: 2 Gerrit-Owner: pespin Gerrit-Reviewer: Jenkins Builder Gerrit-MessageType: newpatchset

Change in ...osmo-ttcn3-hacks[master]: sgsn: Proper shutdown of RAN_Adapter components

2019-08-27 Thread pespin
pespin has uploaded this change for review. ( https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/15295 Change subject: sgsn: Proper shutdown of RAN_Adapter components .. sgsn: Proper shutdown of RAN_Adapter components Otherwise

Change in ...osmo-ttcn3-hacks[master]: Revert "bts: f_init_pcu: sleep before connect"

2019-09-04 Thread pespin
pespin has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/15401 ) Change subject: Revert "bts: f_init_pcu: sleep before connect" .. Patch Set 1: Code-Review+2 -- To view, v

Change in ...osmo-bsc[master]: manual: Update statements regarding SCCPlite

2019-09-04 Thread pespin
pespin has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-bsc/+/15402 ) Change subject: manual: Update statements regarding SCCPlite .. Patch Set 1: Code-Review+1 (1 comment) https://gerrit.osmocom.org

Change in ...libosmocore[master]: tdef: Introduce API osmo_tdef_set()

2019-09-05 Thread pespin
://gerrit.osmocom.org/settings Gerrit-Project: libosmocore Gerrit-Branch: master Gerrit-Change-Id: Id56a1226d724a374f04231df85fe5b49ffd2c43c Gerrit-Change-Number: 15418 Gerrit-PatchSet: 2 Gerrit-Owner: pespin Gerrit-Reviewer: Jenkins Builder Gerrit-MessageType: newpatchset

Change in ...libosmocore[master]: tdef_vty.h: Add missing header dependencies

2019-09-05 Thread pespin
pespin has uploaded this change for review. ( https://gerrit.osmocom.org/c/libosmocore/+/15419 Change subject: tdef_vty.h: Add missing header dependencies .. tdef_vty.h: Add missing header dependencies enum node_type

Change in ...osmo-pcu[master]: cosmetic: tbf: Rename T and N arrays

2019-09-05 Thread pespin
pespin has uploaded this change for review. ( https://gerrit.osmocom.org/c/osmo-pcu/+/15424 Change subject: cosmetic: tbf: Rename T and N arrays .. cosmetic: tbf: Rename T and N arrays Those namings my collide with usual

Change in ...osmo-pcu[master]: Use proper API osmo_timer_setup() to set up timer struct

2019-09-05 Thread pespin
pespin has uploaded this change for review. ( https://gerrit.osmocom.org/c/osmo-pcu/+/15426 Change subject: Use proper API osmo_timer_setup() to set up timer struct .. Use proper API osmo_timer_setup() to set up timer struct

Change in ...osmo-pcu[master]: Use osmo_tdef for BSSGP T1 and T2

2019-09-05 Thread pespin
pespin has uploaded this change for review. ( https://gerrit.osmocom.org/c/osmo-pcu/+/15427 Change subject: Use osmo_tdef for BSSGP T1 and T2 .. Use osmo_tdef for BSSGP T1 and T2 Change-Id

Change in ...libosmocore[master]: tdef: Introduce API osmo_tdef_set()

2019-09-05 Thread pespin
pespin has uploaded this change for review. ( https://gerrit.osmocom.org/c/libosmocore/+/15418 Change subject: tdef: Introduce API osmo_tdef_set() .. tdef: Introduce API osmo_tdef_set() This API is already useful for users

Change in ...libosmo-netif[master]: stream: Introduce API osmo_stream_cli_is_connected

2019-09-04 Thread pespin
pespin has uploaded this change for review. ( https://gerrit.osmocom.org/c/libosmo-netif/+/15403 Change subject: stream: Introduce API osmo_stream_cli_is_connected .. stream: Introduce API osmo_stream_cli_is_connected Can

Change in ...libosmo-netif[master]: stream: Fix scheduling of queued messages during connecting state

2019-09-04 Thread pespin
pespin has uploaded this change for review. ( https://gerrit.osmocom.org/c/libosmo-netif/+/15404 Change subject: stream: Fix scheduling of queued messages during connecting state .. stream: Fix scheduling of queued messages

Change in ...libosmo-netif[master]: stream: Fix scheduling of queued messages during connecting state

2019-09-04 Thread pespin
rit-PatchSet: 2 Gerrit-Owner: pespin Gerrit-Reviewer: Jenkins Builder Gerrit-MessageType: newpatchset

Change in ...osmo-bsc[master]: a_reset.c: Don't wait 2 seconds to send first BSSMAP RESET

2019-09-04 Thread pespin
pespin has uploaded this change for review. ( https://gerrit.osmocom.org/c/osmo-bsc/+/15406 Change subject: a_reset.c: Don't wait 2 seconds to send first BSSMAP RESET .. a_reset.c: Don't wait 2 seconds to send first BSSMAP

Change in ...osmo-bsc[master]: bsc: gsm_08_08.c: Remove repeated conn not null check

2019-09-04 Thread pespin
pespin has uploaded this change for review. ( https://gerrit.osmocom.org/c/osmo-bsc/+/15407 Change subject: bsc: gsm_08_08.c: Remove repeated conn not null check .. bsc: gsm_08_08.c: Remove repeated conn not null check

Change in ...osmo-bsc[master]: bsc_subscr_conn_fsm: Cleanly clear BSSAP conn if associated channel c...

2019-09-04 Thread pespin
pespin has uploaded this change for review. ( https://gerrit.osmocom.org/c/osmo-bsc/+/15408 Change subject: bsc_subscr_conn_fsm: Cleanly clear BSSAP conn if associated channel closed during WAIT_CC .. bsc_subscr_conn_fsm

Change in ...libosmo-sccp[master]: ss7: Do not queue messages if stream is not connected

2019-09-04 Thread pespin
pespin has uploaded this change for review. ( https://gerrit.osmocom.org/c/libosmo-sccp/+/15405 Change subject: ss7: Do not queue messages if stream is not connected .. ss7: Do not queue messages if stream is not connected

Change in ...osmo-ttcn3-hacks[master]: RAN_Adapter: f_ran_adapter_cleanup() check if adapter is bound

2019-09-04 Thread pespin
pespin has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/15391 ) Change subject: RAN_Adapter: f_ran_adapter_cleanup() check if adapter is bound .. Patch Set 3: Code-Review-1 Don't merge

Change in ...osmo-bts[master]: ETWS Primary Notification via P1 Rest Octets

2019-09-05 Thread pespin
pespin has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-bts/+/15417 ) Change subject: ETWS Primary Notification via P1 Rest Octets .. Patch Set 2: Code-Review+2 (1 comment) https://gerrit.osmocom.org

Change in ...osmo-ttcn3-hacks[master]: bsc: Test suite for CBSP (Cell Broadcast Service Protocol)

2019-09-05 Thread pespin
pespin has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/15376 ) Change subject: bsc: Test suite for CBSP (Cell Broadcast Service Protocol) .. Patch Set 5: (1 comment) https

Change in ...osmo-pcu[master]: Introduce osmo_tdef infra and timer VTY commands

2019-09-06 Thread pespin
pespin has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-pcu/+/15425 ) Change subject: Introduce osmo_tdef infra and timer VTY commands .. Patch Set 2: Build failing due to dependent libosmocore patch

Change in ...osmo-trx[master]: Transceiver: Fix logging TN and version

2019-09-06 Thread pespin
pespin has uploaded this change for review. ( https://gerrit.osmocom.org/c/osmo-trx/+/15433 Change subject: Transceiver: Fix logging TN and version .. Transceiver: Fix logging TN and version Since tn is declared as uint8_t

Change in ...osmo-trx[master]: Transceiver: Log error condition no burst in pullRadioVector()

2019-09-06 Thread pespin
pespin has uploaded this change for review. ( https://gerrit.osmocom.org/c/osmo-trx/+/15435 Change subject: Transceiver: Log error condition no burst in pullRadioVector() .. Transceiver: Log error condition no burst

Change in ...osmo-trx[master]: Transceiver: Don't stop TRX if pulling from OFF timeslot

2019-09-06 Thread pespin
pespin has uploaded this change for review. ( https://gerrit.osmocom.org/c/osmo-trx/+/15436 Change subject: Transceiver: Don't stop TRX if pulling from OFF timeslot .. Transceiver: Don't stop TRX if pulling from OFF timeslot

Change in ...osmo-trx[master]: Transceiver: Use LOGCHAN in logRxBurst to unify log format

2019-09-06 Thread pespin
pespin has uploaded this change for review. ( https://gerrit.osmocom.org/c/osmo-trx/+/15434 Change subject: Transceiver: Use LOGCHAN in logRxBurst to unify log format .. Transceiver: Use LOGCHAN in logRxBurst to unify log

Change in ...osmo-sgsn[master]: sgsn: Reject PdpActReq if no GTP pdp ctx exists

2019-09-06 Thread pespin
/settings Gerrit-Project: osmo-sgsn Gerrit-Branch: master Gerrit-Change-Id: I6dd87557ebb26fdbd280504abde10d976acecf64 Gerrit-Change-Number: 15330 Gerrit-PatchSet: 2 Gerrit-Owner: pespin Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: lynxis lazus Gerrit-Reviewer: pespin Gerrit-MessageType: newpatchset

Change in ...osmo-pcu[master]: Introduce osmo_tdef infra and timer VTY commands

2019-09-06 Thread pespin
pespin has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-pcu/+/15425 ) Change subject: Introduce osmo_tdef infra and timer VTY commands .. Patch Set 2: (1 comment) https://gerrit.osmocom.org/#/c/15425/2

Change in ...osmo-iuh[master]: iu_client: allow to control the notifications

2019-09-12 Thread pespin
pespin has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-iuh/+/15472 ) Change subject: iu_client: allow to control the notifications .. Patch Set 2: Code-Review+1 -- To view, visit https

Change in ...osmo-bts[master]: osmo-bts-trx/scheduler: fix: check rc of osmo_ecu_frame_out()

2019-09-12 Thread pespin
pespin has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-bts/+/15489 ) Change subject: osmo-bts-trx/scheduler: fix: check rc of osmo_ecu_frame_out() .. Patch Set 1: (1 comment) https

Change in ...osmo-sgsn[master]: mm_gb_fsm: unassign the llme when entering MM_IDLE

2019-09-12 Thread pespin
pespin has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-sgsn/+/15479 ) Change subject: mm_gb_fsm: unassign the llme when entering MM_IDLE .. Patch Set 2: Code-Review+2 -- To view, visit https

Change in ...osmo-pcu[master]: tbf_dl: add comments to the scheduler

2019-09-12 Thread pespin
pespin has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-pcu/+/15466 ) Change subject: tbf_dl: add comments to the scheduler .. Patch Set 2: Code-Review+2 -- To view, visit https://gerrit.osmocom.org/c

Change in ...osmo-msc[master]: vlr_auth_fsm: on SAI use the GSUP provided GMM cause code

2019-09-12 Thread pespin
pespin has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-msc/+/15492 ) Change subject: vlr_auth_fsm: on SAI use the GSUP provided GMM cause code .. Patch Set 1: (1 comment) https://gerrit.osmocom.org

Change in ...osmo-sgsn[master]: gprs_ranap: introduce Iu helper to free the UE context

2019-09-12 Thread pespin
pespin has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-sgsn/+/15481 ) Change subject: gprs_ranap: introduce Iu helper to free the UE context .. Patch Set 2: gprs_ranap.c: In function

Change in ...osmo-sgsn[master]: gprs_ranap: refactor REQUIRE_MM define

2019-09-12 Thread pespin
pespin has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-sgsn/+/15480 ) Change subject: gprs_ranap: refactor REQUIRE_MM define .. Patch Set 2: Code-Review+2 -- To view, visit https://gerrit.osmocom.org

Change in ...osmo-iuh[master]: iu_client: introduce ranap_iu_tx_release_free()

2019-09-12 Thread pespin
pespin has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-iuh/+/15473 ) Change subject: iu_client: introduce ranap_iu_tx_release_free() .. Patch Set 2: Code-Review+1 (1 comment) https

Change in ...osmo-iuh[master]: iu_client: allow to control the notifications

2019-09-12 Thread pespin
pespin has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-iuh/+/15472 ) Change subject: iu_client: allow to control the notifications .. Patch Set 2: (1 comment) https://gerrit.osmocom.org/#/c/15472/2

Change in ...libosmocore[master]: tdef: fixup osmo_tdef_set()

2019-09-12 Thread pespin
pespin has posted comments on this change. ( https://gerrit.osmocom.org/c/libosmocore/+/15478 ) Change subject: tdef: fixup osmo_tdef_set() .. Patch Set 1: Code-Review+2 -- To view, visit https://gerrit.osmocom.org/c

Change in ...osmo-msc[master]: vlr: gmm_cause_to_fsm_and_mm_cause() drop fsm_cause_p argument

2019-09-12 Thread pespin
pespin has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-msc/+/15490 ) Change subject: vlr: gmm_cause_to_fsm_and_mm_cause() drop fsm_cause_p argument .. Patch Set 1: Code-Review+1 (1 comment) https

Change in ...osmo-ttcn3-hacks[master]: msc: add f_tc_lu_and_mt_sms_paging_repeated

2019-09-12 Thread pespin
pespin has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/15493 ) Change subject: msc: add f_tc_lu_and_mt_sms_paging_repeated .. Patch Set 1: Code-Review+1 -- To view, visit https

Change in ...osmo-msc[master]: Introduce multiple paging attempts

2019-09-12 Thread pespin
pespin has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-msc/+/15494 ) Change subject: Introduce multiple paging attempts .. Patch Set 1: (1 comment) https://gerrit.osmocom.org/#/c/15494/1/include

Change in ...osmo-sgsn[master]: gprs_ranap: introduce Iu helper to free the UE context

2019-09-12 Thread pespin
pespin has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-sgsn/+/15481 ) Change subject: gprs_ranap: introduce Iu helper to free the UE context .. Patch Set 2: (1 comment) https://gerrit.osmocom.org/#/c

Change in ...osmo-sgsn[master]: Iu: implement a user inactivity timer

2019-09-12 Thread pespin
pespin has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-sgsn/+/15483 ) Change subject: Iu: implement a user inactivity timer .. Patch Set 2: Code-Review-1 (5 comments) https://gerrit.osmocom.org/#/c

Change in ...osmo-ttcn3-hacks[master]: sgsn: add TC_geran_attach_iu_rau

2019-09-12 Thread pespin
pespin has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/15397 ) Change subject: sgsn: add TC_geran_attach_iu_rau .. Patch Set 8: Code-Review+2 (1 comment) https://gerrit.osmocom.org/#/c

Change in ...osmo-msc[master]: Introduce multiple paging attempts

2019-09-12 Thread pespin
pespin has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-msc/+/15494 ) Change subject: Introduce multiple paging attempts .. Patch Set 1: (5 comments) https://gerrit.osmocom.org/#/c/15494/1/include

Change in ...osmo-sgsn[master]: gprs_ranap: on Iu release, stop the attach fsm if running

2019-09-12 Thread pespin
pespin has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-sgsn/+/15485 ) Change subject: gprs_ranap: on Iu release, stop the attach fsm if running .. Patch Set 2: (1 comment) https://gerrit.osmocom.org

Change in ...osmo-iuh[master]: iu_client: introduce UE field free_on_release

2019-09-12 Thread pespin
pespin has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-iuh/+/15474 ) Change subject: iu_client: introduce UE field free_on_release .. Patch Set 2: Code-Review+1 -- To view, visit https

Change in ...osmo-sgsn[master]: gprs_ranap: release Iu UE Context when exiting PMM Connected

2019-09-12 Thread pespin
pespin has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-sgsn/+/15482 ) Change subject: gprs_ranap: release Iu UE Context when exiting PMM Connected .. Patch Set 2: Code-Review+1 -- To view, visit https

Change in ...osmo-sgsn[master]: gprs_mm_state_gb_fsm: ensure T3350 is not running when entering IDLE

2019-09-12 Thread pespin
pespin has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-sgsn/+/15486 ) Change subject: gprs_mm_state_gb_fsm: ensure T3350 is not running when entering IDLE .. Patch Set 2: (1 comment) https

Change in ...osmo-ttcn3-hacks[master]: sgsn: TC_attach_check_complete_resend: Expect LU sent to HLR

2019-09-12 Thread pespin
pespin has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/15475 ) Change subject: sgsn: TC_attach_check_complete_resend: Expect LU sent to HLR .. Patch Set 1: > Patch Set 1: > >

Change in ...osmo-msc[master]: make vlr_gmm_cause_to_mm_cause public

2019-09-12 Thread pespin
pespin has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-msc/+/15491 ) Change subject: make vlr_gmm_cause_to_mm_cause public .. Patch Set 1: Code-Review+1 Usually you want to have this together

Change in ...osmo-trx[master]: Transceiver: pullRadioVector(): Fix use of uninitialized value bi->tn

2019-09-13 Thread pespin
pespin has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-trx/+/15450 ) Change subject: Transceiver: pullRadioVector(): Fix use of uninitialized value bi->tn .. Patch Set 1: Code-Review+2 Merging si

Change in ...osmo-trx[master]: Transceiver: Don't stop TRX if pulling from OFF timeslot

2019-09-13 Thread pespin
pespin has submitted this change and it was merged. ( https://gerrit.osmocom.org/c/osmo-trx/+/15436 ) Change subject: Transceiver: Don't stop TRX if pulling from OFF timeslot .. Transceiver: Don't stop TRX if pulling from OFF

Change in ...osmo-pcu[master]: bts.cpp: Fix osmo_tdef initialization on older g++ compilers

2019-09-13 Thread pespin
pespin has submitted this change and it was merged. ( https://gerrit.osmocom.org/c/osmo-pcu/+/15510 ) Change subject: bts.cpp: Fix osmo_tdef initialization on older g++ compilers .. bts.cpp: Fix osmo_tdef initialization

Change in ...osmo-pcu[master]: bts.cpp: Fix osmo_tdef initialization on older g++ compilers

2019-09-13 Thread pespin
pespin has uploaded this change for review. ( https://gerrit.osmocom.org/c/osmo-pcu/+/15510 Change subject: bts.cpp: Fix osmo_tdef initialization on older g++ compilers .. bts.cpp: Fix osmo_tdef initialization on older g

Change in ...osmo-trx[master]: Transceiver: Don't stop TRX if pulling from OFF timeslot

2019-09-13 Thread pespin
pespin has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-trx/+/15436 ) Change subject: Transceiver: Don't stop TRX if pulling from OFF timeslot .. Patch Set 2: Code-Review+2 Merging since it fixes

Change in ...osmo-trx[master]: Transceiver: pullRadioVector(): Fix use of uninitialized value bi->tn

2019-09-13 Thread pespin
pespin has submitted this change and it was merged. ( https://gerrit.osmocom.org/c/osmo-trx/+/15450 ) Change subject: Transceiver: pullRadioVector(): Fix use of uninitialized value bi->tn .. Transceiver: pullRadioVector():

Change in ...osmo-gsm-tester[master]: Revert "resources.conf.prod: Use different ARFCN for sysmocell-5k"

2019-09-12 Thread pespin
pespin has submitted this change and it was merged. ( https://gerrit.osmocom.org/c/osmo-gsm-tester/+/15468 ) Change subject: Revert "resources.conf.prod: Use different ARFCN for sysmocell-5k" .. Revert "reso

Change in ...osmo-gsm-tester[master]: process: respawn(): return process result

2019-09-12 Thread pespin
pespin has submitted this change and it was merged. ( https://gerrit.osmocom.org/c/osmo-gsm-tester/+/15463 ) Change subject: process: respawn(): return process result .. process: respawn(): return process result Change-Id

Change in ...osmo-gsm-tester[master]: process: Introduce respawn_sync() method

2019-09-12 Thread pespin
pespin has submitted this change and it was merged. ( https://gerrit.osmocom.org/c/osmo-gsm-tester/+/15464 ) Change subject: process: Introduce respawn_sync() method .. process: Introduce respawn_sync() method Change-Id

Change in ...osmo-gsm-tester[master]: Support SC5 power cycling through powersupply

2019-09-12 Thread pespin
pespin has submitted this change and it was merged. ( https://gerrit.osmocom.org/c/osmo-gsm-tester/+/15465 ) Change subject: Support SC5 power cycling through powersupply .. Support SC5 power cycling through powersupply * Add

Change in ...osmo-gsm-tester[master]: Revert "resources.conf.prod: Use different ARFCN for sysmocell-5k"

2019-09-12 Thread pespin
pespin has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-gsm-tester/+/15468 ) Change subject: Revert "resources.conf.prod: Use different ARFCN for sysmocell-5k" .. Patch Set 1: Code-Review+2

Change in ...osmo-pcu[master]: Use osmo_tdef to implement dl-tbf-idle-time

2019-09-12 Thread pespin
: I5e4f0d2f90e643600b7752525d6c2830856c9d3b Gerrit-Change-Number: 15454 Gerrit-PatchSet: 3 Gerrit-Owner: pespin Gerrit-Reviewer: Jenkins Builder Gerrit-MessageType: newpatchset

Change in ...osmo-pcu[master]: Introduce osmo_tdef infra and timer VTY commands

2019-09-12 Thread pespin
rit-Branch: master Gerrit-Change-Id: I5cfb9ef01706124be262d4536617b9edb4601dd5 Gerrit-Change-Number: 15425 Gerrit-PatchSet: 7 Gerrit-Owner: pespin Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria Gerrit-Reviewer: laforge Gerrit-Reviewer: lynxis lazus Gerrit-Reviewer: osmith Gerrit-Review

Change in ...osmo-gsm-tester[master]: Support SC5 power cycling through powersupply

2019-09-12 Thread pespin
pespin has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-gsm-tester/+/15465 ) Change subject: Support SC5 power cycling through powersupply .. Patch Set 2: Code-Review+2 -- To view, visit https

Change in ...osmo-gsm-tester[master]: process: respawn(): return process result

2019-09-12 Thread pespin
pespin has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-gsm-tester/+/15463 ) Change subject: process: respawn(): return process result .. Patch Set 1: Code-Review+2 -- To view, visit https

Change in ...osmo-gsm-tester[master]: process: Introduce respawn_sync() method

2019-09-12 Thread pespin
pespin has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-gsm-tester/+/15464 ) Change subject: process: Introduce respawn_sync() method .. Patch Set 1: Code-Review+2 -- To view, visit https

Change in ...osmo-ttcn3-hacks[master]: sgsn: TC_attach_check_complete_resend: Expect LU sent to HLR

2019-09-12 Thread pespin
pespin has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/15475 ) Change subject: sgsn: TC_attach_check_complete_resend: Expect LU sent to HLR .. Patch Set 1: > Patch Set 1: > > &g

Change in ...osmo-pcu[master]: Use osmo_tdef to implement ms-idle-time

2019-09-13 Thread pespin
, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-pcu Gerrit-Branch: master Gerrit-Change-Id: Id8e70b0f44ef2f7e20ecdb3fd8ca93ae2a05b9a3 Gerrit-Change-Number: 15453 Gerrit-PatchSet: 4 Gerrit-Owner: pespin Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer

Change in ...osmo-pcu[master]: Use osmo_tdef to implement dl-tbf-idle-time

2019-09-13 Thread pespin
: I5e4f0d2f90e643600b7752525d6c2830856c9d3b Gerrit-Change-Number: 15454 Gerrit-PatchSet: 4 Gerrit-Owner: pespin Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: laforge Gerrit-MessageType: newpatchset

Change in ...osmo-trx[master]: radioInterfaceMulti: Check equals zero explicitly

2019-09-13 Thread pespin
pespin has uploaded this change for review. ( https://gerrit.osmocom.org/c/osmo-trx/+/15515 Change subject: radioInterfaceMulti: Check equals zero explicitly .. radioInterfaceMulti: Check equals zero explicitly It's

Change in ...osmo-trx[master]: radioInterface: Remove unusued getRxGain()

2019-09-13 Thread pespin
pespin has uploaded this change for review. ( https://gerrit.osmocom.org/c/osmo-trx/+/15519 Change subject: radioInterface: Remove unusued getRxGain() .. radioInterface: Remove unusued getRxGain() Only the radioDevice

Change in ...osmo-trx[master]: radioInterface: Rename mRadio to mDevice

2019-09-13 Thread pespin
pespin has uploaded this change for review. ( https://gerrit.osmocom.org/c/osmo-trx/+/15514 Change subject: radioInterface: Rename mRadio to mDevice .. radioInterface: Rename mRadio to mDevice Previous naming is ready

Change in ...osmo-trx[master]: USRPDevice: Fix setRxGain return on error and getRxGain() returning a...

2019-09-13 Thread pespin
pespin has uploaded this change for review. ( https://gerrit.osmocom.org/c/osmo-trx/+/15516 Change subject: USRPDevice: Fix setRxGain return on error and getRxGain() returning always 0 .. USRPDevice: Fix setRxGain return

Change in ...osmo-trx[master]: LMSDevice: Return previous txGain/rxGain if setting value failed

2019-09-13 Thread pespin
pespin has uploaded this change for review. ( https://gerrit.osmocom.org/c/osmo-trx/+/15518 Change subject: LMSDevice: Return previous txGain/rxGain if setting value failed .. LMSDevice: Return previous txGain/rxGain

Change in ...osmo-trx[master]: USRPDevice: Return previous txGain if setting value failed

2019-09-13 Thread pespin
pespin has uploaded this change for review. ( https://gerrit.osmocom.org/c/osmo-trx/+/15517 Change subject: USRPDevice: Return previous txGain if setting value failed .. USRPDevice: Return previous txGain if setting value

Change in ...osmo-trx[master]: radioInterfaceMulti: Override setTxGain() to avoid chan!=0 calls

2019-09-13 Thread pespin
pespin has uploaded this change for review. ( https://gerrit.osmocom.org/c/osmo-trx/+/15521 Change subject: radioInterfaceMulti: Override setTxGain() to avoid chan!=0 calls .. radioInterfaceMulti: Override setTxGain() to avoid

Change in ...osmo-trx[master]: radioInterface: Atomically fetch and change underrun variable

2019-09-13 Thread pespin
pespin has uploaded this change for review. ( https://gerrit.osmocom.org/c/osmo-trx/+/15524 Change subject: radioInterface: Atomically fetch and change underrun variable .. radioInterface: Atomically fetch and change underrun

Change in ...osmo-trx[master]: radioInterface{Multi, Resamp}: Fix successful writeSamples() masking u...

2019-09-13 Thread pespin
pespin has uploaded this change for review. ( https://gerrit.osmocom.org/c/osmo-trx/+/15523 Change subject: radioInterface{Multi,Resamp}: Fix successful writeSamples() masking underrun from readSamples() .. radioInterface

<    5   6   7   8   9   10   11   12   13   14   >