Change in osmo-trx[master]: vty: Don't enable random filler bursts automatically with EDGE.

2019-10-15 Thread fixeria
fixeria has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-trx/+/15796 ) Change subject: vty: Don't enable random filler bursts automatically with EDGE. .. Patch Set 1: Code-Review+1 I would CR+2, but I

Change in osmocom-bb[master]: Fix common misspellings and typos

2019-10-15 Thread fixeria
fixeria has posted comments on this change. ( https://gerrit.osmocom.org/c/osmocom-bb/+/15789 ) Change subject: Fix common misspellings and typos .. Patch Set 1: Code-Review-1 I don't think we should touch a local copy

Change in osmo-trx[master]: vty: Simplify filler burst settings and improve help and readability.

2019-10-14 Thread fixeria
fixeria has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-trx/+/15793 ) Change subject: vty: Simplify filler burst settings and improve help and readability. .. Patch Set 1: (4 comments) https

Change in osmo-ttcn3-hacks[master]: BTS_Tests.ttcn: add a test case for PTCCH/D and PTCCH/U

2019-10-13 Thread fixeria
fixeria has uploaded this change for review. ( https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/15792 ) Change subject: BTS_Tests.ttcn: add a test case for PTCCH/D and PTCCH/U .. BTS_Tests.ttcn: add a test case for PTCCH/D

Change in libosmocore[master]: vty: Fix go_parent_cb not called for indented nodes at end of cfg file

2019-10-11 Thread fixeria
fixeria has posted comments on this change. ( https://gerrit.osmocom.org/c/libosmocore/+/15777 ) Change subject: vty: Fix go_parent_cb not called for indented nodes at end of cfg file .. Patch Set 1: Code-Review+1

Change in libosmocore[master]: tdef: Return correct snprintf value for osmo_tdef_range_str_buf()

2019-10-11 Thread fixeria
fixeria has posted comments on this change. ( https://gerrit.osmocom.org/c/libosmocore/+/15779 ) Change subject: tdef: Return correct snprintf value for osmo_tdef_range_str_buf() .. Patch Set 1: Code-Review+1 -- To view

Change in libosmocore[master]: vty/vty.c: log received commands from telnet interface

2019-10-11 Thread fixeria
/+/14974 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: libosmocore Gerrit-Branch: master Gerrit-Change-Id: I5f6639f6ebc3e8f8df50ef48538df94285b759fd Gerrit-Change-Number: 14974 Gerrit-PatchSet: 6 Gerrit-Owner: fixeria Gerrit-Reviewer

Change in libosmocore[master]: vty/vty.c: log received commands from telnet interface

2019-10-11 Thread fixeria
/+/14974 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: libosmocore Gerrit-Branch: master Gerrit-Change-Id: I5f6639f6ebc3e8f8df50ef48538df94285b759fd Gerrit-Change-Number: 14974 Gerrit-PatchSet: 5 Gerrit-Owner: fixeria Gerrit-Reviewer

Change in libosmocore[master]: vty/vty.c: log received commands from telnet interface

2019-10-11 Thread fixeria
fixeria has posted comments on this change. ( https://gerrit.osmocom.org/c/libosmocore/+/14974 ) Change subject: vty/vty.c: log received commands from telnet interface .. Patch Set 4: This change is ready for review

Change in ...osmo-bts[master]: log: set L1 SAPI log context

2019-10-11 Thread fixeria
fixeria has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-bts/+/15539 ) Change subject: log: set L1 SAPI log context .. Patch Set 9: Code-Review+1 -- To view, visit https://gerrit.osmocom.org/c/osmo-bts

Change in ...osmo-bts[master]: scheduler_trx: use gsm0502_fn_remap() to calculate frame number

2019-10-10 Thread fixeria
fixeria has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-bts/+/15757 ) Change subject: scheduler_trx: use gsm0502_fn_remap() to calculate frame number .. Patch Set 1: (4 comments) https

Change in ...osmo-bts[master]: log: set L1 SAPI log context

2019-10-10 Thread fixeria
fixeria has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-bts/+/15539 ) Change subject: log: set L1 SAPI log context .. Patch Set 8: Code-Review-1 (2 comments) https://gerrit.osmocom.org/#/c/15539/8/src

Change in ...libosmo-netif[master]: stream.c: remove duplicated line setting variable

2019-10-10 Thread fixeria
fixeria has posted comments on this change. ( https://gerrit.osmocom.org/c/libosmo-netif/+/15748 ) Change subject: stream.c: remove duplicated line setting variable .. Patch Set 1: Code-Review+2 -- To view, visit https

Change in ...osmo-bts[master]: README.md: update osmo-bts-trx specific limitations

2019-10-09 Thread fixeria
fixeria has uploaded this change for review. ( https://gerrit.osmocom.org/c/osmo-bts/+/15740 Change subject: README.md: update osmo-bts-trx specific limitations .. README.md: update osmo-bts-trx specific limitations

Change in ...osmo-bts[master]: log: set L1 SAPI log context

2019-10-09 Thread fixeria
fixeria has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-bts/+/15539 ) Change subject: log: set L1 SAPI log context .. Patch Set 7: (3 comments) https://gerrit.osmocom.org/#/c/15539/7/src/common

Change in ...osmo-ttcn3-hacks[master]: pcu: Introduce test TC_mo_ping_pong

2019-10-09 Thread fixeria
fixeria has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/15681 ) Change subject: pcu: Introduce test TC_mo_ping_pong .. Patch Set 6: -Code-Review > Whether it is correct behav

Change in ...osmo-bts[master]: L1SAP: there can be no DATA.ind primitives on PTCCH/U, reject them

2019-10-09 Thread fixeria
: 2 Gerrit-Owner: fixeria Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria Gerrit-CC: pespin Gerrit-MessageType: newpatchset

Change in ...osmo-bts[master]: L1SAP: there can be no DATA.ind primitives on PTCCH/U, reject them

2019-10-09 Thread fixeria
fixeria has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-bts/+/15716 ) Change subject: L1SAP: there can be no DATA.ind primitives on PTCCH/U, reject them .. Patch Set 1: (1 comment) https

Change in ...osmo-ttcn3-hacks[master]: PCUIF_RAW_Components.ttcn: ClckGen_CT: fix PTCCH event handling

2019-10-09 Thread fixeria
fixeria has submitted this change and it was merged. ( https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/15678 ) Change subject: PCUIF_RAW_Components.ttcn: ClckGen_CT: fix PTCCH event handling .. PCUIF_RAW_Components.ttcn

Change in ...osmo-ttcn3-hacks[master]: PCU_Tests_RAW.ttcn: fix ToA handling in as_ta_ptcch()

2019-10-09 Thread fixeria
fixeria has submitted this change and it was merged. ( https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/15679 ) Change subject: PCU_Tests_RAW.ttcn: fix ToA handling in as_ta_ptcch() .. PCU_Tests_RAW.ttcn: fix ToA handling

Change in ...osmo-ttcn3-hacks[master]: pcu: Introduce test TC_mo_ping_pong

2019-10-09 Thread fixeria
fixeria has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/15681 ) Change subject: pcu: Introduce test TC_mo_ping_pong .. Patch Set 6: Code-Review+1 (1 comment) It seems to me

Change in ...osmo-ttcn3-hacks[master]: PCUIF_RAW_Components.ttcn: ClckGen_CT: fix PTCCH event handling

2019-10-09 Thread fixeria
fixeria has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/15678 ) Change subject: PCUIF_RAW_Components.ttcn: ClckGen_CT: fix PTCCH event handling .. Patch Set 1: Code-Review+2 -- To view

Change in ...osmo-ttcn3-hacks[master]: PCU_Tests_RAW.ttcn: fix ToA handling in as_ta_ptcch()

2019-10-09 Thread fixeria
fixeria has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/15679 ) Change subject: PCU_Tests_RAW.ttcn: fix ToA handling in as_ta_ptcch() .. Patch Set 1: Code-Review+2 -- To view, visit

Change in ...osmo-pcu[master]: VTY: refactor pcu_vty_show_ms_all(): use show_ms()

2019-10-09 Thread fixeria
fixeria has uploaded this change for review. ( https://gerrit.osmocom.org/c/osmo-pcu/+/15726 Change subject: VTY: refactor pcu_vty_show_ms_all(): use show_ms() .. VTY: refactor pcu_vty_show_ms_all(): use show_ms() Change-Id

Change in ...osmo-pcu[master]: VTY: fix command 'show tbf all': properly filter TBFs

2019-10-09 Thread fixeria
fixeria has uploaded this change for review. ( https://gerrit.osmocom.org/c/osmo-pcu/+/15727 Change subject: VTY: fix command 'show tbf all': properly filter TBFs .. VTY: fix command 'show tbf all': properly filter TBFs

Change in ...osmo-bts[master]: L1SAP: fix gsmtap_pdch(): there can be no DATA.ind on PTCCH/U

2019-10-09 Thread fixeria
fixeria has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-bts/+/15714 ) Change subject: L1SAP: fix gsmtap_pdch(): there can be no DATA.ind on PTCCH/U .. Patch Set 1: > Ok, I just reali

Change in ...osmo-sgsn[master]: gprs_mm_state_iu_fsm.c: fix: assign timer_cb to mm_state_iu_fsm

2019-10-09 Thread fixeria
fixeria has uploaded this change for review. ( https://gerrit.osmocom.org/c/osmo-sgsn/+/15718 Change subject: gprs_mm_state_iu_fsm.c: fix: assign timer_cb to mm_state_iu_fsm .. gprs_mm_state_iu_fsm.c: fix: assign timer_cb

Change in ...osmo-sgsn[master]: sgsn_libgtp: refactor ps paging into gprs_gb

2019-10-09 Thread fixeria
fixeria has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-sgsn/+/15547 ) Change subject: sgsn_libgtp: refactor ps paging into gprs_gb .. Patch Set 4: Code-Review+1 -- To view, visit https

Change in ...osmo-bts[master]: L1SAP: clarify debug messages in rach_pass_filter()

2019-10-09 Thread fixeria
fixeria has submitted this change and it was merged. ( https://gerrit.osmocom.org/c/osmo-bts/+/15709 ) Change subject: L1SAP: clarify debug messages in rach_pass_filter() .. L1SAP: clarify debug messages in rach_pass_filter

Change in ...osmo-bts[master]: L1SAP: properly handle 11-bit encoded RACH.ind in gsmtap_ph_rach()

2019-10-09 Thread fixeria
fixeria has submitted this change and it was merged. ( https://gerrit.osmocom.org/c/osmo-bts/+/15712 ) Change subject: L1SAP: properly handle 11-bit encoded RACH.ind in gsmtap_ph_rach() .. L1SAP: properly handle 11-bit encoded

Change in ...osmo-bts[master]: L1SAP: refactor handling of Access Bursts on PDCH

2019-10-09 Thread fixeria
fixeria has submitted this change and it was merged. ( https://gerrit.osmocom.org/c/osmo-bts/+/15711 ) Change subject: L1SAP: refactor handling of Access Bursts on PDCH .. L1SAP: refactor handling of Access Bursts on PDCH

Change in ...osmo-bts[master]: L1SAP: also consider RSL_CHAN_OSMO_CBCH8 as CBCH

2019-10-09 Thread fixeria
fixeria has submitted this change and it was merged. ( https://gerrit.osmocom.org/c/osmo-bts/+/15708 ) Change subject: L1SAP: also consider RSL_CHAN_OSMO_CBCH8 as CBCH .. L1SAP: also consider RSL_CHAN_OSMO_CBCH8 as CBCH

Change in ...osmo-bts[master]: L1SAP: do not pass unused parameter to l1sap_handover_rach()

2019-10-09 Thread fixeria
fixeria has submitted this change and it was merged. ( https://gerrit.osmocom.org/c/osmo-bts/+/15710 ) Change subject: L1SAP: do not pass unused parameter to l1sap_handover_rach() .. L1SAP: do not pass unused parameter

Change in ...osmo-bts[master]: L1SAP: use RSL_CHAN_* definitions from libosmogsm

2019-10-09 Thread fixeria
fixeria has submitted this change and it was merged. ( https://gerrit.osmocom.org/c/osmo-bts/+/15707 ) Change subject: L1SAP: use RSL_CHAN_* definitions from libosmogsm .. L1SAP: use RSL_CHAN_* definitions from libosmogsm

Change in ...osmo-ttcn3-hacks[master]: pcu: add TC_paging_cs_from_bts

2019-10-09 Thread fixeria
fixeria has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/15623 ) Change subject: pcu: add TC_paging_cs_from_bts .. Patch Set 2: (1 comment) https://gerrit.osmocom.org/#/c/15623/2/pcu

Change in ...osmo-ttcn3-hacks[master]: pcu: add TC_paging_cs_from_bts

2019-10-09 Thread fixeria
fixeria has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/15623 ) Change subject: pcu: add TC_paging_cs_from_bts .. Patch Set 2: Code-Review-1 (3 comments) https://gerrit.osmocom.org/#/c

Change in ...osmo-sgsn[master]: sgsn_libgtp: refactor ps paging into gprs_gb

2019-10-08 Thread fixeria
fixeria has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-sgsn/+/15547 ) Change subject: sgsn_libgtp: refactor ps paging into gprs_gb .. Patch Set 3: Code-Review+1 (1 comment) https://gerrit.osmocom.org

Change in ...osmo-bts[master]: L1SAP: use GSMTAP_CHANNEL_PDTCH for PDTCH blocks by default

2019-10-08 Thread fixeria
fixeria has uploaded this change for review. ( https://gerrit.osmocom.org/c/osmo-bts/+/15715 Change subject: L1SAP: use GSMTAP_CHANNEL_PDTCH for PDTCH blocks by default .. L1SAP: use GSMTAP_CHANNEL_PDTCH for PDTCH blocks

Change in ...osmo-bts[master]: L1SAP: fix gsmtap_pdch(): there can be no DATA.ind on PTCCH/U

2019-10-08 Thread fixeria
fixeria has uploaded this change for review. ( https://gerrit.osmocom.org/c/osmo-bts/+/15714 Change subject: L1SAP: fix gsmtap_pdch(): there can be no DATA.ind on PTCCH/U .. L1SAP: fix gsmtap_pdch(): there can be no DATA.ind

Change in ...osmo-bts[master]: L1SAP: use the actual ARFCN for outgoing PCUIF messages

2019-10-08 Thread fixeria
fixeria has uploaded this change for review. ( https://gerrit.osmocom.org/c/osmo-bts/+/15713 Change subject: L1SAP: use the actual ARFCN for outgoing PCUIF messages .. L1SAP: use the actual ARFCN for outgoing PCUIF messages

Change in ...osmo-bts[master]: L1SAP: there can be no DATA.ind primitives on PTCCH/U, reject them

2019-10-08 Thread fixeria
fixeria has uploaded this change for review. ( https://gerrit.osmocom.org/c/osmo-bts/+/15716 Change subject: L1SAP: there can be no DATA.ind primitives on PTCCH/U, reject them .. L1SAP: there can be no DATA.ind primitives

Change in ...osmo-bts[master]: L1SAP: clarify debug messages in rach_pass_filter()

2019-10-08 Thread fixeria
fixeria has uploaded this change for review. ( https://gerrit.osmocom.org/c/osmo-bts/+/15709 Change subject: L1SAP: clarify debug messages in rach_pass_filter() .. L1SAP: clarify debug messages in rach_pass_filter() RACH

Change in ...osmo-bts[master]: L1SAP: also consider RSL_CHAN_OSMO_CBCH8 as CBCH

2019-10-08 Thread fixeria
fixeria has uploaded this change for review. ( https://gerrit.osmocom.org/c/osmo-bts/+/15708 Change subject: L1SAP: also consider RSL_CHAN_OSMO_CBCH8 as CBCH .. L1SAP: also consider RSL_CHAN_OSMO_CBCH8 as CBCH Currently we

Change in ...osmo-bts[master]: L1SAP: refactor handling of Access Bursts on PDCH

2019-10-08 Thread fixeria
fixeria has uploaded this change for review. ( https://gerrit.osmocom.org/c/osmo-bts/+/15711 Change subject: L1SAP: refactor handling of Access Bursts on PDCH .. L1SAP: refactor handling of Access Bursts on PDCH First of all

Change in ...osmo-bts[master]: L1SAP: do not pass unused parameter to l1sap_handover_rach()

2019-10-08 Thread fixeria
fixeria has uploaded this change for review. ( https://gerrit.osmocom.org/c/osmo-bts/+/15710 Change subject: L1SAP: do not pass unused parameter to l1sap_handover_rach() .. L1SAP: do not pass unused parameter

Change in ...osmo-bts[master]: L1SAP: properly handle 11-bit encoded RACH.ind in gsmtap_ph_rach()

2019-10-08 Thread fixeria
fixeria has uploaded this change for review. ( https://gerrit.osmocom.org/c/osmo-bts/+/15712 Change subject: L1SAP: properly handle 11-bit encoded RACH.ind in gsmtap_ph_rach() .. L1SAP: properly handle 11-bit encoded RACH.ind

Change in ...osmo-bts[master]: L1SAP: use RSL_CHAN_* definitions from libosmogsm

2019-10-08 Thread fixeria
fixeria has uploaded this change for review. ( https://gerrit.osmocom.org/c/osmo-bts/+/15707 Change subject: L1SAP: use RSL_CHAN_* definitions from libosmogsm .. L1SAP: use RSL_CHAN_* definitions from libosmogsm Change-Id

Change in ...osmo-bts[master]: bts-trx: Time out if no clock ind recvd after RSP POWERON

2019-10-08 Thread fixeria
fixeria has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-bts/+/15706 ) Change subject: bts-trx: Time out if no clock ind recvd after RSP POWERON .. Patch Set 1: Code-Review+1 (2 comments) https

Change in ...osmo-bts[master]: bts-trx: Log TRXC and TRXD socket recv()/send() failures

2019-10-08 Thread fixeria
fixeria has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-bts/+/15702 ) Change subject: bts-trx: Log TRXC and TRXD socket recv()/send() failures .. Patch Set 1: Code-Review+1 (5 comments) Checking rc

Change in ...osmo-ttcn3-hacks[master]: pcu: Introduce test TC_mo_ping_pong

2019-10-08 Thread fixeria
fixeria has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/15681 ) Change subject: pcu: Introduce test TC_mo_ping_pong .. Patch Set 4: (3 comments) https://gerrit.osmocom.org/#/c/15681/4

Change in ...osmo-bts[master]: remove dummy UL measurement results for lost sacch frames

2019-10-07 Thread fixeria
fixeria has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-bts/+/14762 ) Change subject: remove dummy UL measurement results for lost sacch frames .. Patch Set 1: Code-Review+1 -- To view, visit https

Change in ...osmo-pcu[master]: pcu_l1_if.cpp: Imm Assign PCH: clarify size of different items

2019-10-07 Thread fixeria
fixeria has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-pcu/+/15683 ) Change subject: pcu_l1_if.cpp: Imm Assign PCH: clarify size of different items .. Patch Set 1: (5 comments) https

Change in ...osmo-pcu[master]: pcu_l1_if.cpp: Fix GSMTAP Imm Assign PCH wrong encoding

2019-10-07 Thread fixeria
fixeria has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-pcu/+/15682 ) Change subject: pcu_l1_if.cpp: Fix GSMTAP Imm Assign PCH wrong encoding .. Patch Set 1: Code-Review+2 -- To view, visit https

Change in ...libosmocore[master]: tdef: Introduce min_val and max_val fields

2019-10-07 Thread fixeria
fixeria has posted comments on this change. ( https://gerrit.osmocom.org/c/libosmocore/+/15546 ) Change subject: tdef: Introduce min_val and max_val fields .. Patch Set 7: Code-Review+1 -- To view, visit https

Change in ...osmo-ttcn3-hacks[master]: pcu: Introduce test TC_t3169

2019-10-07 Thread fixeria
fixeria has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/15676 ) Change subject: pcu: Introduce test TC_t3169 .. Patch Set 5: Code-Review+2 -- To view, visit https://gerrit.osmocom.org/c

Change in ...osmo-ttcn3-hacks[master]: pcu: Introduce func helper f_imm_ass_verify_ul_tbf_ass()

2019-10-07 Thread fixeria
fixeria has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/15675 ) Change subject: pcu: Introduce func helper f_imm_ass_verify_ul_tbf_ass() .. Patch Set 4: Code-Review+1 -- To view, visit

Change in ...osmo-ttcn3-hacks[master]: pcu: Allow tests to overwrite pcuif INFO_IND params

2019-10-07 Thread fixeria
fixeria has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/15674 ) Change subject: pcu: Allow tests to overwrite pcuif INFO_IND params .. Patch Set 3: Code-Review+1 Much better now

Change in ...osmo-ttcn3-hacks[master]: PCU_Tests_RAW.ttcn: fix ToA handling in as_ta_ptcch()

2019-10-05 Thread fixeria
fixeria has uploaded this change for review. ( https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/15679 Change subject: PCU_Tests_RAW.ttcn: fix ToA handling in as_ta_ptcch() .. PCU_Tests_RAW.ttcn: fix ToA handling in as_ta_ptcch

Change in ...osmo-ttcn3-hacks[master]: PCUIF_RAW_Components.ttcn: ClckGen_CT: fix PTCCH event handling

2019-10-05 Thread fixeria
fixeria has uploaded this change for review. ( https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/15678 Change subject: PCUIF_RAW_Components.ttcn: ClckGen_CT: fix PTCCH event handling .. PCUIF_RAW_Components.ttcn: ClckGen_CT: fix

Change in ...osmo-bts[master]: bts-trx: Drop unused func check_transceiver_availability()

2019-10-05 Thread fixeria
fixeria has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-bts/+/15631 ) Change subject: bts-trx: Drop unused func check_transceiver_availability() .. Patch Set 1: Code-Review+1 -- To view, visit https

Change in ...osmo-bts[master]: bts-trx: Get rid of messy transceiver_available state handler

2019-10-05 Thread fixeria
fixeria has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-bts/+/15615 ) Change subject: bts-trx: Get rid of messy transceiver_available state handler .. Patch Set 5: Code-Review+1 (1 comment) https

Change in ...osmo-bts[master]: bts-trx: Don't reset transceiver_available in scheduler_trx.c

2019-10-05 Thread fixeria
fixeria has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-bts/+/15630 ) Change subject: bts-trx: Don't reset transceiver_available in scheduler_trx.c .. Patch Set 1: Code-Review+1 -- To view, visit

Change in ...osmo-bts[master]: bts-trx: Rework code handling poweron state

2019-10-05 Thread fixeria
fixeria has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-bts/+/15629 ) Change subject: bts-trx: Rework code handling poweron state .. Patch Set 1: Code-Review+1 -- To view, visit https

Change in ...osmo-bts[master]: bts-trx: trx_set_bts(): Avoid double loop by checking current trx

2019-10-05 Thread fixeria
fixeria has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-bts/+/15628 ) Change subject: bts-trx: trx_set_bts(): Avoid double loop by checking current trx .. Patch Set 1: Code-Review+1 -- To view, visit

Change in ...osmo-bts[master]: bts-trx: vty: Print phy link state in cmd 'show transceiver'

2019-10-05 Thread fixeria
fixeria has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-bts/+/15627 ) Change subject: bts-trx: vty: Print phy link state in cmd 'show transceiver' .. Patch Set 1: (2 comments) https

Change in ...osmo-bts[master]: bts-trx: Allocate struct osmo_trx_clock_state as part of bts-trx priv...

2019-10-05 Thread fixeria
fixeria has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-bts/+/15614 ) Change subject: bts-trx: Allocate struct osmo_trx_clock_state as part of bts-trx private data .. Patch Set 4: Code-Review+2

Change in ...osmo-bts[master]: struct gsm_bts: Add model_priv pointer handing bts_model specific data

2019-10-05 Thread fixeria
fixeria has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-bts/+/15613 ) Change subject: struct gsm_bts: Add model_priv pointer handing bts_model specific data .. Patch Set 4: Code-Review+1 (2 comments

Change in ...osmocom-bb[master]: host/trxcon: add optional GSMTAP frame logging support

2019-10-05 Thread fixeria
fixeria has submitted this change and it was merged. ( https://gerrit.osmocom.org/c/osmocom-bb/+/15568 ) Change subject: host/trxcon: add optional GSMTAP frame logging support .. host/trxcon: add optional GSMTAP frame logging

Change in ...osmocom-bb[master]: host/trxcon: add optional GSMTAP frame logging support

2019-10-05 Thread fixeria
fixeria has posted comments on this change. ( https://gerrit.osmocom.org/c/osmocom-bb/+/15568 ) Change subject: host/trxcon: add optional GSMTAP frame logging support .. Patch Set 2: This change is ready for review

Change in ...libosmocore[master]: add osmo_fsm_inst_watch()

2019-10-04 Thread fixeria
fixeria has posted comments on this change. ( https://gerrit.osmocom.org/c/libosmocore/+/15660 ) Change subject: add osmo_fsm_inst_watch() .. Patch Set 2: (1 comment) https://gerrit.osmocom.org/#/c/15660/2//COMMIT_MSG Commit

Change in ...osmocom-bb[master]: trxcon/scheduler: fix handling of PTCCH logical channel

2019-10-04 Thread fixeria
fixeria has submitted this change and it was merged. ( https://gerrit.osmocom.org/c/osmocom-bb/+/15626 ) Change subject: trxcon/scheduler: fix handling of PTCCH logical channel .. trxcon/scheduler: fix handling of PTCCH logical

Change in ...osmocom-bb[master]: trxcon/scheduler: fix comment in description of PDTCH

2019-10-04 Thread fixeria
fixeria has submitted this change and it was merged. ( https://gerrit.osmocom.org/c/osmocom-bb/+/15625 ) Change subject: trxcon/scheduler: fix comment in description of PDTCH .. trxcon/scheduler: fix comment in description

Change in ...osmocom-bb[master]: trxcon/scheduler: fix handling of PTCCH logical channel

2019-10-04 Thread fixeria
fixeria has posted comments on this change. ( https://gerrit.osmocom.org/c/osmocom-bb/+/15626 ) Change subject: trxcon/scheduler: fix handling of PTCCH logical channel .. Patch Set 1: Code-Review+2 -- To view, visit https

Change in ...osmocom-bb[master]: trxcon/scheduler: fix comment in description of PDTCH

2019-10-04 Thread fixeria
fixeria has posted comments on this change. ( https://gerrit.osmocom.org/c/osmocom-bb/+/15625 ) Change subject: trxcon/scheduler: fix comment in description of PDTCH .. Patch Set 1: Code-Review+2 -- To view, visit https

Change in ...osmo-ttcn3-hacks[master]: pcu: Introduce test TC_t3169

2019-10-04 Thread fixeria
fixeria has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/15676 ) Change subject: pcu: Introduce test TC_t3169 .. Patch Set 2: (8 comments) https://gerrit.osmocom.org/#/c/15676/2/library

Change in ...osmo-ttcn3-hacks[master]: pcu: Introduce func helper f_establish_tbf_ul()

2019-10-04 Thread fixeria
fixeria has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/15675 ) Change subject: pcu: Introduce func helper f_establish_tbf_ul() .. Patch Set 1: (2 comments) https://gerrit.osmocom.org

Change in ...libosmocore[master]: add osmo_fsm_set_dealloc_ctx(), to help with use-after-free

2019-10-04 Thread fixeria
fixeria has posted comments on this change. ( https://gerrit.osmocom.org/c/libosmocore/+/15677 ) Change subject: add osmo_fsm_set_dealloc_ctx(), to help with use-after-free .. Patch Set 1: Code-Review+1 (1 comment) Same

Change in ...osmo-ttcn3-hacks[master]: pcu: Allow tests to overwrite pcuif INFO_IND params

2019-10-04 Thread fixeria
fixeria has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/15674 ) Change subject: pcu: Allow tests to overwrite pcuif INFO_IND params .. Patch Set 1: Code-Review-1 (4 comments) https

Change in ...osmo-ttcn3-hacks[master]: Create dummy gsmtap sink with netcat

2019-10-04 Thread fixeria
fixeria has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/15651 ) Change subject: Create dummy gsmtap sink with netcat .. Patch Set 1: Code-Review+1 -- To view, visit https

Change in ...osmo-ttcn3-hacks[master]: PCU_Tests_RAW.ttcn: add a test case for continuous Timing Advance con...

2019-10-04 Thread fixeria
-hacks/+/15672 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-ttcn3-hacks Gerrit-Branch: master Gerrit-Change-Id: I868f78e3e95a95f8f2e55e237eea700d7d4726a3 Gerrit-Change-Number: 15672 Gerrit-PatchSet: 2 Gerrit-Owner: fixeria Gerrit

Change in ...osmo-ttcn3-hacks[master]: library/PCUIF_Types.ttcn: add optional parameter for RACH SAPI

2019-10-04 Thread fixeria
fixeria has uploaded this change for review. ( https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/15671 Change subject: library/PCUIF_Types.ttcn: add optional parameter for RACH SAPI .. library/PCUIF_Types.ttcn: add optional

Change in ...osmo-ttcn3-hacks[master]: PCU_Tests_RAW.ttcn: add a test case for continuous Timing Advance con...

2019-10-04 Thread fixeria
fixeria has uploaded this change for review. ( https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/15672 Change subject: PCU_Tests_RAW.ttcn: add a test case for continuous Timing Advance control .. PCU_Tests_RAW.ttcn: add a test

Change in ...osmo-sgsn[master]: Avoid compiling unneeded files when building without Iu

2019-10-03 Thread fixeria
fixeria has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-sgsn/+/15618 ) Change subject: Avoid compiling unneeded files when building without Iu .. Patch Set 3: Code-Review+2 -- To view, visit https

Change in ...osmo-ttcn3-hacks[master]: pcu: Introduce some function helpers

2019-10-03 Thread fixeria
fixeria has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/15664 ) Change subject: pcu: Introduce some function helpers .. Patch Set 1: Code-Review+1 (1 comment) Cool! I was also thinking

Change in ...libosmocore[master]: add osmo_fsm_inst_watch()

2019-10-03 Thread fixeria
fixeria has posted comments on this change. ( https://gerrit.osmocom.org/c/libosmocore/+/15660 ) Change subject: add osmo_fsm_inst_watch() .. Patch Set 2: (2 comments) https://gerrit.osmocom.org/#/c/15660/2//COMMIT_MSG

Change in ...libosmocore[master]: API doc tweaks (mncc.h, gsm_08_08.h)

2019-10-03 Thread fixeria
fixeria has posted comments on this change. ( https://gerrit.osmocom.org/c/libosmocore/+/15659 ) Change subject: API doc tweaks (mncc.h, gsm_08_08.h) .. Patch Set 1: Code-Review+2 -- To view, visit https://gerrit.osmocom.org

Change in ...osmo-bts[master]: l1sap: Log conn dropped due to radio link counter timeout

2019-10-02 Thread fixeria
fixeria has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-bts/+/15654 ) Change subject: l1sap: Log conn dropped due to radio link counter timeout .. Patch Set 3: Code-Review+2 -- To view, visit https

Change in ...osmo-bts[master]: scheduler.c: Move some message log level to DEBUG

2019-10-02 Thread fixeria
fixeria has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-bts/+/15653 ) Change subject: scheduler.c: Move some message log level to DEBUG .. Patch Set 2: Code-Review+2 -- To view, visit https

Change in ...osmo-bts[master]: scheduler: Use OSMO_ASSERT instead of abort

2019-10-02 Thread fixeria
fixeria has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-bts/+/15655 ) Change subject: scheduler: Use OSMO_ASSERT instead of abort .. Patch Set 1: Code-Review+2 -- To view, visit https

Change in ...osmo-bts[master]: osmo-bts-trx/scheduler: also detect TSC for Access Bursts on PDCH

2019-10-02 Thread fixeria
fixeria has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-bts/+/15657 ) Change subject: osmo-bts-trx/scheduler: also detect TSC for Access Bursts on PDCH .. Patch Set 1: > Looks like this patch belo

Change in ...osmo-bts[master]: scheduler: fix handling of PTCCH/U and PTCCH/D logical channels

2019-10-02 Thread fixeria
fixeria has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-bts/+/15656 ) Change subject: scheduler: fix handling of PTCCH/U and PTCCH/D logical channels .. Patch Set 1: (1 comment) https

Change in ...osmo-bts[master]: osmo-bts-trx/scheduler: also detect TSC for Access Bursts on PDCH

2019-10-02 Thread fixeria
fixeria has uploaded this change for review. ( https://gerrit.osmocom.org/c/osmo-bts/+/15657 Change subject: osmo-bts-trx/scheduler: also detect TSC for Access Bursts on PDCH .. osmo-bts-trx/scheduler: also detect TSC

Change in ...osmo-bts[master]: scheduler: fix handling of PTCCH/U and PTCCH/D logical channels

2019-10-02 Thread fixeria
fixeria has uploaded this change for review. ( https://gerrit.osmocom.org/c/osmo-bts/+/15656 Change subject: scheduler: fix handling of PTCCH/U and PTCCH/D logical channels .. scheduler: fix handling of PTCCH/U and PTCCH/D

Change in ...osmo-bts[master]: common/l1sap: increase ToA precision for packet Access Bursts

2019-10-02 Thread fixeria
fixeria has uploaded this change for review. ( https://gerrit.osmocom.org/c/osmo-bts/+/15658 Change subject: common/l1sap: increase ToA precision for packet Access Bursts .. common/l1sap: increase ToA precision for packet

Change in ...osmo-bts[master]: l1sap: Log conn dropped due to radio link counter timeout

2019-10-02 Thread fixeria
fixeria has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-bts/+/15654 ) Change subject: l1sap: Log conn dropped due to radio link counter timeout .. Patch Set 1: (1 comment) https://gerrit.osmocom.org

Change in ...osmo-bts[master]: scheduler.c: Move some message log level to DEBUG

2019-10-02 Thread fixeria
fixeria has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-bts/+/15653 ) Change subject: scheduler.c: Move some message log level to DEBUG .. Patch Set 1: Code-Review+1 (2 comments) https

Change in ...osmo-ttcn3-hacks[master]: MSC_Tests.ttcn: fix race condition in f_tc_proc_ss_paging_fail()

2019-10-01 Thread fixeria
fixeria has uploaded this change for review. ( https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/15648 Change subject: MSC_Tests.ttcn: fix race condition in f_tc_proc_ss_paging_fail() .. MSC_Tests.ttcn: fix race condition

Change in ...osmo-pcu[master]: Log AGCH and PCH blocks using GSMTAP

2019-10-01 Thread fixeria
fixeria has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-pcu/+/15633 ) Change subject: Log AGCH and PCH blocks using GSMTAP .. Patch Set 3: Code-Review+1 -- To view, visit https://gerrit.osmocom.org/c

Change in ...osmo-ttcn3-hacks[master]: PCU_Tests_RAW.ttcn: introduce a test case for PTCCH/D coding

2019-10-01 Thread fixeria
fixeria has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/15638 ) Change subject: PCU_Tests_RAW.ttcn: introduce a test case for PTCCH/D coding .. Patch Set 1: (1 comment) https

Change in ...osmo-ttcn3-hacks[master]: PCU_Tests_RAW.ttcn: introduce a test case for PTCCH/D coding

2019-09-30 Thread fixeria
fixeria has uploaded this change for review. ( https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/15638 Change subject: PCU_Tests_RAW.ttcn: introduce a test case for PTCCH/D coding .. PCU_Tests_RAW.ttcn: introduce a test case

  1   2   3   4   5   6   7   8   9   >