Change in ...osmo-sip-connector[master]: exit if the sip agent failed to start

2019-09-16 Thread keith
keith has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-sip-connector/+/15532 ) Change subject: exit if the sip agent failed to start .. Patch Set 1: > Assume osmo-sip-connector is only managed thro

Change in ...osmo-sip-connector[master]: exit if the sip agent failed to start

2019-09-16 Thread keith
keith has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-sip-connector/+/15532 ) Change subject: exit if the sip agent failed to start .. Patch Set 1: > Assume osmo-sip-connector is only managed thro

Change in ...osmo-sip-connector[master]: .service: require to ran after network-online.target

2019-09-16 Thread keith
keith has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-sip-connector/+/15533 ) Change subject: .service: require to ran after network-online.target .. Patch Set 1: Code-Review+1 I've verified

Change in ...osmo-msc[master]: Implement a global switch on the network to disable call waiting.

2019-09-03 Thread keith
keith has submitted this change and it was merged. ( https://gerrit.osmocom.org/c/osmo-msc/+/15120 ) Change subject: Implement a global switch on the network to disable call waiting. .. Implement a global switch on the network

Change in ...osmo-msc[master]: Implement a global switch on the network to disable call waiting.

2019-09-03 Thread keith
keith has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-msc/+/15120 ) Change subject: Implement a global switch on the network to disable call waiting. .. Patch Set 12: Code-Review+2 -- To view, visit

Change in ...osmo-sgsn[master]: libgtp: don't call sgsn_pdp_ctx_free() with NULL pdp

2019-08-28 Thread keith
keith has abandoned this change. ( https://gerrit.osmocom.org/c/osmo-sgsn/+/13929 ) Change subject: libgtp: don't call sgsn_pdp_ctx_free() with NULL pdp .. Abandoned -- To view, visit https://gerrit.osmocom.org/c/osmo-sgsn

Change in ...osmo-msc[master]: Implement a global switch on the network to disable call waiting.

2019-08-15 Thread keith
keith has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-msc/+/15120 ) Change subject: Implement a global switch on the network to disable call waiting. .. Patch Set 12: (1 comment) https

Change in ...osmo-sip-connector[master]: avoid bogus error logs when no cmd_timer is set

2019-08-14 Thread keith
keith has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-sip-connector/+/15142 ) Change subject: avoid bogus error logs when no cmd_timer is set .. Patch Set 1: I'm actually not getting this error

Change in ...osmo-sip-connector[master]: avoid bogus error logs when no cmd_timer is set

2019-08-14 Thread keith
keith has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-sip-connector/+/15142 ) Change subject: avoid bogus error logs when no cmd_timer is set .. Patch Set 1: Looking closer, Log is kind of hard

Change in ...osmo-sip-connector[master]: avoid bogus error logs when no cmd_timer is set

2019-08-14 Thread keith
keith has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-sip-connector/+/15142 ) Change subject: avoid bogus error logs when no cmd_timer is set .. Patch Set 1: > (2 comments) hmm.. so I'm tota

Change in ...osmo-mgw[master]: differentiate AMR octet-aligned=0 vs =1

2019-08-13 Thread keith
keith has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-mgw/+/15136 ) Change subject: differentiate AMR octet-aligned=0 vs =1 .. Patch Set 3: Code-Review+1 :) -- To view, visit https

Change in ...osmo-sip-connector[master]: avoid bogus error logs when no cmd_timer is set

2019-08-12 Thread keith
keith has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-sip-connector/+/15142 ) Change subject: avoid bogus error logs when no cmd_timer is set .. Patch Set 1: (1 comment) https://gerrit.osmocom.org/#/c

Change in ...osmo-sip-connector[master]: avoid bogus error logs when no cmd_timer is set

2019-08-12 Thread keith
keith has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-sip-connector/+/15142 ) Change subject: avoid bogus error logs when no cmd_timer is set .. Patch Set 1: I'm looking at the log from a busy site

Change in ...osmo-sip-connector[master]: avoid bogus error logs when no cmd_timer is set

2019-08-12 Thread keith
keith has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-sip-connector/+/15142 ) Change subject: avoid bogus error logs when no cmd_timer is set .. Patch Set 1: (1 comment) https://gerrit.osmocom.org/#/c

Change in ...osmo-msc[master]: Implement a global switch on the network to disable call waiting.

2019-08-10 Thread keith
keith has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-msc/+/15120 ) Change subject: Implement a global switch on the network to disable call waiting. .. Patch Set 12: Code-Review+1 Just want to make

Change in ...osmo-sip-connector[master]: coverity: Address issue found by coverity

2019-08-10 Thread keith
keith has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-sip-connector/+/15143 ) Change subject: coverity: Address issue found by coverity .. Patch Set 5: Code-Review+2 -- To view, visit https

Change in ...osmo-sip-connector[master]: coverity: Address issue found by coverity

2019-08-10 Thread keith
keith has submitted this change and it was merged. ( https://gerrit.osmocom.org/c/osmo-sip-connector/+/15143 ) Change subject: coverity: Address issue found by coverity .. coverity: Address issue found by coverity Add NULL

Change in ...osmo-sip-connector[master]: coverity: Address issue found by coverity

2019-08-09 Thread keith
keith has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-sip-connector/+/15143 ) Change subject: coverity: Address issue found by coverity .. Patch Set 4: (1 comment) https://gerrit.osmocom.org/#/c/15143

Change in ...osmo-sip-connector[master]: coverity: Address issue found by coverity

2019-08-09 Thread keith
Gerrit-PatchSet: 5 Gerrit-Owner: keith Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria Gerrit-Reviewer: keith Gerrit-CC: pespin Gerrit-MessageType: newpatchset

Change in ...osmo-mgw[master]: differentiate AMR octet-aligned=0 vs =1

2019-08-09 Thread keith
keith has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-mgw/+/15136 ) Change subject: differentiate AMR octet-aligned=0 vs =1 .. Patch Set 1: (1 comment) https://gerrit.osmocom.org/#/c/15136/1/src

Change in ...osmo-mgw[master]: differentiate AMR octet-aligned=0 vs =1

2019-08-09 Thread keith
keith has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-mgw/+/15136 ) Change subject: differentiate AMR octet-aligned=0 vs =1 .. Patch Set 1: (1 comment) https://gerrit.osmocom.org/#/c/15136/1/src

Change in ...osmo-mgw[master]: differentiate AMR octet-aligned=0 vs =1

2019-08-09 Thread keith
keith has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-mgw/+/15136 ) Change subject: differentiate AMR octet-aligned=0 vs =1 .. Patch Set 1: Code-Review+1 -- To view, visit https://gerrit.osmocom.org/c

Change in ...osmo-sip-connector[master]: coverity: Address issue found by coverity

2019-08-09 Thread keith
Gerrit-PatchSet: 4 Gerrit-Owner: keith Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria Gerrit-Reviewer: keith Gerrit-CC: pespin Gerrit-MessageType: newpatchset

Change in ...osmo-sip-connector[master]: coverity: Address issue found by coverity

2019-08-09 Thread keith
keith has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-sip-connector/+/15143 ) Change subject: coverity: Address issue found by coverity .. Patch Set 3: (1 comment) https://gerrit.osmocom.org/#/c/15143

Change in ...osmo-sip-connector[master]: coverity: Address issue found by coverity

2019-08-09 Thread keith
keith has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-sip-connector/+/15143 ) Change subject: coverity: Address issue found by coverity .. Patch Set 3: (1 comment) https://gerrit.osmocom.org/#/c/15143

Change in ...osmo-sip-connector[master]: coverity: Address issue found by coverity

2019-08-09 Thread keith
Gerrit-PatchSet: 3 Gerrit-Owner: keith Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria Gerrit-CC: pespin Gerrit-MessageType: newpatchset

Change in ...osmo-msc[master]: Implement a global switch on the network to disable call waiting.

2019-08-09 Thread keith
om.org/c/osmo-msc/+/15120 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-msc Gerrit-Branch: master Gerrit-Change-Id: I3eb6f23f7103e3002874fb5d3a30c9de952202ae Gerrit-Change-Number: 15120 Gerrit-PatchSet: 12 Gerrit-Owner: keith Ge

Change in ...osmo-msc[master]: Implement a global switch on the network to disable call waiting.

2019-08-09 Thread keith
rg/c/osmo-msc/+/15120 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-msc Gerrit-Branch: master Gerrit-Change-Id: I3eb6f23f7103e3002874fb5d3a30c9de952202ae Gerrit-Change-Number: 15120 Gerrit-PatchSet: 11 Gerrit-Owner: keith Gerrit-Revi

Change in ...osmo-msc[master]: Implement a global switch on the network to disable call waiting.

2019-08-09 Thread keith
keith has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-msc/+/15120 ) Change subject: Implement a global switch on the network to disable call waiting. .. Patch Set 10: (1 comment) https

Change in ...osmo-sip-connector[master]: coverity: Address issue found by coverity

2019-08-09 Thread keith
Gerrit-PatchSet: 2 Gerrit-Owner: keith Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria Gerrit-MessageType: newpatchset

Change in ...osmo-sip-connector[master]: coverity: Address issue found by coverity

2019-08-09 Thread keith
keith has uploaded this change for review. ( https://gerrit.osmocom.org/c/osmo-sip-connector/+/15143 Change subject: coverity: Address issue found by coverity .. coverity: Address issue found by coverity Add NULL checks

Change in ...osmo-msc[master]: Implement a global switch on the network to disable call waiting.

2019-08-08 Thread keith
rg/c/osmo-msc/+/15120 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-msc Gerrit-Branch: master Gerrit-Change-Id: I3eb6f23f7103e3002874fb5d3a30c9de952202ae Gerrit-Change-Number: 15120 Gerrit-PatchSet: 10 Gerrit-Owner: keith Gerrit-Revi

Change in ...osmo-msc[master]: Implement a global switch on the network to disable call waiting.

2019-08-08 Thread keith
rg/c/osmo-msc/+/15120 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-msc Gerrit-Branch: master Gerrit-Change-Id: I3eb6f23f7103e3002874fb5d3a30c9de952202ae Gerrit-Change-Number: 15120 Gerrit-PatchSet: 9 Gerrit-Owner: keith Gerrit-Revi

Change in ...osmo-msc[master]: Implement a global switch on the network to disable call waiting.

2019-08-08 Thread keith
keith has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-msc/+/15120 ) Change subject: Implement a global switch on the network to disable call waiting. .. Patch Set 8: (1 comment) https

Change in ...osmo-msc[master]: Implement a global switch on the network to disable call waiting.

2019-08-08 Thread keith
rg/c/osmo-msc/+/15120 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-msc Gerrit-Branch: master Gerrit-Change-Id: I3eb6f23f7103e3002874fb5d3a30c9de952202ae Gerrit-Change-Number: 15120 Gerrit-PatchSet: 8 Gerrit-Owner: keith Gerrit-Revi

Change in ...osmo-msc[master]: Implement a global switch on the network to disable call waiting.

2019-08-08 Thread keith
rg/c/osmo-msc/+/15120 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-msc Gerrit-Branch: master Gerrit-Change-Id: I3eb6f23f7103e3002874fb5d3a30c9de952202ae Gerrit-Change-Number: 15120 Gerrit-PatchSet: 7 Gerrit-Owner: keith Gerrit-Revi

Change in ...osmo-msc[master]: Implement a global switch on the network to disable call waiting.

2019-08-08 Thread keith
keith has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-msc/+/15120 ) Change subject: Implement a global switch on the network to disable call waiting. .. Patch Set 1: (1 comment) https

Change in ...osmo-msc[master]: Implements a global switch on the network to disable call waiting.

2019-08-08 Thread keith
rg/c/osmo-msc/+/15120 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-msc Gerrit-Branch: master Gerrit-Change-Id: I3eb6f23f7103e3002874fb5d3a30c9de952202ae Gerrit-Change-Number: 15120 Gerrit-PatchSet: 6 Gerrit-Owner: keith Gerrit-Revi

Change in ...osmo-msc[master]: Implements a global switch on the network to disable call waiting.

2019-08-08 Thread keith
rit-Change-Id: I3eb6f23f7103e3002874fb5d3a30c9de952202ae Gerrit-Change-Number: 15120 Gerrit-PatchSet: 5 Gerrit-Owner: keith Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: keith Gerrit-Reviewer: neels Gerrit-CC: pespin Gerrit-MessageType: newpatchset

Change in ...osmo-msc[master]: Implements a global switch on the network to disable call waiting.

2019-08-08 Thread keith
rit-Change-Id: I3eb6f23f7103e3002874fb5d3a30c9de952202ae Gerrit-Change-Number: 15120 Gerrit-PatchSet: 4 Gerrit-Owner: keith Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: keith Gerrit-Reviewer: neels Gerrit-CC: pespin Gerrit-MessageType: newpatchset

Change in ...osmo-msc[master]: Implements a global switch on the network to disable call waiting.

2019-08-08 Thread keith
mo-msc Gerrit-Branch: master Gerrit-Change-Id: I3eb6f23f7103e3002874fb5d3a30c9de952202ae Gerrit-Change-Number: 15120 Gerrit-PatchSet: 3 Gerrit-Owner: keith Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: keith Gerrit-Reviewer: neels Gerrit-CC: pespin Gerrit-MessageType: newpatchset

Change in ...osmo-msc[master]: Implements a global switch on the network to disable call waiting.

2019-08-08 Thread keith
keith has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-msc/+/15120 ) Change subject: Implements a global switch on the network to disable call waiting. .. Patch Set 1: (1 comment) https

Change in ...osmo-msc[master]: Implements a global switch on the network to disable call waiting.

2019-08-08 Thread keith
tings Gerrit-Project: osmo-msc Gerrit-Branch: master Gerrit-Change-Id: I3eb6f23f7103e3002874fb5d3a30c9de952202ae Gerrit-Change-Number: 15120 Gerrit-PatchSet: 2 Gerrit-Owner: keith Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: keith Gerrit-Reviewer: neels Gerrit-CC: pespin Gerrit-MessageType: newpatchset

Change in ...osmo-msc[master]: Implements a global switch on the network to disable call waiting.

2019-08-08 Thread keith
keith has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-msc/+/15120 ) Change subject: Implements a global switch on the network to disable call waiting. .. Patch Set 1: (1 comment) > Build Fai

Change in ...osmo-msc[master]: Implements a global switch on the network to disable call waiting.

2019-08-08 Thread keith
keith has uploaded this change for review. ( https://gerrit.osmocom.org/c/osmo-msc/+/15120 Change subject: Implements a global switch on the network to disable call waiting. .. Implements a global switch on the network

Change in ...osmo-sip-connector[master]: Logging: Make use of Levels, clarify some messages

2019-08-08 Thread keith
keith has submitted this change and it was merged. ( https://gerrit.osmocom.org/c/osmo-sip-connector/+/15078 ) Change subject: Logging: Make use of Levels, clarify some messages .. Logging: Make use of Levels, clarify some

Change in ...osmo-sip-connector[master]: In hold/retrieve/reinvite, add check that other_leg exists

2019-08-08 Thread keith
keith has submitted this change and it was merged. ( https://gerrit.osmocom.org/c/osmo-sip-connector/+/15079 ) Change subject: In hold/retrieve/reinvite, add check that other_leg exists .. In hold/retrieve/reinvite, add check

Change in ...osmo-dev[master]: add sysmobts-calib.py

2019-08-07 Thread keith
keith has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-dev/+/15074 ) Change subject: add sysmobts-calib.py .. Patch Set 1: Code-Review+1 -- To view, visit https://gerrit.osmocom.org/c/osmo-dev/+/15074

Change in ...osmo-dev[master]: run.sh: add comment to show how to enable MNCC udtrace

2019-08-07 Thread keith
keith has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-dev/+/15075 ) Change subject: run.sh: add comment to show how to enable MNCC udtrace .. Patch Set 1: Code-Review+1 -- To view, visit https

Change in ...osmo-dev[master]: kamailio: fixes and tweaks

2019-08-07 Thread keith
keith has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-dev/+/15077 ) Change subject: kamailio: fixes and tweaks .. Patch Set 1: Code-Review+1 -- To view, visit https://gerrit.osmocom.org/c/osmo-dev

Change in ...osmo-sip-connector[master]: Logging: Make use of Levels, clarify some messages

2019-08-07 Thread keith
keith has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-sip-connector/+/15078 ) Change subject: Logging: Make use of Levels, clarify some messages .. Patch Set 2: (1 comment) https://gerrit.osmocom.org

Change in ...osmo-sip-connector[master]: Logging: Make use of Levels, clarify some messages

2019-08-07 Thread keith
-Change-Id: Ie0014043d93303a87cbb8bb351e439ff78651cbe Gerrit-Change-Number: 15078 Gerrit-PatchSet: 3 Gerrit-Owner: keith Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: keith Gerrit-CC: fixeria Gerrit-CC: pespin Gerrit-MessageType: newpatchset

Change in ...osmo-sip-connector[master]: Logging: Make use of Levels

2019-08-07 Thread keith
keith has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-sip-connector/+/15078 ) Change subject: Logging: Make use of Levels .. Patch Set 2: (1 comment) https://gerrit.osmocom.org/#/c/15078/2/src/mncc.c

Change in ...osmo-sip-connector[master]: Logging: Make use of Levels

2019-08-07 Thread keith
keith has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-sip-connector/+/15078 ) Change subject: Logging: Make use of Levels .. Patch Set 2: (1 comment) https://gerrit.osmocom.org/#/c/15078/2/src/mncc.c

Change in ...osmo-sip-connector[master]: Logging: Make use of Levels

2019-08-07 Thread keith
keith has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-sip-connector/+/15078 ) Change subject: Logging: Make use of Levels .. Patch Set 2: (1 comment) https://gerrit.osmocom.org/#/c/15078/2/src/sip.c

Change in ...osmo-sip-connector[master]: In hold/retrieve/reinvite, add check that other_leg exists

2019-08-07 Thread keith
keith has uploaded a new patch set (#2). ( https://gerrit.osmocom.org/c/osmo-sip-connector/+/15079 ) Change subject: In hold/retrieve/reinvite, add check that other_leg exists .. In hold/retrieve/reinvite, add check

Change in ...osmo-sip-connector[master]: In hold/retreive/reinvite, add check that other_leg exists

2019-08-07 Thread keith
keith has uploaded this change for review. ( https://gerrit.osmocom.org/c/osmo-sip-connector/+/15079 Change subject: In hold/retreive/reinvite, add check that other_leg exists .. In hold/retreive/reinvite, add check

Change in ...osmo-sip-connector[master]: Logging: Make use of Levels

2019-08-07 Thread keith
keith has uploaded a new patch set (#2). ( https://gerrit.osmocom.org/c/osmo-sip-connector/+/15078 ) Change subject: Logging: Make use of Levels .. Logging: Make use of Levels Up to now most logging is on LDEBUG, lets make

Change in ...osmo-sip-connector[master]: Logging: Make use of Levels

2019-08-07 Thread keith
keith has uploaded this change for review. ( https://gerrit.osmocom.org/c/osmo-sip-connector/+/15078 Change subject: Logging: Make use of Levels .. Logging: Make use of Levels Up to now most logging is on LDEBUG, lets make

Change in ...osmo-sip-connector[master]: Cosmetic: Logging and Comments, spelling and clarity changes

2019-08-07 Thread keith
Gerrit-Owner: keith Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: pespin Gerrit-MessageType: newpatchset

Change in ...osmo-sip-connector[master]: Handle case where SIP side hangsup while MNCC is on hold

2019-08-07 Thread keith
: 15073 Gerrit-PatchSet: 2 Gerrit-Owner: keith Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: pespin Gerrit-MessageType: newpatchset

Change in ...osmo-sip-connector[master]: Define hold/retrieve functions for MO calls

2019-08-06 Thread keith
keith has submitted this change and it was merged. ( https://gerrit.osmocom.org/c/osmo-sip-connector/+/15069 ) Change subject: Define hold/retrieve functions for MO calls .. Define hold/retrieve functions for MO calls My

Change in ...osmo-sip-connector[master]: Fix bug with MO calls not connecting.

2019-08-06 Thread keith
keith has submitted this change and it was merged. ( https://gerrit.osmocom.org/c/osmo-sip-connector/+/15068 ) Change subject: Fix bug with MO calls not connecting. .. Fix bug with MO calls not connecting. Fixes a bug I

Change in ...osmo-sip-connector[master]: Fix bug with MO calls not connecting.

2019-08-06 Thread keith
, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-sip-connector Gerrit-Branch: master Gerrit-Change-Id: Ic7cc56c0d68a27eb1229c0c4aa1fa54d00b660b6 Gerrit-Change-Number: 15068 Gerrit-PatchSet: 2 Gerrit-Owner: keith Gerrit-Reviewer: Jenkins Builder Gerrit

Change in ...osmo-sip-connector[master]: Handle case where SIP side hangsup while MNCC is on hold

2019-08-06 Thread keith
keith has uploaded this change for review. ( https://gerrit.osmocom.org/c/osmo-sip-connector/+/15073 Change subject: Handle case where SIP side hangsup while MNCC is on hold .. Handle case where SIP side hangsup while MNCC

Change in ...osmo-sip-connector[master]: Cosmetic: Logging and Comments, spelling and clarity changes

2019-08-06 Thread keith
keith has uploaded this change for review. ( https://gerrit.osmocom.org/c/osmo-sip-connector/+/15072 Change subject: Cosmetic: Logging and Comments, spelling and clarity changes .. Cosmetic: Logging and Comments, spelling

Change in ...osmo-sip-connector[master]: Fix bug with MO calls not connecting.

2019-08-06 Thread keith
keith has uploaded this change for review. ( https://gerrit.osmocom.org/c/osmo-sip-connector/+/15068 Change subject: Fix bug with MO calls not connecting. .. Fix bug with MO calls not connecting. Fixes a bug I introduced

Change in ...osmo-sip-connector[master]: Define hold/retrieve functions for MO calls

2019-08-06 Thread keith
keith has uploaded this change for review. ( https://gerrit.osmocom.org/c/osmo-sip-connector/+/15069 Change subject: Define hold/retrieve functions for MO calls .. Define hold/retrieve functions for MO calls My original patch

Change in ...osmo-sip-connector[master]: inet_ntoa() is deprecated, use inet_ntop() instead

2019-08-06 Thread keith
keith has submitted this change and it was merged. ( https://gerrit.osmocom.org/c/osmo-sip-connector/+/15065 ) Change subject: inet_ntoa() is deprecated, use inet_ntop() instead .. inet_ntoa() is deprecated, use inet_ntop

Change in ...osmo-sip-connector[master]: inet_ntoa() is deprecated, use inet_ntop() instead

2019-08-06 Thread keith
-Change-Number: 15065 Gerrit-PatchSet: 5 Gerrit-Owner: keith Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: pespin Gerrit-MessageType: newpatchset

Change in ...osmo-sip-connector[master]: inet_ntoa() is deprecated, use inet_ntop() instead

2019-08-06 Thread keith
-Change-Number: 15065 Gerrit-PatchSet: 4 Gerrit-Owner: keith Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: pespin Gerrit-MessageType: newpatchset

Change in ...osmo-sip-connector[master]: inet_ntoa() is deprecated, use inet_ntop() instead

2019-08-06 Thread keith
-Number: 15065 Gerrit-PatchSet: 3 Gerrit-Owner: keith Gerrit-Reviewer: Jenkins Builder Gerrit-MessageType: newpatchset

Change in ...osmo-sip-connector[master]: inet_ntoa() is deprecated, use inet_ntop() instead

2019-08-06 Thread keith
-Number: 15065 Gerrit-PatchSet: 2 Gerrit-Owner: keith Gerrit-Reviewer: Jenkins Builder Gerrit-MessageType: newpatchset

Change in ...osmo-sip-connector[master]: inet_ntoa() is deprecated, use inet_ntop() instead

2019-08-06 Thread keith
keith has uploaded this change for review. ( https://gerrit.osmocom.org/c/osmo-sip-connector/+/15065 Change subject: inet_ntoa() is deprecated, use inet_ntop() instead .. inet_ntoa() is deprecated, use inet_ntop() instead

Change in ...osmo-sip-connector[master]: Following from previous commit, assume other->ip is network byte order

2019-08-06 Thread keith
keith has uploaded this change for review. ( https://gerrit.osmocom.org/c/osmo-sip-connector/+/15064 Change subject: Following from previous commit, assume other->ip is network byte order .. Following from previous com

Change in ...osmo-sip-connector[master]: IPs stored in the call struct are NETWORK byte order

2019-08-06 Thread keith
keith has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-sip-connector/+/15063 ) Change subject: IPs stored in the call struct are NETWORK byte order .. Patch Set 2: > Change has been successfully mer

Change in ...osmo-sip-connector[master]: IPs stored in the call struct are NETWORK byte order

2019-08-06 Thread keith
://gerrit.osmocom.org/settings Gerrit-Project: osmo-sip-connector Gerrit-Branch: master Gerrit-Change-Id: I89ef26aa32a672f394699251cf560b53ae01a814 Gerrit-Change-Number: 15063 Gerrit-PatchSet: 2 Gerrit-Owner: keith Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: pespin Gerrit-MessageType: newpatchset

Change in ...osmo-sip-connector[master]: Add further logging.

2019-08-06 Thread keith
keith has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-sip-connector/+/14997 ) Change subject: Add further logging. .. Patch Set 7: > (1 comment) yep.. that's what it looks like. I was doing the pa

Change in ...osmo-sip-connector[master]: IPs stored in the call struct are NETWORK byte order

2019-08-06 Thread keith
keith has uploaded this change for review. ( https://gerrit.osmocom.org/c/osmo-sip-connector/+/15063 Change subject: IPs stored in the call struct are NETWORK byte order .. IPs stored in the call struct are NETWORK byte order

Change in ...osmo-sip-connector[master]: Add further logging.

2019-08-06 Thread keith
keith has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-sip-connector/+/14997 ) Change subject: Add further logging. .. Patch Set 1: (1 comment) https://gerrit.osmocom.org/#/c/14997/1/src/mncc.c File

Change in ...osmo-sip-connector[master]: Add further logging.

2019-08-06 Thread keith
keith has abandoned this change. ( https://gerrit.osmocom.org/c/osmo-sip-connector/+/14997 ) Change subject: Add further logging. .. Abandoned These changes were erroneously included in https://gerrit.osmocom.org/#/c/osmo

Change in ...osmo-sip-connector[master]: Add further logging.

2019-08-05 Thread keith
keith has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-sip-connector/+/14997 ) Change subject: Add further logging. .. Patch Set 1: (2 comments) https://gerrit.osmocom.org/#/c/14997/1/src/mncc.c File

Change in ...osmo-sip-connector[master]: Only send update to MNCC if media info changed.

2019-08-05 Thread keith
keith has submitted this change and it was merged. ( https://gerrit.osmocom.org/c/osmo-sip-connector/+/15010 ) Change subject: Only send update to MNCC if media info changed. .. Only send update to MNCC if media info changed

Change in ...osmo-sip-connector[master]: Add support for MNCC HOLD/RETRIEVE

2019-08-05 Thread keith
keith has submitted this change and it was merged. ( https://gerrit.osmocom.org/c/osmo-sip-connector/+/14996 ) Change subject: Add support for MNCC HOLD/RETRIEVE .. Add support for MNCC HOLD/RETRIEVE Handle MO hold

Change in ...osmo-sip-connector[master]: Add support for MNCC HOLD/RETRIEVE

2019-08-05 Thread keith
keith has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-sip-connector/+/14996 ) Change subject: Add support for MNCC HOLD/RETRIEVE .. Patch Set 9: Code-Review+2 -- To view, visit https

Change in ...osmo-sip-connector[master]: Add support for MNCC HOLD/RETRIEVE

2019-08-05 Thread keith
keith has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-sip-connector/+/14996 ) Change subject: Add support for MNCC HOLD/RETRIEVE .. Patch Set 9: Code-Review+1 (1 comment) https://gerrit.osmocom.org

Change in ...osmo-sip-connector[master]: Prepare to support MO Call HOLD

2019-08-05 Thread keith
keith has submitted this change and it was merged. ( https://gerrit.osmocom.org/c/osmo-sip-connector/+/14995 ) Change subject: Prepare to support MO Call HOLD .. Prepare to support MO Call HOLD Add function pointers

Change in ...osmo-sip-connector[master]: Prepare to support MO Call HOLD

2019-08-05 Thread keith
keith has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-sip-connector/+/14995 ) Change subject: Prepare to support MO Call HOLD .. Patch Set 7: Verified+1 -- To view, visit https://gerrit.osmocom.org/c

Change in ...osmo-sip-connector[master]: Handle SIP re-INVITEs

2019-08-05 Thread keith
keith has submitted this change and it was merged. ( https://gerrit.osmocom.org/c/osmo-sip-connector/+/14994 ) Change subject: Handle SIP re-INVITEs .. Handle SIP re-INVITEs SIP end points can send periodic re-INVITES

Change in ...osmo-sip-connector[master]: Handle SIP re-INVITEs

2019-08-05 Thread keith
keith has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-sip-connector/+/14994 ) Change subject: Handle SIP re-INVITEs .. Patch Set 9: Code-Review+2 -- To view, visit https://gerrit.osmocom.org/c/osmo

Change in ...osmo-sip-connector[master]: Add support for MNCC HOLD/RETRIEVE

2019-08-05 Thread keith
writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-sip-connector Gerrit-Branch: master Gerrit-Change-Id: Ife7bdab20cde92b7ce550215bab28b36a0f302e9 Gerrit-Change-Number: 14996 Gerrit-PatchSet: 9 Gerrit-Owner: keith Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer

Change in ...osmo-sip-connector[master]: Handle SIP re-INVITEs

2019-08-05 Thread keith
-connector/+/14994 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-sip-connector Gerrit-Branch: master Gerrit-Change-Id: I4083ed50d0cf1b302b80354fe0c2b73fc6e14fed Gerrit-Change-Number: 14994 Gerrit-PatchSet: 9 Gerrit-Owner: keith Gerrit

Change in ...osmo-sip-connector[master]: Add media mode parameter to sdp_create_file()

2019-08-05 Thread keith
keith has submitted this change and it was merged. ( https://gerrit.osmocom.org/c/osmo-sip-connector/+/14993 ) Change subject: Add media mode parameter to sdp_create_file() .. Add media mode parameter to sdp_create_file

Change in ...osmo-sip-connector[master]: Add support for MNCC HOLD/RETRIEVE

2019-08-05 Thread keith
keith has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-sip-connector/+/14996 ) Change subject: Add support for MNCC HOLD/RETRIEVE .. Patch Set 8: Code-Review+2 -- To view, visit https

Change in ...osmo-sip-connector[master]: Add support for MNCC HOLD/RETRIEVE

2019-08-05 Thread keith
filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-sip-connector Gerrit-Branch: master Gerrit-Change-Id: Ife7bdab20cde92b7ce550215bab28b36a0f302e9 Gerrit-Change-Number: 14996 Gerrit-PatchSet: 8 Gerrit-Owner: keith Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: keith Gerrit

Change in ...osmo-sip-connector[master]: Prepare to support MO Call HOLD

2019-08-05 Thread keith
filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-sip-connector Gerrit-Branch: master Gerrit-Change-Id: I2595626dfa50eb2f8e29a02540b708c9c1dce88c Gerrit-Change-Number: 14995 Gerrit-PatchSet: 6 Gerrit-Owner: keith Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: keith Gerrit

Change in ...osmo-sip-connector[master]: Handle SIP re-INVITEs

2019-08-05 Thread keith
-connector/+/14994 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-sip-connector Gerrit-Branch: master Gerrit-Change-Id: I4083ed50d0cf1b302b80354fe0c2b73fc6e14fed Gerrit-Change-Number: 14994 Gerrit-PatchSet: 8 Gerrit-Owner: keith Gerrit

Change in ...osmo-sip-connector[master]: Add support for MNCC HOLD/RETRIEVE

2019-08-05 Thread keith
filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-sip-connector Gerrit-Branch: master Gerrit-Change-Id: Ife7bdab20cde92b7ce550215bab28b36a0f302e9 Gerrit-Change-Number: 14996 Gerrit-PatchSet: 7 Gerrit-Owner: keith Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: keith Gerrit

Change in ...osmo-sip-connector[master]: Remove undefined param passed to {logging, osmo_stats}_vty_add_cmds

2019-08-05 Thread keith
keith has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-sip-connector/+/15049 ) Change subject: Remove undefined param passed to {logging,osmo_stats}_vty_add_cmds .. Patch Set 1: Code-Review+1 Seems

Change in ...osmo-msc[master]: Set coding in mncc_set_cause()

2019-08-02 Thread keith
keith has submitted this change and it was merged. ( https://gerrit.osmocom.org/c/osmo-msc/+/15009 ) Change subject: Set coding in mncc_set_cause() .. Set coding in mncc_set_cause() GSM 04.08 10.5.4.11 The Release indication

  1   2   3   4   5   >