Change in osmo-dev[master]: ttcn3.sh: run ttcn3 testsuites from osmo-dev

2019-10-14 Thread neels
neels has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-dev/+/15778 ) Change subject: ttcn3.sh: run ttcn3 testsuites from osmo-dev .. Patch Set 2: instead of putting ttcn related scripts in src/, can

Change in ...libosmocore[master]: add osmo_fsm_set_dealloc_ctx(), to help with use-after-free

2019-10-04 Thread neels
neels has posted comments on this change. ( https://gerrit.osmocom.org/c/libosmocore/+/15677 ) Change subject: add osmo_fsm_set_dealloc_ctx(), to help with use-after-free .. Patch Set 1: > why not LOGP()? I guess I wan

Change in ...libosmocore[master]: add osmo_fsm_inst_watch()

2019-10-04 Thread neels
neels has posted comments on this change. ( https://gerrit.osmocom.org/c/libosmocore/+/15660 ) Change subject: add osmo_fsm_inst_watch() .. Patch Set 2: I wish my reply could be shorter, but this is a quite important aspect

Change in ...libosmocore[master]: add osmo_fsm_inst_watch()

2019-10-02 Thread neels
ngs Gerrit-Project: libosmocore Gerrit-Branch: master Gerrit-Change-Id: I4d8306488506c60b4c2fc1c4cb3ac04654db9c43 Gerrit-Change-Number: 15660 Gerrit-PatchSet: 2 Gerrit-Owner: neels Gerrit-Reviewer: Jenkins Builder Gerrit-MessageType: newpatchset

Change in ...libosmocore[master]: add osmo_fsm_inst_watch()

2019-10-02 Thread neels
neels has uploaded this change for review. ( https://gerrit.osmocom.org/c/libosmocore/+/15660 Change subject: add osmo_fsm_inst_watch() .. add osmo_fsm_inst_watch() I discovered an osmo-msc use-after-free crash from

Change in ...libosmocore[master]: add osmo_fsm_inst_dispatch_and_watch()

2019-10-02 Thread neels
neels has uploaded this change for review. ( https://gerrit.osmocom.org/c/libosmocore/+/15661 Change subject: add osmo_fsm_inst_dispatch_and_watch() .. add osmo_fsm_inst_dispatch_and_watch() The most common use case

Change in ...libosmocore[master]: API doc tweaks (mncc.h, gsm_08_08.h)

2019-10-02 Thread neels
neels has uploaded this change for review. ( https://gerrit.osmocom.org/c/libosmocore/+/15659 Change subject: API doc tweaks (mncc.h, gsm_08_08.h) .. API doc tweaks (mncc.h, gsm_08_08.h) Change-Id

Change in ...osmo-msc[master]: catch GSUP auth result without auth_fsm

2019-09-26 Thread neels
neels has submitted this change and it was merged. ( https://gerrit.osmocom.org/c/osmo-msc/+/15544 ) Change subject: catch GSUP auth result without auth_fsm .. catch GSUP auth result without auth_fsm When a vlr_subscr receives

Change in ...osmo-msc[master]: catch GSUP auth result without auth_fsm

2019-09-26 Thread neels
neels has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-msc/+/15544 ) Change subject: catch GSUP auth result without auth_fsm .. Patch Set 1: Code-Review+2 I think this patch is trivial and prevents

Change in ...osmo-ttcn3-hacks[master]: Revert "MGCP: fix pattern warning"

2019-09-18 Thread neels
neels has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/15570 ) Change subject: Revert "MGCP: fix pattern warning" .. Patch Set 1: Code-Review+2 -- To view, v

Change in ...osmo-ttcn3-hacks[master]: Revert "MGCP: fix pattern warning"

2019-09-18 Thread neels
neels has submitted this change and it was merged. ( https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/15570 ) Change subject: Revert "MGCP: fix pattern warning" .. Revert "MGCP: fix pattern warning" For m

Change in ...osmo-ttcn3-hacks[master]: Revert "MGCP: fix pattern warning"

2019-09-18 Thread neels
neels has uploaded this change for review. ( https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/15570 Change subject: Revert "MGCP: fix pattern warning" .. Revert "MGCP: fix pattern warning" For me thi

Change in ...libosmocore[master]: logging: Introduce mutex API to manage log_target in multi-thread envs

2019-09-18 Thread neels
neels has posted comments on this change. ( https://gerrit.osmocom.org/c/libosmocore/+/15560 ) Change subject: logging: Introduce mutex API to manage log_target in multi-thread envs .. Patch Set 3: (1 comment) I hope

Change in ...osmo-msc[master]: fix error on BSSMAP Cipher Mode Complete L3 msg IE

2019-09-18 Thread neels
neels has submitted this change and it was merged. ( https://gerrit.osmocom.org/c/osmo-msc/+/15317 ) Change subject: fix error on BSSMAP Cipher Mode Complete L3 msg IE .. fix error on BSSMAP Cipher Mode Complete L3 msg IE When

Change in ...osmo-msc[master]: fix error on BSSMAP Cipher Mode Complete L3 msg IE

2019-09-18 Thread neels
: master Gerrit-Change-Id: Icd8dad18d6dda24d075dd8da72c3d6db1302090d Gerrit-Change-Number: 15317 Gerrit-PatchSet: 8 Gerrit-Owner: neels Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria Gerrit-Reviewer: laforge Gerrit-Reviewer: neels Gerrit-MessageType: newpatchset

Change in ...pysim[master]: switch to python3

2019-09-17 Thread neels
neels has posted comments on this change. ( https://gerrit.osmocom.org/c/pysim/+/15504 ) Change subject: switch to python3 .. Patch Set 4: Code-Review-1 (marking -1 until gnutoo replied about encodings) -- To view, visit

Change in ...pysim[master]: switch to python3

2019-09-17 Thread neels
neels has posted comments on this change. ( https://gerrit.osmocom.org/c/pysim/+/15504 ) Change subject: switch to python3 .. Patch Set 4: A considerable part of python3 migration is the encoding on I/O. Are you sure

Change in ...pysim[master]: python3 conversion: Use python 2 and 3 compatible exceptions

2019-09-17 Thread neels
neels has posted comments on this change. ( https://gerrit.osmocom.org/c/pysim/+/15503 ) Change subject: python3 conversion: Use python 2 and 3 compatible exceptions .. Patch Set 4: (1 comment) https://gerrit.osmocom.org/#/c

Change in ...pysim[master]: python3 conversion: fix tabs and spaces inconsistency

2019-09-17 Thread neels
neels has posted comments on this change. ( https://gerrit.osmocom.org/c/pysim/+/15505 ) Change subject: python3 conversion: fix tabs and spaces inconsistency .. Patch Set 2: Code-Review+1 -- To view, visit https

Change in ...pysim[master]: python3 conversion: Use braces around print calls

2019-09-17 Thread neels
neels has posted comments on this change. ( https://gerrit.osmocom.org/c/pysim/+/15502 ) Change subject: python3 conversion: Use braces around print calls .. Patch Set 2: Code-Review+1 also +1 when that missing quote is fixed

Change in ...osmo-bts[master]: log: set L1 SAPI context

2019-09-17 Thread neels
neels has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-bts/+/15539 ) Change subject: log: set L1 SAPI context .. Patch Set 3: Code-Review-1 (2 comments) This change is ready for review. https

Change in ...osmo-bts[master]: vty: add "logging filter l1-sapi"

2019-09-17 Thread neels
neels has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-bts/+/15550 ) Change subject: vty: add "logging filter l1-sapi" .. Patch Set 1: Code-Review+1 (2 comments) https://gerrit.osmocom.org/#

Change in ...libosmocore[master]: logging.h: add L1 SAPI related context and filter

2019-09-17 Thread neels
neels has posted comments on this change. ( https://gerrit.osmocom.org/c/libosmocore/+/15538 ) Change subject: logging.h: add L1 SAPI related context and filter .. Patch Set 2: Code-Review+1 (1 comment) https

Change in ...osmo-ttcn3-hacks[master]: MGCP: fix pattern warning

2019-09-17 Thread neels
neels has submitted this change and it was merged. ( https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/12237 ) Change subject: MGCP: fix pattern warning .. MGCP: fix pattern warning Remove implied \r to fix following warnings

Change in ...osmo-ttcn3-hacks[master]: MGCP: fix pattern warning

2019-09-17 Thread neels
neels has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/12237 ) Change subject: MGCP: fix pattern warning .. Patch Set 3: Code-Review+2 -- To view, visit https://gerrit.osmocom.org/c/osmo

Change in ...osmo-bsc[master]: bsc_subscr_conn_fsm: Cleanly clear BSSAP conn if associated channel c...

2019-09-17 Thread neels
neels has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-bsc/+/15408 ) Change subject: bsc_subscr_conn_fsm: Cleanly clear BSSAP conn if associated channel closed during WAIT_CC .. Patch Set 3: Code-Review

Change in ...libosmocore[master]: logging_internal.h: Fix osmo_log_info definition

2019-09-17 Thread neels
neels has posted comments on this change. ( https://gerrit.osmocom.org/c/libosmocore/+/15558 ) Change subject: logging_internal.h: Fix osmo_log_info definition .. Patch Set 1: Code-Review+1 -- To view, visit https

Change in ...libosmocore[master]: logging: Move osmo_log_target_list from logging.h to logging_internal.h

2019-09-17 Thread neels
neels has posted comments on this change. ( https://gerrit.osmocom.org/c/libosmocore/+/15559 ) Change subject: logging: Move osmo_log_target_list from logging.h to logging_internal.h .. Patch Set 1: though, once the cat

Change in ...libosmocore[master]: logging: Introduce mutex API to manage log_target in multi-thread envs

2019-09-17 Thread neels
neels has posted comments on this change. ( https://gerrit.osmocom.org/c/libosmocore/+/15560 ) Change subject: logging: Introduce mutex API to manage log_target in multi-thread envs .. Patch Set 2: (14 comments) https

Change in ...osmo-sgsn[master]: gprs_ranap: on Iu release, stop the attach fsm if running

2019-09-17 Thread neels
neels has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-sgsn/+/15485 ) Change subject: gprs_ranap: on Iu release, stop the attach fsm if running .. Patch Set 7: Code-Review+1 -- To view, visit https

Change in ...osmo-sgsn[master]: Iu: implement a user inactivity timer

2019-09-17 Thread neels
neels has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-sgsn/+/15483 ) Change subject: Iu: implement a user inactivity timer .. Patch Set 7: (1 comment) https://gerrit.osmocom.org/#/c/15483/7/src/sgsn

Change in ...osmo-sgsn[master]: Iu: implement a user inactivity timer

2019-09-17 Thread neels
neels has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-sgsn/+/15483 ) Change subject: Iu: implement a user inactivity timer .. Patch Set 7: Code-Review+1 should be able to easily fix the failing

Change in ...osmo-sgsn[master]: gprs_ranap: release Iu UE Context when exiting PMM Connected

2019-09-17 Thread neels
neels has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-sgsn/+/15482 ) Change subject: gprs_ranap: release Iu UE Context when exiting PMM Connected .. Patch Set 6: Code-Review+1 (1 comment) would prefer

Change in ...osmo-sgsn[master]: gprs_ranap: introduce Iu helper to free the UE context

2019-09-17 Thread neels
neels has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-sgsn/+/15481 ) Change subject: gprs_ranap: introduce Iu helper to free the UE context .. Patch Set 6: Code-Review-1 Atomic patches are good

Change in ...libosmocore[master]: sanity: make vty buffer_* API NULL safe

2019-09-17 Thread neels
neels has abandoned this change. ( https://gerrit.osmocom.org/c/libosmocore/+/15265 ) Change subject: sanity: make vty buffer_* API NULL safe .. Abandoned -- To view, visit https://gerrit.osmocom.org/c/libosmocore/+/15265

Change in ...osmo-msc[master]: catch GSUP auth result without auth_fsm

2019-09-17 Thread neels
neels has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-msc/+/15544 ) Change subject: catch GSUP auth result without auth_fsm .. Patch Set 1: (1 comment) https://gerrit.osmocom.org/#/c/15544/1/src

Change in ...osmo-msc[master]: fix error on BSSMAP Cipher Mode Complete L3 msg IE

2019-09-17 Thread neels
-Branch: master Gerrit-Change-Id: Icd8dad18d6dda24d075dd8da72c3d6db1302090d Gerrit-Change-Number: 15317 Gerrit-PatchSet: 7 Gerrit-Owner: neels Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: neels Gerrit-CC: fixeria Gerrit-CC: laforge Gerrit-MessageType: newpatchset

Change in ...osmo-msc[master]: fix error on BSSMAP Cipher Mode Complete L3 msg IE

2019-09-17 Thread neels
neels has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-msc/+/15317 ) Change subject: fix error on BSSMAP Cipher Mode Complete L3 msg IE .. Patch Set 6: almost forgot about this one. will do

Change in ...libosmocore[master]: tdef: Introduce min_val and max_val fields

2019-09-17 Thread neels
neels has posted comments on this change. ( https://gerrit.osmocom.org/c/libosmocore/+/15546 ) Change subject: tdef: Introduce min_val and max_val fields .. Patch Set 1: Code-Review-1 (7 comments) All in all very nice

Change in ...osmo-msc[master]: vty: fix access to wrong argv in paging response-timer

2019-09-16 Thread neels
neels has submitted this change and it was merged. ( https://gerrit.osmocom.org/c/osmo-msc/+/15545 ) Change subject: vty: fix access to wrong argv in paging response-timer .. vty: fix access to wrong argv in paging response

Change in ...osmo-msc[master]: vty: fix access to wrong argv in paging response-timer

2019-09-16 Thread neels
neels has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-msc/+/15545 ) Change subject: vty: fix access to wrong argv in paging response-timer .. Patch Set 1: Code-Review+2 -- To view, visit https

Change in ...osmo-msc[master]: catch GSUP auth result without auth_fsm

2019-09-16 Thread neels
neels has uploaded this change for review. ( https://gerrit.osmocom.org/c/osmo-msc/+/15544 Change subject: catch GSUP auth result without auth_fsm .. catch GSUP auth result without auth_fsm When a vlr_subscr receives an Send

Change in ...osmo-bsc[master]: bsc_subscr_conn_fsm: Cleanly clear BSSAP conn if associated channel c...

2019-09-16 Thread neels
neels has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-bsc/+/15408 ) Change subject: bsc_subscr_conn_fsm: Cleanly clear BSSAP conn if associated channel closed during WAIT_CC .. Patch Set 1: Code-Review

Change in ...osmo-ttcn3-hacks[master]: sgsn: TC_attach_check_complete_resend: Expect LU sent to HLR

2019-09-11 Thread neels
neels has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/15475 ) Change subject: sgsn: TC_attach_check_complete_resend: Expect LU sent to HLR .. Patch Set 1: could you add some info

Change in ...osmo-pcu[master]: Forward ETWS Primary Notification to MS

2019-09-11 Thread neels
neels has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-pcu/+/15459 ) Change subject: Forward ETWS Primary Notification to MS .. Patch Set 4: (1 comment) https://gerrit.osmocom.org/#/c/15459/3/src

Change in ...osmo-iuh[master]: iu_client: allow to control the notifications

2019-09-11 Thread neels
neels has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-iuh/+/15472 ) Change subject: iu_client: allow to control the notifications .. Patch Set 1: Code-Review+1 -- To view, visit https

Change in ...osmo-iuh[master]: iu_client: introduce UE field free_on_release

2019-09-11 Thread neels
neels has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-iuh/+/15474 ) Change subject: iu_client: introduce UE field free_on_release .. Patch Set 1: Code-Review+1 (1 comment) https://gerrit.osmocom.org

Change in ...osmo-iuh[master]: iu_client: allow to control the notifications

2019-09-11 Thread neels
neels has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-iuh/+/15472 ) Change subject: iu_client: allow to control the notifications .. Patch Set 1: > I think this patch changes ABI, so it needs a rec

Change in ...osmo-iuh[master]: iu_client: introduce a guard around global_iu_event_cb

2019-09-11 Thread neels
neels has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-iuh/+/15471 ) Change subject: iu_client: introduce a guard around global_iu_event_cb .. Patch Set 1: Code-Review+1 -- To view, visit https

Change in ...osmo-iuh[master]: iu_client: introduce ranap_iu_tx_release_free()

2019-09-11 Thread neels
neels has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-iuh/+/15473 ) Change subject: iu_client: introduce ranap_iu_tx_release_free() .. Patch Set 1: Code-Review+1 (3 comments) It works and the code

Change in ...osmo-iuh[master]: iu_client: introduce a guard around global_iu_event_cb

2019-09-11 Thread neels
neels has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-iuh/+/15471 ) Change subject: iu_client: introduce a guard around global_iu_event_cb .. Patch Set 1: In general, I think we would do good

Change in ...libosmocore[master]: tdef: fixup osmo_tdef_set()

2019-09-10 Thread neels
neels has uploaded this change for review. ( https://gerrit.osmocom.org/c/libosmocore/+/15478 Change subject: tdef: fixup osmo_tdef_set() .. tdef: fixup osmo_tdef_set() I missed code review, so here are my comments in form

Change in ...osmo-msc[master]: ran_dec logging: log message sizes on errors

2019-09-03 Thread neels
neels has submitted this change and it was merged. ( https://gerrit.osmocom.org/c/osmo-msc/+/15342 ) Change subject: ran_dec logging: log message sizes on errors .. ran_dec logging: log message sizes on errors Change-Id

Change in ...osmo-msc[master]: msc_a fsm: ignore state chg to same state

2019-09-03 Thread neels
neels has submitted this change and it was merged. ( https://gerrit.osmocom.org/c/osmo-msc/+/15389 ) Change subject: msc_a fsm: ignore state chg to same state .. msc_a fsm: ignore state chg to same state We sometimes see

Change in ...osmo-msc[master]: vlr: don't log about "gratuitous ID RESPONSE"

2019-09-03 Thread neels
neels has submitted this change and it was merged. ( https://gerrit.osmocom.org/c/osmo-msc/+/15388 ) Change subject: vlr: don't log about "gratuitous ID RESPONSE" .. vlr: don't log about "gratuitous ID RESP

Change in ...osmo-msc[master]: msc_a fsm: ignore state chg to same state

2019-09-03 Thread neels
neels has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-msc/+/15389 ) Change subject: msc_a fsm: ignore state chg to same state .. Patch Set 1: Code-Review+2 -- To view, visit https://gerrit.osmocom.org

Change in ...osmo-msc[master]: vlr: don't log about "gratuitous ID RESPONSE"

2019-09-03 Thread neels
neels has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-msc/+/15388 ) Change subject: vlr: don't log about "gratuitous ID RESPONSE" .. Patch Set 1: Code-Review+2 -- To view, v

Change in ...osmo-msc[master]: msc_a fsm: ignore state chg to same state

2019-09-02 Thread neels
neels has uploaded this change for review. ( https://gerrit.osmocom.org/c/osmo-msc/+/15389 Change subject: msc_a fsm: ignore state chg to same state .. msc_a fsm: ignore state chg to same state We sometimes see errors like

Change in ...osmo-msc[master]: Implement a global switch on the network to disable call waiting.

2019-09-02 Thread neels
neels has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-msc/+/15120 ) Change subject: Implement a global switch on the network to disable call waiting. .. Patch Set 12: keith, since you have numerous +1

Change in ...osmo-msc[master]: vlr: don't log about "gratuitous ID RESPONSE"

2019-09-02 Thread neels
neels has uploaded this change for review. ( https://gerrit.osmocom.org/c/osmo-msc/+/15388 Change subject: vlr: don't log about "gratuitous ID RESPONSE" .. vlr: don't log about "gratuitous ID RESPONSE" If

Change in ...osmo-msc[master]: ran_dec logging: log message sizes on errors

2019-09-02 Thread neels
: neels Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria Gerrit-Reviewer: laforge Gerrit-Reviewer: neels Gerrit-Reviewer: pespin Gerrit-MessageType: newpatchset

Change in ...osmo-msc[master]: ran_dec logging: log message sizes on errors

2019-09-02 Thread neels
neels has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-msc/+/15342 ) Change subject: ran_dec logging: log message sizes on errors .. Patch Set 4: (1 comment) https://gerrit.osmocom.org/#/c/15342/2/src

Change in ...osmo-msc[master]: fix error on BSSMAP Cipher Mode Complete L3 msg IE

2019-09-02 Thread neels
neels has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-msc/+/15317 ) Change subject: fix error on BSSMAP Cipher Mode Complete L3 msg IE .. Patch Set 6: (1 comment) https://gerrit.osmocom.org/#/c/15317

Change in ...osmo-msc[master]: ran_dec logging: log message sizes on errors

2019-08-30 Thread neels
-msc/+/15342 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-msc Gerrit-Branch: master Gerrit-Change-Id: Id08e4ee5a4dbf552dbb107d8f0519110664f6acb Gerrit-Change-Number: 15342 Gerrit-PatchSet: 2 Gerrit-Owner: neels Gerrit-Reviewer

Change in ...osmo-msc[master]: ran_dec logging: log message sizes on errors

2019-08-30 Thread neels
neels has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-msc/+/15342 ) Change subject: ran_dec logging: log message sizes on errors .. Patch Set 1: interesting to note that my gcc seems to not warn about

Change in ...osmo-msc[master]: ran_dec logging: log message sizes on errors

2019-08-30 Thread neels
neels has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-msc/+/15342 ) Change subject: ran_dec logging: log message sizes on errors .. Patch Set 1: The --enable-iu build only warns: "ran_msg_a.c:

Change in ...osmo-msc[master]: ran_dec logging: log message sizes on errors

2019-08-30 Thread neels
neels has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-msc/+/15342 ) Change subject: ran_dec logging: log message sizes on errors .. Patch Set 1: (1 comment) https://gerrit.osmocom.org/#/c/15342/1/src

Change in ...osmo-msc[master]: ran_dec logging: log message sizes on errors

2019-08-30 Thread neels
neels has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-msc/+/15342 ) Change subject: ran_dec logging: log message sizes on errors .. Patch Set 1: > Patch Set 1: > > Compilation warnings, jenk

Change in ...libosmocore[master]: OSMO_SOCKADDR_STR_FMT_ARGS: remove useless condition

2019-08-30 Thread neels
: libosmocore Gerrit-Branch: master Gerrit-Change-Id: I13ed06776a784cfa99bbdfca2bb4dfe12913a1ec Gerrit-Change-Number: 15340 Gerrit-PatchSet: 3 Gerrit-Owner: neels Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria Gerrit-Reviewer: laforge Gerrit-MessageType: newpatchset

Change in ...osmo-msc[master]: msc_vlr_tests: GSUP: don't care about extra IEs

2019-08-29 Thread neels
neels has uploaded this change for review. ( https://gerrit.osmocom.org/c/osmo-msc/+/15343 Change subject: msc_vlr_tests: GSUP: don't care about extra IEs .. msc_vlr_tests: GSUP: don't care about extra IEs To not break

Change in ...osmo-msc[master]: cosmetic: fix call_leg_ensure_ci() decl. arg name to match impl.

2019-08-29 Thread neels
neels has uploaded this change for review. ( https://gerrit.osmocom.org/c/osmo-msc/+/15346 Change subject: cosmetic: fix call_leg_ensure_ci() decl. arg name to match impl. .. cosmetic: fix call_leg_ensure_ci() decl. arg name

Change in ...osmo-msc[master]: gsm48_tch_rtp_create(): check against NULL mgcp_info

2019-08-29 Thread neels
neels has uploaded this change for review. ( https://gerrit.osmocom.org/c/osmo-msc/+/15344 Change subject: gsm48_tch_rtp_create(): check against NULL mgcp_info .. gsm48_tch_rtp_create(): check against NULL mgcp_info

Change in ...osmo-msc[master]: msc_a.c, CC trans: change a comment to a debug log

2019-08-29 Thread neels
neels has uploaded this change for review. ( https://gerrit.osmocom.org/c/osmo-msc/+/15345 Change subject: msc_a.c, CC trans: change a comment to a debug log .. msc_a.c, CC trans: change a comment to a debug log Change-Id

Change in ...osmo-msc[master]: ran_dec logging: log message sizes on errors

2019-08-29 Thread neels
neels has uploaded this change for review. ( https://gerrit.osmocom.org/c/osmo-msc/+/15342 Change subject: ran_dec logging: log message sizes on errors .. ran_dec logging: log message sizes on errors Change-Id

Change in ...libosmocore[master]: sanity: make vty buffer_* API NULL safe

2019-08-29 Thread neels
neels has posted comments on this change. ( https://gerrit.osmocom.org/c/libosmocore/+/15265 ) Change subject: sanity: make vty buffer_* API NULL safe .. Patch Set 3: I realize I was trying to talk my way out of spending more

Change in ...libosmocore[master]: sanity: make vty buffer_* API NULL safe

2019-08-29 Thread neels
neels has posted comments on this change. ( https://gerrit.osmocom.org/c/libosmocore/+/15265 ) Change subject: sanity: make vty buffer_* API NULL safe .. Patch Set 3: see https://gerrit.osmocom.org/c/libosmocore/+/15339

Change in ...libosmocore[master]: OSMO_SOCKADDR_STR_FMT_ARGS: remove useless condition

2019-08-29 Thread neels
neels has uploaded this change for review. ( https://gerrit.osmocom.org/c/libosmocore/+/15340 Change subject: OSMO_SOCKADDR_STR_FMT_ARGS: remove useless condition .. OSMO_SOCKADDR_STR_FMT_ARGS: remove useless condition Since

Change in ...libosmocore[master]: OSMO_SOCKADDR_STR_FMT_ARGS: guard against NULL pointer

2019-08-29 Thread neels
neels has uploaded this change for review. ( https://gerrit.osmocom.org/c/libosmocore/+/15341 Change subject: OSMO_SOCKADDR_STR_FMT_ARGS: guard against NULL pointer .. OSMO_SOCKADDR_STR_FMT_ARGS: guard against NULL pointer

Change in ...libosmocore[master]: fix: vty crash by logging during VTY_CLOSED event handling

2019-08-29 Thread neels
neels has uploaded this change for review. ( https://gerrit.osmocom.org/c/libosmocore/+/15339 Change subject: fix: vty crash by logging during VTY_CLOSED event handling .. fix: vty crash by logging during VTY_CLOSED event

Change in ...libosmocore[master]: sanity: make vty buffer_* API NULL safe

2019-08-29 Thread neels
-Branch: master Gerrit-Change-Id: Idca3f54dc986abf6784790c12e69e02bdf77cb41 Gerrit-Change-Number: 15265 Gerrit-PatchSet: 3 Gerrit-Owner: neels Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria Gerrit-Reviewer: laforge Gerrit-Reviewer: neels Gerrit-Reviewer: osmith Gerrit-CC: pespin

Change in ...libosmo-sccp[master]: osmo_sccp_simple_client(): use sccp instance index 0 instead of 1

2019-08-28 Thread neels
neels has posted comments on this change. ( https://gerrit.osmocom.org/c/libosmo-sccp/+/15062 ) Change subject: osmo_sccp_simple_client(): use sccp instance index 0 instead of 1 .. Patch Set 2: Code-Review+1 -- To view

Change in ...osmo-sip-connector[master]: avoid bogus error logs when no cmd_timer is set

2019-08-28 Thread neels
neels has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-sip-connector/+/15142 ) Change subject: avoid bogus error logs when no cmd_timer is set .. Patch Set 1: let's put this on hold until I clarified

Change in ...osmo-mgw[master]: mgcp_test: extend / rewrite test_mgcp_codec_pt_translate()

2019-08-28 Thread neels
neels has submitted this change and it was merged. ( https://gerrit.osmocom.org/c/osmo-mgw/+/15134 ) Change subject: mgcp_test: extend / rewrite test_mgcp_codec_pt_translate() .. mgcp_test: extend / rewrite

Change in ...osmo-mgw[master]: test_mgcp_codec_pt_translate(): more tests

2019-08-28 Thread neels
neels has submitted this change and it was merged. ( https://gerrit.osmocom.org/c/osmo-mgw/+/15135 ) Change subject: test_mgcp_codec_pt_translate(): more tests .. test_mgcp_codec_pt_translate(): more tests Change-Id

Change in ...osmo-mgw[master]: SDP: store all ptmap entries

2019-08-28 Thread neels
neels has submitted this change and it was merged. ( https://gerrit.osmocom.org/c/osmo-mgw/+/15141 ) Change subject: SDP: store all ptmap entries .. SDP: store all ptmap entries If a ptmap appears in the SDP, always store

Change in ...osmo-mgw[master]: tweak mgcp_parse_audio_ptime_rtpmap()

2019-08-28 Thread neels
neels has submitted this change and it was merged. ( https://gerrit.osmocom.org/c/osmo-mgw/+/15140 ) Change subject: tweak mgcp_parse_audio_ptime_rtpmap() .. tweak mgcp_parse_audio_ptime_rtpmap() - move the error logging up

Change in ...osmo-mgw[master]: mgcp_codec: codec_set(): log about all possible errors

2019-08-28 Thread neels
neels has submitted this change and it was merged. ( https://gerrit.osmocom.org/c/osmo-mgw/+/15138 ) Change subject: mgcp_codec: codec_set(): log about all possible errors .. mgcp_codec: codec_set(): log about all possible

Change in ...osmo-mgw[master]: ptmap: implicitly match '/8000' and '/8000/1'

2019-08-28 Thread neels
neels has submitted this change and it was merged. ( https://gerrit.osmocom.org/c/osmo-mgw/+/15137 ) Change subject: ptmap: implicitly match '/8000' and '/8000/1' .. ptmap: implicitly match '/8000' and '/8000/1

Change in ...osmo-mgw[master]: differentiate AMR octet-aligned=0 vs =1

2019-08-28 Thread neels
neels has submitted this change and it was merged. ( https://gerrit.osmocom.org/c/osmo-mgw/+/15136 ) Change subject: differentiate AMR octet-aligned=0 vs =1 .. differentiate AMR octet-aligned=0 vs =1 Add corresponding tests

Change in ...osmo-mgw[master]: mgcp_codec_add: fix audio_name size check

2019-08-28 Thread neels
neels has submitted this change and it was merged. ( https://gerrit.osmocom.org/c/osmo-mgw/+/15301 ) Change subject: mgcp_codec_add: fix audio_name size check .. mgcp_codec_add: fix audio_name size check Needs to account

Change in ...osmo-mgw[master]: explicitly free codecs in mgcp_rtp_conn_cleanup()

2019-08-28 Thread neels
neels has submitted this change and it was merged. ( https://gerrit.osmocom.org/c/osmo-mgw/+/15139 ) Change subject: explicitly free codecs in mgcp_rtp_conn_cleanup() .. explicitly free codecs in mgcp_rtp_conn_cleanup

Change in ...osmo-sip-connector[master]: mncc: do not unregister unregistered osmo fds

2019-08-28 Thread neels
neels has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-sip-connector/+/15303 ) Change subject: mncc: do not unregister unregistered osmo fds .. Patch Set 2: Code-Review-1 (1 comment) plz explain

Change in ...osmo-ggsn[master]: gtp: Log msg retransmits and timeouts

2019-08-28 Thread neels
neels has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-ggsn/+/15305 ) Change subject: gtp: Log msg retransmits and timeouts .. Patch Set 1: Code-Review+1 (1 comment) https://gerrit.osmocom.org/#/c

Change in ...osmo-ggsn[master]: cosmetic: fix formatting in if line

2019-08-28 Thread neels
neels has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-ggsn/+/15302 ) Change subject: cosmetic: fix formatting in if line .. Patch Set 1: Code-Review+1 (1 comment) not really worth the trouble

Change in ...osmo-ttcn3-hacks[master]: sgsn: Introduce test TC_attach_echo_timeout

2019-08-28 Thread neels
neels has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/15306 ) Change subject: sgsn: Introduce test TC_attach_echo_timeout .. Patch Set 1: Code-Review+1 (1 comment) I don't fully

Change in ...osmo-ttcn3-hacks[master]: sgsn: Proper shutdown of RAN_Adapter components

2019-08-28 Thread neels
neels has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/15295 ) Change subject: sgsn: Proper shutdown of RAN_Adapter components .. Patch Set 2: Code-Review+1 I don't fully understand

Change in ...pysim[master]: Make programming OPC optional

2019-08-28 Thread neels
neels has posted comments on this change. ( https://gerrit.osmocom.org/c/pysim/+/15311 ) Change subject: Make programming OPC optional .. Patch Set 1: Code-Review+1 I was kind of expecting a cmdline switch to go along

Change in ...pysim[master]: make writing SMSP optional

2019-08-28 Thread neels
neels has posted comments on this change. ( https://gerrit.osmocom.org/c/pysim/+/15312 ) Change subject: make writing SMSP optional .. Patch Set 1: Code-Review+1 I was kind of expecting a cmdline switch to go along

Change in ...osmo-bsc[master]: gsm_08_08.c: always pick first msc for unsolicit paging responses

2019-08-28 Thread neels
neels has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-bsc/+/15209 ) Change subject: gsm_08_08.c: always pick first msc for unsolicit paging responses .. Patch Set 2: Code-Review+1 (1 comment) Even

Change in ...osmo-msc[master]: log, cosmetic: add "RR" to "Ciphering Mode Complete"

2019-08-28 Thread neels
sit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-msc Gerrit-Branch: master Gerrit-Change-Id: I80c69b491e2ddb932bc4295a01caaf6a903b1fe4 Gerrit-Change-Number: 15318 Gerrit-PatchSet: 2 Gerrit-Owner: neels Gerrit-Reviewer: Jenkins Builder Gerrit-MessageType: newpatchset

  1   2   3   4   5   6   7   8   9   10   >