Change in ...osmo-msc[master]: gsup_client_mux_tx_error_reply(): fix: do not omit message class IE

2019-06-15 Thread laforge 
laforge has submitted this change and it was merged. ( 
https://gerrit.osmocom.org/c/osmo-msc/+/14454 )

Change subject: gsup_client_mux_tx_error_reply(): fix: do not omit message 
class IE
..

gsup_client_mux_tx_error_reply(): fix: do not omit message class IE

Found using the new TC_mt_ussd_for_unknown_subscr test case.

Change-Id: Id00a99b713a6b97c455b8e6ae49abea163e8281f
Related: (TTCN-3) Id35cd3ec15d1bab15260312d7bbb41e2d10349fe
Related: OS#2931
---
M src/libmsc/gsup_client_mux.c
1 file changed, 1 insertion(+), 0 deletions(-)

Approvals:
  laforge: Looks good to me, approved
  Jenkins Builder: Verified



diff --git a/src/libmsc/gsup_client_mux.c b/src/libmsc/gsup_client_mux.c
index 8c80a6b..495318f 100644
--- a/src/libmsc/gsup_client_mux.c
+++ b/src/libmsc/gsup_client_mux.c
@@ -153,6 +153,7 @@
gsup_reply = (struct osmo_gsup_message){
.cause = cause,
.message_type = 
OSMO_GSUP_TO_MSGT_ERROR(gsup_orig->message_type),
+   .message_class = gsup_orig->message_class,
};

OSMO_STRLCPY_ARRAY(gsup_reply.imsi, gsup_orig->imsi);

--
To view, visit https://gerrit.osmocom.org/c/osmo-msc/+/14454
To unsubscribe, or for help writing mail filters, visit 
https://gerrit.osmocom.org/settings

Gerrit-Project: osmo-msc
Gerrit-Branch: master
Gerrit-Change-Id: Id00a99b713a6b97c455b8e6ae49abea163e8281f
Gerrit-Change-Number: 14454
Gerrit-PatchSet: 3
Gerrit-Owner: fixeria 
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: laforge 
Gerrit-MessageType: merged

Change in ...osmo-msc[master]: gsup_client_mux_tx_error_reply(): fix: do not omit message class IE

2019-06-15 Thread laforge 
laforge has posted comments on this change. ( 
https://gerrit.osmocom.org/c/osmo-msc/+/14454 )

Change subject: gsup_client_mux_tx_error_reply(): fix: do not omit message 
class IE
..


Patch Set 3: Code-Review+2


--
To view, visit https://gerrit.osmocom.org/c/osmo-msc/+/14454
To unsubscribe, or for help writing mail filters, visit 
https://gerrit.osmocom.org/settings

Gerrit-Project: osmo-msc
Gerrit-Branch: master
Gerrit-Change-Id: Id00a99b713a6b97c455b8e6ae49abea163e8281f
Gerrit-Change-Number: 14454
Gerrit-PatchSet: 3
Gerrit-Owner: fixeria 
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: laforge 
Gerrit-Comment-Date: Sat, 15 Jun 2019 08:49:35 +
Gerrit-HasComments: No
Gerrit-Has-Labels: Yes
Gerrit-MessageType: comment

Change in ...osmo-msc[master]: gsup_client_mux_tx_error_reply(): fix: do not omit message class IE

2019-06-15 Thread fixeria 
Hello Jenkins Builder,

I'd like you to reexamine a change. Please visit

https://gerrit.osmocom.org/c/osmo-msc/+/14454

to look at the new patch set (#3).

Change subject: gsup_client_mux_tx_error_reply(): fix: do not omit message 
class IE
..

gsup_client_mux_tx_error_reply(): fix: do not omit message class IE

Found using the new TC_mt_ussd_for_unknown_subscr test case.

Change-Id: Id00a99b713a6b97c455b8e6ae49abea163e8281f
Related: (TTCN-3) Id35cd3ec15d1bab15260312d7bbb41e2d10349fe
Related: OS#2931
---
M src/libmsc/gsup_client_mux.c
1 file changed, 1 insertion(+), 0 deletions(-)


  git pull ssh://gerrit.osmocom.org:29418/osmo-msc refs/changes/54/14454/3
--
To view, visit https://gerrit.osmocom.org/c/osmo-msc/+/14454
To unsubscribe, or for help writing mail filters, visit 
https://gerrit.osmocom.org/settings

Gerrit-Project: osmo-msc
Gerrit-Branch: master
Gerrit-Change-Id: Id00a99b713a6b97c455b8e6ae49abea163e8281f
Gerrit-Change-Number: 14454
Gerrit-PatchSet: 3
Gerrit-Owner: fixeria 
Gerrit-Reviewer: Jenkins Builder
Gerrit-MessageType: newpatchset

Change in ...osmo-msc[master]: gsup_client_mux_tx_error_reply(): fix: do not omit message class IE

2019-06-14 Thread fixeria 
fixeria has uploaded this change for review. ( 
https://gerrit.osmocom.org/c/osmo-msc/+/14454


Change subject: gsup_client_mux_tx_error_reply(): fix: do not omit message 
class IE
..

gsup_client_mux_tx_error_reply(): fix: do not omit message class IE

Found using the new TC_mt_ussd_for_unknown_subscr test case.

Change-Id: Id00a99b713a6b97c455b8e6ae49abea163e8281f
Related: (TTCN-3) Id35cd3ec15d1bab15260312d7bbb41e2d10349fe
Related: OS#2931
---
M src/libmsc/gsup_client_mux.c
1 file changed, 1 insertion(+), 0 deletions(-)



  git pull ssh://gerrit.osmocom.org:29418/osmo-msc refs/changes/54/14454/1

diff --git a/src/libmsc/gsup_client_mux.c b/src/libmsc/gsup_client_mux.c
index 6bac7b2..f5f6927 100644
--- a/src/libmsc/gsup_client_mux.c
+++ b/src/libmsc/gsup_client_mux.c
@@ -153,6 +153,7 @@
gsup_reply = (struct osmo_gsup_message){
.cause = cause,
.message_type = 
OSMO_GSUP_TO_MSGT_ERROR(gsup_orig->message_type),
+   .message_class = gsup_orig->message_class,
};

OSMO_STRLCPY_ARRAY(gsup_reply.imsi, gsup_orig->imsi);

--
To view, visit https://gerrit.osmocom.org/c/osmo-msc/+/14454
To unsubscribe, or for help writing mail filters, visit 
https://gerrit.osmocom.org/settings

Gerrit-Project: osmo-msc
Gerrit-Branch: master
Gerrit-Change-Id: Id00a99b713a6b97c455b8e6ae49abea163e8281f
Gerrit-Change-Number: 14454
Gerrit-PatchSet: 1
Gerrit-Owner: fixeria 
Gerrit-CC: Jenkins Builder
Gerrit-MessageType: newchange