Change in ...osmo-sgsn[master]: gprs_sgsn.h: Flag MM_CTX_T_GERAN_Iu as not supported

2019-08-17 Thread pespin 
pespin has submitted this change and it was merged. ( 
https://gerrit.osmocom.org/c/osmo-sgsn/+/15184 )

Change subject: gprs_sgsn.h: Flag MM_CTX_T_GERAN_Iu as not supported
..

gprs_sgsn.h: Flag MM_CTX_T_GERAN_Iu as not supported

Change-Id: I3b53a530ab25434e2b2f4d80ad70a8a5f22bfcac
---
M include/osmocom/sgsn/gprs_sgsn.h
M src/gprs/sgsn_libgtp.c
2 files changed, 5 insertions(+), 1 deletion(-)

Approvals:
  Jenkins Builder: Verified
  laforge: Looks good to me, approved
  fixeria: Looks good to me, but someone else must approve



diff --git a/include/osmocom/sgsn/gprs_sgsn.h b/include/osmocom/sgsn/gprs_sgsn.h
index a0a056f..10455d6 100644
--- a/include/osmocom/sgsn/gprs_sgsn.h
+++ b/include/osmocom/sgsn/gprs_sgsn.h
@@ -108,8 +108,10 @@
MM_CTX_T_GERAN_Gb,
/* UMTS via Iu */
MM_CTX_T_UTRAN_Iu,
-   /* GPRS/EDGE via Iu */
+#if 0
+   /* GPRS/EDGE via Iu, not supported */
MM_CTX_T_GERAN_Iu,
+#endif
 };

 struct service_info {
diff --git a/src/gprs/sgsn_libgtp.c b/src/gprs/sgsn_libgtp.c
index e9fffd8..88b8d04 100644
--- a/src/gprs/sgsn_libgtp.c
+++ b/src/gprs/sgsn_libgtp.c
@@ -279,7 +279,9 @@
pdp->userloc.l = 8;
switch (mmctx->ran_type) {
case MM_CTX_T_GERAN_Gb:
+#if 0
case MM_CTX_T_GERAN_Iu:
+#endif
pdp->rattype.v[0] = 2;
/* User Location Information */
pdp->userloc_given = 1;

-- 
To view, visit https://gerrit.osmocom.org/c/osmo-sgsn/+/15184
To unsubscribe, or for help writing mail filters, visit 
https://gerrit.osmocom.org/settings

Gerrit-Project: osmo-sgsn
Gerrit-Branch: master
Gerrit-Change-Id: I3b53a530ab25434e2b2f4d80ad70a8a5f22bfcac
Gerrit-Change-Number: 15184
Gerrit-PatchSet: 3
Gerrit-Owner: pespin 
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: fixeria 
Gerrit-Reviewer: laforge 
Gerrit-Reviewer: neels 
Gerrit-Reviewer: pespin 
Gerrit-CC: lynxis lazus 
Gerrit-MessageType: merged

Change in ...osmo-sgsn[master]: gprs_sgsn.h: Flag MM_CTX_T_GERAN_Iu as not supported

2019-08-17 Thread fixeria 
fixeria has posted comments on this change. ( 
https://gerrit.osmocom.org/c/osmo-sgsn/+/15184 )

Change subject: gprs_sgsn.h: Flag MM_CTX_T_GERAN_Iu as not supported
..


Patch Set 3: Code-Review+1


--
To view, visit https://gerrit.osmocom.org/c/osmo-sgsn/+/15184
To unsubscribe, or for help writing mail filters, visit 
https://gerrit.osmocom.org/settings

Gerrit-Project: osmo-sgsn
Gerrit-Branch: master
Gerrit-Change-Id: I3b53a530ab25434e2b2f4d80ad70a8a5f22bfcac
Gerrit-Change-Number: 15184
Gerrit-PatchSet: 3
Gerrit-Owner: pespin 
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: fixeria 
Gerrit-Reviewer: laforge 
Gerrit-Reviewer: neels 
Gerrit-Reviewer: pespin 
Gerrit-CC: lynxis lazus 
Gerrit-Comment-Date: Sat, 17 Aug 2019 08:50:06 +
Gerrit-HasComments: No
Gerrit-Has-Labels: Yes
Gerrit-MessageType: comment

Change in ...osmo-sgsn[master]: gprs_sgsn.h: Flag MM_CTX_T_GERAN_Iu as not supported

2019-08-16 Thread laforge 
laforge has posted comments on this change. ( 
https://gerrit.osmocom.org/c/osmo-sgsn/+/15184 )

Change subject: gprs_sgsn.h: Flag MM_CTX_T_GERAN_Iu as not supported
..


Patch Set 3: Code-Review+2


--
To view, visit https://gerrit.osmocom.org/c/osmo-sgsn/+/15184
To unsubscribe, or for help writing mail filters, visit 
https://gerrit.osmocom.org/settings

Gerrit-Project: osmo-sgsn
Gerrit-Branch: master
Gerrit-Change-Id: I3b53a530ab25434e2b2f4d80ad70a8a5f22bfcac
Gerrit-Change-Number: 15184
Gerrit-PatchSet: 3
Gerrit-Owner: pespin 
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: fixeria 
Gerrit-Reviewer: laforge 
Gerrit-Reviewer: neels 
Gerrit-Reviewer: pespin 
Gerrit-CC: lynxis lazus 
Gerrit-Comment-Date: Sat, 17 Aug 2019 01:22:28 +
Gerrit-HasComments: No
Gerrit-Has-Labels: Yes
Gerrit-MessageType: comment

Change in ...osmo-sgsn[master]: gprs_sgsn.h: Flag MM_CTX_T_GERAN_Iu as not supported

2019-08-16 Thread pespin 
pespin has posted comments on this change. ( 
https://gerrit.osmocom.org/c/osmo-sgsn/+/15184 )

Change subject: gprs_sgsn.h: Flag MM_CTX_T_GERAN_Iu as not supported
..


Patch Set 3:

> Patch Set 3:
>
> IMHO: remove the case ..._Iu and add a comment to the enum _Iu it's 
> unsupported. I don't like the ifdef0

I already changed it following some comments, and end result is the same you 
are expected, so if you don't mind I'm leaving it this way.


--
To view, visit https://gerrit.osmocom.org/c/osmo-sgsn/+/15184
To unsubscribe, or for help writing mail filters, visit 
https://gerrit.osmocom.org/settings

Gerrit-Project: osmo-sgsn
Gerrit-Branch: master
Gerrit-Change-Id: I3b53a530ab25434e2b2f4d80ad70a8a5f22bfcac
Gerrit-Change-Number: 15184
Gerrit-PatchSet: 3
Gerrit-Owner: pespin 
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: fixeria 
Gerrit-Reviewer: laforge 
Gerrit-Reviewer: neels 
Gerrit-Reviewer: pespin 
Gerrit-CC: lynxis lazus 
Gerrit-Comment-Date: Fri, 16 Aug 2019 10:15:19 +
Gerrit-HasComments: No
Gerrit-Has-Labels: No
Gerrit-MessageType: comment

Change in ...osmo-sgsn[master]: gprs_sgsn.h: Flag MM_CTX_T_GERAN_Iu as not supported

2019-08-15 Thread lynxis lazus 
lynxis lazus has posted comments on this change. ( 
https://gerrit.osmocom.org/c/osmo-sgsn/+/15184 )

Change subject: gprs_sgsn.h: Flag MM_CTX_T_GERAN_Iu as not supported
..


Patch Set 3:

IMHO: remove the case ..._Iu and add a comment to the enum _Iu it's 
unsupported. I don't like the ifdef0


-- 
To view, visit https://gerrit.osmocom.org/c/osmo-sgsn/+/15184
To unsubscribe, or for help writing mail filters, visit 
https://gerrit.osmocom.org/settings

Gerrit-Project: osmo-sgsn
Gerrit-Branch: master
Gerrit-Change-Id: I3b53a530ab25434e2b2f4d80ad70a8a5f22bfcac
Gerrit-Change-Number: 15184
Gerrit-PatchSet: 3
Gerrit-Owner: pespin 
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: fixeria 
Gerrit-Reviewer: laforge 
Gerrit-Reviewer: neels 
Gerrit-CC: lynxis lazus 
Gerrit-Comment-Date: Fri, 16 Aug 2019 00:09:30 +
Gerrit-HasComments: No
Gerrit-Has-Labels: No
Gerrit-MessageType: comment

Change in ...osmo-sgsn[master]: gprs_sgsn.h: Flag MM_CTX_T_GERAN_Iu as not supported

2019-08-15 Thread pespin 
Hello fixeria, neels, laforge, Jenkins Builder,

I'd like you to reexamine a change. Please visit

https://gerrit.osmocom.org/c/osmo-sgsn/+/15184

to look at the new patch set (#3).

Change subject: gprs_sgsn.h: Flag MM_CTX_T_GERAN_Iu as not supported
..

gprs_sgsn.h: Flag MM_CTX_T_GERAN_Iu as not supported

Change-Id: I3b53a530ab25434e2b2f4d80ad70a8a5f22bfcac
---
M include/osmocom/sgsn/gprs_sgsn.h
M src/gprs/sgsn_libgtp.c
2 files changed, 5 insertions(+), 1 deletion(-)


  git pull ssh://gerrit.osmocom.org:29418/osmo-sgsn refs/changes/84/15184/3
--
To view, visit https://gerrit.osmocom.org/c/osmo-sgsn/+/15184
To unsubscribe, or for help writing mail filters, visit 
https://gerrit.osmocom.org/settings

Gerrit-Project: osmo-sgsn
Gerrit-Branch: master
Gerrit-Change-Id: I3b53a530ab25434e2b2f4d80ad70a8a5f22bfcac
Gerrit-Change-Number: 15184
Gerrit-PatchSet: 3
Gerrit-Owner: pespin 
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: fixeria 
Gerrit-Reviewer: laforge 
Gerrit-Reviewer: neels 
Gerrit-MessageType: newpatchset

Change in ...osmo-sgsn[master]: gprs_sgsn.h: Flag MM_CTX_T_GERAN_Iu as not supported

2019-08-15 Thread laforge 
laforge has posted comments on this change. ( 
https://gerrit.osmocom.org/c/osmo-sgsn/+/15184 )

Change subject: gprs_sgsn.h: Flag MM_CTX_T_GERAN_Iu as not supported
..


Patch Set 2: Code-Review+2


--
To view, visit https://gerrit.osmocom.org/c/osmo-sgsn/+/15184
To unsubscribe, or for help writing mail filters, visit 
https://gerrit.osmocom.org/settings

Gerrit-Project: osmo-sgsn
Gerrit-Branch: master
Gerrit-Change-Id: I3b53a530ab25434e2b2f4d80ad70a8a5f22bfcac
Gerrit-Change-Number: 15184
Gerrit-PatchSet: 2
Gerrit-Owner: pespin 
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: fixeria 
Gerrit-Reviewer: laforge 
Gerrit-Reviewer: neels 
Gerrit-Comment-Date: Thu, 15 Aug 2019 09:56:34 +
Gerrit-HasComments: No
Gerrit-Has-Labels: Yes
Gerrit-MessageType: comment

Change in ...osmo-sgsn[master]: gprs_sgsn.h: Flag MM_CTX_T_GERAN_Iu as not supported

2019-08-14 Thread neels 
neels has posted comments on this change. ( 
https://gerrit.osmocom.org/c/osmo-sgsn/+/15184 )

Change subject: gprs_sgsn.h: Flag MM_CTX_T_GERAN_Iu as not supported
..


Patch Set 2: Code-Review+2

why is that even in there...


--
To view, visit https://gerrit.osmocom.org/c/osmo-sgsn/+/15184
To unsubscribe, or for help writing mail filters, visit 
https://gerrit.osmocom.org/settings

Gerrit-Project: osmo-sgsn
Gerrit-Branch: master
Gerrit-Change-Id: I3b53a530ab25434e2b2f4d80ad70a8a5f22bfcac
Gerrit-Change-Number: 15184
Gerrit-PatchSet: 2
Gerrit-Owner: pespin 
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: fixeria 
Gerrit-Reviewer: neels 
Gerrit-Comment-Date: Wed, 14 Aug 2019 23:21:38 +
Gerrit-HasComments: No
Gerrit-Has-Labels: Yes
Gerrit-MessageType: comment

Change in ...osmo-sgsn[master]: gprs_sgsn.h: Flag MM_CTX_T_GERAN_Iu as not supported

2019-08-14 Thread fixeria 
fixeria has posted comments on this change. ( 
https://gerrit.osmocom.org/c/osmo-sgsn/+/15184 )

Change subject: gprs_sgsn.h: Flag MM_CTX_T_GERAN_Iu as not supported
..


Patch Set 2: Code-Review+1


--
To view, visit https://gerrit.osmocom.org/c/osmo-sgsn/+/15184
To unsubscribe, or for help writing mail filters, visit 
https://gerrit.osmocom.org/settings

Gerrit-Project: osmo-sgsn
Gerrit-Branch: master
Gerrit-Change-Id: I3b53a530ab25434e2b2f4d80ad70a8a5f22bfcac
Gerrit-Change-Number: 15184
Gerrit-PatchSet: 2
Gerrit-Owner: pespin 
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: fixeria 
Gerrit-Comment-Date: Wed, 14 Aug 2019 22:56:16 +
Gerrit-HasComments: No
Gerrit-Has-Labels: Yes
Gerrit-MessageType: comment

Change in ...osmo-sgsn[master]: gprs_sgsn.h: Flag MM_CTX_T_GERAN_Iu as not supported

2019-08-13 Thread pespin 
pespin has uploaded this change for review. ( 
https://gerrit.osmocom.org/c/osmo-sgsn/+/15184


Change subject: gprs_sgsn.h: Flag MM_CTX_T_GERAN_Iu as not supported
..

gprs_sgsn.h: Flag MM_CTX_T_GERAN_Iu as not supported

Change-Id: I3b53a530ab25434e2b2f4d80ad70a8a5f22bfcac
---
M include/osmocom/sgsn/gprs_sgsn.h
1 file changed, 1 insertion(+), 1 deletion(-)



  git pull ssh://gerrit.osmocom.org:29418/osmo-sgsn refs/changes/84/15184/1

diff --git a/include/osmocom/sgsn/gprs_sgsn.h b/include/osmocom/sgsn/gprs_sgsn.h
index a0a056f..9f58aaa 100644
--- a/include/osmocom/sgsn/gprs_sgsn.h
+++ b/include/osmocom/sgsn/gprs_sgsn.h
@@ -109,7 +109,7 @@
/* UMTS via Iu */
MM_CTX_T_UTRAN_Iu,
/* GPRS/EDGE via Iu */
-   MM_CTX_T_GERAN_Iu,
+   MM_CTX_T_GERAN_Iu, /* FIXME: not supported */
 };

 struct service_info {

--
To view, visit https://gerrit.osmocom.org/c/osmo-sgsn/+/15184
To unsubscribe, or for help writing mail filters, visit 
https://gerrit.osmocom.org/settings

Gerrit-Project: osmo-sgsn
Gerrit-Branch: master
Gerrit-Change-Id: I3b53a530ab25434e2b2f4d80ad70a8a5f22bfcac
Gerrit-Change-Number: 15184
Gerrit-PatchSet: 1
Gerrit-Owner: pespin 
Gerrit-MessageType: newchange