Change in ...osmo-ttcn3-hacks[master]: start-testsuite.sh: Add commented-out section for using custom TITAN

2019-08-15 Thread laforge
laforge has submitted this change and it was merged. ( 
https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/15192 )

Change subject: start-testsuite.sh: Add commented-out section for using custom 
TITAN
..

start-testsuite.sh: Add commented-out section for using custom TITAN

Sometimes it's useful to test with a non-installed locally-compiled
version of Eclipse TITAN.  This adds an example on how to do that.

Change-Id: I6a8c26becff868a3d2fcd3a01e2c03adfc748e0a
---
M start-testsuite.sh
1 file changed, 9 insertions(+), 1 deletion(-)

Approvals:
  pespin: Looks good to me, approved
  Jenkins Builder: Verified



diff --git a/start-testsuite.sh b/start-testsuite.sh
index 54332bb..e5bc756 100755
--- a/start-testsuite.sh
+++ b/start-testsuite.sh
@@ -36,8 +36,16 @@
TEST=$3
 fi

+# this is an example for using a non-installed custom (e.g. git master) TITAN
+#TTCN3_DIR="/home/laforge/projects/git/titan/titan.core/Install"
+#export TTCN3_DIR
+#TITAN_LIBRARY_PATH="$TTCN3_DIR/lib"
+#TTCN3_BIN_DIR="$TTCN3_DIR/bin"
+
+# below is for the debian packages
+TTCN3_BIN_DIR="/usr/bin"
 TITAN_LIBRARY_PATH="/usr/lib/titan:/usr/ttcn3/lib"
-LD_LIBRARY_PATH="$LD_LIBRARY_PATH:$SUITE_DIR:$TITAN_LIBRARY_PATH" ttcn3_start 
$SUITE $CFG $TEST
+LD_LIBRARY_PATH="$LD_LIBRARY_PATH:$SUITE_DIR:$TITAN_LIBRARY_PATH" 
"$TTCN3_BIN_DIR/ttcn3_start" $SUITE $CFG $TEST

 expected="$SUITE_DIR/expected-results.xml"
 if [ ! -f "$expected" ]; then

--
To view, visit https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/15192
To unsubscribe, or for help writing mail filters, visit 
https://gerrit.osmocom.org/settings

Gerrit-Project: osmo-ttcn3-hacks
Gerrit-Branch: master
Gerrit-Change-Id: I6a8c26becff868a3d2fcd3a01e2c03adfc748e0a
Gerrit-Change-Number: 15192
Gerrit-PatchSet: 2
Gerrit-Owner: laforge 
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: laforge 
Gerrit-Reviewer: pespin 
Gerrit-MessageType: merged


Change in ...osmo-ttcn3-hacks[master]: start-testsuite.sh: Add commented-out section for using custom TITAN

2019-08-14 Thread pespin
pespin has posted comments on this change. ( 
https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/15192 )

Change subject: start-testsuite.sh: Add commented-out section for using custom 
TITAN
..


Patch Set 1: Code-Review+2


--
To view, visit https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/15192
To unsubscribe, or for help writing mail filters, visit 
https://gerrit.osmocom.org/settings

Gerrit-Project: osmo-ttcn3-hacks
Gerrit-Branch: master
Gerrit-Change-Id: I6a8c26becff868a3d2fcd3a01e2c03adfc748e0a
Gerrit-Change-Number: 15192
Gerrit-PatchSet: 1
Gerrit-Owner: laforge 
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: laforge 
Gerrit-Reviewer: pespin 
Gerrit-Comment-Date: Wed, 14 Aug 2019 11:50:32 +
Gerrit-HasComments: No
Gerrit-Has-Labels: Yes
Gerrit-MessageType: comment


Change in ...osmo-ttcn3-hacks[master]: start-testsuite.sh: Add commented-out section for using custom TITAN

2019-08-14 Thread laforge
laforge has posted comments on this change. ( 
https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/15192 )

Change subject: start-testsuite.sh: Add commented-out section for using custom 
TITAN
..


Patch Set 1:

(1 comment)

https://gerrit.osmocom.org/#/c/15192/1/start-testsuite.sh
File start-testsuite.sh:

https://gerrit.osmocom.org/#/c/15192/1/start-testsuite.sh@41 
PS1, Line 41: #export TTCN3_DIR
> Why not putting this 2 lines together? export TTCN3_DIR="..." […]
I remember some shells don't like/support putting the export and the variable 
definition in one row.  I got burnt by that too often in the past to try it 
anymore.

The export is needed AFAIR, yes.



--
To view, visit https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/15192
To unsubscribe, or for help writing mail filters, visit 
https://gerrit.osmocom.org/settings

Gerrit-Project: osmo-ttcn3-hacks
Gerrit-Branch: master
Gerrit-Change-Id: I6a8c26becff868a3d2fcd3a01e2c03adfc748e0a
Gerrit-Change-Number: 15192
Gerrit-PatchSet: 1
Gerrit-Owner: laforge 
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: laforge 
Gerrit-CC: pespin 
Gerrit-Comment-Date: Wed, 14 Aug 2019 11:49:27 +
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: pespin 
Gerrit-MessageType: comment


Change in ...osmo-ttcn3-hacks[master]: start-testsuite.sh: Add commented-out section for using custom TITAN

2019-08-14 Thread pespin
pespin has posted comments on this change. ( 
https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/15192 )

Change subject: start-testsuite.sh: Add commented-out section for using custom 
TITAN
..


Patch Set 1:

(1 comment)

https://gerrit.osmocom.org/#/c/15192/1/start-testsuite.sh
File start-testsuite.sh:

https://gerrit.osmocom.org/#/c/15192/1/start-testsuite.sh@41
PS1, Line 41: #export TTCN3_DIR
Why not putting this 2 lines together? export TTCN3_DIR="..."

Do you really need the export?



--
To view, visit https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/15192
To unsubscribe, or for help writing mail filters, visit 
https://gerrit.osmocom.org/settings

Gerrit-Project: osmo-ttcn3-hacks
Gerrit-Branch: master
Gerrit-Change-Id: I6a8c26becff868a3d2fcd3a01e2c03adfc748e0a
Gerrit-Change-Number: 15192
Gerrit-PatchSet: 1
Gerrit-Owner: laforge 
Gerrit-Reviewer: Jenkins Builder
Gerrit-CC: pespin 
Gerrit-Comment-Date: Wed, 14 Aug 2019 11:21:29 +
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Gerrit-MessageType: comment


Change in ...osmo-ttcn3-hacks[master]: start-testsuite.sh: Add commented-out section for using custom TITAN

2019-08-14 Thread laforge
laforge has uploaded this change for review. ( 
https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/15192


Change subject: start-testsuite.sh: Add commented-out section for using custom 
TITAN
..

start-testsuite.sh: Add commented-out section for using custom TITAN

Sometimes it's useful to test with a non-installed locally-compiled
version of Eclipse TITAN.  This adds an example on how to do that.

Change-Id: I6a8c26becff868a3d2fcd3a01e2c03adfc748e0a
---
M start-testsuite.sh
1 file changed, 9 insertions(+), 1 deletion(-)



  git pull ssh://gerrit.osmocom.org:29418/osmo-ttcn3-hacks 
refs/changes/92/15192/1

diff --git a/start-testsuite.sh b/start-testsuite.sh
index 54332bb..e5bc756 100755
--- a/start-testsuite.sh
+++ b/start-testsuite.sh
@@ -36,8 +36,16 @@
TEST=$3
 fi

+# this is an example for using a non-installed custom (e.g. git master) TITAN
+#TTCN3_DIR="/home/laforge/projects/git/titan/titan.core/Install"
+#export TTCN3_DIR
+#TITAN_LIBRARY_PATH="$TTCN3_DIR/lib"
+#TTCN3_BIN_DIR="$TTCN3_DIR/bin"
+
+# below is for the debian packages
+TTCN3_BIN_DIR="/usr/bin"
 TITAN_LIBRARY_PATH="/usr/lib/titan:/usr/ttcn3/lib"
-LD_LIBRARY_PATH="$LD_LIBRARY_PATH:$SUITE_DIR:$TITAN_LIBRARY_PATH" ttcn3_start 
$SUITE $CFG $TEST
+LD_LIBRARY_PATH="$LD_LIBRARY_PATH:$SUITE_DIR:$TITAN_LIBRARY_PATH" 
"$TTCN3_BIN_DIR/ttcn3_start" $SUITE $CFG $TEST

 expected="$SUITE_DIR/expected-results.xml"
 if [ ! -f "$expected" ]; then

--
To view, visit https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/15192
To unsubscribe, or for help writing mail filters, visit 
https://gerrit.osmocom.org/settings

Gerrit-Project: osmo-ttcn3-hacks
Gerrit-Branch: master
Gerrit-Change-Id: I6a8c26becff868a3d2fcd3a01e2c03adfc748e0a
Gerrit-Change-Number: 15192
Gerrit-PatchSet: 1
Gerrit-Owner: laforge 
Gerrit-MessageType: newchange