Change in osmo-msc[master]: Update VLR test helper

2018-11-04 Thread Neels Hofmeyr 
Neels Hofmeyr has posted comments on this change. ( 
https://gerrit.osmocom.org/11458 )

Change subject: Update VLR test helper
..


Patch Set 1:

hrm, why is a -1 vote hidden by a +2? I'd at least want to see the author that 
there is a negative vote in the overview... I don't want to -2, since that 
would be too sticky...


--
To view, visit https://gerrit.osmocom.org/11458
To unsubscribe, or for help writing mail filters, visit 
https://gerrit.osmocom.org/settings

Gerrit-Project: osmo-msc
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Icf507d094319123c6667ba963db1d385df4d4f92
Gerrit-Change-Number: 11458
Gerrit-PatchSet: 1
Gerrit-Owner: Max 
Gerrit-Reviewer: Harald Welte 
Gerrit-Reviewer: Jenkins Builder (102)
Gerrit-Reviewer: Neels Hofmeyr 
Gerrit-Comment-Date: Mon, 05 Nov 2018 03:43:37 +
Gerrit-HasComments: No
Gerrit-HasLabels: No

Change in osmo-msc[master]: Update VLR test helper

2018-11-04 Thread Neels Hofmeyr 
Neels Hofmeyr has posted comments on this change. ( 
https://gerrit.osmocom.org/11458 )

Change subject: Update VLR test helper
..


Patch Set 1: Code-Review-1

(1 comment)

not sure why, but if you merge please fix the commit summary

https://gerrit.osmocom.org/#/c/11458/1//COMMIT_MSG
Commit Message:

https://gerrit.osmocom.org/#/c/11458/1//COMMIT_MSG@7
PS1, Line 7: Update VLR test helper
this summary could mean just about anything! Rather say:

  msc_vlr_tests: tweak conn_exists()



--
To view, visit https://gerrit.osmocom.org/11458
To unsubscribe, or for help writing mail filters, visit 
https://gerrit.osmocom.org/settings

Gerrit-Project: osmo-msc
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Icf507d094319123c6667ba963db1d385df4d4f92
Gerrit-Change-Number: 11458
Gerrit-PatchSet: 1
Gerrit-Owner: Max 
Gerrit-Reviewer: Harald Welte 
Gerrit-Reviewer: Jenkins Builder (102)
Gerrit-Reviewer: Neels Hofmeyr 
Gerrit-Comment-Date: Mon, 05 Nov 2018 03:41:33 +
Gerrit-HasComments: Yes
Gerrit-HasLabels: Yes

Change in osmo-msc[master]: Update VLR test helper

2018-10-25 Thread Harald Welte 
Harald Welte has posted comments on this change. ( 
https://gerrit.osmocom.org/11458 )

Change subject: Update VLR test helper
..


Patch Set 1: Code-Review+2

nice, but again one of those patches where I'm wondering "why spend time on 
this now?"


--
To view, visit https://gerrit.osmocom.org/11458
To unsubscribe, or for help writing mail filters, visit 
https://gerrit.osmocom.org/settings

Gerrit-Project: osmo-msc
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Icf507d094319123c6667ba963db1d385df4d4f92
Gerrit-Change-Number: 11458
Gerrit-PatchSet: 1
Gerrit-Owner: Max 
Gerrit-Reviewer: Harald Welte 
Gerrit-Reviewer: Jenkins Builder (102)
Gerrit-Comment-Date: Thu, 25 Oct 2018 17:58:41 +
Gerrit-HasComments: No
Gerrit-HasLabels: Yes

Change in osmo-msc[master]: Update VLR test helper

2018-10-25 Thread Max 
Max has posted comments on this change. ( https://gerrit.osmocom.org/11458 )

Change subject: Update VLR test helper
..


Set Ready For Review


--
To view, visit https://gerrit.osmocom.org/11458
To unsubscribe, or for help writing mail filters, visit 
https://gerrit.osmocom.org/settings

Gerrit-Project: osmo-msc
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Icf507d094319123c6667ba963db1d385df4d4f92
Gerrit-Change-Number: 11458
Gerrit-PatchSet: 1
Gerrit-Owner: Max 
Gerrit-Reviewer: Jenkins Builder (102)
Gerrit-Comment-Date: Thu, 25 Oct 2018 16:19:27 +
Gerrit-HasComments: No
Gerrit-HasLabels: No