[ABANDON] libosmocore[master]: gsm0480: expose the gsm0480_parse_ss_facility_ie()

2018-01-18 Thread Vadim Yanitskiy 
Vadim Yanitskiy has abandoned this change.

Change subject: gsm0480: expose the gsm0480_parse_ss_facility_ie()
..


Abandoned

Change is not required anymore.

-- 
To view, visit https://gerrit.osmocom.org/3381
To unsubscribe, visit https://gerrit.osmocom.org/settings

Gerrit-MessageType: abandon
Gerrit-Change-Id: I35d3360f36c48eb1295610ab96ff264c45af77eb
Gerrit-PatchSet: 9
Gerrit-Project: libosmocore
Gerrit-Branch: master
Gerrit-Owner: Vadim Yanitskiy 
Gerrit-Reviewer: Alexander Chemeris 
Gerrit-Reviewer: Harald Welte 
Gerrit-Reviewer: Ivan Kluchnikov 
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: Vadim Yanitskiy

libosmocore[master]: gsm0480: expose the gsm0480_parse_ss_facility_ie()

2018-01-17 Thread Alexander Chemeris 

Patch Set 9:

I don't remember off the top of my head. If it's not used in OpenBSC or in the 
SIP proxy, then I guess this is not required.

-- 
To view, visit https://gerrit.osmocom.org/3381
To unsubscribe, visit https://gerrit.osmocom.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I35d3360f36c48eb1295610ab96ff264c45af77eb
Gerrit-PatchSet: 9
Gerrit-Project: libosmocore
Gerrit-Branch: master
Gerrit-Owner: Vadim Yanitskiy 
Gerrit-Reviewer: Alexander Chemeris 
Gerrit-Reviewer: Harald Welte 
Gerrit-Reviewer: Ivan Kluchnikov 
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: Vadim Yanitskiy 
Gerrit-HasComments: No

libosmocore[master]: gsm0480: expose the gsm0480_parse_ss_facility_ie()

2018-01-17 Thread Vadim Yanitskiy 

Patch Set 9: Code-Review-1

I am not sure if we really need this change.
Alexander?

-- 
To view, visit https://gerrit.osmocom.org/3381
To unsubscribe, visit https://gerrit.osmocom.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I35d3360f36c48eb1295610ab96ff264c45af77eb
Gerrit-PatchSet: 9
Gerrit-Project: libosmocore
Gerrit-Branch: master
Gerrit-Owner: Vadim Yanitskiy 
Gerrit-Reviewer: Alexander Chemeris 
Gerrit-Reviewer: Harald Welte 
Gerrit-Reviewer: Ivan Kluchnikov 
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: Vadim Yanitskiy 
Gerrit-HasComments: No

[PATCH] libosmocore[master]: gsm0480: expose the gsm0480_parse_ss_facility_ie()

2018-01-14 Thread Vadim Yanitskiy 
Hello Alexander Chemeris, Harald Welte, Jenkins Builder,

I'd like you to reexamine a change.  Please visit

https://gerrit.osmocom.org/3381

to look at the new patch set (#8).

gsm0480: expose the gsm0480_parse_ss_facility_ie()

Change-Id: I35d3360f36c48eb1295610ab96ff264c45af77eb
---
M include/osmocom/gsm/gsm0480.h
M src/gsm/gsm0480.c
M src/gsm/libosmogsm.map
3 files changed, 8 insertions(+), 6 deletions(-)


  git pull ssh://gerrit.osmocom.org:29418/libosmocore refs/changes/81/3381/8

diff --git a/include/osmocom/gsm/gsm0480.h b/include/osmocom/gsm/gsm0480.h
index 000c0b0..963ae9b 100644
--- a/include/osmocom/gsm/gsm0480.h
+++ b/include/osmocom/gsm/gsm0480.h
@@ -50,6 +50,8 @@
 
 int gsm0480_decode_ss_request(const struct gsm48_hdr *hdr, uint16_t len,
struct ss_request *request);
+int gsm0480_parse_ss_facility_ie(const uint8_t *facility_ie, uint16_t length,
+struct ss_request *req);
 
 struct msgb *gsm0480_create_ussd_resp(uint8_t invoke_id, uint8_t trans_id, 
const char *text);
 struct msgb *gsm0480_create_unstructuredSS_Notify(int alertPattern, const char 
*text);
diff --git a/src/gsm/gsm0480.c b/src/gsm/gsm0480.c
index 9e27aab..82946a3 100644
--- a/src/gsm/gsm0480.c
+++ b/src/gsm/gsm0480.c
@@ -200,8 +200,6 @@
 struct ss_request *req);
 static int parse_ss_info_elements(const uint8_t *ussd_ie, uint16_t len,
  struct ss_request *req);
-static int parse_facility_ie(const uint8_t *facility_ie, uint16_t length,
-struct ss_request *req);
 static int parse_ss_invoke(const uint8_t *invoke_data, uint16_t length,
struct ss_request *req);
 static int parse_ss_return_result(const uint8_t *rr_data, uint16_t length,
@@ -316,7 +314,8 @@
if (len - 1 < facility_length)
return 0;
 
-   return parse_facility_ie(ss_facility + 1, facility_length, req);
+   return gsm0480_parse_ss_facility_ie(ss_facility + 1,
+   facility_length, req);
 }
 
 static int parse_ss_info_elements(const uint8_t *ss_ie, uint16_t len,
@@ -338,7 +337,7 @@
case GSM48_IE_CAUSE:
break;
case GSM0480_IE_FACILITY:
-   rc = parse_facility_ie(ss_ie + 2, iei_length, req);
+   rc = gsm0480_parse_ss_facility_ie(ss_ie + 2, iei_length, req);
break;
case GSM0480_IE_SS_VERSION:
break;
@@ -352,8 +351,8 @@
return rc;
 }
 
-static int parse_facility_ie(const uint8_t *facility_ie, uint16_t length,
-struct ss_request *req)
+int gsm0480_parse_ss_facility_ie(const uint8_t *facility_ie, uint16_t length,
+struct ss_request *req)
 {
int rc = 1;
uint8_t offset = 0;
diff --git a/src/gsm/libosmogsm.map b/src/gsm/libosmogsm.map
index 985ec83..de9cdaa 100644
--- a/src/gsm/libosmogsm.map
+++ b/src/gsm/libosmogsm.map
@@ -90,6 +90,7 @@
 gsm0480_create_ussd_release_complete;
 gsm0480_decode_ussd_request;
 gsm0480_decode_ss_request;
+gsm0480_parse_ss_facility_ie;
 gsm0480_wrap_facility;
 gsm0480_wrap_invoke;
 

-- 
To view, visit https://gerrit.osmocom.org/3381
To unsubscribe, visit https://gerrit.osmocom.org/settings

Gerrit-MessageType: newpatchset
Gerrit-Change-Id: I35d3360f36c48eb1295610ab96ff264c45af77eb
Gerrit-PatchSet: 8
Gerrit-Project: libosmocore
Gerrit-Branch: master
Gerrit-Owner: Vadim Yanitskiy 
Gerrit-Reviewer: Alexander Chemeris 
Gerrit-Reviewer: Harald Welte 
Gerrit-Reviewer: Ivan Kluchnikov 
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: Vadim Yanitskiy

libosmocore[master]: gsm0480: expose the gsm0480_parse_ss_facility_ie()

2018-01-12 Thread Vadim Yanitskiy 

Patch Set 7:

> but then, all the other routines in this function
> don't seem to follow that rule.

Moreover, for some functions here a positive return
value means 'success', while rc=0 indicates an error ;)

-- 
To view, visit https://gerrit.osmocom.org/3381
To unsubscribe, visit https://gerrit.osmocom.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I35d3360f36c48eb1295610ab96ff264c45af77eb
Gerrit-PatchSet: 7
Gerrit-Project: libosmocore
Gerrit-Branch: master
Gerrit-Owner: Vadim Yanitskiy 
Gerrit-Reviewer: Alexander Chemeris 
Gerrit-Reviewer: Harald Welte 
Gerrit-Reviewer: Ivan Kluchnikov 
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: Vadim Yanitskiy 
Gerrit-HasComments: No

libosmocore[master]: gsm0480: expose the gsm0480_parse_ss_facility_ie()

2018-01-12 Thread Harald Welte 

Patch Set 7: Code-Review+2

(1 comment)

https://gerrit.osmocom.org/#/c/3381/7/include/osmocom/gsm/gsm0480.h
File include/osmocom/gsm/gsm0480.h:

Line 73: int gsm0480_parse_ss_facility_ie(const uint8_t *facility_ie, uint16_t 
length,
> the general "rule of thumb" in smocom coding style is is to follow "memcpy"
but then, all the other routines in this function don't seem to follow that 
rule.


-- 
To view, visit https://gerrit.osmocom.org/3381
To unsubscribe, visit https://gerrit.osmocom.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I35d3360f36c48eb1295610ab96ff264c45af77eb
Gerrit-PatchSet: 7
Gerrit-Project: libosmocore
Gerrit-Branch: master
Gerrit-Owner: Vadim Yanitskiy 
Gerrit-Reviewer: Alexander Chemeris 
Gerrit-Reviewer: Harald Welte 
Gerrit-Reviewer: Ivan Kluchnikov 
Gerrit-Reviewer: Jenkins Builder
Gerrit-HasComments: Yes

libosmocore[master]: gsm0480: expose the gsm0480_parse_ss_facility_ie()

2018-01-12 Thread Harald Welte 

Patch Set 7:

(1 comment)

https://gerrit.osmocom.org/#/c/3381/7/include/osmocom/gsm/gsm0480.h
File include/osmocom/gsm/gsm0480.h:

Line 73: int gsm0480_parse_ss_facility_ie(const uint8_t *facility_ie, uint16_t 
length,
the general "rule of thumb" in smocom coding style is is to follow "memcpy" 
notation, and have non-const output pointer first, followed by input arguments 
such as the const buffer.


-- 
To view, visit https://gerrit.osmocom.org/3381
To unsubscribe, visit https://gerrit.osmocom.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I35d3360f36c48eb1295610ab96ff264c45af77eb
Gerrit-PatchSet: 7
Gerrit-Project: libosmocore
Gerrit-Branch: master
Gerrit-Owner: Vadim Yanitskiy 
Gerrit-Reviewer: Alexander Chemeris 
Gerrit-Reviewer: Harald Welte 
Gerrit-Reviewer: Ivan Kluchnikov 
Gerrit-Reviewer: Jenkins Builder
Gerrit-HasComments: Yes

libosmocore[master]: gsm0480: expose the gsm0480_parse_ss_facility_ie()

2018-01-10 Thread Alexander Chemeris 

Patch Set 6: Code-Review+1

-- 
To view, visit https://gerrit.osmocom.org/3381
To unsubscribe, visit https://gerrit.osmocom.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I35d3360f36c48eb1295610ab96ff264c45af77eb
Gerrit-PatchSet: 6
Gerrit-Project: libosmocore
Gerrit-Branch: master
Gerrit-Owner: Vadim Yanitskiy 
Gerrit-Reviewer: Alexander Chemeris 
Gerrit-Reviewer: Harald Welte 
Gerrit-Reviewer: Ivan Kluchnikov 
Gerrit-Reviewer: Jenkins Builder
Gerrit-HasComments: No

[PATCH] libosmocore[master]: gsm0480: expose the gsm0480_parse_ss_facility_ie()

2018-01-10 Thread Vadim Yanitskiy 
Hello Alexander Chemeris, Harald Welte, Jenkins Builder,

I'd like you to reexamine a change.  Please visit

https://gerrit.osmocom.org/3381

to look at the new patch set (#6).

gsm0480: expose the gsm0480_parse_ss_facility_ie()

Change-Id: I35d3360f36c48eb1295610ab96ff264c45af77eb
---
M include/osmocom/gsm/gsm0480.h
M src/gsm/gsm0480.c
M src/gsm/libosmogsm.map
3 files changed, 8 insertions(+), 6 deletions(-)


  git pull ssh://gerrit.osmocom.org:29418/libosmocore refs/changes/81/3381/6

diff --git a/include/osmocom/gsm/gsm0480.h b/include/osmocom/gsm/gsm0480.h
index 7811c9e..4e0d99f 100644
--- a/include/osmocom/gsm/gsm0480.h
+++ b/include/osmocom/gsm/gsm0480.h
@@ -50,6 +50,8 @@
 
 int gsm0480_decode_ss_request(const struct gsm48_hdr *hdr, uint16_t len,
struct gsm0480_ss_request *request);
+int gsm0480_parse_ss_facility_ie(const uint8_t *facility_ie, uint16_t length,
+struct gsm0480_ss_request *req);
 
 struct msgb *gsm0480_create_ussd_resp(uint8_t invoke_id, uint8_t trans_id, 
const char *text);
 struct msgb *gsm0480_create_unstructuredSS_Notify(int alertPattern, const char 
*text);
diff --git a/src/gsm/gsm0480.c b/src/gsm/gsm0480.c
index a35ff4a..ae82f46 100644
--- a/src/gsm/gsm0480.c
+++ b/src/gsm/gsm0480.c
@@ -200,8 +200,6 @@
 struct gsm0480_ss_request *req);
 static int parse_ss_info_elements(const uint8_t *ussd_ie, uint16_t len,
  struct gsm0480_ss_request *req);
-static int parse_facility_ie(const uint8_t *facility_ie, uint16_t length,
-struct gsm0480_ss_request *req);
 static int parse_ss_invoke(const uint8_t *invoke_data, uint16_t length,
struct gsm0480_ss_request *req);
 static int parse_ss_return_result(const uint8_t *rr_data, uint16_t length,
@@ -311,7 +309,8 @@
if (len - 1 < facility_length)
return 0;
 
-   return parse_facility_ie(ss_facility + 1, facility_length, req);
+   return gsm0480_parse_ss_facility_ie(ss_facility + 1,
+   facility_length, req);
 }
 
 static int parse_ss_info_elements(const uint8_t *ss_ie, uint16_t len,
@@ -333,7 +332,7 @@
case GSM48_IE_CAUSE:
break;
case GSM0480_IE_FACILITY:
-   rc = parse_facility_ie(ss_ie + 2, iei_length, req);
+   rc = gsm0480_parse_ss_facility_ie(ss_ie + 2, iei_length, req);
break;
case GSM0480_IE_SS_VERSION:
break;
@@ -347,8 +346,8 @@
return rc;
 }
 
-static int parse_facility_ie(const uint8_t *facility_ie, uint16_t length,
-struct gsm0480_ss_request *req)
+int gsm0480_parse_ss_facility_ie(const uint8_t *facility_ie, uint16_t length,
+struct gsm0480_ss_request *req)
 {
int rc = 1;
uint8_t offset = 0;
diff --git a/src/gsm/libosmogsm.map b/src/gsm/libosmogsm.map
index 5611ba3..f316cad 100644
--- a/src/gsm/libosmogsm.map
+++ b/src/gsm/libosmogsm.map
@@ -90,6 +90,7 @@
 gsm0480_create_ussd_release_complete;
 gsm0480_decode_ussd_request;
 gsm0480_decode_ss_request;
+gsm0480_parse_ss_facility_ie;
 gsm0480_wrap_facility;
 gsm0480_wrap_invoke;
 

-- 
To view, visit https://gerrit.osmocom.org/3381
To unsubscribe, visit https://gerrit.osmocom.org/settings

Gerrit-MessageType: newpatchset
Gerrit-Change-Id: I35d3360f36c48eb1295610ab96ff264c45af77eb
Gerrit-PatchSet: 6
Gerrit-Project: libosmocore
Gerrit-Branch: master
Gerrit-Owner: Vadim Yanitskiy 
Gerrit-Reviewer: Alexander Chemeris 
Gerrit-Reviewer: Harald Welte 
Gerrit-Reviewer: Ivan Kluchnikov 
Gerrit-Reviewer: Jenkins Builder

[PATCH] libosmocore[master]: gsm0480: expose the gsm0480_parse_ss_facility_ie()

2018-01-10 Thread Vadim Yanitskiy 
Hello Alexander Chemeris, Harald Welte, Jenkins Builder,

I'd like you to reexamine a change.  Please visit

https://gerrit.osmocom.org/3381

to look at the new patch set (#5).

gsm0480: expose the gsm0480_parse_ss_facility_ie()

Change-Id: I35d3360f36c48eb1295610ab96ff264c45af77eb
---
M include/osmocom/gsm/gsm0480.h
M src/gsm/gsm0480.c
M src/gsm/libosmogsm.map
3 files changed, 8 insertions(+), 6 deletions(-)


  git pull ssh://gerrit.osmocom.org:29418/libosmocore refs/changes/81/3381/5

diff --git a/include/osmocom/gsm/gsm0480.h b/include/osmocom/gsm/gsm0480.h
index 7811c9e..4e0d99f 100644
--- a/include/osmocom/gsm/gsm0480.h
+++ b/include/osmocom/gsm/gsm0480.h
@@ -50,6 +50,8 @@
 
 int gsm0480_decode_ss_request(const struct gsm48_hdr *hdr, uint16_t len,
struct gsm0480_ss_request *request);
+int gsm0480_parse_ss_facility_ie(const uint8_t *facility_ie, uint16_t length,
+struct gsm0480_ss_request *req);
 
 struct msgb *gsm0480_create_ussd_resp(uint8_t invoke_id, uint8_t trans_id, 
const char *text);
 struct msgb *gsm0480_create_unstructuredSS_Notify(int alertPattern, const char 
*text);
diff --git a/src/gsm/gsm0480.c b/src/gsm/gsm0480.c
index a35ff4a..ae82f46 100644
--- a/src/gsm/gsm0480.c
+++ b/src/gsm/gsm0480.c
@@ -200,8 +200,6 @@
 struct gsm0480_ss_request *req);
 static int parse_ss_info_elements(const uint8_t *ussd_ie, uint16_t len,
  struct gsm0480_ss_request *req);
-static int parse_facility_ie(const uint8_t *facility_ie, uint16_t length,
-struct gsm0480_ss_request *req);
 static int parse_ss_invoke(const uint8_t *invoke_data, uint16_t length,
struct gsm0480_ss_request *req);
 static int parse_ss_return_result(const uint8_t *rr_data, uint16_t length,
@@ -311,7 +309,8 @@
if (len - 1 < facility_length)
return 0;
 
-   return parse_facility_ie(ss_facility + 1, facility_length, req);
+   return gsm0480_parse_ss_facility_ie(ss_facility + 1,
+   facility_length, req);
 }
 
 static int parse_ss_info_elements(const uint8_t *ss_ie, uint16_t len,
@@ -333,7 +332,7 @@
case GSM48_IE_CAUSE:
break;
case GSM0480_IE_FACILITY:
-   rc = parse_facility_ie(ss_ie + 2, iei_length, req);
+   rc = gsm0480_parse_ss_facility_ie(ss_ie + 2, iei_length, req);
break;
case GSM0480_IE_SS_VERSION:
break;
@@ -347,8 +346,8 @@
return rc;
 }
 
-static int parse_facility_ie(const uint8_t *facility_ie, uint16_t length,
-struct gsm0480_ss_request *req)
+int gsm0480_parse_ss_facility_ie(const uint8_t *facility_ie, uint16_t length,
+struct gsm0480_ss_request *req)
 {
int rc = 1;
uint8_t offset = 0;
diff --git a/src/gsm/libosmogsm.map b/src/gsm/libosmogsm.map
index 5611ba3..f316cad 100644
--- a/src/gsm/libosmogsm.map
+++ b/src/gsm/libosmogsm.map
@@ -90,6 +90,7 @@
 gsm0480_create_ussd_release_complete;
 gsm0480_decode_ussd_request;
 gsm0480_decode_ss_request;
+gsm0480_parse_ss_facility_ie;
 gsm0480_wrap_facility;
 gsm0480_wrap_invoke;
 

-- 
To view, visit https://gerrit.osmocom.org/3381
To unsubscribe, visit https://gerrit.osmocom.org/settings

Gerrit-MessageType: newpatchset
Gerrit-Change-Id: I35d3360f36c48eb1295610ab96ff264c45af77eb
Gerrit-PatchSet: 5
Gerrit-Project: libosmocore
Gerrit-Branch: master
Gerrit-Owner: Vadim Yanitskiy 
Gerrit-Reviewer: Alexander Chemeris 
Gerrit-Reviewer: Harald Welte 
Gerrit-Reviewer: Ivan Kluchnikov 
Gerrit-Reviewer: Jenkins Builder

[PATCH] libosmocore[master]: gsm0480: expose the gsm0480_parse_ss_facility_ie()

2018-01-09 Thread Vadim Yanitskiy 
Hello Alexander Chemeris, Harald Welte, Jenkins Builder,

I'd like you to reexamine a change.  Please visit

https://gerrit.osmocom.org/3381

to look at the new patch set (#4).

gsm0480: expose the gsm0480_parse_ss_facility_ie()

Change-Id: I35d3360f36c48eb1295610ab96ff264c45af77eb
---
M include/osmocom/gsm/gsm0480.h
M src/gsm/gsm0480.c
M src/gsm/libosmogsm.map
3 files changed, 8 insertions(+), 6 deletions(-)


  git pull ssh://gerrit.osmocom.org:29418/libosmocore refs/changes/81/3381/4

diff --git a/include/osmocom/gsm/gsm0480.h b/include/osmocom/gsm/gsm0480.h
index 7811c9e..4e0d99f 100644
--- a/include/osmocom/gsm/gsm0480.h
+++ b/include/osmocom/gsm/gsm0480.h
@@ -50,6 +50,8 @@
 
 int gsm0480_decode_ss_request(const struct gsm48_hdr *hdr, uint16_t len,
struct gsm0480_ss_request *request);
+int gsm0480_parse_ss_facility_ie(const uint8_t *facility_ie, uint16_t length,
+struct gsm0480_ss_request *req);
 
 struct msgb *gsm0480_create_ussd_resp(uint8_t invoke_id, uint8_t trans_id, 
const char *text);
 struct msgb *gsm0480_create_unstructuredSS_Notify(int alertPattern, const char 
*text);
diff --git a/src/gsm/gsm0480.c b/src/gsm/gsm0480.c
index a35ff4a..ae82f46 100644
--- a/src/gsm/gsm0480.c
+++ b/src/gsm/gsm0480.c
@@ -200,8 +200,6 @@
 struct gsm0480_ss_request *req);
 static int parse_ss_info_elements(const uint8_t *ussd_ie, uint16_t len,
  struct gsm0480_ss_request *req);
-static int parse_facility_ie(const uint8_t *facility_ie, uint16_t length,
-struct gsm0480_ss_request *req);
 static int parse_ss_invoke(const uint8_t *invoke_data, uint16_t length,
struct gsm0480_ss_request *req);
 static int parse_ss_return_result(const uint8_t *rr_data, uint16_t length,
@@ -311,7 +309,8 @@
if (len - 1 < facility_length)
return 0;
 
-   return parse_facility_ie(ss_facility + 1, facility_length, req);
+   return gsm0480_parse_ss_facility_ie(ss_facility + 1,
+   facility_length, req);
 }
 
 static int parse_ss_info_elements(const uint8_t *ss_ie, uint16_t len,
@@ -333,7 +332,7 @@
case GSM48_IE_CAUSE:
break;
case GSM0480_IE_FACILITY:
-   rc = parse_facility_ie(ss_ie + 2, iei_length, req);
+   rc = gsm0480_parse_ss_facility_ie(ss_ie + 2, iei_length, req);
break;
case GSM0480_IE_SS_VERSION:
break;
@@ -347,8 +346,8 @@
return rc;
 }
 
-static int parse_facility_ie(const uint8_t *facility_ie, uint16_t length,
-struct gsm0480_ss_request *req)
+int gsm0480_parse_ss_facility_ie(const uint8_t *facility_ie, uint16_t length,
+struct gsm0480_ss_request *req)
 {
int rc = 1;
uint8_t offset = 0;
diff --git a/src/gsm/libosmogsm.map b/src/gsm/libosmogsm.map
index 5611ba3..f316cad 100644
--- a/src/gsm/libosmogsm.map
+++ b/src/gsm/libosmogsm.map
@@ -90,6 +90,7 @@
 gsm0480_create_ussd_release_complete;
 gsm0480_decode_ussd_request;
 gsm0480_decode_ss_request;
+gsm0480_parse_ss_facility_ie;
 gsm0480_wrap_facility;
 gsm0480_wrap_invoke;
 

-- 
To view, visit https://gerrit.osmocom.org/3381
To unsubscribe, visit https://gerrit.osmocom.org/settings

Gerrit-MessageType: newpatchset
Gerrit-Change-Id: I35d3360f36c48eb1295610ab96ff264c45af77eb
Gerrit-PatchSet: 4
Gerrit-Project: libosmocore
Gerrit-Branch: master
Gerrit-Owner: Vadim Yanitskiy 
Gerrit-Reviewer: Alexander Chemeris 
Gerrit-Reviewer: Harald Welte 
Gerrit-Reviewer: Ivan Kluchnikov 
Gerrit-Reviewer: Jenkins Builder

libosmocore[master]: gsm0480: expose the gsm0480_parse_ss_facility_ie()

2017-08-09 Thread Harald Welte 

Patch Set 3: Code-Review+2

-- 
To view, visit https://gerrit.osmocom.org/3381
To unsubscribe, visit https://gerrit.osmocom.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I35d3360f36c48eb1295610ab96ff264c45af77eb
Gerrit-PatchSet: 3
Gerrit-Project: libosmocore
Gerrit-Branch: master
Gerrit-Owner: Vadim Yanitskiy 
Gerrit-Reviewer: Alexander Chemeris 
Gerrit-Reviewer: Harald Welte 
Gerrit-Reviewer: Ivan Kluchnikov 
Gerrit-Reviewer: Jenkins Builder
Gerrit-HasComments: No

libosmocore[master]: gsm0480: expose the gsm0480_parse_ss_facility_ie()

2017-07-30 Thread Alexander Chemeris 

Patch Set 3: Code-Review+1

-- 
To view, visit https://gerrit.osmocom.org/3381
To unsubscribe, visit https://gerrit.osmocom.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I35d3360f36c48eb1295610ab96ff264c45af77eb
Gerrit-PatchSet: 3
Gerrit-Project: libosmocore
Gerrit-Branch: master
Gerrit-Owner: Vadim Yanitskiy 
Gerrit-Reviewer: Alexander Chemeris 
Gerrit-Reviewer: Ivan Kluchnikov 
Gerrit-Reviewer: Jenkins Builder
Gerrit-HasComments: No

[PATCH] libosmocore[master]: gsm0480: expose the gsm0480_parse_ss_facility_ie()

2017-07-29 Thread Vadim Yanitskiy 

gsm0480: expose the gsm0480_parse_ss_facility_ie()

Change-Id: I35d3360f36c48eb1295610ab96ff264c45af77eb
---
M include/osmocom/gsm/gsm0480.h
M src/gsm/gsm0480.c
M src/gsm/libosmogsm.map
3 files changed, 8 insertions(+), 6 deletions(-)


  git pull ssh://gerrit.osmocom.org:29418/libosmocore refs/changes/81/3381/2

diff --git a/include/osmocom/gsm/gsm0480.h b/include/osmocom/gsm/gsm0480.h
index e3b15d2..e3d40a9 100644
--- a/include/osmocom/gsm/gsm0480.h
+++ b/include/osmocom/gsm/gsm0480.h
@@ -50,6 +50,8 @@
 
 int gsm0480_decode_ss_request(const struct gsm48_hdr *hdr, uint16_t len,
struct ss_request *request);
+int gsm0480_parse_ss_facility_ie(const uint8_t *facility_ie, uint16_t length,
+struct ss_request *req);
 
 struct msgb *gsm0480_create_ussd_resp(uint8_t invoke_id, uint8_t trans_id, 
const char *text);
 struct msgb *gsm0480_create_unstructuredSS_Notify(int alertPattern, const char 
*text);
diff --git a/src/gsm/gsm0480.c b/src/gsm/gsm0480.c
index 6731cec..9705359 100644
--- a/src/gsm/gsm0480.c
+++ b/src/gsm/gsm0480.c
@@ -198,8 +198,6 @@
 struct ss_request *req);
 static int parse_ss_info_elements(const uint8_t *ussd_ie, uint16_t len,
  struct ss_request *req);
-static int parse_facility_ie(const uint8_t *facility_ie, uint16_t length,
-struct ss_request *req);
 static int parse_ss_invoke(const uint8_t *invoke_data, uint16_t length,
struct ss_request *req);
 static int parse_ss_return_result(const uint8_t *rr_data, uint16_t length,
@@ -302,7 +300,8 @@
if (len - 1 < facility_length)
return 0;
 
-   return parse_facility_ie(ss_facility + 1, facility_length, req);
+   return gsm0480_parse_ss_facility_ie(ss_facility + 1,
+   facility_length, req);
 }
 
 static int parse_ss_info_elements(const uint8_t *ss_ie, uint16_t len,
@@ -324,7 +323,7 @@
case GSM48_IE_CAUSE:
break;
case GSM0480_IE_FACILITY:
-   rc = parse_facility_ie(ss_ie + 2, iei_length, req);
+   rc = gsm0480_parse_ss_facility_ie(ss_ie + 2, iei_length, req);
break;
case GSM0480_IE_SS_VERSION:
break;
@@ -338,8 +337,8 @@
return rc;
 }
 
-static int parse_facility_ie(const uint8_t *facility_ie, uint16_t length,
-struct ss_request *req)
+int gsm0480_parse_ss_facility_ie(const uint8_t *facility_ie, uint16_t length,
+struct ss_request *req)
 {
int rc = 1;
uint8_t offset = 0;
diff --git a/src/gsm/libosmogsm.map b/src/gsm/libosmogsm.map
index 714cb25..b9d30bb 100644
--- a/src/gsm/libosmogsm.map
+++ b/src/gsm/libosmogsm.map
@@ -83,6 +83,7 @@
 gsm0480_create_ussd_release_complete;
 gsm0480_decode_ussd_request;
 gsm0480_decode_ss_request;
+gsm0480_parse_ss_facility_ie;
 gsm0480_wrap_facility;
 gsm0480_wrap_invoke;
 

-- 
To view, visit https://gerrit.osmocom.org/3381
To unsubscribe, visit https://gerrit.osmocom.org/settings

Gerrit-MessageType: newpatchset
Gerrit-Change-Id: I35d3360f36c48eb1295610ab96ff264c45af77eb
Gerrit-PatchSet: 2
Gerrit-Project: libosmocore
Gerrit-Branch: master
Gerrit-Owner: Vadim Yanitskiy

[PATCH] libosmocore[master]: gsm0480: expose the gsm0480_parse_ss_facility_ie()

2017-07-29 Thread Vadim Yanitskiy 

Review at  https://gerrit.osmocom.org/3381

gsm0480: expose the gsm0480_parse_ss_facility_ie()

Change-Id: I35d3360f36c48eb1295610ab96ff264c45af77eb
---
M include/osmocom/gsm/gsm0480.h
M src/gsm/gsm0480.c
M src/gsm/libosmogsm.map
3 files changed, 8 insertions(+), 6 deletions(-)


  git pull ssh://gerrit.osmocom.org:29418/libosmocore refs/changes/81/3381/1

diff --git a/include/osmocom/gsm/gsm0480.h b/include/osmocom/gsm/gsm0480.h
index e3b15d2..e3d40a9 100644
--- a/include/osmocom/gsm/gsm0480.h
+++ b/include/osmocom/gsm/gsm0480.h
@@ -50,6 +50,8 @@
 
 int gsm0480_decode_ss_request(const struct gsm48_hdr *hdr, uint16_t len,
struct ss_request *request);
+int gsm0480_parse_ss_facility_ie(const uint8_t *facility_ie, uint16_t length,
+struct ss_request *req);
 
 struct msgb *gsm0480_create_ussd_resp(uint8_t invoke_id, uint8_t trans_id, 
const char *text);
 struct msgb *gsm0480_create_unstructuredSS_Notify(int alertPattern, const char 
*text);
diff --git a/src/gsm/gsm0480.c b/src/gsm/gsm0480.c
index 6731cec..9705359 100644
--- a/src/gsm/gsm0480.c
+++ b/src/gsm/gsm0480.c
@@ -198,8 +198,6 @@
 struct ss_request *req);
 static int parse_ss_info_elements(const uint8_t *ussd_ie, uint16_t len,
  struct ss_request *req);
-static int parse_facility_ie(const uint8_t *facility_ie, uint16_t length,
-struct ss_request *req);
 static int parse_ss_invoke(const uint8_t *invoke_data, uint16_t length,
struct ss_request *req);
 static int parse_ss_return_result(const uint8_t *rr_data, uint16_t length,
@@ -302,7 +300,8 @@
if (len - 1 < facility_length)
return 0;
 
-   return parse_facility_ie(ss_facility + 1, facility_length, req);
+   return gsm0480_parse_ss_facility_ie(ss_facility + 1,
+   facility_length, req);
 }
 
 static int parse_ss_info_elements(const uint8_t *ss_ie, uint16_t len,
@@ -324,7 +323,7 @@
case GSM48_IE_CAUSE:
break;
case GSM0480_IE_FACILITY:
-   rc = parse_facility_ie(ss_ie + 2, iei_length, req);
+   rc = gsm0480_parse_ss_facility_ie(ss_ie + 2, iei_length, req);
break;
case GSM0480_IE_SS_VERSION:
break;
@@ -338,8 +337,8 @@
return rc;
 }
 
-static int parse_facility_ie(const uint8_t *facility_ie, uint16_t length,
-struct ss_request *req)
+int gsm0480_parse_ss_facility_ie(const uint8_t *facility_ie, uint16_t length,
+struct ss_request *req)
 {
int rc = 1;
uint8_t offset = 0;
diff --git a/src/gsm/libosmogsm.map b/src/gsm/libosmogsm.map
index 714cb25..b9d30bb 100644
--- a/src/gsm/libosmogsm.map
+++ b/src/gsm/libosmogsm.map
@@ -83,6 +83,7 @@
 gsm0480_create_ussd_release_complete;
 gsm0480_decode_ussd_request;
 gsm0480_decode_ss_request;
+gsm0480_parse_ss_facility_ie;
 gsm0480_wrap_facility;
 gsm0480_wrap_invoke;
 

-- 
To view, visit https://gerrit.osmocom.org/3381
To unsubscribe, visit https://gerrit.osmocom.org/settings

Gerrit-MessageType: newchange
Gerrit-Change-Id: I35d3360f36c48eb1295610ab96ff264c45af77eb
Gerrit-PatchSet: 1
Gerrit-Project: libosmocore
Gerrit-Branch: master
Gerrit-Owner: Vadim Yanitskiy