Patch Set 3: Code-Review+2
--
To view, visit https://gerrit.osmocom.org/3470
To unsubscribe, visit https://gerrit.osmocom.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I53a65164a6cc4abc6bf57d9a8dc275cf21c90222
Gerrit-PatchSet: 3
Gerrit-Project: openbsc
Gerrit-Branch: master
Harald Welte has submitted this change and it was merged.
Change subject: libmsc: use smpp34_tlv_for_each() to avoid suboptimal TLV
handling
..
libmsc: use smpp34_tlv_for_each() to avoid suboptimal TLV handling
Hello Jenkins Builder,
I'd like you to reexamine a change. Please visit
https://gerrit.osmocom.org/3470
to look at the new patch set (#3).
libmsc: use smpp34_tlv_for_each() to avoid suboptimal TLV handling
submit_to_sms() now handles two TLVs, so find_tlv() is suboptiomal and
it can be
Patch Set 2:
I never looked at that library so far, and I cannot give +2 on it anyway, sorry
for that.
Regarding your "retrigger by pushing again", I give you a tip for that: You can
re-trigger the jenkins job which was launched by Gerrit and it if succeeds, it
will automatically give
Patch Set 2:
Oh, I forgot.
You can probably speed up the process if you give me +X to my libsmpp34 patches
(if you're familiar with that code).
Thanks!
--
To view, visit https://gerrit.osmocom.org/3470
To unsubscribe, visit https://gerrit.osmocom.org/settings
Gerrit-MessageType: comment
Patch Set 2:
OK, will include this info once patches for libsmpp34 get in. So this also
helps re-kick Jenkins building.
--
To view, visit https://gerrit.osmocom.org/3470
To unsubscribe, visit https://gerrit.osmocom.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id:
Patch Set 2:
You could provide info about the dependency in the form "Requires libsmpp34
Change-Id XYZ" in the commit message, or at least here as a comment. This way
is easier to track what needs to be merged, or which version of the library is
used.
--
To view, visit
Patch Set 2:
Build breaks because this patch depends on a patch in libsmpp34.
--
To view, visit https://gerrit.osmocom.org/3470
To unsubscribe, visit https://gerrit.osmocom.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I53a65164a6cc4abc6bf57d9a8dc275cf21c90222
Gerrit-PatchSet: 2
libmsc: use smpp34_tlv_for_each() to avoid suboptimal TLV handling
submit_to_sms() now handles two TLVs, so find_tlv() is suboptiomal and
it can be removed, since it would result in two passes on the TLV list.
Use new smpp34_tlv_for_each() helper to iterate over the list of TLVs.
Change-Id:
Review at https://gerrit.osmocom.org/3470
libmsc: use smpp34_tlv_for_each() to avoid suboptimal TLV handling
submit_to_sms() now handles two TLVs, so find_tlv() is suboptiomal and
it can be removed, since it would result in two passes on the TLV list.
Use new smpp34_tlv_for_each() helper to
10 matches
Mail list logo
