[MERGED] osmo-msc[master]: Accept SMS for any receiver

2018-01-25 Thread Harald Welte
Harald Welte has submitted this change and it was merged. Change subject: Accept SMS for any receiver .. Accept SMS for any receiver Accept any SMS and store it in the database, even if the receiver of the message cannot be

osmo-msc[master]: Accept SMS for any receiver

2018-01-25 Thread Pau Espin Pedrol
Patch Set 1: Code-Review+1 -- To view, visit https://gerrit.osmocom.org/5997 To unsubscribe, visit https://gerrit.osmocom.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I833c3abd290d2bc5fceec7457e3933c9600e6c24 Gerrit-PatchSet: 1 Gerrit-Project: osmo-msc Gerrit-Branch: master

osmo-msc[master]: Accept SMS for any receiver

2018-01-25 Thread Stefan Sperling
Patch Set 1: > This seems fine as a quick fix for now,but I'd guess in the long > term we should asynchronously start a procedure to check if the > subscriber exists and then send a response back to the MS. If we > agree that's the best way we can perhaps create a task to not > forget about

osmo-msc[master]: Accept SMS for any receiver

2018-01-25 Thread Pau Espin Pedrol
Patch Set 1: This seems fine as a quick fix for now,but I'd guess in the long term we should asynchronously start a procedure to check if the subscriber exists and then send a response back to the MS. If we agree that's the best way we can perhaps create a task to not forget about it? -- To

osmo-msc[master]: Accept SMS for any receiver

2018-01-25 Thread Stefan Sperling
Patch Set 1: > Shouldn't we be checking if we can find the subscriber in the > VLR/HLR instead of blindly accepting? The VLR/HLR might not be reachable, and we need to immediately ack or reject the SMS. Harald suggested that it's easier to simply accept any message and deal with non-existing

osmo-msc[master]: Accept SMS for any receiver

2018-01-25 Thread Stefan Sperling
Patch Set 1: This cannot be merged yet because it depends on https://gerrit.osmocom.org/#/c/5989/ -- To view, visit https://gerrit.osmocom.org/5997 To unsubscribe, visit https://gerrit.osmocom.org/settings Gerrit-MessageType: comment Gerrit-Change-Id:

osmo-msc[master]: Accept SMS for any receiver

2018-01-23 Thread Pau Espin Pedrol
Patch Set 1: Shouldn't we be checking if we can find the subscriber in the VLR/HLR instead of blindly accepting? -- To view, visit https://gerrit.osmocom.org/5997 To unsubscribe, visit https://gerrit.osmocom.org/settings Gerrit-MessageType: comment Gerrit-Change-Id:

osmo-msc[master]: Accept SMS for any receiver

2018-01-22 Thread Harald Welte
Patch Set 1: Code-Review+2 -- To view, visit https://gerrit.osmocom.org/5997 To unsubscribe, visit https://gerrit.osmocom.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I833c3abd290d2bc5fceec7457e3933c9600e6c24 Gerrit-PatchSet: 1 Gerrit-Project: osmo-msc Gerrit-Branch: master

[PATCH] osmo-msc[master]: Accept SMS for any receiver

2018-01-22 Thread Stefan Sperling
Review at https://gerrit.osmocom.org/5997 Accept SMS for any receiver Accept any SMS and store it in the database, even if the receiver of the message cannot be determined when the message arrives at the MSC. This fixes https://osmocom.org/issues/2354 ("SMSC: Store not working for subscribed