Alexander Chemeris has submitted this change and it was merged. Change subject: pySim-prog: Replace magic numbers with a readable EF file name. ......................................................................
pySim-prog: Replace magic numbers with a readable EF file name. Change-Id: Ibda7d5a4132971e884f6d760baf20cd33025a2af --- M pySim-prog.py 1 file changed, 1 insertion(+), 1 deletion(-) Approvals: Vadim Yanitskiy: Looks good to me, but someone else must approve Alexander Chemeris: Verified Harald Welte: Looks good to me, approved diff --git a/pySim-prog.py b/pySim-prog.py index 2177d8c..44ca1fd 100755 --- a/pySim-prog.py +++ b/pySim-prog.py @@ -618,7 +618,7 @@ # Connect transport print "Insert card now (or CTRL-C to cancel)" sl.wait_for_card(newcardonly=not first) - (res,_) = scc.read_binary(['3f00', '7f20', '6f07']) + (res,_) = scc.read_binary(EF['IMSI']) imsi = swap_nibbles(res)[3:] else: imsi = opts.imsi -- To view, visit https://gerrit.osmocom.org/5720 To unsubscribe, visit https://gerrit.osmocom.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Ibda7d5a4132971e884f6d760baf20cd33025a2af Gerrit-PatchSet: 2 Gerrit-Project: pysim Gerrit-Branch: master Gerrit-Owner: Alexander Chemeris <alexander.cheme...@gmail.com> Gerrit-Reviewer: Alexander Chemeris <alexander.cheme...@gmail.com> Gerrit-Reviewer: Harald Welte <lafo...@gnumonks.org> Gerrit-Reviewer: Vadim Yanitskiy <axilira...@gmail.com>