Review at  https://gerrit.osmocom.org/7711

MNCC: don't delete call table entries

If we receive an MNCC_REL_ind, we still may want to reply with an MNCC_REL_cnf.
If the REL_ind, however, already drops the call table entry, all I get is:
"MNCC Call table not found by MNCC Call ID <id>"

The call table should be cleared on each f_mncc_init(), so I guess it's fine to
just not delete entries during ongoing communication.

Change-Id: I73ec066744475d3cc464e34854175f8cf14cf125
---
M library/MNCC_Emulation.ttcn
1 file changed, 0 insertions(+), 4 deletions(-)


  git pull ssh://gerrit.osmocom.org:29418/osmo-ttcn3-hacks 
refs/changes/11/7711/1

diff --git a/library/MNCC_Emulation.ttcn b/library/MNCC_Emulation.ttcn
index 59e3e77..2b83e70 100644
--- a/library/MNCC_Emulation.ttcn
+++ b/library/MNCC_Emulation.ttcn
@@ -299,8 +299,6 @@
                        /* forward to respective client */
                        vc_conn := f_comp_by_call_id(call_id);
                        MNCC_CLIENT.send(sd.data) to vc_conn;
-                       /* remove from call table */
-                       f_call_table_del(call_id);
                        }
 
                /* MNCC -> Client: call related messages */
@@ -325,8 +323,6 @@
                        var integer call_id := f_call_id_by_comp(vc_conn);
                        /* forward to MNCC socket */
                        MNCC.send(t_SD_MNCC(g_mncc_ud_id, mncc));
-                       /* remove from call table */
-                       f_call_table_del(call_id);
                        }
 
                /* Client -> MNCC Socket: Normal message */

-- 
To view, visit https://gerrit.osmocom.org/7711
To unsubscribe, visit https://gerrit.osmocom.org/settings

Gerrit-MessageType: newchange
Gerrit-Change-Id: I73ec066744475d3cc464e34854175f8cf14cf125
Gerrit-PatchSet: 1
Gerrit-Project: osmo-ttcn3-hacks
Gerrit-Branch: master
Gerrit-Owner: Neels Hofmeyr <nhofm...@sysmocom.de>

Reply via email to