[S] Change in osmo-ttcn3-hacks[master]: hnbgw: TC_hnb_register_duplicate: Fix 2nd HNB_REG_REQ containing diff...

2024-04-16 Thread pespin 
pespin has submitted this change. ( 
https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/36572?usp=email )

Change subject: hnbgw: TC_hnb_register_duplicate: Fix 2nd HNB_REG_REQ 
containing different LAC
..

hnbgw: TC_hnb_register_duplicate: Fix 2nd HNB_REG_REQ containing different LAC

Change-Id: I7f5d8d8403211488966fc30bf4d82e894664df51
---
M hnbgw/HNBGW_Tests.ttcn
1 file changed, 15 insertions(+), 0 deletions(-)

Approvals:
  Jenkins Builder: Verified
  fixeria: Looks good to me, approved
  laforge: Looks good to me, but someone else must approve




diff --git a/hnbgw/HNBGW_Tests.ttcn b/hnbgw/HNBGW_Tests.ttcn
index e28fecc..3369e37 100644
--- a/hnbgw/HNBGW_Tests.ttcn
+++ b/hnbgw/HNBGW_Tests.ttcn
@@ -980,9 +980,15 @@
 testcase TC_hnb_register_duplicate() runs on test_CT {
g_num_hnbs := 2;
f_init(start_hnb := false);
+
+   /* Make HNB REQ look as if it came from the same HnodeB (LAI+SAC),
+* but from different IP address (underlaying link): */
+   g_hnb_cfg[1] := g_hnb_cfg[0];
f_hnbap_hnb_register(0);
f_hnbap_hnb_register(1, 0, expect_reject := true);
+
f_verify_talloc_count(HNBGWVTY, {"struct hnb_context"}, expect_count := 
1);
+
f_shutdown_helper();
 }


-- 
To view, visit https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/36572?usp=email
To unsubscribe, or for help writing mail filters, visit 
https://gerrit.osmocom.org/settings

Gerrit-Project: osmo-ttcn3-hacks
Gerrit-Branch: master
Gerrit-Change-Id: I7f5d8d8403211488966fc30bf4d82e894664df51
Gerrit-Change-Number: 36572
Gerrit-PatchSet: 2
Gerrit-Owner: pespin 
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: fixeria 
Gerrit-Reviewer: laforge 
Gerrit-Reviewer: pespin 
Gerrit-MessageType: merged

[S] Change in osmo-ttcn3-hacks[master]: hnbgw: TC_hnb_register_duplicate: Fix 2nd HNB_REG_REQ containing diff...

2024-04-16 Thread fixeria 
Attention is currently required from: pespin.

fixeria has posted comments on this change. ( 
https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/36572?usp=email )

Change subject: hnbgw: TC_hnb_register_duplicate: Fix 2nd HNB_REG_REQ 
containing different LAC
..


Patch Set 2: Code-Review+2


--
To view, visit https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/36572?usp=email
To unsubscribe, or for help writing mail filters, visit 
https://gerrit.osmocom.org/settings

Gerrit-Project: osmo-ttcn3-hacks
Gerrit-Branch: master
Gerrit-Change-Id: I7f5d8d8403211488966fc30bf4d82e894664df51
Gerrit-Change-Number: 36572
Gerrit-PatchSet: 2
Gerrit-Owner: pespin 
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: fixeria 
Gerrit-Reviewer: laforge 
Gerrit-Attention: pespin 
Gerrit-Comment-Date: Tue, 16 Apr 2024 18:56:06 +
Gerrit-HasComments: No
Gerrit-Has-Labels: Yes
Gerrit-MessageType: comment

[S] Change in osmo-ttcn3-hacks[master]: hnbgw: TC_hnb_register_duplicate: Fix 2nd HNB_REG_REQ containing diff...

2024-04-16 Thread laforge 
Attention is currently required from: pespin.

laforge has posted comments on this change. ( 
https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/36572?usp=email )

Change subject: hnbgw: TC_hnb_register_duplicate: Fix 2nd HNB_REG_REQ 
containing different LAC
..


Patch Set 1: Code-Review+1


--
To view, visit https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/36572?usp=email
To unsubscribe, or for help writing mail filters, visit 
https://gerrit.osmocom.org/settings

Gerrit-Project: osmo-ttcn3-hacks
Gerrit-Branch: master
Gerrit-Change-Id: I7f5d8d8403211488966fc30bf4d82e894664df51
Gerrit-Change-Number: 36572
Gerrit-PatchSet: 1
Gerrit-Owner: pespin 
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: laforge 
Gerrit-Attention: pespin 
Gerrit-Comment-Date: Tue, 16 Apr 2024 16:06:43 +
Gerrit-HasComments: No
Gerrit-Has-Labels: Yes
Gerrit-MessageType: comment

[S] Change in osmo-ttcn3-hacks[master]: hnbgw: TC_hnb_register_duplicate: Fix 2nd HNB_REG_REQ containing diff...

2024-04-16 Thread pespin 
pespin has uploaded this change for review. ( 
https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/36572?usp=email )


Change subject: hnbgw: TC_hnb_register_duplicate: Fix 2nd HNB_REG_REQ 
containing different LAC
..

hnbgw: TC_hnb_register_duplicate: Fix 2nd HNB_REG_REQ containing different LAC

Change-Id: I7f5d8d8403211488966fc30bf4d82e894664df51
---
M hnbgw/HNBGW_Tests.ttcn
1 file changed, 15 insertions(+), 0 deletions(-)



  git pull ssh://gerrit.osmocom.org:29418/osmo-ttcn3-hacks 
refs/changes/72/36572/1

diff --git a/hnbgw/HNBGW_Tests.ttcn b/hnbgw/HNBGW_Tests.ttcn
index e28fecc..3369e37 100644
--- a/hnbgw/HNBGW_Tests.ttcn
+++ b/hnbgw/HNBGW_Tests.ttcn
@@ -980,9 +980,15 @@
 testcase TC_hnb_register_duplicate() runs on test_CT {
g_num_hnbs := 2;
f_init(start_hnb := false);
+
+   /* Make HNB REQ look as if it came from the same HnodeB (LAI+SAC),
+* but from different IP address (underlaying link): */
+   g_hnb_cfg[1] := g_hnb_cfg[0];
f_hnbap_hnb_register(0);
f_hnbap_hnb_register(1, 0, expect_reject := true);
+
f_verify_talloc_count(HNBGWVTY, {"struct hnb_context"}, expect_count := 
1);
+
f_shutdown_helper();
 }


--
To view, visit https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/36572?usp=email
To unsubscribe, or for help writing mail filters, visit 
https://gerrit.osmocom.org/settings

Gerrit-Project: osmo-ttcn3-hacks
Gerrit-Branch: master
Gerrit-Change-Id: I7f5d8d8403211488966fc30bf4d82e894664df51
Gerrit-Change-Number: 36572
Gerrit-PatchSet: 1
Gerrit-Owner: pespin 
Gerrit-MessageType: newchange