[S] Change in pysim[master]: runtime: cosmetic: prnounce file reference data
laforge has submitted this change. ( https://gerrit.osmocom.org/c/pysim/+/35250?usp=email ) Change subject: runtime: cosmetic: prnounce file reference data .. runtime: cosmetic: prnounce file reference data One of the most important properties of the RuntimeLchan are the selected_file/adf properties. Let's reformat the code so that those properties are more pronounced. Change-Id: I4aa028f66879b7d6c2a1cd102cda8d8ca5ff48b1 Related: OS#5418 --- M pySim/runtime.py 1 file changed, 17 insertions(+), 1 deletion(-) Approvals: laforge: Looks good to me, approved Jenkins Builder: Verified diff --git a/pySim/runtime.py b/pySim/runtime.py index 670babc..028bef1 100644 --- a/pySim/runtime.py +++ b/pySim/runtime.py @@ -170,11 +170,13 @@ def __init__(self, lchan_nr: int, rs: RuntimeState): self.lchan_nr = lchan_nr self.rs = rs +self.scc = self.rs.card._scc.fork_lchan(lchan_nr) + +# File reference data self.selected_file = self.rs.mf self.selected_adf = None self.selected_file_fcp = None self.selected_file_fcp_hex = None -self.scc = self.rs.card._scc.fork_lchan(lchan_nr) def add_lchan(self, lchan_nr: int) -> 'RuntimeLchan': """Add a new logical channel from the current logical channel. Just affects -- To view, visit https://gerrit.osmocom.org/c/pysim/+/35250?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: pysim Gerrit-Branch: master Gerrit-Change-Id: I4aa028f66879b7d6c2a1cd102cda8d8ca5ff48b1 Gerrit-Change-Number: 35250 Gerrit-PatchSet: 1 Gerrit-Owner: dexter Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: laforge Gerrit-MessageType: merged
[S] Change in pysim[master]: runtime: cosmetic: prnounce file reference data
Attention is currently required from: dexter. laforge has posted comments on this change. ( https://gerrit.osmocom.org/c/pysim/+/35250?usp=email ) Change subject: runtime: cosmetic: prnounce file reference data .. Patch Set 1: Code-Review+2 -- To view, visit https://gerrit.osmocom.org/c/pysim/+/35250?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: pysim Gerrit-Branch: master Gerrit-Change-Id: I4aa028f66879b7d6c2a1cd102cda8d8ca5ff48b1 Gerrit-Change-Number: 35250 Gerrit-PatchSet: 1 Gerrit-Owner: dexter Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: laforge Gerrit-Attention: dexter Gerrit-Comment-Date: Thu, 07 Dec 2023 13:17:38 + Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment
[S] Change in pysim[master]: runtime: cosmetic: prnounce file reference data
dexter has uploaded this change for review. ( https://gerrit.osmocom.org/c/pysim/+/35250?usp=email ) Change subject: runtime: cosmetic: prnounce file reference data .. runtime: cosmetic: prnounce file reference data One of the most important properties of the RuntimeLchan are the selected_file/adf properties. Let's reformat the code so that those properties are more pronounced. Change-Id: I4aa028f66879b7d6c2a1cd102cda8d8ca5ff48b1 Related: OS#5418 --- M pySim/runtime.py 1 file changed, 17 insertions(+), 1 deletion(-) git pull ssh://gerrit.osmocom.org:29418/pysim refs/changes/50/35250/1 diff --git a/pySim/runtime.py b/pySim/runtime.py index 670babc..028bef1 100644 --- a/pySim/runtime.py +++ b/pySim/runtime.py @@ -170,11 +170,13 @@ def __init__(self, lchan_nr: int, rs: RuntimeState): self.lchan_nr = lchan_nr self.rs = rs +self.scc = self.rs.card._scc.fork_lchan(lchan_nr) + +# File reference data self.selected_file = self.rs.mf self.selected_adf = None self.selected_file_fcp = None self.selected_file_fcp_hex = None -self.scc = self.rs.card._scc.fork_lchan(lchan_nr) def add_lchan(self, lchan_nr: int) -> 'RuntimeLchan': """Add a new logical channel from the current logical channel. Just affects -- To view, visit https://gerrit.osmocom.org/c/pysim/+/35250?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: pysim Gerrit-Branch: master Gerrit-Change-Id: I4aa028f66879b7d6c2a1cd102cda8d8ca5ff48b1 Gerrit-Change-Number: 35250 Gerrit-PatchSet: 1 Gerrit-Owner: dexter Gerrit-MessageType: newchange
