Change in osmo-bsc[master]: abis_rsl.c: missing newlines on log lines
Neels Hofmeyr has posted comments on this change. ( https://gerrit.osmocom.org/13889 ) Change subject: abis_rsl.c: missing newlines on log lines .. Patch Set 1: Code-Review+2 triviality +2 -- To view, visit https://gerrit.osmocom.org/13889 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-bsc Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: Ic8885ca75ff23e4813a133f8fe34b7e67a1bc3e3 Gerrit-Change-Number: 13889 Gerrit-PatchSet: 1 Gerrit-Owner: Neels Hofmeyr Gerrit-Reviewer: Jenkins Builder (102) Gerrit-Reviewer: Neels Hofmeyr Gerrit-Comment-Date: Mon, 06 May 2019 23:12:26 + Gerrit-HasComments: No Gerrit-HasLabels: Yes
Change in osmo-bsc[master]: abis_rsl.c: missing newlines on log lines
Neels Hofmeyr has submitted this change and it was merged. (
https://gerrit.osmocom.org/13889 )
Change subject: abis_rsl.c: missing newlines on log lines
..
abis_rsl.c: missing newlines on log lines
Change-Id: Ic8885ca75ff23e4813a133f8fe34b7e67a1bc3e3
---
M src/osmo-bsc/abis_rsl.c
1 file changed, 4 insertions(+), 4 deletions(-)
Approvals:
Jenkins Builder: Verified
Neels Hofmeyr: Looks good to me, approved
diff --git a/src/osmo-bsc/abis_rsl.c b/src/osmo-bsc/abis_rsl.c
index 0117435..bc07457 100644
--- a/src/osmo-bsc/abis_rsl.c
+++ b/src/osmo-bsc/abis_rsl.c
@@ -1899,7 +1899,7 @@
struct gsm_lchan *lchan = msg->lchan;
if (!lchan->fi_rtp) {
- LOG_LCHAN(msg->lchan, LOGL_ERROR, "Rx RSL IPACC: CRCX ACK
message for unconfigured lchan");
+ LOG_LCHAN(msg->lchan, LOGL_ERROR, "Rx RSL IPACC: CRCX ACK
message for unconfigured lchan\n");
return -EINVAL;
}
@@ -1930,7 +1930,7 @@
rate_ctr_inc(_link->trx->bts->bts_ctrs->ctr[BTS_CTR_RSL_IPA_NACK]);
if (!lchan->fi_rtp) {
- LOG_LCHAN(msg->lchan, LOGL_ERROR, "Rx RSL IPACC: CRCX NACK
message for unconfigured lchan");
+ LOG_LCHAN(msg->lchan, LOGL_ERROR, "Rx RSL IPACC: CRCX NACK
message for unconfigured lchan\n");
return -EINVAL;
}
osmo_fsm_inst_dispatch(msg->lchan->fi_rtp,
LCHAN_RTP_EV_IPACC_CRCX_NACK, 0);
@@ -1944,7 +1944,7 @@
struct gsm_lchan *lchan = msg->lchan;
if (!lchan->fi_rtp) {
- LOG_LCHAN(msg->lchan, LOGL_ERROR, "Rx RSL IPACC: MDCX ACK
message for unconfigured lchan");
+ LOG_LCHAN(msg->lchan, LOGL_ERROR, "Rx RSL IPACC: MDCX ACK
message for unconfigured lchan\n");
return -EINVAL;
}
@@ -1968,7 +1968,7 @@
rate_ctr_inc(_link->trx->bts->bts_ctrs->ctr[BTS_CTR_RSL_IPA_NACK]);
if (!lchan->fi_rtp) {
- LOG_LCHAN(msg->lchan, LOGL_ERROR, "Rx RSL IPACC: MDCX NACK
message for unconfigured lchan");
+ LOG_LCHAN(msg->lchan, LOGL_ERROR, "Rx RSL IPACC: MDCX NACK
message for unconfigured lchan\n");
return -EINVAL;
}
osmo_fsm_inst_dispatch(msg->lchan->fi_rtp,
LCHAN_RTP_EV_IPACC_MDCX_NACK, 0);
--
To view, visit https://gerrit.osmocom.org/13889
To unsubscribe, or for help writing mail filters, visit
https://gerrit.osmocom.org/settings
Gerrit-Project: osmo-bsc
Gerrit-Branch: master
Gerrit-MessageType: merged
Gerrit-Change-Id: Ic8885ca75ff23e4813a133f8fe34b7e67a1bc3e3
Gerrit-Change-Number: 13889
Gerrit-PatchSet: 1
Gerrit-Owner: Neels Hofmeyr
Gerrit-Reviewer: Jenkins Builder (102)
Gerrit-Reviewer: Neels Hofmeyr
Change in osmo-bsc[master]: abis_rsl.c: missing newlines on log lines
Neels Hofmeyr has uploaded this change for review. (
https://gerrit.osmocom.org/13889
Change subject: abis_rsl.c: missing newlines on log lines
..
abis_rsl.c: missing newlines on log lines
Change-Id: Ic8885ca75ff23e4813a133f8fe34b7e67a1bc3e3
---
M src/osmo-bsc/abis_rsl.c
1 file changed, 4 insertions(+), 4 deletions(-)
git pull ssh://gerrit.osmocom.org:29418/osmo-bsc refs/changes/89/13889/1
diff --git a/src/osmo-bsc/abis_rsl.c b/src/osmo-bsc/abis_rsl.c
index 0117435..bc07457 100644
--- a/src/osmo-bsc/abis_rsl.c
+++ b/src/osmo-bsc/abis_rsl.c
@@ -1899,7 +1899,7 @@
struct gsm_lchan *lchan = msg->lchan;
if (!lchan->fi_rtp) {
- LOG_LCHAN(msg->lchan, LOGL_ERROR, "Rx RSL IPACC: CRCX ACK
message for unconfigured lchan");
+ LOG_LCHAN(msg->lchan, LOGL_ERROR, "Rx RSL IPACC: CRCX ACK
message for unconfigured lchan\n");
return -EINVAL;
}
@@ -1930,7 +1930,7 @@
rate_ctr_inc(_link->trx->bts->bts_ctrs->ctr[BTS_CTR_RSL_IPA_NACK]);
if (!lchan->fi_rtp) {
- LOG_LCHAN(msg->lchan, LOGL_ERROR, "Rx RSL IPACC: CRCX NACK
message for unconfigured lchan");
+ LOG_LCHAN(msg->lchan, LOGL_ERROR, "Rx RSL IPACC: CRCX NACK
message for unconfigured lchan\n");
return -EINVAL;
}
osmo_fsm_inst_dispatch(msg->lchan->fi_rtp,
LCHAN_RTP_EV_IPACC_CRCX_NACK, 0);
@@ -1944,7 +1944,7 @@
struct gsm_lchan *lchan = msg->lchan;
if (!lchan->fi_rtp) {
- LOG_LCHAN(msg->lchan, LOGL_ERROR, "Rx RSL IPACC: MDCX ACK
message for unconfigured lchan");
+ LOG_LCHAN(msg->lchan, LOGL_ERROR, "Rx RSL IPACC: MDCX ACK
message for unconfigured lchan\n");
return -EINVAL;
}
@@ -1968,7 +1968,7 @@
rate_ctr_inc(_link->trx->bts->bts_ctrs->ctr[BTS_CTR_RSL_IPA_NACK]);
if (!lchan->fi_rtp) {
- LOG_LCHAN(msg->lchan, LOGL_ERROR, "Rx RSL IPACC: MDCX NACK
message for unconfigured lchan");
+ LOG_LCHAN(msg->lchan, LOGL_ERROR, "Rx RSL IPACC: MDCX NACK
message for unconfigured lchan\n");
return -EINVAL;
}
osmo_fsm_inst_dispatch(msg->lchan->fi_rtp,
LCHAN_RTP_EV_IPACC_MDCX_NACK, 0);
--
To view, visit https://gerrit.osmocom.org/13889
To unsubscribe, or for help writing mail filters, visit
https://gerrit.osmocom.org/settings
Gerrit-Project: osmo-bsc
Gerrit-Branch: master
Gerrit-MessageType: newchange
Gerrit-Change-Id: Ic8885ca75ff23e4813a133f8fe34b7e67a1bc3e3
Gerrit-Change-Number: 13889
Gerrit-PatchSet: 1
Gerrit-Owner: Neels Hofmeyr
