Change in osmo-ci[master]: poky-sdk: Use first letter in caps (as in python bool)

2020-03-03 Thread laforge 
laforge has submitted this change. ( 
https://gerrit.osmocom.org/c/osmo-ci/+/17147 )

Change subject: poky-sdk: Use first letter in caps (as in python bool)
..

poky-sdk: Use first letter in caps (as in python bool)

Same as done in install-coverity/tasks/main.yml.

Change-Id: Ifbfe678e89bef3acd33e562888ad81093fa1230d
---
M ansible/roles/install-poky-sdk/tasks/main.yml
1 file changed, 4 insertions(+), 4 deletions(-)

Approvals:
  laforge: Looks good to me, approved
  pespin: Verified



diff --git a/ansible/roles/install-poky-sdk/tasks/main.yml 
b/ansible/roles/install-poky-sdk/tasks/main.yml
index 7f95dce..ff65c1b 100644
--- a/ansible/roles/install-poky-sdk/tasks/main.yml
+++ b/ansible/roles/install-poky-sdk/tasks/main.yml
@@ -21,7 +21,7 @@
   command: "/tmp/{{ poky_installer_file }} -y -d '{{ poky_dest }}'"
   args:
 creates: "{{ poky_dest }}"
-  when: poky_copy.failed == false
+  when: poky_copy.failed == False
   tags: [poky]

 - name: change owner/group to jenkins user
@@ -30,18 +30,18 @@
 owner: "{{ jenkins_user }}"
 group: "{{ jenkins_user }}"
 recurse: yes
-  when: poky_copy.failed == false
+  when: poky_copy.failed == False
   tags: [poky]

 - name: remove poky installer
   file:
 path: "/tmp/{{ poky_installer_file }}"
 state: absent
-  when: poky_copy.failed == false
+  when: poky_copy.failed == False
   tags: [poky]

 - name: "Please download {{ poky_installer_file }} to your ansible directory 
to allow ansible to install poky"
   debug:
 msg: "Ansible can not find or copy {{ poky_installer_file }}"
-  when: poky_copy.failed
+  when: poky_copy.failed == True
   tags: [poky]

--
To view, visit https://gerrit.osmocom.org/c/osmo-ci/+/17147
To unsubscribe, or for help writing mail filters, visit 
https://gerrit.osmocom.org/settings

Gerrit-Project: osmo-ci
Gerrit-Branch: master
Gerrit-Change-Id: Ifbfe678e89bef3acd33e562888ad81093fa1230d
Gerrit-Change-Number: 17147
Gerrit-PatchSet: 2
Gerrit-Owner: pespin 
Gerrit-Reviewer: laforge 
Gerrit-Reviewer: pespin 
Gerrit-MessageType: merged

Change in osmo-ci[master]: poky-sdk: Use first letter in caps (as in python bool)

2020-03-03 Thread laforge 
laforge has posted comments on this change. ( 
https://gerrit.osmocom.org/c/osmo-ci/+/17147 )

Change subject: poky-sdk: Use first letter in caps (as in python bool)
..


Patch Set 1: Code-Review+2


--
To view, visit https://gerrit.osmocom.org/c/osmo-ci/+/17147
To unsubscribe, or for help writing mail filters, visit 
https://gerrit.osmocom.org/settings

Gerrit-Project: osmo-ci
Gerrit-Branch: master
Gerrit-Change-Id: Ifbfe678e89bef3acd33e562888ad81093fa1230d
Gerrit-Change-Number: 17147
Gerrit-PatchSet: 1
Gerrit-Owner: pespin 
Gerrit-Reviewer: laforge 
Gerrit-Reviewer: pespin 
Gerrit-Comment-Date: Tue, 03 Mar 2020 16:26:43 +
Gerrit-HasComments: No
Gerrit-Has-Labels: Yes
Gerrit-MessageType: comment

Change in osmo-ci[master]: poky-sdk: Use first letter in caps (as in python bool)

2020-02-27 Thread pespin 
pespin has posted comments on this change. ( 
https://gerrit.osmocom.org/c/osmo-ci/+/17147 )

Change subject: poky-sdk: Use first letter in caps (as in python bool)
..


Patch Set 1: Verified+1


--
To view, visit https://gerrit.osmocom.org/c/osmo-ci/+/17147
To unsubscribe, or for help writing mail filters, visit 
https://gerrit.osmocom.org/settings

Gerrit-Project: osmo-ci
Gerrit-Branch: master
Gerrit-Change-Id: Ifbfe678e89bef3acd33e562888ad81093fa1230d
Gerrit-Change-Number: 17147
Gerrit-PatchSet: 1
Gerrit-Owner: pespin 
Gerrit-Reviewer: laforge 
Gerrit-Reviewer: pespin 
Gerrit-Comment-Date: Thu, 27 Feb 2020 10:44:24 +
Gerrit-HasComments: No
Gerrit-Has-Labels: Yes
Gerrit-MessageType: comment

Change in osmo-ci[master]: poky-sdk: Use first letter in caps (as in python bool)

2020-02-14 Thread laforge 
laforge has posted comments on this change. ( 
https://gerrit.osmocom.org/c/osmo-ci/+/17147 )

Change subject: poky-sdk: Use first letter in caps (as in python bool)
..


Patch Set 1: Code-Review+1


--
To view, visit https://gerrit.osmocom.org/c/osmo-ci/+/17147
To unsubscribe, or for help writing mail filters, visit 
https://gerrit.osmocom.org/settings

Gerrit-Project: osmo-ci
Gerrit-Branch: master
Gerrit-Change-Id: Ifbfe678e89bef3acd33e562888ad81093fa1230d
Gerrit-Change-Number: 17147
Gerrit-PatchSet: 1
Gerrit-Owner: pespin 
Gerrit-Reviewer: laforge 
Gerrit-Comment-Date: Fri, 14 Feb 2020 19:35:26 +
Gerrit-HasComments: No
Gerrit-Has-Labels: Yes
Gerrit-MessageType: comment

Change in osmo-ci[master]: poky-sdk: Use first letter in caps (as in python bool)

2020-02-14 Thread pespin 
pespin has uploaded this change for review. ( 
https://gerrit.osmocom.org/c/osmo-ci/+/17147 )


Change subject: poky-sdk: Use first letter in caps (as in python bool)
..

poky-sdk: Use first letter in caps (as in python bool)

Same as done in install-coverity/tasks/main.yml.

Change-Id: Ifbfe678e89bef3acd33e562888ad81093fa1230d
---
M ansible/roles/install-poky-sdk/tasks/main.yml
1 file changed, 4 insertions(+), 4 deletions(-)



  git pull ssh://gerrit.osmocom.org:29418/osmo-ci refs/changes/47/17147/1

diff --git a/ansible/roles/install-poky-sdk/tasks/main.yml 
b/ansible/roles/install-poky-sdk/tasks/main.yml
index 7f95dce..ff65c1b 100644
--- a/ansible/roles/install-poky-sdk/tasks/main.yml
+++ b/ansible/roles/install-poky-sdk/tasks/main.yml
@@ -21,7 +21,7 @@
   command: "/tmp/{{ poky_installer_file }} -y -d '{{ poky_dest }}'"
   args:
 creates: "{{ poky_dest }}"
-  when: poky_copy.failed == false
+  when: poky_copy.failed == False
   tags: [poky]

 - name: change owner/group to jenkins user
@@ -30,18 +30,18 @@
 owner: "{{ jenkins_user }}"
 group: "{{ jenkins_user }}"
 recurse: yes
-  when: poky_copy.failed == false
+  when: poky_copy.failed == False
   tags: [poky]

 - name: remove poky installer
   file:
 path: "/tmp/{{ poky_installer_file }}"
 state: absent
-  when: poky_copy.failed == false
+  when: poky_copy.failed == False
   tags: [poky]

 - name: "Please download {{ poky_installer_file }} to your ansible directory 
to allow ansible to install poky"
   debug:
 msg: "Ansible can not find or copy {{ poky_installer_file }}"
-  when: poky_copy.failed
+  when: poky_copy.failed == True
   tags: [poky]

--
To view, visit https://gerrit.osmocom.org/c/osmo-ci/+/17147
To unsubscribe, or for help writing mail filters, visit 
https://gerrit.osmocom.org/settings

Gerrit-Project: osmo-ci
Gerrit-Branch: master
Gerrit-Change-Id: Ifbfe678e89bef3acd33e562888ad81093fa1230d
Gerrit-Change-Number: 17147
Gerrit-PatchSet: 1
Gerrit-Owner: pespin 
Gerrit-MessageType: newchange