Change in osmo-hlr[master]: mslookup_client_mdns_test: no automatic skip

2020-02-14 Thread osmith
osmith has submitted this change. ( 
https://gerrit.osmocom.org/c/osmo-hlr/+/17072 )

Change subject: mslookup_client_mdns_test: no automatic skip
..

mslookup_client_mdns_test: no automatic skip

Exit with error code if multicast is disabled. The test is disabled by
default already, so when explicitly enabling it, we should not
automatically skip it.

Related: OS#4385
Change-Id: I82022c23fa9c40535f922b12d917efd7e229912b
---
M tests/mslookup/mslookup_client_mdns_test.c
1 file changed, 2 insertions(+), 2 deletions(-)

Approvals:
  fixeria: Looks good to me, approved
  Jenkins Builder: Verified



diff --git a/tests/mslookup/mslookup_client_mdns_test.c 
b/tests/mslookup/mslookup_client_mdns_test.c
index f33ef98..5e558b4 100644
--- a/tests/mslookup/mslookup_client_mdns_test.c
+++ b/tests/mslookup/mslookup_client_mdns_test.c
@@ -225,8 +225,8 @@
 int main()
 {
if (!is_multicast_enabled()) {
-   fprintf(stderr, "WARNING: multicast is disabled, skipping the 
test! (OS#4361)");
-   return 77;
+   fprintf(stderr, "ERROR: multicast is disabled! (OS#4361)");
+   return 1;
}

talloc_enable_null_tracking();

--
To view, visit https://gerrit.osmocom.org/c/osmo-hlr/+/17072
To unsubscribe, or for help writing mail filters, visit 
https://gerrit.osmocom.org/settings

Gerrit-Project: osmo-hlr
Gerrit-Branch: master
Gerrit-Change-Id: I82022c23fa9c40535f922b12d917efd7e229912b
Gerrit-Change-Number: 17072
Gerrit-PatchSet: 2
Gerrit-Owner: osmith 
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: fixeria 
Gerrit-Reviewer: osmith 
Gerrit-MessageType: merged


Change in osmo-hlr[master]: mslookup_client_mdns_test: no automatic skip

2020-01-30 Thread osmith
osmith has uploaded this change for review. ( 
https://gerrit.osmocom.org/c/osmo-hlr/+/17072 )


Change subject: mslookup_client_mdns_test: no automatic skip
..

mslookup_client_mdns_test: no automatic skip

Exit with error code if multicast is disabled. The test is disabled by
default already, so when explicitly enabling it, we should not
automatically skip it.

Related: OS#4385
Change-Id: I82022c23fa9c40535f922b12d917efd7e229912b
---
M tests/mslookup/mslookup_client_mdns_test.c
1 file changed, 2 insertions(+), 2 deletions(-)



  git pull ssh://gerrit.osmocom.org:29418/osmo-hlr refs/changes/72/17072/1

diff --git a/tests/mslookup/mslookup_client_mdns_test.c 
b/tests/mslookup/mslookup_client_mdns_test.c
index f33ef98..5e558b4 100644
--- a/tests/mslookup/mslookup_client_mdns_test.c
+++ b/tests/mslookup/mslookup_client_mdns_test.c
@@ -225,8 +225,8 @@
 int main()
 {
if (!is_multicast_enabled()) {
-   fprintf(stderr, "WARNING: multicast is disabled, skipping the 
test! (OS#4361)");
-   return 77;
+   fprintf(stderr, "ERROR: multicast is disabled! (OS#4361)");
+   return 1;
}

talloc_enable_null_tracking();

--
To view, visit https://gerrit.osmocom.org/c/osmo-hlr/+/17072
To unsubscribe, or for help writing mail filters, visit 
https://gerrit.osmocom.org/settings

Gerrit-Project: osmo-hlr
Gerrit-Branch: master
Gerrit-Change-Id: I82022c23fa9c40535f922b12d917efd7e229912b
Gerrit-Change-Number: 17072
Gerrit-PatchSet: 1
Gerrit-Owner: osmith 
Gerrit-MessageType: newchange