Change in osmo-msc[master]: Add tests for transaction routines

2019-12-12 Thread neels
neels has abandoned this change. ( https://gerrit.osmocom.org/c/osmo-msc/+/12556 ) Change subject: Add tests for transaction routines .. Abandoned -- To view, visit https://gerrit.osmocom.org/c/osmo-msc/+/12556 To unsubscribe,

Change in osmo-msc[master]: Add tests for transaction routines

2019-05-10 Thread Harald Welte
Harald Welte has posted comments on this change. ( https://gerrit.osmocom.org/12556 ) Change subject: Add tests for transaction routines .. Patch Set 11: I presume the MSC has changed too far to still make use of this? In

Change in osmo-msc[master]: Add tests for transaction routines

2019-01-15 Thread Vadim Yanitskiy
Vadim Yanitskiy has posted comments on this change. ( https://gerrit.osmocom.org/12556 ) Change subject: Add tests for transaction routines .. Patch Set 11: Code-Review-1 Keeping my -1 because I am against using same callref

Change in osmo-msc[master]: Add tests for transaction routines

2019-01-15 Thread Vadim Yanitskiy
Vadim Yanitskiy has posted comments on this change. ( https://gerrit.osmocom.org/12556 ) Change subject: Add tests for transaction routines .. Patch Set 9: (3 comments)

Change in osmo-msc[master]: Add tests for transaction routines

2019-01-15 Thread Max
Hello Vadim Yanitskiy, Neels Hofmeyr, Harald Welte, Jenkins Builder, I'd like you to reexamine a change. Please visit https://gerrit.osmocom.org/12556 to look at the new patch set (#11). Change subject: Add tests for transaction routines

Change in osmo-msc[master]: Add tests for transaction routines

2019-01-15 Thread Max
Max has posted comments on this change. ( https://gerrit.osmocom.org/12556 ) Change subject: Add tests for transaction routines .. Patch Set 10: (1 comment) https://gerrit.osmocom.org/#/c/12556/9/tests/trans/trans_test.c File

Change in osmo-msc[master]: Add tests for transaction routines

2019-01-15 Thread Vadim Yanitskiy
Vadim Yanitskiy has posted comments on this change. ( https://gerrit.osmocom.org/12556 ) Change subject: Add tests for transaction routines .. Patch Set 9: > (1 comment) Yup, please see: https://osmocom.org/issues/3294 --

Change in osmo-msc[master]: Add tests for transaction routines

2019-01-15 Thread Vadim Yanitskiy
Vadim Yanitskiy has posted comments on this change. ( https://gerrit.osmocom.org/12556 ) Change subject: Add tests for transaction routines .. Patch Set 9: (4 comments)

Change in osmo-msc[master]: Add tests for transaction routines

2019-01-15 Thread Max
Max has posted comments on this change. ( https://gerrit.osmocom.org/12556 ) Change subject: Add tests for transaction routines .. Patch Set 10: (1 comment) https://gerrit.osmocom.org/#/c/12556/9/tests/trans/trans_test.c File

Change in osmo-msc[master]: Add tests for transaction routines

2019-01-15 Thread Max
Hello Vadim Yanitskiy, Harald Welte, Jenkins Builder, I'd like you to reexamine a change. Please visit https://gerrit.osmocom.org/12556 to look at the new patch set (#10). Change subject: Add tests for transaction routines

Change in osmo-msc[master]: Add tests for transaction routines

2019-01-15 Thread Max
Max has posted comments on this change. ( https://gerrit.osmocom.org/12556 ) Change subject: Add tests for transaction routines .. Patch Set 9: (8 comments) > you could set its level to DEBUG Good point. I'll update it in

Change in osmo-msc[master]: Add tests for transaction routines

2019-01-14 Thread Vadim Yanitskiy
Vadim Yanitskiy has posted comments on this change. ( https://gerrit.osmocom.org/12556 ) Change subject: Add tests for transaction routines .. Patch Set 9: Code-Review-1 (13 comments)

Change in osmo-msc[master]: Add tests for transaction routines

2019-01-14 Thread Harald Welte
Harald Welte has posted comments on this change. ( https://gerrit.osmocom.org/12556 ) Change subject: Add tests for transaction routines .. Patch Set 9: Code-Review+2 -- To view, visit https://gerrit.osmocom.org/12556 To

Change in osmo-msc[master]: Add tests for transaction routines

2019-01-14 Thread Max
Max has posted comments on this change. ( https://gerrit.osmocom.org/12556 ) Change subject: Add tests for transaction routines .. Patch Set 9: This change is ready for review. -- To view, visit

Change in osmo-msc[master]: Add tests for transaction routines

2019-01-14 Thread Harald Welte
Harald Welte has posted comments on this change. ( https://gerrit.osmocom.org/12556 ) Change subject: Add tests for transaction routines .. Patch Set 1: Code-Review+2 -- To view, visit https://gerrit.osmocom.org/12556 To

Change in osmo-msc[master]: Add tests for transaction routines

2019-01-14 Thread Max
Max has uploaded this change for review. ( https://gerrit.osmocom.org/12556 Change subject: Add tests for transaction routines .. Add tests for transaction routines Change-Id: I78dfb7cd35073a305cf668beda7d9d58d5a5a713 --- M