Change in osmo-ttcn3-hacks[master]: ttcn3-tcpdump-start: Fix path of setcap
laforge has submitted this change. ( https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/21675 ) Change subject: ttcn3-tcpdump-start: Fix path of setcap .. ttcn3-tcpdump-start: Fix path of setcap if we test if /sbin/setcap exists, we als should execute it from that path, as running from a normal user doesn't have /sbin included in $PATH Change-Id: I5131f869f86e6d136e0485da5e3749abbfc951e3 --- M ttcn3-tcpdump-start.sh 1 file changed, 1 insertion(+), 1 deletion(-) Approvals: Jenkins Builder: Verified laforge: Looks good to me, approved diff --git a/ttcn3-tcpdump-start.sh b/ttcn3-tcpdump-start.sh index 3ad14c0..e905d8a 100755 --- a/ttcn3-tcpdump-start.sh +++ b/ttcn3-tcpdump-start.sh @@ -39,7 +39,7 @@ CAP_ERR="1" if [ -x /sbin/setcap ]; then # N. B: this check requires libcap2-bin package - setcap -q -v 'cap_net_admin,cap_net_raw=pie' $DUMPCAP + /sbin/setcap -q -v 'cap_net_admin,cap_net_raw=pie' $DUMPCAP CAP_ERR="$?" fi if [ -u $DUMPCAP -o "$CAP_ERR" = "0" ]; then -- To view, visit https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/21675 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-ttcn3-hacks Gerrit-Branch: master Gerrit-Change-Id: I5131f869f86e6d136e0485da5e3749abbfc951e3 Gerrit-Change-Number: 21675 Gerrit-PatchSet: 1 Gerrit-Owner: laforge Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: laforge Gerrit-MessageType: merged
Change in osmo-ttcn3-hacks[master]: ttcn3-tcpdump-start: Fix path of setcap
laforge has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/21675 ) Change subject: ttcn3-tcpdump-start: Fix path of setcap .. Patch Set 1: Code-Review+2 -- To view, visit https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/21675 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-ttcn3-hacks Gerrit-Branch: master Gerrit-Change-Id: I5131f869f86e6d136e0485da5e3749abbfc951e3 Gerrit-Change-Number: 21675 Gerrit-PatchSet: 1 Gerrit-Owner: laforge Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: laforge Gerrit-Comment-Date: Fri, 11 Dec 2020 14:36:48 + Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment
Change in osmo-ttcn3-hacks[master]: ttcn3-tcpdump-start: Fix path of setcap
laforge has uploaded this change for review. ( https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/21675 ) Change subject: ttcn3-tcpdump-start: Fix path of setcap .. ttcn3-tcpdump-start: Fix path of setcap if we test if /sbin/setcap exists, we als should execute it from that path, as running from a normal user doesn't have /sbin included in $PATH Change-Id: I5131f869f86e6d136e0485da5e3749abbfc951e3 --- M ttcn3-tcpdump-start.sh 1 file changed, 1 insertion(+), 1 deletion(-) git pull ssh://gerrit.osmocom.org:29418/osmo-ttcn3-hacks refs/changes/75/21675/1 diff --git a/ttcn3-tcpdump-start.sh b/ttcn3-tcpdump-start.sh index 3ad14c0..e905d8a 100755 --- a/ttcn3-tcpdump-start.sh +++ b/ttcn3-tcpdump-start.sh @@ -39,7 +39,7 @@ CAP_ERR="1" if [ -x /sbin/setcap ]; then # N. B: this check requires libcap2-bin package - setcap -q -v 'cap_net_admin,cap_net_raw=pie' $DUMPCAP + /sbin/setcap -q -v 'cap_net_admin,cap_net_raw=pie' $DUMPCAP CAP_ERR="$?" fi if [ -u $DUMPCAP -o "$CAP_ERR" = "0" ]; then -- To view, visit https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/21675 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-ttcn3-hacks Gerrit-Branch: master Gerrit-Change-Id: I5131f869f86e6d136e0485da5e3749abbfc951e3 Gerrit-Change-Number: 21675 Gerrit-PatchSet: 1 Gerrit-Owner: laforge Gerrit-MessageType: newchange
