Change in osmocom-bb[master]: mobile: display MS IMSI in vty

2018-10-24 Thread Max 
Max has abandoned this change. ( https://gerrit.osmocom.org/11440 )

Change subject: mobile: display MS IMSI in vty
..


Abandoned
--
To view, visit https://gerrit.osmocom.org/11440
To unsubscribe, or for help writing mail filters, visit 
https://gerrit.osmocom.org/settings

Gerrit-Project: osmocom-bb
Gerrit-Branch: master
Gerrit-MessageType: abandon
Gerrit-Change-Id: Id05f4f5f3416dcdb9ce2fd24f9360f5e6faaf654
Gerrit-Change-Number: 11440
Gerrit-PatchSet: 1
Gerrit-Owner: Max 
Gerrit-Reviewer: Harald Welte 
Gerrit-Reviewer: Jenkins Builder (102)
Gerrit-Reviewer: Max 
Gerrit-Reviewer: Vadim Yanitskiy 
Gerrit-Reviewer: fixeria

Change in osmocom-bb[master]: mobile: display MS IMSI in vty

2018-10-24 Thread Max 
Max has posted comments on this change. ( https://gerrit.osmocom.org/11440 )

Change subject: mobile: display MS IMSI in vty
..


Patch Set 1:

Curious, "sh subs 1" gives me empty IMSI while with this patch I can see it via 
"sh ms 1". Anyway, it's purely cosmetic - will investigate later on.


--
To view, visit https://gerrit.osmocom.org/11440
To unsubscribe, or for help writing mail filters, visit 
https://gerrit.osmocom.org/settings

Gerrit-Project: osmocom-bb
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Id05f4f5f3416dcdb9ce2fd24f9360f5e6faaf654
Gerrit-Change-Number: 11440
Gerrit-PatchSet: 1
Gerrit-Owner: Max 
Gerrit-Reviewer: Harald Welte 
Gerrit-Reviewer: Jenkins Builder (102)
Gerrit-Reviewer: Max 
Gerrit-Reviewer: Vadim Yanitskiy 
Gerrit-Reviewer: fixeria 
Gerrit-Comment-Date: Wed, 24 Oct 2018 09:39:23 +
Gerrit-HasComments: No
Gerrit-HasLabels: No

Change in osmocom-bb[master]: mobile: display MS IMSI in vty

2018-10-23 Thread Harald Welte 
Harald Welte has posted comments on this change. ( 
https://gerrit.osmocom.org/11440 )

Change subject: mobile: display MS IMSI in vty
..


Patch Set 1: Code-Review-1

also, why only print the IMSI if it's an emulaed SIM, but not with a real 
hardware SIM?  That's just wrong.


--
To view, visit https://gerrit.osmocom.org/11440
To unsubscribe, or for help writing mail filters, visit 
https://gerrit.osmocom.org/settings

Gerrit-Project: osmocom-bb
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Id05f4f5f3416dcdb9ce2fd24f9360f5e6faaf654
Gerrit-Change-Number: 11440
Gerrit-PatchSet: 1
Gerrit-Owner: Max 
Gerrit-Reviewer: Harald Welte 
Gerrit-Reviewer: Jenkins Builder (102)
Gerrit-Reviewer: Vadim Yanitskiy 
Gerrit-Reviewer: fixeria 
Gerrit-Comment-Date: Tue, 23 Oct 2018 16:33:24 +
Gerrit-HasComments: No
Gerrit-HasLabels: Yes

Change in osmocom-bb[master]: mobile: display MS IMSI in vty

2018-10-23 Thread Vadim Yanitskiy 
Vadim Yanitskiy has posted comments on this change. ( 
https://gerrit.osmocom.org/11440 )

Change subject: mobile: display MS IMSI in vty
..


Patch Set 1: Code-Review-1

I think it can be obtained using 'subscriber' command,
why do we need to duplicate?


--
To view, visit https://gerrit.osmocom.org/11440
To unsubscribe, or for help writing mail filters, visit 
https://gerrit.osmocom.org/settings

Gerrit-Project: osmocom-bb
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Id05f4f5f3416dcdb9ce2fd24f9360f5e6faaf654
Gerrit-Change-Number: 11440
Gerrit-PatchSet: 1
Gerrit-Owner: Max 
Gerrit-Reviewer: Jenkins Builder (102)
Gerrit-Reviewer: Vadim Yanitskiy 
Gerrit-Reviewer: fixeria 
Gerrit-Comment-Date: Tue, 23 Oct 2018 16:31:55 +
Gerrit-HasComments: No
Gerrit-HasLabels: Yes

Change in osmocom-bb[master]: mobile: display MS IMSI in vty

2018-10-23 Thread Max 
Max has uploaded this change for review. ( https://gerrit.osmocom.org/11440


Change subject: mobile: display MS IMSI in vty
..

mobile: display MS IMSI in vty

Show IMSI in addition to IMEI when using 'show ms 1' command.

Change-Id: Id05f4f5f3416dcdb9ce2fd24f9360f5e6faaf654
---
M src/host/layer23/src/mobile/vty_interface.c
1 file changed, 3 insertions(+), 0 deletions(-)



  git pull ssh://gerrit.osmocom.org:29418/osmocom-bb refs/changes/40/11440/1

diff --git a/src/host/layer23/src/mobile/vty_interface.c 
b/src/host/layer23/src/mobile/vty_interface.c
index 12c32a5..1fb6e15 100644
--- a/src/host/layer23/src/mobile/vty_interface.c
+++ b/src/host/layer23/src/mobile/vty_interface.c
@@ -201,6 +201,9 @@
else
vty_out(vty, " IMEI generation: fixed%s", VTY_NEWLINE);

+   if (ms->settings.test_imsi)
+   vty_out(vty, "  IMSI: %s%s", ms->settings.test_imsi, 
VTY_NEWLINE);
+
if (ms->shutdown != MS_SHUTDOWN_NONE)
return;


--
To view, visit https://gerrit.osmocom.org/11440
To unsubscribe, or for help writing mail filters, visit 
https://gerrit.osmocom.org/settings

Gerrit-Project: osmocom-bb
Gerrit-Branch: master
Gerrit-MessageType: newchange
Gerrit-Change-Id: Id05f4f5f3416dcdb9ce2fd24f9360f5e6faaf654
Gerrit-Change-Number: 11440
Gerrit-PatchSet: 1
Gerrit-Owner: Max