Vadim Yanitskiy has abandoned this change.
Change subject: gsm0480: expose the gsm0480_parse_ss_facility_ie()
..
Abandoned
Change is not required anymore.
--
To view, visit https://gerrit.osmocom.org/3381
To unsubscribe,
Patch Set 9:
I don't remember off the top of my head. If it's not used in OpenBSC or in the
SIP proxy, then I guess this is not required.
--
To view, visit https://gerrit.osmocom.org/3381
To unsubscribe, visit https://gerrit.osmocom.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id:
Patch Set 9: Code-Review-1
I am not sure if we really need this change.
Alexander?
--
To view, visit https://gerrit.osmocom.org/3381
To unsubscribe, visit https://gerrit.osmocom.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I35d3360f36c48eb1295610ab96ff264c45af77eb
Hello Alexander Chemeris, Harald Welte, Jenkins Builder,
I'd like you to reexamine a change. Please visit
https://gerrit.osmocom.org/3381
to look at the new patch set (#8).
gsm0480: expose the gsm0480_parse_ss_facility_ie()
Change-Id: I35d3360f36c48eb1295610ab96ff264c45af77eb
---
M
Patch Set 7:
> but then, all the other routines in this function
> don't seem to follow that rule.
Moreover, for some functions here a positive return
value means 'success', while rc=0 indicates an error ;)
--
To view, visit https://gerrit.osmocom.org/3381
To unsubscribe, visit
Patch Set 7: Code-Review+2
(1 comment)
https://gerrit.osmocom.org/#/c/3381/7/include/osmocom/gsm/gsm0480.h
File include/osmocom/gsm/gsm0480.h:
Line 73: int gsm0480_parse_ss_facility_ie(const uint8_t *facility_ie, uint16_t
length,
> the general "rule of thumb" in smocom coding style is is to
Patch Set 7:
(1 comment)
https://gerrit.osmocom.org/#/c/3381/7/include/osmocom/gsm/gsm0480.h
File include/osmocom/gsm/gsm0480.h:
Line 73: int gsm0480_parse_ss_facility_ie(const uint8_t *facility_ie, uint16_t
length,
the general "rule of thumb" in smocom coding style is is to follow "memcpy"
Patch Set 6: Code-Review+1
--
To view, visit https://gerrit.osmocom.org/3381
To unsubscribe, visit https://gerrit.osmocom.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I35d3360f36c48eb1295610ab96ff264c45af77eb
Gerrit-PatchSet: 6
Gerrit-Project: libosmocore
Gerrit-Branch: master
Hello Alexander Chemeris, Harald Welte, Jenkins Builder,
I'd like you to reexamine a change. Please visit
https://gerrit.osmocom.org/3381
to look at the new patch set (#6).
gsm0480: expose the gsm0480_parse_ss_facility_ie()
Change-Id: I35d3360f36c48eb1295610ab96ff264c45af77eb
---
M
Hello Alexander Chemeris, Harald Welte, Jenkins Builder,
I'd like you to reexamine a change. Please visit
https://gerrit.osmocom.org/3381
to look at the new patch set (#5).
gsm0480: expose the gsm0480_parse_ss_facility_ie()
Change-Id: I35d3360f36c48eb1295610ab96ff264c45af77eb
---
M
Hello Alexander Chemeris, Harald Welte, Jenkins Builder,
I'd like you to reexamine a change. Please visit
https://gerrit.osmocom.org/3381
to look at the new patch set (#4).
gsm0480: expose the gsm0480_parse_ss_facility_ie()
Change-Id: I35d3360f36c48eb1295610ab96ff264c45af77eb
---
M
Patch Set 3: Code-Review+2
--
To view, visit https://gerrit.osmocom.org/3381
To unsubscribe, visit https://gerrit.osmocom.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I35d3360f36c48eb1295610ab96ff264c45af77eb
Gerrit-PatchSet: 3
Gerrit-Project: libosmocore
Gerrit-Branch: master
Patch Set 3: Code-Review+1
--
To view, visit https://gerrit.osmocom.org/3381
To unsubscribe, visit https://gerrit.osmocom.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I35d3360f36c48eb1295610ab96ff264c45af77eb
Gerrit-PatchSet: 3
Gerrit-Project: libosmocore
Gerrit-Branch: master
gsm0480: expose the gsm0480_parse_ss_facility_ie()
Change-Id: I35d3360f36c48eb1295610ab96ff264c45af77eb
---
M include/osmocom/gsm/gsm0480.h
M src/gsm/gsm0480.c
M src/gsm/libosmogsm.map
3 files changed, 8 insertions(+), 6 deletions(-)
git pull ssh://gerrit.osmocom.org:29418/libosmocore
Review at https://gerrit.osmocom.org/3381
gsm0480: expose the gsm0480_parse_ss_facility_ie()
Change-Id: I35d3360f36c48eb1295610ab96ff264c45af77eb
---
M include/osmocom/gsm/gsm0480.h
M src/gsm/gsm0480.c
M src/gsm/libosmogsm.map
3 files changed, 8 insertions(+), 6 deletions(-)
git pull
15 matches
Mail list logo