Patch Set 3:
> Please move the description
I'd say better copy it, not move.
--
To view, visit https://gerrit.osmocom.org/5712
To unsubscribe, visit https://gerrit.osmocom.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I6dead74f9ecea079752ff2400cdaf7c30187784e
Gerrit-PatchSet: 3
Patch Set 3: Code-Review-1
Please move the description of this calculation from the commit message to a
comment. It should be easily understood when you browse the code.
--
To view, visit https://gerrit.osmocom.org/5712
To unsubscribe, visit https://gerrit.osmocom.org/settings
Hello Jenkins Builder,
I'd like you to reexamine a change. Please visit
https://gerrit.osmocom.org/5712
to look at the new patch set (#3).
gsm0480: increase the MAX_LEN_USSD_STRING to 182
According to the GSM 04.80 (version 5.0.0) specification Annex A
"Expanded ASN.1 Module
Hello Jenkins Builder,
I'd like you to reexamine a change. Please visit
https://gerrit.osmocom.org/5712
to look at the new patch set (#2).
gsm0480: increase the MAX_LEN_USSD_STRING to 182
According to the GSM 04.80 (version 5.0.0) specification Annex A
"Expanded ASN.1 Module
Patch Set 1:
> Would be nice to have more detailed spec reference - which
> chapter/paragraph exactly states that? Also, 160 * 8 / 7 is around
> 182.86 - you sure we shouldn't use 183 chars?
Ok, I'll upload more detailed description soon.
Regarding to 182.86, you have:
160 * 8 = 1280 bits
Patch Set 1:
Would be nice to have more detailed spec reference - which chapter/paragraph
exactly states that? Also, 160 * 8 / 7 is around 182.86 - you sure we shouldn't
use 183 chars?
--
To view, visit https://gerrit.osmocom.org/5712
To unsubscribe, visit https://gerrit.osmocom.org/settings
Review at https://gerrit.osmocom.org/5712
gsm0480: increase the MAX_LEN_USSD_STRING to 182
According to the GSM 04.08 specification, the maximum size of
a USSD message is 160 bytes. So, for 7-bit data coding schemes,
the maximum number of characters is 182 (160 * 8 / 7) characters.
Change-Id:
