libosmocore[master]: gsm0480: refactor the parse_process_uss_req()

2017-08-09 Thread Harald Welte
Patch Set 3: Code-Review+2 -- To view, visit https://gerrit.osmocom.org/3375 To unsubscribe, visit https://gerrit.osmocom.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I467f75794c5ac9df75c001245b18bbdfcfaadd88 Gerrit-PatchSet: 3 Gerrit-Project: libosmocore Gerrit-Branch: master

libosmocore[master]: gsm0480: refactor the parse_process_uss_req()

2017-08-01 Thread Harald Welte
Patch Set 3: rather than improving the manually-generated code for USSD/SS parsing, shouldn't we simply move to using asn1c for generaging C code for the SS related ASN.1? -- To view, visit https://gerrit.osmocom.org/3375 To unsubscribe, visit https://gerrit.osmocom.org/settings

libosmocore[master]: gsm0480: refactor the parse_process_uss_req()

2017-07-30 Thread Alexander Chemeris
Patch Set 3: Code-Review+1 -- To view, visit https://gerrit.osmocom.org/3375 To unsubscribe, visit https://gerrit.osmocom.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I467f75794c5ac9df75c001245b18bbdfcfaadd88 Gerrit-PatchSet: 3 Gerrit-Project: libosmocore Gerrit-Branch: master

[PATCH] libosmocore[master]: gsm0480: refactor the parse_process_uss_req()

2017-07-29 Thread Vadim Yanitskiy
Hello Jenkins Builder, I'd like you to reexamine a change. Please visit https://gerrit.osmocom.org/3375 to look at the new patch set (#2). gsm0480: refactor the parse_process_uss_req() This change reduces the degree of code nesting using the 'follow by contradiction' pattern. Change-Id:

[PATCH] libosmocore[master]: gsm0480: refactor the parse_process_uss_req()

2017-07-29 Thread Vadim Yanitskiy
Review at https://gerrit.osmocom.org/3375 gsm0480: refactor the parse_process_uss_req() This change reduces the degree of code nesting using the 'follow by contradiction' pattern. Change-Id: I467f75794c5ac9df75c001245b18bbdfcfaadd88 --- M src/gsm/gsm0480.c 1 file changed, 20 insertions(+), 19