Patch Set 1:
yeah, I first wanted to fix the current situation, then maybe add a new
function after that, but at that point I went back to the other issues...
--
To view, visit https://gerrit.osmocom.org/6512
To unsubscribe, visit https://gerrit.osmocom.org/settings
Gerrit-MessageType:
Neels Hofmeyr has submitted this change and it was merged.
Change subject: gsmtap_sendmsg(): clarify API doc concerning msgb ownership
..
gsmtap_sendmsg(): clarify API doc concerning msgb ownership
Not freeing on error does
Patch Set 1: Code-Review+2
we could have added a new function that includes the free, something lie
gsmtap_sendmsg_free() and then migrate new cold over, deprecate the old API, ...
--
To view, visit https://gerrit.osmocom.org/6512
To unsubscribe, visit https://gerrit.osmocom.org/settings
Patch Set 1: Code-Review+1
--
To view, visit https://gerrit.osmocom.org/6512
To unsubscribe, visit https://gerrit.osmocom.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: Id3266ce36442024f16eaf6afa3f516d201930c41
Gerrit-PatchSet: 1
Gerrit-Project: libosmocore
Gerrit-Branch: master
Review at https://gerrit.osmocom.org/6512
gsmtap_sendmsg(): clarify API doc concerning msgb ownership
Not freeing on error does enable callers to try to re-send as well, so it is a
kind of useful feature, even though I find it likely for callers to either
forget about freeing the msg on error
