openbsc[master]: libcommon: Fix log output for bts>0.

2017-08-13 Thread Harald Welte
Patch Set 4: Code-Review+2 -- To view, visit https://gerrit.osmocom.org/3185 To unsubscribe, visit https://gerrit.osmocom.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I61c18a7f021fcb1ec00d34a745f4e3ab03416c2d Gerrit-PatchSet: 4 Gerrit-Project: openbsc Gerrit-Branch: master

[MERGED] openbsc[master]: libcommon: Fix log output for bts>0.

2017-08-13 Thread Harald Welte
Harald Welte has submitted this change and it was merged. Change subject: libcommon: Fix log output for bts>0. .. libcommon: Fix log output for bts>0. Fixes regression probably introduced in c696cc28. For bts>0 logging

openbsc[master]: libcommon: Fix log output for bts>0.

2017-08-12 Thread Alexander Chemeris
Patch Set 3: Harald - I've added a test. Hope it's enough. It doesn't look like the build failure is due to my change.. Not sure if I need to do anything? -- To view, visit https://gerrit.osmocom.org/3185 To unsubscribe, visit https://gerrit.osmocom.org/settings Gerrit-MessageType: comment

[PATCH] openbsc[master]: libcommon: Fix log output for bts>0.

2017-08-12 Thread Alexander Chemeris
Hello Max, Jenkins Builder, I'd like you to reexamine a change. Please visit https://gerrit.osmocom.org/3185 to look at the new patch set (#3). libcommon: Fix log output for bts>0. Fixes regression probably introduced in c696cc28. For bts>0 logging doesn't show bts number correctly when

openbsc[master]: libcommon: Fix log output for bts>0.

2017-08-09 Thread Alexander Chemeris
Patch Set 2: Hi Harald, thank you for a reminder. I'll try to find some time to extend the patch. -- To view, visit https://gerrit.osmocom.org/3185 To unsubscribe, visit https://gerrit.osmocom.org/settings Gerrit-MessageType: comment Gerrit-Change-Id:

openbsc[master]: libcommon: Fix log output for bts>0.

2017-08-09 Thread Harald Welte
Patch Set 2: ping? Alexander, can I motivat you to extend the test case to cover multiple BTSs and their numbers, as requested a month ago? Should be super trivial, AFAICT. -- To view, visit https://gerrit.osmocom.org/3185 To unsubscribe, visit https://gerrit.osmocom.org/settings

openbsc[master]: libcommon: Fix log output for bts>0.

2017-07-12 Thread Harald Welte
Patch Set 2: (1 comment) > Btw, Harald - any reason we're caching lchan log string, but > doesn't cache pchan log string? We don't print pchan names anywhere nearly as frequently as lchan names. Have you seen the pchan name printing show up in any profiles? We can certainly add it if

openbsc[master]: libcommon: Fix log output for bts>0.

2017-07-12 Thread Max
Patch Set 2: Code-Review+1 -- To view, visit https://gerrit.osmocom.org/3185 To unsubscribe, visit https://gerrit.osmocom.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I61c18a7f021fcb1ec00d34a745f4e3ab03416c2d Gerrit-PatchSet: 2 Gerrit-Project: openbsc Gerrit-Branch: master

[PATCH] openbsc[master]: libcommon: Fix log output for bts>0.

2017-07-11 Thread Alexander Chemeris
Hello Jenkins Builder, I'd like you to reexamine a change. Please visit https://gerrit.osmocom.org/3185 to look at the new patch set (#2). libcommon: Fix log output for bts>0. Fixes regression probably introduced in c696cc28. For bts>0 logging doesn't show bts number correctly when

openbsc[master]: libcommon: Fix log output for bts>0.

2017-07-11 Thread Alexander Chemeris
Patch Set 1: Btw, Harald - any reason we're caching lchan log string, but doesn't cache pchan log string? -- To view, visit https://gerrit.osmocom.org/3185 To unsubscribe, visit https://gerrit.osmocom.org/settings Gerrit-MessageType: comment Gerrit-Change-Id:

[PATCH] openbsc[master]: libcommon: Fix log output for bts>0.

2017-07-11 Thread Alexander Chemeris
Review at https://gerrit.osmocom.org/3185 libcommon: Fix log output for bts>0. Fixes regression probably introduced in c696cc28. For bts>0 logging doesn't show bts number correctly when printing lchan identification string - it will always show it as "bts=0". The reason for this is that the