Patch Set 1: Code-Review+2
--
To view, visit https://gerrit.osmocom.org/7503
To unsubscribe, visit https://gerrit.osmocom.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I78a152671a00b95c997830f7161fca92bb898fa3
Gerrit-PatchSet: 1
Gerrit-Project: osmo-bsc
Gerrit-Branch: master
Harald Welte has submitted this change and it was merged.
Change subject: Generate the S_L_INP_TEI_UP signal earlier.
..
Generate the S_L_INP_TEI_UP signal earlier.
The S_L_INP_TEI_UP signal was generated when the first
Patch Set 1:
> my assumption is that
> * before this patch, the proposed test would fail (i.e. link not
> up)
> * after this patch, the proposed test will pass as the UP signal is
> created at connect, not at receive
I am still not entirely sure how such a test would work.
There is
Patch Set 1:
my assumption is that
* before this patch, the proposed test would fail (i.e. link not up)
* after this patch, the proposed test will pass as the UP signal is created at
connect, not at receive
--
To view, visit https://gerrit.osmocom.org/7503
To unsubscribe, visit
Patch Set 1:
> how did you test it exactly? AFAICT you cannot provoke this
> behavior with real OsmoBTS as it will always send the RSL CCCH
> LOAD INDICATION or an EVENT CHANGE REPORT or anything immediately
> after the connection is up. So in order to trigger this situation,
> you'd have
Patch Set 1:
how did you test it exactly? AFAICT you cannot provoke this behavior with real
OsmoBTS as it will always send the RSL CCCH LOAD INDICATION or an EVENT CHANGE
REPORT or anything immediately after the connection is up. So in order to
trigger this situation, you'd have to
Review at https://gerrit.osmocom.org/7503
Generate the S_L_INP_TEI_UP signal earlier.
The S_L_INP_TEI_UP signal was generated when the first message from a BTS
arrives on the OML/RSL link, rather than when the OML/RSL link comes up.
Instead, generate this signal when the link is brought up, so
Harald Welte has submitted this change and it was merged.
Change subject: Generate the S_L_INP_TEI_UP signal earlier.
..
Generate the S_L_INP_TEI_UP signal earlier.
The S_L_INP_TEI_UP signal was generated when the first
Patch Set 3: Code-Review+2 Verified+1
--
To view, visit https://gerrit.osmocom.org/6387
To unsubscribe, visit https://gerrit.osmocom.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I3b76ae6b00043e706dddc78209311e00ace85bb7
Gerrit-PatchSet: 3
Gerrit-Project: osmo-bsc
Gerrit-Branch:
Hello Harald Welte, Jenkins Builder,
I'd like you to reexamine a change. Please visit
https://gerrit.osmocom.org/6387
to look at the new patch set (#3).
Generate the S_L_INP_TEI_UP signal earlier.
The S_L_INP_TEI_UP signal was generated when the first message from a BTS
arrives on the
Patch Set 1:
> > pleaes test with real BTS setup, update commitlog and then we can
> > merge it.
>
> Yes, as noted in https://osmocom.org/issues/2719#note-7 I plan to
> get to doing this soon.
I have tested the patch with a sysmobts now and it looks good to me. Please see
the pcap files I
Patch Set 1:
> pleaes test with real BTS setup, update commitlog and then we can
> merge it.
Yes, as noted in https://osmocom.org/issues/2719#note-7 I plan to get to doing
this soon.
--
To view, visit https://gerrit.osmocom.org/6387
To unsubscribe, visit https://gerrit.osmocom.org/settings
Patch Set 1:
pleaes test with real BTS setup, update commitlog and then we can merge it.
--
To view, visit https://gerrit.osmocom.org/6387
To unsubscribe, visit https://gerrit.osmocom.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I3b76ae6b00043e706dddc78209311e00ace85bb7
Patch Set 1: Code-Review+1
i think this should be tested with a real BTS setup before merging
--
To view, visit https://gerrit.osmocom.org/6387
To unsubscribe, visit https://gerrit.osmocom.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I3b76ae6b00043e706dddc78209311e00ace85bb7
Review at https://gerrit.osmocom.org/6387
Generate the S_L_INP_TEI_UP signal earlier.
The S_L_INP_TEI_UP signal was generated when the first message from a BTS
arrives on the OML/RSL link, rather than when the OML/RSL link comes up.
Instead, generate this signal when the link is brought up, so
15 matches
Mail list logo
