Patch Set 3: Code-Review+2
--
To view, visit https://gerrit.osmocom.org/6861
To unsubscribe, visit https://gerrit.osmocom.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I0a4d311f6939a4fcee59129daa18da4a2ab510ae
Gerrit-PatchSet: 3
Gerrit-Project: osmo-bsc
Gerrit-Branch: master
Hello Harald Welte, Jenkins Builder,
I'd like you to reexamine a change. Please visit
https://gerrit.osmocom.org/6861
to look at the new patch set (#3).
bsc_api: drop unknown RR messages.
Radio Resource (RR) handling is entirely done inside the BSC. However,
the current implementation
Patch Set 2:
(1 comment)
https://gerrit.osmocom.org/#/c/6861/2/src/libbsc/bsc_api.c
File src/libbsc/bsc_api.c:
Line 778:"BSC: Dropping %s 04.08 RR message from
%s\n",
sorry, but where do we normally put context information? Always at the
beginning of the log
Patch Set 2: Code-Review-1
--
To view, visit https://gerrit.osmocom.org/6861
To unsubscribe, visit https://gerrit.osmocom.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I0a4d311f6939a4fcee59129daa18da4a2ab510ae
Gerrit-PatchSet: 2
Gerrit-Project: osmo-bsc
Gerrit-Branch: master
Hello Jenkins Builder,
I'd like you to reexamine a change. Please visit
https://gerrit.osmocom.org/6861
to look at the new patch set (#2).
bsc_api: drop unknown RR messages.
Radio Resource (RR) handling is entirely done inside the BSC. However,
the current implementation forwards unknown
Patch Set 1:
(1 comment)
https://gerrit.osmocom.org/#/c/6861/1/src/libbsc/bsc_api.c
File src/libbsc/bsc_api.c:
Line 778:"BSC: Dropping %s 04.08 RR message\n",
I think yo want the lchan->name or some other identity/context of the
subscr-conn on *where* that message
Review at https://gerrit.osmocom.org/6861
bsc_api: drop unknown RR messages.
Radio Resource (RR) handling is entirely done inside the BSC. However,
the current implementation forwards unknown RR messages to the MSC.
This is not compliant to the specification.
- Remove the forwarding and drop
