Harald Welte has submitted this change and it was merged.
Change subject: RSL: Ensure we don't accept DCHAN messages for CCHAN
..
RSL: Ensure we don't accept DCHAN messages for CCHAN
If the Channel Number IE points to a common
Patch Set 1:
(1 comment)
https://gerrit.osmocom.org/#/c/6635/1/src/common/rsl.c
File src/common/rsl.c:
Line 139: static bool chan_nr_is_dchan(uint8_t chan_nr)
Why not to use a macros here?
#define CHAN_NR_IS_DCHAN(chan) \
(chan & 0x80)
--
To view, visit https://gerrit.osmocom.org/6635
Patch Set 1: Code-Review+2
(1 comment)
https://gerrit.osmocom.org/#/c/6635/1/src/common/rsl.c
File src/common/rsl.c:
Line 139: static bool chan_nr_is_dchan(uint8_t chan_nr)
> Why not to use a macros here?
what's wrong with a function? it gets inlined by the compiler anyway...
--
To view,
Review at https://gerrit.osmocom.org/6635
RSL: Ensure we don't accept DCHAN messages for CCHAN
If the Channel Number IE points to a common channel, we cannot
accept such messages in code paths that only process dedicated
channels, such as RLL/DCHAN/IPA.
Related: OS#2972, OS#2971
Change-Id:
