Patch Set 2: Code-Review+2
--
To view, visit https://gerrit.osmocom.org/6248
To unsubscribe, visit https://gerrit.osmocom.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I3fec7e4b337f3ea4d8cd79f4e7261babc34911cb
Gerrit-PatchSet: 2
Gerrit-Project: osmo-bts
Gerrit-Branch: master
Gerrit
Harald Welte has submitted this change and it was merged.
Change subject: Remove unused variables
..
Remove unused variables
Change-Id: I3fec7e4b337f3ea4d8cd79f4e7261babc34911cb
---
M src/common/l1sap.c
M src/osmo-bts-trx/l1_if
Hello Vadim Yanitskiy, Harald Welte, Jenkins Builder,
I'd like you to reexamine a change. Please visit
https://gerrit.osmocom.org/6248
to look at the new patch set (#2).
Remove unused variables
Change-Id: I3fec7e4b337f3ea4d8cd79f4e7261babc34911cb
---
M src/common/l1sap.c
M src/osmo-bts-tr
Patch Set 1:
(1 comment)
https://gerrit.osmocom.org/#/c/6248/1/src/common/rsl.c
File src/common/rsl.c:
Line 1251
> The Patch looks ok to me, but this line must stay. Its a fix for a nullpoin
Hey thanks for pointing it out, I think this change ended inside the patch
while playing with git rever
Patch Set 1: Code-Review-1
--
To view, visit https://gerrit.osmocom.org/6248
To unsubscribe, visit https://gerrit.osmocom.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I3fec7e4b337f3ea4d8cd79f4e7261babc34911cb
Gerrit-PatchSet: 1
Gerrit-Project: osmo-bts
Gerrit-Branch: master
Gerrit
Patch Set 1:
(1 comment)
> (1 comment)
https://gerrit.osmocom.org/#/c/6248/1/src/common/rsl.c
File src/common/rsl.c:
Line 1251
> This one was introduced recently by @dexter.
The Patch looks ok to me, but this line must stay. Its a fix for a nullpointer
deref. See also function rsl_tx_mode_mod
Patch Set 1: Code-Review-1
(1 comment)
https://gerrit.osmocom.org/#/c/6248/1/src/common/rsl.c
File src/common/rsl.c:
Line 1251
This one was introduced recently by @dexter.
Please see: https://gerrit.osmocom.org/#/c/6096/
Why is this considered as unused?
--
To view, visit https://gerrit.osm
Review at https://gerrit.osmocom.org/6248
Remove unused variables
Change-Id: I3fec7e4b337f3ea4d8cd79f4e7261babc34911cb
---
M src/common/l1sap.c
M src/common/rsl.c
M src/osmo-bts-trx/l1_if.c
3 files changed, 0 insertions(+), 6 deletions(-)
git pull ssh://gerrit.osmocom.org:29418/osmo-bts ref
