[MERGED] osmo-bts[master]: TRX: Use timerfd and CLOCK_MONOTONIC for GSM frame timer

2017-06-28 Thread Harald Welte
Harald Welte has submitted this change and it was merged. Change subject: TRX: Use timerfd and CLOCK_MONOTONIC for GSM frame timer .. TRX: Use timerfd and CLOCK_MONOTONIC for GSM frame timer using gettimeofday() is not

osmo-bts[master]: TRX: Use timerfd and CLOCK_MONOTONIC for GSM frame timer

2017-06-28 Thread Harald Welte
Patch Set 2: (1 comment) https://gerrit.osmocom.org/#/c/3037/2/src/osmo-bts-trx/scheduler_trx.c File src/osmo-bts-trx/scheduler_trx.c: Line 1473: if (elapsed_fn >= 135774) > where does this number comes from? I don't know, I just moved the code around. The original code did not contain

osmo-bts[master]: TRX: Use timerfd and CLOCK_MONOTONIC for GSM frame timer

2017-06-26 Thread Max
Patch Set 2: (1 comment) https://gerrit.osmocom.org/#/c/3037/2/src/osmo-bts-trx/scheduler_trx.c File src/osmo-bts-trx/scheduler_trx.c: Line 1473: if (elapsed_fn >= 135774) where does this number comes from? -- To view, visit https://gerrit.osmocom.org/3037 To unsubscribe, visit

osmo-bts[master]: TRX: Use timerfd and CLOCK_MONOTONIC for GSM frame timer

2017-06-25 Thread Vadim Yanitskiy
Patch Set 2: > let's say if osmo-gsm-tester at least doesn't get worse with this. Did you measured avarage clock jitter before and after this change? Does this change solve the problem with osmo-gsm-tester? -- To view, visit https://gerrit.osmocom.org/3037 To unsubscribe, visit

osmo-bts[master]: TRX: Use timerfd and CLOCK_MONOTONIC for GSM frame timer

2017-06-24 Thread Harald Welte
Patch Set 2: Code-Review+1 let's say if osmo-gsm-tester at least doesn't get worse with this. -- To view, visit https://gerrit.osmocom.org/3037 To unsubscribe, visit https://gerrit.osmocom.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I51b19adde14ebb7ef3bb863d45e06243c323e22e

[PATCH] osmo-bts[master]: TRX: Use timerfd and CLOCK_MONOTONIC for GSM frame timer

2017-06-24 Thread Harald Welte
Hello Jenkins Builder, I'd like you to reexamine a change. Please visit https://gerrit.osmocom.org/3037 to look at the new patch set (#2). TRX: Use timerfd and CLOCK_MONOTONIC for GSM frame timer using gettimeofday() is not suitable for the GSM frame timer, as it relies on the normal

osmo-bts[master]: TRX: Use timerfd and CLOCK_MONOTONIC for GSM frame timer

2017-06-24 Thread Harald Welte
Patch Set 1: Code-Review+1 let's wait for feedback from osmo-gsm-tester folks -- To view, visit https://gerrit.osmocom.org/3037 To unsubscribe, visit https://gerrit.osmocom.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I51b19adde14ebb7ef3bb863d45e06243c323e22e Gerrit-PatchSet: 1

[PATCH] osmo-bts[master]: TRX: Use timerfd and CLOCK_MONOTONIC for GSM frame timer

2017-06-24 Thread Harald Welte
Review at https://gerrit.osmocom.org/3037 TRX: Use timerfd and CLOCK_MONOTONIC for GSM frame timer using gettimeofday() is not suitable for the GSM frame timer, as it relies on the normal 'wall clock' system time, which may be adjusted by ntp, gps or other means at runtime. Switching to a