[MERGED] osmo-bts[master]: osmo-bts-trx: Fix reported frame number during PRIM_INFO_MEAS

2017-12-04 Thread Harald Welte
Harald Welte has submitted this change and it was merged. Change subject: osmo-bts-trx: Fix reported frame number during PRIM_INFO_MEAS .. osmo-bts-trx: Fix reported frame number during PRIM_INFO_MEAS The upper layers (L1SAP,

osmo-bts[master]: osmo-bts-trx: Fix reported frame number during PRIM_INFO_MEAS

2017-12-04 Thread Harald Welte
Patch Set 3: Verified+1 -- To view, visit https://gerrit.osmocom.org/5136 To unsubscribe, visit https://gerrit.osmocom.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I1065ae9c400bb5240a63ab8213aee59aeb9ceeff Gerrit-PatchSet: 3 Gerrit-Project: osmo-bts Gerrit-Branch: master

osmo-bts[master]: osmo-bts-trx: Fix reported frame number during PRIM_INFO_MEAS

2017-12-04 Thread Harald Welte
Patch Set 3: Code-Review+2 -- To view, visit https://gerrit.osmocom.org/5136 To unsubscribe, visit https://gerrit.osmocom.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I1065ae9c400bb5240a63ab8213aee59aeb9ceeff Gerrit-PatchSet: 3 Gerrit-Project: osmo-bts Gerrit-Branch: master

osmo-bts[master]: osmo-bts-trx: Fix reported frame number during PRIM_INFO_MEAS

2017-12-04 Thread dexter
Patch Set 3: Code-Review+1 > I don't have equipment right now to test this, but the code looks > good on the first glance. > > Just one comment - is this requirement of sending the first frame > number documented in the parameters of the relevant functions? That > would be great to have it

osmo-bts[master]: osmo-bts-trx: Fix reported frame number during PRIM_INFO_MEAS

2017-12-03 Thread Alexander Chemeris
Patch Set 3: Code-Review+1 I don't have equipment right now to test this, but the code looks good on the first glance. Just one comment - is this requirement of sending the first frame number documented in the parameters of the relevant functions? That would be great to have it there to

osmo-bts[master]: osmo-bts-trx: Fix reported frame number during PRIM_INFO_MEAS

2017-12-03 Thread Vadim Yanitskiy
Patch Set 3: Code-Review+1 -- To view, visit https://gerrit.osmocom.org/5136 To unsubscribe, visit https://gerrit.osmocom.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I1065ae9c400bb5240a63ab8213aee59aeb9ceeff Gerrit-PatchSet: 3 Gerrit-Project: osmo-bts Gerrit-Branch: master

osmo-bts[master]: osmo-bts-trx: Fix reported frame number during PRIM_INFO_MEAS

2017-12-03 Thread Harald Welte
Patch Set 3: Code-Review+1 -- To view, visit https://gerrit.osmocom.org/5136 To unsubscribe, visit https://gerrit.osmocom.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I1065ae9c400bb5240a63ab8213aee59aeb9ceeff Gerrit-PatchSet: 3 Gerrit-Project: osmo-bts Gerrit-Branch: master

[PATCH] osmo-bts[master]: osmo-bts-trx: Fix reported frame number during PRIM_INFO_MEAS

2017-12-03 Thread Harald Welte
Hello Jenkins Builder, I'd like you to reexamine a change. Please visit https://gerrit.osmocom.org/5136 to look at the new patch set (#3). osmo-bts-trx: Fix reported frame number during PRIM_INFO_MEAS The upper layers (L1SAP, the common part of L1) *always* require frame numbers in the

[PATCH] osmo-bts[master]: osmo-bts-trx: Fix reported frame number during PRIM_INFO_MEAS

2017-12-02 Thread Harald Welte
Review at https://gerrit.osmocom.org/5136 osmo-bts-trx: Fix reported frame number during PRIM_INFO_MEAS The upper layers (L1SAP, the common part of L1) *always* require frame numbers in the uplink direction to be reported as the frame number of the *first* burst, not the last burst of a given