[MERGED] osmo-ggsn[master]: ggsn.c: Fix byte order of IPCP IPv4 DNS servers

2017-12-05 Thread Harald Welte
Harald Welte has submitted this change and it was merged. Change subject: ggsn.c: Fix byte order of IPCP IPv4 DNS servers .. ggsn.c: Fix byte order of IPCP IPv4 DNS servers ... this probably didn't show up as 8.8.8.8 is

osmo-ggsn[master]: ggsn.c: Fix byte order of IPCP IPv4 DNS servers

2017-12-05 Thread Harald Welte
Patch Set 1: Code-Review+2 -- To view, visit https://gerrit.osmocom.org/5151 To unsubscribe, visit https://gerrit.osmocom.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ia4bcac5fcebfc24760432eb66be258a01d78f65f Gerrit-PatchSet: 1 Gerrit-Project: osmo-ggsn Gerrit-Branch: master

osmo-ggsn[master]: ggsn.c: Fix byte order of IPCP IPv4 DNS servers

2017-12-03 Thread Harald Welte
Patch Set 1: Code-Review+1 > I think lynxis saw this one last week yes, that' why I fixed it and I'm linking to the Osmocom redmine issue you created :) -- To view, visit https://gerrit.osmocom.org/5151 To unsubscribe, visit https://gerrit.osmocom.org/settings Gerrit-MessageType: comment

osmo-ggsn[master]: ggsn.c: Fix byte order of IPCP IPv4 DNS servers

2017-12-03 Thread Pau Espin Pedrol
Patch Set 1: I think lynxis saw this one last week -- To view, visit https://gerrit.osmocom.org/5151 To unsubscribe, visit https://gerrit.osmocom.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ia4bcac5fcebfc24760432eb66be258a01d78f65f Gerrit-PatchSet: 1 Gerrit-Project: osmo-ggsn

[PATCH] osmo-ggsn[master]: ggsn.c: Fix byte order of IPCP IPv4 DNS servers

2017-12-03 Thread Harald Welte
Review at https://gerrit.osmocom.org/5151 ggsn.c: Fix byte order of IPCP IPv4 DNS servers ... this probably didn't show up as 8.8.8.8 is dual-endian. doh! The address was already in network byte order, but msgb_put_u32 "of course" expects host byte order, ending up the wrong way in the actual