[MERGED] osmo-msc[master]: a_iface_bssap: compiler warning: cast const away from TLV va...

[Neels Hofmeyr]

Neels Hofmeyr has submitted this change and it was merged.

Change subject: a_iface_bssap: compiler warning: cast const away from TLV val 
for l2h
..


a_iface_bssap: compiler warning: cast const away from TLV val for l2h

Change-Id: Id91a4299391ff0d0e4e28ed05c2f755b9702146a
---
M src/libmsc/a_iface_bssap.c
1 file changed, 2 insertions(+), 2 deletions(-)

Approvals:
  Harald Welte: Looks good to me, approved
  Jenkins Builder: Verified



diff --git a/src/libmsc/a_iface_bssap.c b/src/libmsc/a_iface_bssap.c
index 922dca9..8a1e39b 100644
--- a/src/libmsc/a_iface_bssap.c
+++ b/src/libmsc/a_iface_bssap.c
@@ -325,7 +325,7 @@
 
/* Parse Layer 3 Information element */
/* FIXME: This is probably to hackish, compiler also complains 
"assignment discards ‘const’ qualifier..." */
-   msg->l3h = TLVP_VAL(, GSM0808_IE_LAYER_3_INFORMATION);
+   msg->l3h = (uint8_t*)TLVP_VAL(, GSM0808_IE_LAYER_3_INFORMATION);
msg->tail = msg->l3h + TLVP_LEN(, GSM0808_IE_LAYER_3_INFORMATION);
 
/* Create new subscriber context */
@@ -421,7 +421,7 @@
}
 
if (TLVP_PRESENT(, GSM0808_IE_LAYER_3_MESSAGE_CONTENTS)) {
-   msg->l3h = TLVP_VAL(, GSM0808_IE_LAYER_3_MESSAGE_CONTENTS);
+   msg->l3h = (uint8_t*)TLVP_VAL(, 
GSM0808_IE_LAYER_3_MESSAGE_CONTENTS);
msg->tail = msg->l3h + TLVP_LEN(, 
GSM0808_IE_LAYER_3_MESSAGE_CONTENTS);
} else {
msgb_free(msg);

-- 
To view, visit https://gerrit.osmocom.org/5472
To unsubscribe, visit https://gerrit.osmocom.org/settings

Gerrit-MessageType: merged
Gerrit-Change-Id: Id91a4299391ff0d0e4e28ed05c2f755b9702146a
Gerrit-PatchSet: 3
Gerrit-Project: osmo-msc
Gerrit-Branch: master
Gerrit-Owner: Neels Hofmeyr 
Gerrit-Reviewer: Harald Welte 
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: Neels Hofmeyr 
Gerrit-Reviewer: Pau Espin Pedrol 

osmo-msc[master]: a_iface_bssap: compiler warning: cast const away from TLV va...

[Harald Welte]

Patch Set 1: Code-Review+2

-- 
To view, visit https://gerrit.osmocom.org/5472
To unsubscribe, visit https://gerrit.osmocom.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Id91a4299391ff0d0e4e28ed05c2f755b9702146a
Gerrit-PatchSet: 1
Gerrit-Project: osmo-msc
Gerrit-Branch: master
Gerrit-Owner: Neels Hofmeyr 
Gerrit-Reviewer: Harald Welte 
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: Pau Espin Pedrol 
Gerrit-HasComments: No

osmo-msc[master]: a_iface_bssap: compiler warning: cast const away from TLV va...

[Pau Espin Pedrol]

Patch Set 1:

In case you didn't see it, I submitted related 
https://gerrit.osmocom.org/#/c/5424

-- 
To view, visit https://gerrit.osmocom.org/5472
To unsubscribe, visit https://gerrit.osmocom.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Id91a4299391ff0d0e4e28ed05c2f755b9702146a
Gerrit-PatchSet: 1
Gerrit-Project: osmo-msc
Gerrit-Branch: master
Gerrit-Owner: Neels Hofmeyr 
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: Pau Espin Pedrol 
Gerrit-HasComments: No