osmo-msc[master]: libmsc/ussd: implement basic USSD session management

2018-04-09 Thread Neels Hofmeyr
Patch Set 1: (1 comment) https://gerrit.osmocom.org/#/c/7699/1/tests/msc_vlr/msc_vlr_test_authen_reuse.err File tests/msc_vlr/msc_vlr_test_authen_reuse.err: Line 263: DCC (ti 08 sub MSISDN:42342 callref 0) New transaction > read above three log lines. the first two have incomplete or no

osmo-msc[master]: libmsc/ussd: implement basic USSD session management

2018-04-09 Thread Neels Hofmeyr
Patch Set 1: (1 comment) https://gerrit.osmocom.org/#/c/7699/1/src/libmsc/ussd.c File src/libmsc/ussd.c: Line 129: OSMO_ASSERT(session); > if we pass a NULL in here, osmo-msc would crash on the assert, taking down btw, I made the same mistake recently and you hit that in OS#3125 --

osmo-msc[master]: libmsc/ussd: implement basic USSD session management

2018-04-09 Thread Neels Hofmeyr
Patch Set 1: Code-Review-1 (15 comments) https://gerrit.osmocom.org/#/c/7699/1/include/osmocom/msc/ussd.h File include/osmocom/msc/ussd.h: Line 33:struct gsm_trans *trans; a gsm_trans always belongs to a conn. Do you really need a separate conn pointer? Can there be a valid

[PATCH] osmo-msc[master]: libmsc/ussd: implement basic USSD session management

2018-04-09 Thread Vadim Yanitskiy
Review at https://gerrit.osmocom.org/7699 libmsc/ussd: implement basic USSD session management During some long period, including the OpenBSC time, the USSD processing code was (and still is) pretty trivial, so there was no transaction management, nor connection reference counting. Meanwhile,