[MERGED] osmo-msc[master]: libmsc: Fix VTY output for handover counters.

[Neels Hofmeyr]

Neels Hofmeyr has submitted this change and it was merged.

Change subject: libmsc: Fix VTY output for handover counters.
..


libmsc: Fix VTY output for handover counters.

Handover countrs belong to BSC, but we mistakenly take values from MSC counters.

Change-Id: I9512330f2e91d2f526751c5228e6e8e0fe17d579
---
M src/libmsc/vty_interface_layer3.c
1 file changed, 5 insertions(+), 5 deletions(-)

Approvals:
  Neels Hofmeyr: Looks good to me, approved



diff --git a/src/libmsc/vty_interface_layer3.c 
b/src/libmsc/vty_interface_layer3.c
index d1bf6b3..1761ebc 100644
--- a/src/libmsc/vty_interface_layer3.c
+++ b/src/libmsc/vty_interface_layer3.c
@@ -570,11 +570,11 @@
VTY_NEWLINE);
vty_out(vty, "Handover: %lu attempted, %lu no_channel, 
%lu timeout, "
"%lu completed, %lu failed%s",
-   net->msc_ctrs->ctr[BSC_CTR_HANDOVER_ATTEMPTED].current,
-   net->msc_ctrs->ctr[BSC_CTR_HANDOVER_NO_CHANNEL].current,
-   net->msc_ctrs->ctr[BSC_CTR_HANDOVER_TIMEOUT].current,
-   net->msc_ctrs->ctr[BSC_CTR_HANDOVER_COMPLETED].current,
-   net->msc_ctrs->ctr[BSC_CTR_HANDOVER_FAILED].current,
+   net->bsc_ctrs->ctr[BSC_CTR_HANDOVER_ATTEMPTED].current,
+   net->bsc_ctrs->ctr[BSC_CTR_HANDOVER_NO_CHANNEL].current,
+   net->bsc_ctrs->ctr[BSC_CTR_HANDOVER_TIMEOUT].current,
+   net->bsc_ctrs->ctr[BSC_CTR_HANDOVER_COMPLETED].current,
+   net->bsc_ctrs->ctr[BSC_CTR_HANDOVER_FAILED].current,
VTY_NEWLINE);
vty_out(vty, "SMS MO  : %lu submitted, %lu no 
receiver%s",
net->msc_ctrs->ctr[MSC_CTR_SMS_SUBMITTED].current,

-- 
To view, visit https://gerrit.osmocom.org/3614
To unsubscribe, visit https://gerrit.osmocom.org/settings

Gerrit-MessageType: merged
Gerrit-Change-Id: I9512330f2e91d2f526751c5228e6e8e0fe17d579
Gerrit-PatchSet: 2
Gerrit-Project: osmo-msc
Gerrit-Branch: master
Gerrit-Owner: Neels Hofmeyr 
Gerrit-Reviewer: Alexander Chemeris 
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: Neels Hofmeyr 

osmo-msc[master]: libmsc: Fix VTY output for handover counters.

[Alexander Chemeris]

Patch Set 1:

I've received a ping about this patch, but I don't think I need to do anything 
here. Please let me know if you need anything

-- 
To view, visit https://gerrit.osmocom.org/3614
To unsubscribe, visit https://gerrit.osmocom.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I9512330f2e91d2f526751c5228e6e8e0fe17d579
Gerrit-PatchSet: 1
Gerrit-Project: osmo-msc
Gerrit-Branch: master
Gerrit-Owner: Neels Hofmeyr 
Gerrit-Reviewer: Alexander Chemeris 
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: Neels Hofmeyr 
Gerrit-HasComments: No

[PATCH] osmo-msc[master]: libmsc: Fix VTY output for handover counters.

[Neels Hofmeyr]

Review at  https://gerrit.osmocom.org/3614

libmsc: Fix VTY output for handover counters.

Handover countrs belong to BSC, but we mistakenly take values from MSC counters.

Change-Id: I9512330f2e91d2f526751c5228e6e8e0fe17d579
---
M src/libmsc/vty_interface_layer3.c
1 file changed, 5 insertions(+), 5 deletions(-)


  git pull ssh://gerrit.osmocom.org:29418/osmo-msc refs/changes/14/3614/1

diff --git a/src/libmsc/vty_interface_layer3.c 
b/src/libmsc/vty_interface_layer3.c
index d1bf6b3..1761ebc 100644
--- a/src/libmsc/vty_interface_layer3.c
+++ b/src/libmsc/vty_interface_layer3.c
@@ -570,11 +570,11 @@
VTY_NEWLINE);
vty_out(vty, "Handover: %lu attempted, %lu no_channel, 
%lu timeout, "
"%lu completed, %lu failed%s",
-   net->msc_ctrs->ctr[BSC_CTR_HANDOVER_ATTEMPTED].current,
-   net->msc_ctrs->ctr[BSC_CTR_HANDOVER_NO_CHANNEL].current,
-   net->msc_ctrs->ctr[BSC_CTR_HANDOVER_TIMEOUT].current,
-   net->msc_ctrs->ctr[BSC_CTR_HANDOVER_COMPLETED].current,
-   net->msc_ctrs->ctr[BSC_CTR_HANDOVER_FAILED].current,
+   net->bsc_ctrs->ctr[BSC_CTR_HANDOVER_ATTEMPTED].current,
+   net->bsc_ctrs->ctr[BSC_CTR_HANDOVER_NO_CHANNEL].current,
+   net->bsc_ctrs->ctr[BSC_CTR_HANDOVER_TIMEOUT].current,
+   net->bsc_ctrs->ctr[BSC_CTR_HANDOVER_COMPLETED].current,
+   net->bsc_ctrs->ctr[BSC_CTR_HANDOVER_FAILED].current,
VTY_NEWLINE);
vty_out(vty, "SMS MO  : %lu submitted, %lu no 
receiver%s",
net->msc_ctrs->ctr[MSC_CTR_SMS_SUBMITTED].current,

-- 
To view, visit https://gerrit.osmocom.org/3614
To unsubscribe, visit https://gerrit.osmocom.org/settings

Gerrit-MessageType: newchange
Gerrit-Change-Id: I9512330f2e91d2f526751c5228e6e8e0fe17d579
Gerrit-PatchSet: 1
Gerrit-Project: osmo-msc
Gerrit-Branch: master
Gerrit-Owner: Neels Hofmeyr 
Gerrit-Reviewer: Alexander Chemeris