[MERGED] osmo-msc[master]: msc_vlr_tests: fix rebuild: rebuild when src/ libs were rebuilt

2017-10-30 Thread Neels Hofmeyr
Neels Hofmeyr has submitted this change and it was merged. Change subject: msc_vlr_tests: fix rebuild: rebuild when src/ libs were rebuilt .. msc_vlr_tests: fix rebuild: rebuild when src/ libs were rebuilt Before this, a code

osmo-msc[master]: msc_vlr_tests: fix rebuild: rebuild when src/ libs were rebuilt

2017-10-30 Thread Harald Welte
Patch Set 2: Code-Review+2 -- To view, visit https://gerrit.osmocom.org/4551 To unsubscribe, visit https://gerrit.osmocom.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Icbdedc1581fa23abe9ed99cef3918592b25f30b3 Gerrit-PatchSet: 2 Gerrit-Project: osmo-msc Gerrit-Branch: master

[PATCH] osmo-msc[master]: msc_vlr_tests: fix rebuild: rebuild when src/ libs were rebuilt

2017-10-29 Thread Neels Hofmeyr
Hello Jenkins Builder, I'd like you to reexamine a change. Please visit https://gerrit.osmocom.org/4551 to look at the new patch set (#2). msc_vlr_tests: fix rebuild: rebuild when src/ libs were rebuilt Before this, a code change in libvlr or libmsc would not cause a rebuild of the

osmo-msc[master]: msc_vlr_tests: fix rebuild: rebuild when src/ libs were rebuilt

2017-10-29 Thread Neels Hofmeyr
Patch Set 1: (1 comment) https://gerrit.osmocom.org/#/c/4551/1/tests/msc_vlr/Makefile.am File tests/msc_vlr/Makefile.am: Line 135: $(top_builddir)/src/libmsc/libmsc.a \ > shouldn't dis work automatically? Would it work if we had those libraries i ah, that makes a lot of sense. Apparently

osmo-msc[master]: msc_vlr_tests: fix rebuild: rebuild when src/ libs were rebuilt

2017-10-29 Thread Harald Welte
Patch Set 1: (1 comment) https://gerrit.osmocom.org/#/c/4551/1/tests/msc_vlr/Makefile.am File tests/msc_vlr/Makefile.am: Line 135: $(top_builddir)/src/libmsc/libmsc.a \ shouldn't dis work automatically? Would it work if we had those libraries in LDADD rather than LDFLAGS above? -- To

[PATCH] osmo-msc[master]: msc_vlr_tests: fix rebuild: rebuild when src/ libs were rebuilt

2017-10-28 Thread Neels Hofmeyr
Review at https://gerrit.osmocom.org/4551 msc_vlr_tests: fix rebuild: rebuild when src/ libs were rebuilt Before this, a code change in libvlr or libmsc would not cause a rebuild of the tests. Change-Id: Icbdedc1581fa23abe9ed99cef3918592b25f30b3 --- M tests/msc_vlr/Makefile.am 1 file changed,