[MERGED] osmo-msc[master]: vty: add 'subscriber ... paging' cmd

[Harald Welte]

Harald Welte has submitted this change and it was merged.

Change subject: vty: add 'subscriber ... paging' cmd
..


vty: add 'subscriber ... paging' cmd

Allow issuing an empty paging from the VTY, for debugging purposes.

Change-Id: I403904cb789ece699f14b4cbd52c336eb02d45e4
---
M src/libmsc/vty_interface_layer3.c
1 file changed, 26 insertions(+), 0 deletions(-)

Approvals:
  Harald Welte: Looks good to me, approved
  Jenkins Builder: Verified



diff --git a/src/libmsc/vty_interface_layer3.c 
b/src/libmsc/vty_interface_layer3.c
index 6def359..06a4267 100644
--- a/src/libmsc/vty_interface_layer3.c
+++ b/src/libmsc/vty_interface_layer3.c
@@ -608,6 +608,31 @@
return CMD_SUCCESS;
 }
 
+DEFUN(subscriber_paging,
+  subscriber_paging_cmd,
+  "subscriber " SUBSCR_TYPES " ID paging",
+  SUBSCR_HELP "Issue an empty Paging for the subscriber (for debugging)\n")
+{
+   struct gsm_network *gsmnet = gsmnet_from_vty(vty);
+   struct vlr_subscr *vsub = get_vsub_by_argv(gsmnet, argv[0], argv[1]);
+   struct subscr_request *req;
+
+   if (!vsub) {
+   vty_out(vty, "%% No subscriber found for %s %s%s",
+   argv[0], argv[1], VTY_NEWLINE);
+   return CMD_WARNING;
+   }
+
+   req = subscr_request_conn(vsub, NULL, NULL, "manual Paging from VTY");
+   if (req)
+   vty_out(vty, "%% paging subscriber%s", VTY_NEWLINE);
+   else
+   vty_out(vty, "%% paging subscriber failed%s", VTY_NEWLINE);
+
+   vlr_subscr_put(vsub);
+   return req ? CMD_SUCCESS : CMD_WARNING;
+}
+
 static int loop_by_char(uint8_t ch)
 {
switch (ch) {
@@ -992,6 +1017,7 @@
install_element_ve(_ussd_notify_cmd);
install_element_ve(_mstest_close_cmd);
install_element_ve(_mstest_open_cmd);
+   install_element_ve(_paging_cmd);
install_element_ve(_stats_cmd);
install_element_ve(_smsqueue_cmd);
install_element_ve(_fltr_imsi_cmd);

-- 
To view, visit https://gerrit.osmocom.org/7179
To unsubscribe, visit https://gerrit.osmocom.org/settings

Gerrit-MessageType: merged
Gerrit-Change-Id: I403904cb789ece699f14b4cbd52c336eb02d45e4
Gerrit-PatchSet: 2
Gerrit-Project: osmo-msc
Gerrit-Branch: master
Gerrit-Owner: Neels Hofmeyr 
Gerrit-Reviewer: Harald Welte 
Gerrit-Reviewer: Jenkins Builder

osmo-msc[master]: vty: add 'subscriber ... paging' cmd

[Harald Welte]

Patch Set 2: Code-Review+2

-- 
To view, visit https://gerrit.osmocom.org/7179
To unsubscribe, visit https://gerrit.osmocom.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I403904cb789ece699f14b4cbd52c336eb02d45e4
Gerrit-PatchSet: 2
Gerrit-Project: osmo-msc
Gerrit-Branch: master
Gerrit-Owner: Neels Hofmeyr 
Gerrit-Reviewer: Harald Welte 
Gerrit-Reviewer: Jenkins Builder
Gerrit-HasComments: No

[PATCH] osmo-msc[master]: vty: add 'subscriber ... paging' cmd

[Neels Hofmeyr]

Review at  https://gerrit.osmocom.org/7179

vty: add 'subscriber ... paging' cmd

Allow issuing an empty paging from the VTY, for debugging purposes.

Change-Id: I403904cb789ece699f14b4cbd52c336eb02d45e4
---
M src/libmsc/vty_interface_layer3.c
1 file changed, 26 insertions(+), 0 deletions(-)


  git pull ssh://gerrit.osmocom.org:29418/osmo-msc refs/changes/79/7179/1

diff --git a/src/libmsc/vty_interface_layer3.c 
b/src/libmsc/vty_interface_layer3.c
index 6def359..06a4267 100644
--- a/src/libmsc/vty_interface_layer3.c
+++ b/src/libmsc/vty_interface_layer3.c
@@ -608,6 +608,31 @@
return CMD_SUCCESS;
 }
 
+DEFUN(subscriber_paging,
+  subscriber_paging_cmd,
+  "subscriber " SUBSCR_TYPES " ID paging",
+  SUBSCR_HELP "Issue an empty Paging for the subscriber (for debugging)\n")
+{
+   struct gsm_network *gsmnet = gsmnet_from_vty(vty);
+   struct vlr_subscr *vsub = get_vsub_by_argv(gsmnet, argv[0], argv[1]);
+   struct subscr_request *req;
+
+   if (!vsub) {
+   vty_out(vty, "%% No subscriber found for %s %s%s",
+   argv[0], argv[1], VTY_NEWLINE);
+   return CMD_WARNING;
+   }
+
+   req = subscr_request_conn(vsub, NULL, NULL, "manual Paging from VTY");
+   if (req)
+   vty_out(vty, "%% paging subscriber%s", VTY_NEWLINE);
+   else
+   vty_out(vty, "%% paging subscriber failed%s", VTY_NEWLINE);
+
+   vlr_subscr_put(vsub);
+   return req ? CMD_SUCCESS : CMD_WARNING;
+}
+
 static int loop_by_char(uint8_t ch)
 {
switch (ch) {
@@ -992,6 +1017,7 @@
install_element_ve(_ussd_notify_cmd);
install_element_ve(_mstest_close_cmd);
install_element_ve(_mstest_open_cmd);
+   install_element_ve(_paging_cmd);
install_element_ve(_stats_cmd);
install_element_ve(_smsqueue_cmd);
install_element_ve(_fltr_imsi_cmd);

-- 
To view, visit https://gerrit.osmocom.org/7179
To unsubscribe, visit https://gerrit.osmocom.org/settings

Gerrit-MessageType: newchange
Gerrit-Change-Id: I403904cb789ece699f14b4cbd52c336eb02d45e4
Gerrit-PatchSet: 1
Gerrit-Project: osmo-msc
Gerrit-Branch: master
Gerrit-Owner: Neels Hofmeyr