[MERGED] osmo-msc[master]: vty: drop unused commands

2018-03-10 Thread Harald Welte
Harald Welte has submitted this change and it was merged.

Change subject: vty: drop unused commands
..


vty: drop unused commands

Change-Id: I76d6777ebe9105b8abf37993b86c3749a7e18008
---
M src/libmsc/vty_interface_layer3.c
1 file changed, 0 insertions(+), 30 deletions(-)

Approvals:
  Harald Welte: Looks good to me, approved
  Jenkins Builder: Verified



diff --git a/src/libmsc/vty_interface_layer3.c 
b/src/libmsc/vty_interface_layer3.c
index 6ed2ade..b0243c3 100644
--- a/src/libmsc/vty_interface_layer3.c
+++ b/src/libmsc/vty_interface_layer3.c
@@ -726,34 +726,6 @@
return CMD_SUCCESS;
 }
 
-#define A3A8_ALG_TYPES "(none|xor|comp128v1)"
-#define A3A8_ALG_HELP  \
-   "Use No A3A8 algorithm\n"   \
-   "Use XOR algorithm\n"   \
-   "Use COMP128v1 algorithm\n"
-
-DEFUN(ena_subscr_a3a8,
-  ena_subscr_a3a8_cmd,
-  "subscriber " SUBSCR_TYPES " ID a3a8 " A3A8_ALG_TYPES " [KI]",
-  SUBSCR_HELP "Set a3a8 parameters for the subscriber\n"
-  A3A8_ALG_HELP "Encryption Key Ki\n")
-{
-   vty_out(vty, "%% 'subscriber a3a8' is no longer supported.%s"
-   "%% This is now up to osmo-hlr.%s",
-   VTY_NEWLINE, VTY_NEWLINE);
-   return CMD_WARNING;
-}
-
-DEFUN(subscriber_update,
-  subscriber_update_cmd,
-  "subscriber " SUBSCR_TYPES " ID update",
-  SUBSCR_HELP "Update the subscriber data from the dabase.\n")
-{
-   vty_out(vty, "%% 'subscriber update' is no longer supported.%s",
-   VTY_NEWLINE);
-   return CMD_WARNING;
-}
-
 static int scall_cbfn(unsigned int subsys, unsigned int signal,
void *handler_data, void *signal_data)
 {
@@ -1019,13 +991,11 @@
install_element_ve(_ussd_notify_cmd);
install_element_ve(_mstest_close_cmd);
install_element_ve(_mstest_open_cmd);
-   install_element_ve(_update_cmd);
install_element_ve(_stats_cmd);
install_element_ve(_smsqueue_cmd);
install_element_ve(_fltr_imsi_cmd);
 
install_element(ENABLE_NODE, _subscr_expire_cmd);
-   install_element(ENABLE_NODE, _subscr_a3a8_cmd);
install_element(ENABLE_NODE, _trigger_cmd);
install_element(ENABLE_NODE, _max_cmd);
install_element(ENABLE_NODE, _clear_cmd);

-- 
To view, visit https://gerrit.osmocom.org/7177
To unsubscribe, visit https://gerrit.osmocom.org/settings

Gerrit-MessageType: merged
Gerrit-Change-Id: I76d6777ebe9105b8abf37993b86c3749a7e18008
Gerrit-PatchSet: 2
Gerrit-Project: osmo-msc
Gerrit-Branch: master
Gerrit-Owner: Neels Hofmeyr 
Gerrit-Reviewer: Harald Welte 
Gerrit-Reviewer: Jenkins Builder


osmo-msc[master]: vty: drop unused commands

2018-03-10 Thread Harald Welte

Patch Set 2: Code-Review+2

-- 
To view, visit https://gerrit.osmocom.org/7177
To unsubscribe, visit https://gerrit.osmocom.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I76d6777ebe9105b8abf37993b86c3749a7e18008
Gerrit-PatchSet: 2
Gerrit-Project: osmo-msc
Gerrit-Branch: master
Gerrit-Owner: Neels Hofmeyr 
Gerrit-Reviewer: Harald Welte 
Gerrit-Reviewer: Jenkins Builder
Gerrit-HasComments: No


[PATCH] osmo-msc[master]: vty: drop unused commands

2018-03-09 Thread Neels Hofmeyr

Review at  https://gerrit.osmocom.org/7177

vty: drop unused commands

Change-Id: I76d6777ebe9105b8abf37993b86c3749a7e18008
---
M src/libmsc/vty_interface_layer3.c
1 file changed, 0 insertions(+), 30 deletions(-)


  git pull ssh://gerrit.osmocom.org:29418/osmo-msc refs/changes/77/7177/1

diff --git a/src/libmsc/vty_interface_layer3.c 
b/src/libmsc/vty_interface_layer3.c
index 6ed2ade..b0243c3 100644
--- a/src/libmsc/vty_interface_layer3.c
+++ b/src/libmsc/vty_interface_layer3.c
@@ -726,34 +726,6 @@
return CMD_SUCCESS;
 }
 
-#define A3A8_ALG_TYPES "(none|xor|comp128v1)"
-#define A3A8_ALG_HELP  \
-   "Use No A3A8 algorithm\n"   \
-   "Use XOR algorithm\n"   \
-   "Use COMP128v1 algorithm\n"
-
-DEFUN(ena_subscr_a3a8,
-  ena_subscr_a3a8_cmd,
-  "subscriber " SUBSCR_TYPES " ID a3a8 " A3A8_ALG_TYPES " [KI]",
-  SUBSCR_HELP "Set a3a8 parameters for the subscriber\n"
-  A3A8_ALG_HELP "Encryption Key Ki\n")
-{
-   vty_out(vty, "%% 'subscriber a3a8' is no longer supported.%s"
-   "%% This is now up to osmo-hlr.%s",
-   VTY_NEWLINE, VTY_NEWLINE);
-   return CMD_WARNING;
-}
-
-DEFUN(subscriber_update,
-  subscriber_update_cmd,
-  "subscriber " SUBSCR_TYPES " ID update",
-  SUBSCR_HELP "Update the subscriber data from the dabase.\n")
-{
-   vty_out(vty, "%% 'subscriber update' is no longer supported.%s",
-   VTY_NEWLINE);
-   return CMD_WARNING;
-}
-
 static int scall_cbfn(unsigned int subsys, unsigned int signal,
void *handler_data, void *signal_data)
 {
@@ -1019,13 +991,11 @@
install_element_ve(_ussd_notify_cmd);
install_element_ve(_mstest_close_cmd);
install_element_ve(_mstest_open_cmd);
-   install_element_ve(_update_cmd);
install_element_ve(_stats_cmd);
install_element_ve(_smsqueue_cmd);
install_element_ve(_fltr_imsi_cmd);
 
install_element(ENABLE_NODE, _subscr_expire_cmd);
-   install_element(ENABLE_NODE, _subscr_a3a8_cmd);
install_element(ENABLE_NODE, _trigger_cmd);
install_element(ENABLE_NODE, _max_cmd);
install_element(ENABLE_NODE, _clear_cmd);

-- 
To view, visit https://gerrit.osmocom.org/7177
To unsubscribe, visit https://gerrit.osmocom.org/settings

Gerrit-MessageType: newchange
Gerrit-Change-Id: I76d6777ebe9105b8abf37993b86c3749a7e18008
Gerrit-PatchSet: 1
Gerrit-Project: osmo-msc
Gerrit-Branch: master
Gerrit-Owner: Neels Hofmeyr