Harald Welte has submitted this change and it was merged.
Change subject: TBF: cleanup state flag handling
..
TBF: cleanup state flag handling
* introduce generic function to check whether particular flag was set
for'a TBF
Patch Set 5: Code-Review+2
--
To view, visit https://gerrit.osmocom.org/5367
To unsubscribe, visit https://gerrit.osmocom.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: Ic4560280c72f91700f2e19c6c7f6658dc29625c2
Gerrit-PatchSet: 5
Gerrit-Project: osmo-pcu
Gerrit-Branch: master
Gerrit
Patch Set 5: Code-Review+1
--
To view, visit https://gerrit.osmocom.org/5367
To unsubscribe, visit https://gerrit.osmocom.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: Ic4560280c72f91700f2e19c6c7f6658dc29625c2
Gerrit-PatchSet: 5
Gerrit-Project: osmo-pcu
Gerrit-Branch: master
Gerrit
Patch Set 4:
Right, thanks for review.
--
To view, visit https://gerrit.osmocom.org/5367
To unsubscribe, visit https://gerrit.osmocom.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: Ic4560280c72f91700f2e19c6c7f6658dc29625c2
Gerrit-PatchSet: 4
Gerrit-Project: osmo-pcu
Gerrit-Branch:
Hello Jenkins Builder,
I'd like you to reexamine a change. Please visit
https://gerrit.osmocom.org/5367
to look at the new patch set (#5).
TBF: cleanup state flag handling
* introduce generic function to check whether particular flag was set
for'a TBF and clear it if necessary. Use th
Patch Set 4:
(1 comment)
https://gerrit.osmocom.org/#/c/5367/4/src/bts.cpp
File src/bts.cpp:
Line 1039: new_tbf->state_flags &= ~(1 <<
GPRS_RLCMAC_FLAG_CCCH);
We could remove this line as well, couldn't we? The flag is already cleared by
check_n_clear if we enter this if-
Hello Jenkins Builder,
I'd like you to reexamine a change. Please visit
https://gerrit.osmocom.org/5367
to look at the new patch set (#4).
TBF: cleanup state flag handling
* introduce generic function to check whether particular flag was set
for'a TBF and clear it if necessary. Use th
Hello Jenkins Builder,
I'd like you to reexamine a change. Please visit
https://gerrit.osmocom.org/5367
to look at the new patch set (#3).
TBF: cleanup state flag handling
* introduce generic function to check whether particular flag was set
for'a TBF and clear it if necessary. Use th
Hello Jenkins Builder,
I'd like you to reexamine a change. Please visit
https://gerrit.osmocom.org/5367
to look at the new patch set (#2).
TBF: cleanup state flag handling
* introduce generic function to check whether particular flag was set
for'a TBF and clear it if necessary. Use th
Review at https://gerrit.osmocom.org/5367
TBF: cleanup state flag handling
* introduce generic function to check whether particular flag was set
for'a TBF and clear it if necessary. Use this instead of
clear_poll_timeout_flag()
* add function to explicitly set assignment and appropriate
10 matches
Mail list logo