Patch Set 2:
> (2 comments)
The "yes" means. This part of the patch is good. And the second part is that
debian will extract the library dependencies from binaries and then will
look-up which installed package provides them and will then add them to the
depends. This is done with the
Patch Set 2:
(2 comments)
https://gerrit.osmocom.org/#/c/3079/2/debian/control
File debian/control:
Line 8
> yes
Could you elaborate? It's much easier to follow up on feedback which consists
of entire sentences.
Line 22: Depends: ${shlibs:Depends}, ${misc:Depends}, libsqlite3-0
> That is
Patch Set 2:
(2 comments)
So a -1 from me.
https://gerrit.osmocom.org/#/c/3079/2/debian/control
File debian/control:
Line 8
yes
Line 22: Depends: ${shlibs:Depends}, ${misc:Depends}, libsqlite3-0
That is wrong. ${shlibs:Depends} will add dependencies for all libraries linked
against.. e.g.
Max has submitted this change and it was merged.
Change subject: deb: remove unused dependency
..
deb: remove unused dependency
The libdbd dependency is not used because libsqlite3 is used directly -
adjust debian/control to
Patch Set 1: Code-Review+2
--
To view, visit https://gerrit.osmocom.org/3079
To unsubscribe, visit https://gerrit.osmocom.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: Id2ab1facad703fa0c1d45084e70d41e73dbad6e7
Gerrit-PatchSet: 1
Gerrit-Project: osmo-trx
Gerrit-Branch: master
Patch Set 1: Code-Review+1
--
To view, visit https://gerrit.osmocom.org/3079
To unsubscribe, visit https://gerrit.osmocom.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: Id2ab1facad703fa0c1d45084e70d41e73dbad6e7
Gerrit-PatchSet: 1
Gerrit-Project: osmo-trx
Gerrit-Branch: master
Review at https://gerrit.osmocom.org/3079
deb: remove unused dependency
The libdbd dependency is not used because libsqlite3 is used directly -
adjust debian/control to match.
Change-Id: Id2ab1facad703fa0c1d45084e70d41e73dbad6e7
Related: OS#1929
---
M debian/control
1 file changed, 1
