[MERGED] osmo-trx[master]: debian: remove obsolete dependency
Tom Tsou has submitted this change and it was merged. Change subject: debian: remove obsolete dependency .. debian: remove obsolete dependency This should fix package build for Ubuntu 17.04: obsolete package hardening-wrapper was removed which cause .deb build failure. The dependency on it is incorrect to begin with because we use DEB_BUILD_MAINT_OPTIONS instead. Change-Id: I3ea72b4123a280a846086d083c4f3189d611f8cf --- M debian/control 1 file changed, 0 insertions(+), 1 deletion(-) Approvals: Tom Tsou: Looks good to me, approved Harald Welte: Looks good to me, but someone else must approve Jenkins Builder: Verified diff --git a/debian/control b/debian/control index 151aa92..0e3b714 100644 --- a/debian/control +++ b/debian/control @@ -12,7 +12,6 @@ libuhd-dev, libusb-1.0-0-dev, libboost-all-dev, - hardening-wrapper, libfftw3-dev Standards-Version: 3.9.6 Vcs-Browser: http://cgit.osmocom.org/osmo-trx -- To view, visit https://gerrit.osmocom.org/2400 To unsubscribe, visit https://gerrit.osmocom.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I3ea72b4123a280a846086d083c4f3189d611f8cf Gerrit-PatchSet: 4 Gerrit-Project: osmo-trx Gerrit-Branch: master Gerrit-Owner: MaxGerrit-Reviewer: Alexander Chemeris Gerrit-Reviewer: Harald Welte Gerrit-Reviewer: Holger Freyther Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: Tom Tsou Gerrit-Reviewer: neels
osmo-trx[master]: debian: remove obsolete dependency
Patch Set 3: Code-Review+2 -- To view, visit https://gerrit.osmocom.org/2400 To unsubscribe, visit https://gerrit.osmocom.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I3ea72b4123a280a846086d083c4f3189d611f8cf Gerrit-PatchSet: 3 Gerrit-Project: osmo-trx Gerrit-Branch: master Gerrit-Owner: MaxGerrit-Reviewer: Alexander Chemeris Gerrit-Reviewer: Harald Welte Gerrit-Reviewer: Holger Freyther Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: Tom Tsou Gerrit-Reviewer: neels Gerrit-HasComments: No
osmo-trx[master]: debian: remove obsolete dependency
Patch Set 3: Code-Review+1 -- To view, visit https://gerrit.osmocom.org/2400 To unsubscribe, visit https://gerrit.osmocom.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I3ea72b4123a280a846086d083c4f3189d611f8cf Gerrit-PatchSet: 3 Gerrit-Project: osmo-trx Gerrit-Branch: master Gerrit-Owner: MaxGerrit-Reviewer: Alexander Chemeris Gerrit-Reviewer: Harald Welte Gerrit-Reviewer: Holger Freyther Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: Tom Tsou Gerrit-Reviewer: neels Gerrit-HasComments: No
[PATCH] osmo-trx[master]: debian: remove obsolete dependency
Hello Harald Welte, Jenkins Builder, Holger Freyther, I'd like you to reexamine a change. Please visit https://gerrit.osmocom.org/2400 to look at the new patch set (#3). debian: remove obsolete dependency This should fix package build for Ubuntu 17.04: obsolete package hardening-wrapper was removed which cause .deb build failure. The dependency on it is incorrect to begin with because we use DEB_BUILD_MAINT_OPTIONS instead. Change-Id: I3ea72b4123a280a846086d083c4f3189d611f8cf --- M debian/control 1 file changed, 0 insertions(+), 1 deletion(-) git pull ssh://gerrit.osmocom.org:29418/osmo-trx refs/changes/00/2400/3 diff --git a/debian/control b/debian/control index 151aa92..0e3b714 100644 --- a/debian/control +++ b/debian/control @@ -12,7 +12,6 @@ libuhd-dev, libusb-1.0-0-dev, libboost-all-dev, - hardening-wrapper, libfftw3-dev Standards-Version: 3.9.6 Vcs-Browser: http://cgit.osmocom.org/osmo-trx -- To view, visit https://gerrit.osmocom.org/2400 To unsubscribe, visit https://gerrit.osmocom.org/settings Gerrit-MessageType: newpatchset Gerrit-Change-Id: I3ea72b4123a280a846086d083c4f3189d611f8cf Gerrit-PatchSet: 3 Gerrit-Project: osmo-trx Gerrit-Branch: master Gerrit-Owner: MaxGerrit-Reviewer: Alexander Chemeris Gerrit-Reviewer: Harald Welte Gerrit-Reviewer: Holger Freyther Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: Tom Tsou Gerrit-Reviewer: neels
osmo-trx[master]: debian: remove obsolete dependency
Patch Set 2: Code-Review+1 In two years we won't know what "latest Ubuntu" is. Always better to put a version number in there. Stretch won't have it either. -- To view, visit https://gerrit.osmocom.org/2400 To unsubscribe, visit https://gerrit.osmocom.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I3ea72b4123a280a846086d083c4f3189d611f8cf Gerrit-PatchSet: 2 Gerrit-Project: osmo-trx Gerrit-Branch: master Gerrit-Owner: MaxGerrit-Reviewer: Alexander Chemeris Gerrit-Reviewer: Harald Welte Gerrit-Reviewer: Holger Freyther Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: Tom Tsou Gerrit-Reviewer: neels Gerrit-HasComments: No
osmo-trx[master]: debian: remove obsolete dependency
Patch Set 2: Max, please could you explain why is this required? What kind of build issues are you seeing? Would be nice to have at least a short version of this in the commit message with a potentially longer explanation in the comments here. -- To view, visit https://gerrit.osmocom.org/2400 To unsubscribe, visit https://gerrit.osmocom.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I3ea72b4123a280a846086d083c4f3189d611f8cf Gerrit-PatchSet: 2 Gerrit-Project: osmo-trx Gerrit-Branch: master Gerrit-Owner: MaxGerrit-Reviewer: Alexander Chemeris Gerrit-Reviewer: Harald Welte Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: Tom Tsou Gerrit-Reviewer: neels Gerrit-HasComments: No
[PATCH] osmo-trx[master]: debian: remove obsolete dependency
Hello Harald Welte, Jenkins Builder, I'd like you to reexamine a change. Please visit https://gerrit.osmocom.org/2400 to look at the new patch set (#2). debian: remove obsolete dependency This should fix package build for latest Ubuntu. Change-Id: I3ea72b4123a280a846086d083c4f3189d611f8cf --- M debian/control 1 file changed, 0 insertions(+), 1 deletion(-) git pull ssh://gerrit.osmocom.org:29418/osmo-trx refs/changes/00/2400/2 diff --git a/debian/control b/debian/control index 151aa92..0e3b714 100644 --- a/debian/control +++ b/debian/control @@ -12,7 +12,6 @@ libuhd-dev, libusb-1.0-0-dev, libboost-all-dev, - hardening-wrapper, libfftw3-dev Standards-Version: 3.9.6 Vcs-Browser: http://cgit.osmocom.org/osmo-trx -- To view, visit https://gerrit.osmocom.org/2400 To unsubscribe, visit https://gerrit.osmocom.org/settings Gerrit-MessageType: newpatchset Gerrit-Change-Id: I3ea72b4123a280a846086d083c4f3189d611f8cf Gerrit-PatchSet: 2 Gerrit-Project: osmo-trx Gerrit-Branch: master Gerrit-Owner: MaxGerrit-Reviewer: Harald Welte Gerrit-Reviewer: Jenkins Builder
osmo-trx[master]: debian: remove obsolete dependency
Patch Set 1: Code-Review+1 -- To view, visit https://gerrit.osmocom.org/2400 To unsubscribe, visit https://gerrit.osmocom.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I3ea72b4123a280a846086d083c4f3189d611f8cf Gerrit-PatchSet: 1 Gerrit-Project: osmo-trx Gerrit-Branch: master Gerrit-Owner: MaxGerrit-Reviewer: Harald Welte Gerrit-Reviewer: Jenkins Builder Gerrit-HasComments: No
[PATCH] osmo-trx[master]: debian: remove obsolete dependency
Review at https://gerrit.osmocom.org/2400 debian: remove obsolete dependency Change-Id: I3ea72b4123a280a846086d083c4f3189d611f8cf --- M debian/control 1 file changed, 0 insertions(+), 1 deletion(-) git pull ssh://gerrit.osmocom.org:29418/osmo-trx refs/changes/00/2400/1 diff --git a/debian/control b/debian/control index 151aa92..0e3b714 100644 --- a/debian/control +++ b/debian/control @@ -12,7 +12,6 @@ libuhd-dev, libusb-1.0-0-dev, libboost-all-dev, - hardening-wrapper, libfftw3-dev Standards-Version: 3.9.6 Vcs-Browser: http://cgit.osmocom.org/osmo-trx -- To view, visit https://gerrit.osmocom.org/2400 To unsubscribe, visit https://gerrit.osmocom.org/settings Gerrit-MessageType: newchange Gerrit-Change-Id: I3ea72b4123a280a846086d083c4f3189d611f8cf Gerrit-PatchSet: 1 Gerrit-Project: osmo-trx Gerrit-Branch: master Gerrit-Owner: Max