Patch Set 2: Code-Review+2
--
To view, visit https://gerrit.osmocom.org/2762
To unsubscribe, visit https://gerrit.osmocom.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I0377029556c8b681b3ba3b635bf19572b34546ea
Gerrit-PatchSet: 2
Gerrit-Project: osmo-trx
Gerrit-Branch: master
Tom Tsou has submitted this change and it was merged.
Change subject: sigProcLib: Fix number of tail bits in random Normal Bursts and
zero Stealing Bits.
..
sigProcLib: Fix number of tail bits in random Normal Bursts and zero
Patch Set 2: Code-Review+1
--
To view, visit https://gerrit.osmocom.org/2762
To unsubscribe, visit https://gerrit.osmocom.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I0377029556c8b681b3ba3b635bf19572b34546ea
Gerrit-PatchSet: 2
Gerrit-Project: osmo-trx
Gerrit-Branch: master
Patch Set 2:
> Yes, I learned this "the hard way". My point is: The commit message
> should clearly state that this is only for generation of random
> test bursts and not a general bug in actual TRX code.
Ok, I've updated the commit message to make it more obvious.
--
To view, visit
Hello Jenkins Builder,
I'd like you to reexamine a change. Please visit
https://gerrit.osmocom.org/2762
to look at the new patch set (#2).
sigProcLib: Fix number of tail bits in random Normal Bursts and zero Stealing
Bits.
This bug only affects generation of normal bursts filled with
Patch Set 1:
Yes, I learned this "the hard way". My point is: The commit message should
clearly state that this is only for generation of random test bursts and not a
general bug in actual TRX code.
--
To view, visit https://gerrit.osmocom.org/2762
To unsubscribe, visit
Patch Set 1:
Harald, this function is used only when we generate bursts locally at osmo-trx,
which is currently only used for generation of test random bursts.
--
To view, visit https://gerrit.osmocom.org/2762
To unsubscribe, visit https://gerrit.osmocom.org/settings
Gerrit-MessageType:
Patch Set 1:
nothing in the commit message indicates that this is about gneration of a
random burst only. It reads almost like it adresses normal(non-random) bursts?
--
To view, visit https://gerrit.osmocom.org/2762
To unsubscribe, visit https://gerrit.osmocom.org/settings
