Alexander Chemeris has submitted this change and it was merged.
Change subject: sigProcLib: make energyDetect() simpler by returning actual
energy.
..
sigProcLib: make energyDetect() simpler by returning actual energy.
Patch Set 2: Code-Review+2
(2 comments)
https://gerrit.osmocom.org/#/c/2136/1/Transceiver52M/Transceiver.cpp
File Transceiver52M/Transceiver.cpp:
Line 609: float toa, max = -1.0, avg = 0.0;
> Is there good reason not to move it? I prefer the moved declaration.
Done
Line 609: float toa,
Hello Max, Jenkins Builder,
I'd like you to reexamine a change. Please visit
https://gerrit.osmocom.org/2136
to look at the new patch set (#2).
sigProcLib: make energyDetect() simpler by returning actual energy.
Change-Id: I9bf97f2dc03fea9bebcf43198dfb05f6e4694e9c
---
M
Patch Set 1: Code-Review+1
--
To view, visit https://gerrit.osmocom.org/2136
To unsubscribe, visit https://gerrit.osmocom.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I9bf97f2dc03fea9bebcf43198dfb05f6e4694e9c
Gerrit-PatchSet: 1
Gerrit-Project: osmo-trx
Gerrit-Branch: master
Patch Set 1:
(1 comment)
> (1 comment)
https://gerrit.osmocom.org/#/c/2136/1/Transceiver52M/Transceiver.cpp
File Transceiver52M/Transceiver.cpp:
Line 609: float toa, max = -1.0, avg = 0.0;
> Is there good reason not to move it? I prefer the moved declaration.
I follow the rule "declare
Patch Set 1:
(2 comments)
https://gerrit.osmocom.org/#/c/2136/1/Transceiver52M/Transceiver.cpp
File Transceiver52M/Transceiver.cpp:
Line 609: float toa, max = -1.0, avg = 0.0;
> There's no need to move variable declaration.
Is there good reason not to move it? I prefer the moved declaration.
Patch Set 1:
(1 comment)
https://gerrit.osmocom.org/#/c/2136/1/Transceiver52M/Transceiver.cpp
File Transceiver52M/Transceiver.cpp:
Line 609: float toa, max = -1.0, avg = 0.0;
There's no need to move variable declaration.
--
To view, visit https://gerrit.osmocom.org/2136
To unsubscribe,
Review at https://gerrit.osmocom.org/2136
sigProcLib: make energyDetect() simpler by returning actual energy.
Change-Id: I9bf97f2dc03fea9bebcf43198dfb05f6e4694e9c
---
M Transceiver52M/Transceiver.cpp
M Transceiver52M/sigProcLib.cpp
M Transceiver52M/sigProcLib.h
3 files changed, 10
