osmo-trx[master]: tests: convolve: Disable due to difference in output in diff...

2018-01-17 Thread Harald Welte 

Patch Set 1: Code-Review+2

-- 
To view, visit https://gerrit.osmocom.org/5817
To unsubscribe, visit https://gerrit.osmocom.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I2320309bc8c1c20e2de6ef2e0f17472c68de80cb
Gerrit-PatchSet: 1
Gerrit-Project: osmo-trx
Gerrit-Branch: master
Gerrit-Owner: Pau Espin Pedrol 
Gerrit-Reviewer: Alexander Chemeris 
Gerrit-Reviewer: Harald Welte 
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: Max 
Gerrit-Reviewer: Pau Espin Pedrol 
Gerrit-Reviewer: fixeria 
Gerrit-Reviewer: ttsou 
Gerrit-HasComments: No

[MERGED] osmo-trx[master]: tests: convolve: Disable due to difference in output in diff...

2018-01-17 Thread Harald Welte 
Harald Welte has submitted this change and it was merged.

Change subject: tests: convolve: Disable due to difference in output in 
different archs
..


tests: convolve: Disable due to difference in output in different archs

Let's disable this test in order to have passing jenkins jobs until we
find a better way to properly test this for different architectures.

Change-Id: I2320309bc8c1c20e2de6ef2e0f17472c68de80cb
---
M tests/testsuite.at
1 file changed, 2 insertions(+), 2 deletions(-)

Approvals:
  Harald Welte: Looks good to me, approved
  Jenkins Builder: Verified

Objections:
  Alexander Chemeris: I would prefer this is not merged as is



diff --git a/tests/testsuite.at b/tests/testsuite.at
index ca979e5..f84225e 100644
--- a/tests/testsuite.at
+++ b/tests/testsuite.at
@@ -46,8 +46,8 @@
 
 AT_SETUP([convolve_test])
 AT_KEYWORDS([convolve_test])
-# Disabled for ARM builds as it gives different output than x86, see  OS#2826
-AT_SKIP_IF(! uname -m | grep x86)
+# Different results for i686, x86_64 and ARM. see  OS#2826, OS#2828, and 
https://lists.osmocom.org/pipermail/openbsc/2018-January/011655.html
+AT_SKIP_IF(true)
 cat $abs_srcdir/Transceiver52M/convolve_test.ok > expout
 AT_CHECK([$abs_top_builddir/tests/Transceiver52M/convolve_test], [], [expout], 
[])
 AT_CLEANUP

-- 
To view, visit https://gerrit.osmocom.org/5817
To unsubscribe, visit https://gerrit.osmocom.org/settings

Gerrit-MessageType: merged
Gerrit-Change-Id: I2320309bc8c1c20e2de6ef2e0f17472c68de80cb
Gerrit-PatchSet: 1
Gerrit-Project: osmo-trx
Gerrit-Branch: master
Gerrit-Owner: Pau Espin Pedrol 
Gerrit-Reviewer: Alexander Chemeris 
Gerrit-Reviewer: Harald Welte 
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: Max 
Gerrit-Reviewer: Pau Espin Pedrol 
Gerrit-Reviewer: fixeria 
Gerrit-Reviewer: ttsou

osmo-trx[master]: tests: convolve: Disable due to difference in output in diff...

2018-01-16 Thread Pau Espin Pedrol 

Patch Set 1:

@alexander: On top of sending the mail to the ml, I already assigned a task to 
Tsou a few days ago too (https://osmocom.org/issues/2826). I think that counts 
as pinging specifically.

@max: I can prefix it with FIXME but anyway it's quite visible since everytime 
you run the tests it outputs "skipped" for that specific test. You can then go 
check and see the comment.

-- 
To view, visit https://gerrit.osmocom.org/5817
To unsubscribe, visit https://gerrit.osmocom.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I2320309bc8c1c20e2de6ef2e0f17472c68de80cb
Gerrit-PatchSet: 1
Gerrit-Project: osmo-trx
Gerrit-Branch: master
Gerrit-Owner: Pau Espin Pedrol 
Gerrit-Reviewer: Alexander Chemeris 
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: Max 
Gerrit-Reviewer: Pau Espin Pedrol 
Gerrit-Reviewer: fixeria 
Gerrit-Reviewer: ttsou 
Gerrit-HasComments: No

osmo-trx[master]: tests: convolve: Disable due to difference in output in diff...

2018-01-16 Thread Max 

Patch Set 1:

> it is even inside the commit in testsuite.at

Might make sense to prefix it with FIXME so it'll jump out when grepping the 
sources.

-- 
To view, visit https://gerrit.osmocom.org/5817
To unsubscribe, visit https://gerrit.osmocom.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I2320309bc8c1c20e2de6ef2e0f17472c68de80cb
Gerrit-PatchSet: 1
Gerrit-Project: osmo-trx
Gerrit-Branch: master
Gerrit-Owner: Pau Espin Pedrol 
Gerrit-Reviewer: Alexander Chemeris 
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: Max 
Gerrit-Reviewer: Pau Espin Pedrol 
Gerrit-Reviewer: fixeria 
Gerrit-Reviewer: ttsou 
Gerrit-HasComments: No

osmo-trx[master]: tests: convolve: Disable due to difference in output in diff...

2018-01-16 Thread Alexander Chemeris 

Patch Set 1:

I think you should send an e-mail to the mailing list, as not everyone is 
reading Gerrit. I've stumbled upon this patch completely accidentally and I 
haven't seen any discussions.

-- 
To view, visit https://gerrit.osmocom.org/5817
To unsubscribe, visit https://gerrit.osmocom.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I2320309bc8c1c20e2de6ef2e0f17472c68de80cb
Gerrit-PatchSet: 1
Gerrit-Project: osmo-trx
Gerrit-Branch: master
Gerrit-Owner: Pau Espin Pedrol 
Gerrit-Reviewer: Alexander Chemeris 
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: Pau Espin Pedrol 
Gerrit-Reviewer: fixeria 
Gerrit-Reviewer: ttsou 
Gerrit-HasComments: No

osmo-trx[master]: tests: convolve: Disable due to difference in output in diff...

2018-01-16 Thread Alexander Chemeris 

Patch Set 1: Code-Review-1

I don't think to disable it is a good idea. Why not improve it? I think Thomas 
Tsou and/or Vadim had suggestions how to do that.

-- 
To view, visit https://gerrit.osmocom.org/5817
To unsubscribe, visit https://gerrit.osmocom.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I2320309bc8c1c20e2de6ef2e0f17472c68de80cb
Gerrit-PatchSet: 1
Gerrit-Project: osmo-trx
Gerrit-Branch: master
Gerrit-Owner: Pau Espin Pedrol 
Gerrit-Reviewer: Alexander Chemeris 
Gerrit-Reviewer: Jenkins Builder
Gerrit-HasComments: No

[PATCH] osmo-trx[master]: tests: convolve: Disable due to difference in output in diff...

2018-01-16 Thread Pau Espin Pedrol 

Review at  https://gerrit.osmocom.org/5817

tests: convolve: Disable due to difference in output in different archs

Let's disable this test in order to have passing jenkins jobs until we
find a better way to properly test this for different architectures.

Change-Id: I2320309bc8c1c20e2de6ef2e0f17472c68de80cb
---
M tests/testsuite.at
1 file changed, 2 insertions(+), 2 deletions(-)


  git pull ssh://gerrit.osmocom.org:29418/osmo-trx refs/changes/17/5817/1

diff --git a/tests/testsuite.at b/tests/testsuite.at
index ca979e5..f84225e 100644
--- a/tests/testsuite.at
+++ b/tests/testsuite.at
@@ -46,8 +46,8 @@
 
 AT_SETUP([convolve_test])
 AT_KEYWORDS([convolve_test])
-# Disabled for ARM builds as it gives different output than x86, see  OS#2826
-AT_SKIP_IF(! uname -m | grep x86)
+# Different results for i686, x86_64 and ARM. see  OS#2826, OS#2828, and 
https://lists.osmocom.org/pipermail/openbsc/2018-January/011655.html
+AT_SKIP_IF(true)
 cat $abs_srcdir/Transceiver52M/convolve_test.ok > expout
 AT_CHECK([$abs_top_builddir/tests/Transceiver52M/convolve_test], [], [expout], 
[])
 AT_CLEANUP

-- 
To view, visit https://gerrit.osmocom.org/5817
To unsubscribe, visit https://gerrit.osmocom.org/settings

Gerrit-MessageType: newchange
Gerrit-Change-Id: I2320309bc8c1c20e2de6ef2e0f17472c68de80cb
Gerrit-PatchSet: 1
Gerrit-Project: osmo-trx
Gerrit-Branch: master
Gerrit-Owner: Pau Espin Pedrol