osmo-bts[master]: vty: reduce code duplication

2017-03-29 Thread Harald Welte
Patch Set 1: Code-Review+2 even if osmo_str2lower() is unfortunate: I still think it's better to have one shared implementation, rather than local ones. -- To view, visit https://gerrit.osmocom.org/2162 To unsubscribe, visit https://gerrit.osmocom.org/settings Gerrit-MessageType: comment

[MERGED] osmo-bts[master]: vty: reduce code duplication

2017-03-29 Thread Harald Welte
Harald Welte has submitted this change and it was merged. Change subject: vty: reduce code duplication .. vty: reduce code duplication Use libosmocore's osmo_str2lower() instead of local equivalent. Change-Id:

[PATCH] libosmo-netif[master]: stream.c: Handle SCTP in osmo_stream_srv_recv()

2017-03-29 Thread Harald Welte
Review at https://gerrit.osmocom.org/2173 stream.c: Handle SCTP in osmo_stream_srv_recv() Change-Id: If0875cfa3eba9ef36acc0c4bfd0d168a45c380b9 --- M src/stream.c 1 file changed, 57 insertions(+), 1 deletion(-) git pull ssh://gerrit.osmocom.org:29418/libosmo-netif refs/changes/73/2173/1

[MERGED] osmo-pcu[master]: bitcomp test: use expected rc instead of 'verify' flag

2017-03-29 Thread Harald Welte
Harald Welte has submitted this change and it was merged. Change subject: bitcomp test: use expected rc instead of 'verify' flag .. bitcomp test: use expected rc instead of 'verify' flag The 'verify' flag is useless, we always

osmo-pcu[master]: bitcomp test: fix: only one hexdump per log; use printf

2017-03-29 Thread Harald Welte
Patch Set 1: Code-Review+2 -- To view, visit https://gerrit.osmocom.org/2168 To unsubscribe, visit https://gerrit.osmocom.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I24fc32eb55baaf22f9c6fdda917bfb8395d02b1c Gerrit-PatchSet: 1 Gerrit-Project: osmo-pcu Gerrit-Branch: master

osmo-pcu[master]: cosmetic: BitcompTest: make readable

2017-03-29 Thread Harald Welte
Patch Set 1: Code-Review+2 -- To view, visit https://gerrit.osmocom.org/2167 To unsubscribe, visit https://gerrit.osmocom.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Id0da9d9b67f4713d3a67e3532ed44b8cb1bd1d08 Gerrit-PatchSet: 1 Gerrit-Project: osmo-pcu Gerrit-Branch: master

[MERGED] libosmocore[master]: Fix LAPD UA message buffer memory leak.

2017-03-29 Thread Harald Welte
Harald Welte has submitted this change and it was merged. Change subject: Fix LAPD UA message buffer memory leak. .. Fix LAPD UA message buffer memory leak. The state check in lapd_dl_reset causes some buffers never to be

osmo-trx[master]: sigProcLib: Remove unreachable code and no-effect checks

2017-03-29 Thread Tom Tsou
Patch Set 1: Code-Review+2 -- To view, visit https://gerrit.osmocom.org/2171 To unsubscribe, visit https://gerrit.osmocom.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: If53b4b03550b0a7656c808cfe96806252153eb2f Gerrit-PatchSet: 1 Gerrit-Project: osmo-trx Gerrit-Branch: master

[MERGED] libosmo-netif[master]: stream.c: Handle SCTP in osmo_stream_srv_recv()

2017-03-29 Thread Harald Welte
Harald Welte has submitted this change and it was merged. Change subject: stream.c: Handle SCTP in osmo_stream_srv_recv() .. stream.c: Handle SCTP in osmo_stream_srv_recv() Change-Id: If0875cfa3eba9ef36acc0c4bfd0d168a45c380b9

libosmo-abis[master]: configure: Fix compilation with new libortp

2017-03-29 Thread Harald Welte
Patch Set 2: Code-Review+2 -- To view, visit https://gerrit.osmocom.org/2164 To unsubscribe, visit https://gerrit.osmocom.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I46e565f1873c7baf3c3b0aafe73951d20ce083b4 Gerrit-PatchSet: 2 Gerrit-Project: libosmo-abis Gerrit-Branch: master

osmo-trx[master]: sigProcLib: Check return status on downsampling

2017-03-29 Thread Harald Welte
Patch Set 1: Code-Review+1 -- To view, visit https://gerrit.osmocom.org/2172 To unsubscribe, visit https://gerrit.osmocom.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I3ad22f9fd7a20754f589c04258dcca3770474a9b Gerrit-PatchSet: 1 Gerrit-Project: osmo-trx Gerrit-Branch: master

osmo-trx[master]: osmo-trx: Separate command line switch to enable EDGE filler.

2017-03-29 Thread Tom Tsou
Patch Set 5: I would very much like to replace the command line and control socket interface. There are more than enough configuration options so that a config file makes sense - that is the direction that I prefer over command line arguments. For the control socket interface, we need to